1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
android_webview / tools / system_webview_shell / lint-baseline.xml [blame]
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.7.0-alpha03" type="baseline" client="" dependencies="true" name="" variant="all" version="8.7.0-alpha03">
<issue
id="NewApi"
message="Call requires API level 23 (current min is 21): `canGrant`"
errorLine1=" if (!canGrant(webkitPermission)) {"
errorLine2=" ~~~~~~~~">
<location
file="../../android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserFragment.java"
line="512"
column="18"/>
</issue>
<issue
id="RequiresFeature"
message="`getInstance` should only be called if the feature `TRACING_CONTROLLER_BASIC_USAGE` is present; to check call `androidx.webkit.WebViewFeature#isFeatureSupported`"
errorLine1=" TracingController tracingController = TracingController.getInstance();"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserActivity.java"
line="226"
column="55"/>
</issue>
<issue
id="RequiresFeature"
message="`setForceDark` should only be called if the feature `FORCE_DARK` is present; to check call `androidx.webkit.WebViewFeature#isFeatureSupported`"
errorLine1=" WebSettingsCompat.setForceDark("
errorLine2=" ^">
<location
file="../../android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserActivity.java"
line="249"
column="13"/>
</issue>
<issue
id="RequiresFeature"
message="`setForceDark` should only be called if the feature `FORCE_DARK` is present; to check call `androidx.webkit.WebViewFeature#isFeatureSupported`"
errorLine1=" WebSettingsCompat.setForceDark("
errorLine2=" ^">
<location
file="../../android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserActivity.java"
line="254"
column="13"/>
</issue>
<issue
id="RequiresFeature"
message="`setForceDark` should only be called if the feature `FORCE_DARK` is present; to check call `androidx.webkit.WebViewFeature#isFeatureSupported`"
errorLine1=" WebSettingsCompat.setForceDark(mWebView.getSettings(), WebSettingsCompat.FORCE_DARK_ON);"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserActivity.java"
line="259"
column="13"/>
</issue>
<issue
id="RequiresFeature"
message="`getInstance` should only be called if the feature `TRACING_CONTROLLER_BASIC_USAGE` is present; to check call `androidx.webkit.WebViewFeature#isFeatureSupported`"
errorLine1=" final TracingController tracingController = TracingController.getInstance();"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewTracingActivity.java"
line="102"
column="53"/>
</issue>
<issue
id="UnclosedTrace"
message="The `beginSection()` call is not always closed with a matching `endSection()` because the code in between may return early"
errorLine1=" Trace.beginSection(startUpAndLoadUrlTraceTag);"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/TelemetryActivity.java"
line="56"
column="15"/>
</issue>
<issue
id="UnclosedTrace"
message="The `beginSection()` call is not always closed with a matching `endSection()` because the code in between may return early"
errorLine1=" Trace.beginSection(loadUrlTraceTag);"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/TelemetryActivity.java"
line="104"
column="15"/>
</issue>
<issue
id="UnclosedTrace"
message="The `beginSection()` call is not always closed with a matching `endSection()` because the code in between may return early"
errorLine1=" Trace.beginSection(placeholderTraceTag);"
errorLine2=" ~~~~~~~~~~~~">
<location
file="../../android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/TelemetryActivity.java"
line="112"
column="15"/>
</issue>
<issue
id="HardcodedDebugMode"
message="Avoid hardcoding the debug mode; leaving it out allows debug and release builds to automatically assign one"
errorLine1=" <application android:icon="@drawable/ic_launcher" android:label="@string/app_name" android:theme="@style/ShellTheme" android:enableOnBackInvokedCallback="true" android:networkSecurityConfig="@xml/network_security_config" android:debuggable="true">"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="gen/android_webview/tools/system_webview_shell/system_webview_shell_apk__lint/AndroidManifest.xml"
line="67"
column="224"/>
</issue>
<issue
id="IconMissingDensityFolder"
message="Missing density variation folders in `../../android_webview/tools/system_webview_shell/apk/res`: drawable-hdpi, drawable-xhdpi, drawable-xxhdpi">
<location
file="../../android_webview/tools/system_webview_shell/apk/res"/>
</issue>
</issues>