1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
ash / components / arc / compat_mode / resize_util_unittest.cc [blame]
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ash/components/arc/compat_mode/resize_util.h"
#include <memory>
#include "ash/components/arc/compat_mode/test/compat_mode_test_base.h"
#include "ash/public/cpp/arc_compat_mode_util.h"
#include "ash/public/cpp/system/scoped_toast_pause.h"
#include "ash/public/cpp/system/toast_data.h"
#include "ash/public/cpp/system/toast_manager.h"
#include "base/notreached.h"
#include "base/test/bind.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/aura/client/aura_constants.h"
#include "ui/base/mojom/window_show_state.mojom.h"
#include "ui/base/ui_base_types.h"
#include "ui/views/widget/widget.h"
#include "ui/views/widget/widget_delegate.h"
namespace arc {
namespace {
constexpr char kTestAppId[] = "123";
class FakeToastManager : public ash::ToastManager {
public:
~FakeToastManager() override = default;
// ToastManager overrides:
void Show(ash::ToastData data) override { called_show_ = true; }
void Cancel(std::string_view id) override { called_cancel_ = true; }
bool RequestFocusOnActiveToastButton(std::string_view id) override {
return false;
}
bool IsToastShown(std::string_view id) const override { return false; }
bool IsToastButtonFocused(std::string_view id) const override {
return false;
}
std::unique_ptr<ash::ScopedToastPause> CreateScopedPause() override {
return nullptr;
}
void Pause() override {}
void Resume() override {}
void ResetState() {
called_show_ = false;
called_cancel_ = false;
}
bool called_show() { return called_show_; }
bool called_cancel() { return called_cancel_; }
private:
bool called_show_{false};
bool called_cancel_{false};
};
class ScopedWindowPropertyObserver : public aura::WindowObserver {
public:
using WindowPropertyChangedCallback =
base::RepeatingCallback<void(aura::Window*, const void*, intptr_t)>;
ScopedWindowPropertyObserver(aura::Window* window,
WindowPropertyChangedCallback on_changed)
: on_changed_(std::move(on_changed)) {
observer_.Observe(window);
}
~ScopedWindowPropertyObserver() override { observer_.Reset(); }
// aura::WindowObserver:
void OnWindowPropertyChanged(aura::Window* window,
const void* key,
intptr_t old) override {
on_changed_.Run(window, key, old);
}
void OnWindowDestroying(aura::Window* window) override { observer_.Reset(); }
private:
WindowPropertyChangedCallback on_changed_;
base::ScopedObservation<aura::Window, aura::WindowObserver> observer_{this};
};
} // namespace
class ResizeUtilTest : public CompatModeTestBase {
public:
// Overridden from test::Test.
void SetUp() override {
CompatModeTestBase::SetUp();
widget_ = CreateArcWidget(std::string(kTestAppId));
}
void TearDown() override {
widget_->CloseNow();
CompatModeTestBase::TearDown();
}
views::Widget* widget() { return widget_.get(); }
private:
std::unique_ptr<views::Widget> widget_;
};
// Test that resize phone works properly in both needs-confirmation and no
// needs-conirmation case.
TEST_F(ResizeUtilTest, TestResizeLockToPhone) {
widget()->Maximize();
// Fake a restore state to make sure resizing always results in normal state.
widget()->GetNativeWindow()->SetProperty(
aura::client::kRestoreShowStateKey,
ui::mojom::WindowShowState::kMaximized);
// Test the widget is resized.
ScopedWindowPropertyObserver observer(
widget()->GetNativeWindow(),
base::BindLambdaForTesting(
[](aura::Window* window, const void* key, intptr_t old) {
if (key != aura::client::kIsRestoringKey) {
return;
}
if (!window->GetProperty(aura::client::kIsRestoringKey)) {
return;
}
NOTREACHED() << "The restroing key should not be enabled.";
}));
pref_delegate()->SetResizeLockNeedsConfirmation(kTestAppId, false);
EXPECT_TRUE(widget()->IsMaximized());
ResizeLockToPhone(widget(), pref_delegate());
SyncResizeLockPropertyWithMojoState(widget());
EXPECT_FALSE(widget()->IsMaximized());
EXPECT_LT(widget()->GetWindowBoundsInScreen().width(),
widget()->GetWindowBoundsInScreen().height());
EXPECT_EQ(ash::compat_mode_util::PredictCurrentMode(widget()),
ash::ResizeCompatMode::kPhone);
}
// Test that resize tablet works properly in both needs-confirmation and no
// needs-conirmation case.
TEST_F(ResizeUtilTest, TestResizeLockToTablet) {
widget()->Maximize();
// Fake a restore state to make sure resizing always results in normal state.
widget()->GetNativeWindow()->SetProperty(
aura::client::kRestoreShowStateKey,
ui::mojom::WindowShowState::kMaximized);
// Test the widget is resized.
ScopedWindowPropertyObserver observer(
widget()->GetNativeWindow(),
base::BindLambdaForTesting(
[](aura::Window* window, const void* key, intptr_t old) {
if (key != aura::client::kIsRestoringKey) {
return;
}
if (!window->GetProperty(aura::client::kIsRestoringKey)) {
return;
}
NOTREACHED() << "The restroing key should not be enabled.";
}));
pref_delegate()->SetResizeLockNeedsConfirmation(kTestAppId, false);
EXPECT_TRUE(widget()->IsMaximized());
ResizeLockToTablet(widget(), pref_delegate());
SyncResizeLockPropertyWithMojoState(widget());
EXPECT_FALSE(widget()->IsMaximized());
EXPECT_GT(widget()->GetWindowBoundsInScreen().width(),
widget()->GetWindowBoundsInScreen().height());
EXPECT_EQ(ash::compat_mode_util::PredictCurrentMode(widget()),
ash::ResizeCompatMode::kTablet);
}
// Test that resize phone/tablet works properly on small displays.
TEST_F(ResizeUtilTest, TestResizeLockToPhoneTabletOnSmallDisplay) {
pref_delegate()->SetResizeLockNeedsConfirmation(kTestAppId, false);
// Set small workarea size.
constexpr gfx::Size workarea_size(300, 300);
SetDisplayWorkArea(gfx::Rect(workarea_size));
// Shrink size according to the workarea size.
ResizeLockToPhone(widget(), pref_delegate());
SyncResizeLockPropertyWithMojoState(widget());
EXPECT_LT(widget()->GetWindowBoundsInScreen().width(),
widget()->GetWindowBoundsInScreen().height());
EXPECT_LT(widget()->GetWindowBoundsInScreen().width(), workarea_size.width());
EXPECT_LT(widget()->GetWindowBoundsInScreen().height(),
workarea_size.height());
// Don't shrink size so that Android can decide what to do.
ResizeLockToTablet(widget(), pref_delegate());
SyncResizeLockPropertyWithMojoState(widget());
EXPECT_GE(widget()->GetWindowBoundsInScreen().width(), workarea_size.width());
EXPECT_GE(widget()->GetWindowBoundsInScreen().height(),
workarea_size.height());
}
// Test that enabling resizing works properly in both needs-confirmation and no
// needs-conirmation case.
TEST_F(ResizeUtilTest, TestEnableResizing) {
FakeToastManager fake_toast_manager;
// Test the state is NOT changed immediately if the confirmation dialog is
// needed.
pref_delegate()->SetResizeLockNeedsConfirmation(kTestAppId, true);
EnableResizingWithConfirmationIfNeeded(widget(), pref_delegate());
SyncResizeLockPropertyWithMojoState(widget());
EXPECT_NE(pref_delegate()->GetResizeLockState(kTestAppId),
mojom::ArcResizeLockState::OFF);
EXPECT_FALSE(fake_toast_manager.called_cancel());
EXPECT_FALSE(fake_toast_manager.called_show());
// Test the state is changed without confirmation.
pref_delegate()->SetResizeLockNeedsConfirmation(kTestAppId, false);
EnableResizingWithConfirmationIfNeeded(widget(), pref_delegate());
SyncResizeLockPropertyWithMojoState(widget());
EXPECT_EQ(pref_delegate()->GetResizeLockState(kTestAppId),
mojom::ArcResizeLockState::OFF);
EXPECT_EQ(ash::compat_mode_util::PredictCurrentMode(widget()),
ash::ResizeCompatMode::kResizable);
EXPECT_TRUE(fake_toast_manager.called_cancel());
EXPECT_TRUE(fake_toast_manager.called_show());
// Test the state is not updated redundantly.
fake_toast_manager.ResetState();
EnableResizingWithConfirmationIfNeeded(widget(), pref_delegate());
SyncResizeLockPropertyWithMojoState(widget());
EXPECT_FALSE(fake_toast_manager.called_cancel());
EXPECT_FALSE(fake_toast_manager.called_show());
}
// Test that should show dialog screen dialog caps at a preset limit
TEST_F(ResizeUtilTest, TestShouldShowSplashScreenDialog) {
// Defines maximum number of showing splash screen per user.
const int kMaxNumSplashScreen = 2;
pref_delegate()->SetShowSplashScreenDialogCount(kMaxNumSplashScreen);
for (int i = 0; i < kMaxNumSplashScreen; i++)
EXPECT_TRUE(ShouldShowSplashScreenDialog(pref_delegate()));
EXPECT_FALSE(ShouldShowSplashScreenDialog(pref_delegate()));
}
// Test that an unresizable app is not in resizable mode.
TEST_F(ResizeUtilTest, TestPredictCurrentModeForUnresizable) {
widget()->widget_delegate()->SetCanResize(false);
ResizeLockToPhone(widget(), pref_delegate());
SyncResizeLockPropertyWithMojoState(widget());
EXPECT_EQ(ash::compat_mode_util::PredictCurrentMode(widget()),
ash::ResizeCompatMode::kPhone);
}
} // namespace arc