1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
ash / wm / snap_group / snap_group_test_util.cc [blame]
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ash/wm/snap_group/snap_group_test_util.h"
#include "ash/root_window_controller.h"
#include "ash/wm/overview/overview_controller.h"
#include "ash/wm/overview/overview_item_base.h"
#include "ash/wm/overview/overview_test_util.h"
#include "ash/wm/snap_group/snap_group.h"
#include "ash/wm/snap_group/snap_group_controller.h"
#include "ash/wm/splitview/split_view_test_util.h"
#include "ash/wm/splitview/split_view_utils.h"
#include "chromeos/ui/base/window_state_type.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/aura/window.h"
#include "ui/display/screen.h"
#include "ui/events/test/event_generator.h"
#include "ui/wm/core/coordinate_conversion.h"
namespace ash {
SplitViewDivider* GetTopmostSnapGroupDivider() {
auto* top_snap_group = SnapGroupController::Get()->GetTopmostSnapGroup();
return top_snap_group ? top_snap_group->snap_group_divider() : nullptr;
}
gfx::Rect GetTopmostSnapGroupDividerBoundsInScreen() {
return GetTopmostSnapGroupDivider()->GetDividerBoundsInScreen(
/*is_dragging=*/false);
}
void ClickOverviewItem(ui::test::EventGenerator* event_generator,
aura::Window* window) {
event_generator->MoveMouseTo(gfx::ToRoundedPoint(
GetOverviewItemForWindow(window)->GetTransformedBounds().CenterPoint()));
event_generator->ClickLeftButton();
}
void SnapTwoTestWindows(aura::Window* window1,
aura::Window* window2,
bool horizontal,
ui::test::EventGenerator* event_generator) {
CHECK_NE(window1, window2);
// Snap `window1` to trigger the overview session shown on the other side of
// the screen.
SnapOneTestWindow(window1,
/*state_type=*/chromeos::WindowStateType::kPrimarySnapped,
chromeos::kDefaultSnapRatio);
WaitForOverviewEntered();
VerifySplitViewOverviewSession(window1);
// Snapping the first window makes it fill half the screen, either
// vertically or horizontally (based on orientation).
gfx::Rect work_area(GetWorkAreaBoundsForWindow(window1));
gfx::Rect primary_bounds, secondary_bounds;
if (horizontal) {
work_area.SplitVertically(primary_bounds, secondary_bounds);
} else {
work_area.SplitHorizontally(primary_bounds, secondary_bounds);
}
EXPECT_EQ(primary_bounds, window1->GetBoundsInScreen());
// The `window2` gets selected in the overview will be snapped to the
// non-occupied snap position and the overview session will end.
ClickOverviewItem(event_generator, window2);
WaitForOverviewExitAnimation();
EXPECT_EQ(WindowState::Get(window2)->GetStateType(),
chromeos::WindowStateType::kSecondarySnapped);
EXPECT_FALSE(OverviewController::Get()->InOverviewSession());
EXPECT_FALSE(
RootWindowController::ForWindow(window1)->split_view_overview_session());
auto* snap_group_controller = SnapGroupController::Get();
ASSERT_TRUE(snap_group_controller);
EXPECT_TRUE(snap_group_controller->AreWindowsInSnapGroup(window1, window2));
// The snap group divider will show on two windows snapped.
EXPECT_TRUE(GetTopmostSnapGroupDivider()->divider_widget());
// There can be a slight rounding error when ChromeVox is on.
EXPECT_NEAR(chromeos::kDefaultSnapRatio,
*WindowState::Get(window1)->snap_ratio(), .01);
EXPECT_NEAR(chromeos::kDefaultSnapRatio,
*WindowState::Get(window2)->snap_ratio(), .01);
gfx::Rect divider_bounds(GetTopmostSnapGroupDividerBoundsInScreen());
EXPECT_EQ(work_area.CenterPoint().x(), divider_bounds.CenterPoint().x());
UnionBoundsEqualToWorkAreaBounds(window1, window2,
GetTopmostSnapGroupDivider());
if (horizontal) {
primary_bounds.set_width(primary_bounds.width() -
divider_bounds.width() / 2);
secondary_bounds.set_x(secondary_bounds.x() + divider_bounds.width() / 2);
secondary_bounds.set_width(secondary_bounds.width() -
divider_bounds.width() / 2);
EXPECT_EQ(primary_bounds.width(), window1->GetBoundsInScreen().width());
EXPECT_EQ(secondary_bounds.width(), window2->GetBoundsInScreen().width());
EXPECT_EQ(primary_bounds.width() + secondary_bounds.width() +
divider_bounds.width(),
work_area.width());
} else {
primary_bounds.set_height(primary_bounds.height() -
divider_bounds.height() / 2);
secondary_bounds.set_y(secondary_bounds.y() + divider_bounds.height() / 2);
secondary_bounds.set_height(secondary_bounds.height() -
divider_bounds.height() / 2);
EXPECT_EQ(primary_bounds.height(), window1->GetBoundsInScreen().height());
EXPECT_EQ(secondary_bounds.height(), window2->GetBoundsInScreen().height());
EXPECT_EQ(primary_bounds.height() + secondary_bounds.height() +
divider_bounds.height(),
work_area.height());
}
}
void UnionBoundsEqualToWorkAreaBounds(aura::Window* w1,
aura::Window* w2,
SplitViewDivider* divider) {
gfx::Rect w1_bounds(w1->GetTargetBounds());
wm::ConvertRectToScreen(w1->GetRootWindow(), &w1_bounds);
gfx::Rect w2_bounds(w2->GetTargetBounds());
wm::ConvertRectToScreen(w2->GetRootWindow(), &w2_bounds);
const auto divider_bounds =
divider->GetDividerBoundsInScreen(/*is_dragging=*/false);
EXPECT_FALSE(w1_bounds.IsEmpty());
EXPECT_FALSE(w2_bounds.IsEmpty());
EXPECT_FALSE(divider_bounds.IsEmpty());
gfx::Rect union_bounds;
union_bounds.Union(w1_bounds);
union_bounds.Union(w2_bounds);
EXPECT_FALSE(w1_bounds.Contains(divider_bounds));
EXPECT_FALSE(w2_bounds.Contains(divider_bounds));
if (IsLayoutHorizontal(w1)) {
EXPECT_EQ(w1_bounds.right(), divider_bounds.x());
EXPECT_EQ(w2_bounds.x(), divider_bounds.right());
} else {
EXPECT_EQ(w1_bounds.bottom(), divider_bounds.y());
EXPECT_EQ(w2_bounds.y(), divider_bounds.bottom());
}
union_bounds.Union(divider_bounds);
EXPECT_EQ(
display::Screen::GetScreen()->GetDisplayNearestWindow(w1).work_area(),
union_bounds);
}
void UnionBoundsEqualToWorkAreaBounds(SnapGroup* snap_group) {
aura::Window* w1 = snap_group->window1();
aura::Window* w2 = snap_group->window2();
auto* divider = snap_group->snap_group_divider();
if (IsPhysicallyLeftOrTop(w1)) {
UnionBoundsEqualToWorkAreaBounds(w1, w2, divider);
} else {
UnionBoundsEqualToWorkAreaBounds(w2, w1, divider);
}
}
} // namespace ash