1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
ash / wm / window_modality_controller_unittest.cc [blame]
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifdef UNSAFE_BUFFERS_BUILD
// TODO(crbug.com/40285824): Remove this and convert code to safer constructs.
#pragma allow_unsafe_buffers
#endif
#include "ui/wm/core/window_modality_controller.h"
#include "ash/shell.h"
#include "ash/test/ash_test_base.h"
#include "ash/wm/test/test_child_modal_parent.h"
#include "ash/wm/window_util.h"
#include "ui/aura/client/aura_constants.h"
#include "ui/aura/client/capture_client.h"
#include "ui/aura/test/test_window_delegate.h"
#include "ui/aura/test/test_windows.h"
#include "ui/aura/window.h"
#include "ui/aura/window_event_dispatcher.h"
#include "ui/base/mojom/ui_base_types.mojom-shared.h"
#include "ui/base/ui_base_types.h"
#include "ui/events/test/event_generator.h"
#include "ui/views/test/capture_tracking_view.h"
#include "ui/views/widget/widget.h"
#include "ui/wm/core/window_util.h"
namespace ash {
using WindowModalityControllerTest = AshTestBase;
namespace {
bool ValidateStacking(aura::Window* parent, int ids[], int count) {
for (int i = 0; i < count; ++i) {
if (parent->children().at(i)->GetId() != ids[i])
return false;
}
return true;
}
} // namespace
// Creates three windows, w1, w11, and w12. w11 is a non-modal transient, w12 is
// a modal transient.
// Validates:
// - it should be possible to activate w12 even when w11 is open.
// - activating w1 activates w12 and updates stacking order appropriately.
// - closing a window passes focus up the stack.
TEST_F(WindowModalityControllerTest, BasicActivation) {
aura::test::TestWindowDelegate d;
std::unique_ptr<aura::Window> w1(
CreateTestWindowInShellWithDelegate(&d, -1, gfx::Rect()));
std::unique_ptr<aura::Window> w11(
CreateTestWindowInShellWithDelegate(&d, -11, gfx::Rect()));
std::unique_ptr<aura::Window> w12(
CreateTestWindowInShellWithDelegate(&d, -12, gfx::Rect()));
::wm::AddTransientChild(w1.get(), w11.get());
wm::ActivateWindow(w1.get());
EXPECT_TRUE(wm::IsActiveWindow(w1.get()));
wm::ActivateWindow(w11.get());
EXPECT_TRUE(wm::IsActiveWindow(w11.get()));
w12->SetProperty(aura::client::kModalKey, ui::mojom::ModalType::kWindow);
::wm::AddTransientChild(w1.get(), w12.get());
wm::ActivateWindow(w12.get());
EXPECT_TRUE(wm::IsActiveWindow(w12.get()));
wm::ActivateWindow(w11.get());
EXPECT_TRUE(wm::IsActiveWindow(w11.get()));
int check1[] = {-1, -12, -11};
EXPECT_TRUE(ValidateStacking(w1->parent(), check1, std::size(check1)));
wm::ActivateWindow(w1.get());
EXPECT_TRUE(wm::IsActiveWindow(w12.get()));
// Transient children are always stacked above their transient parent, which
// is why this order is not -11, -1, -12.
int check2[] = {-1, -11, -12};
EXPECT_TRUE(ValidateStacking(w1->parent(), check2, std::size(check2)));
w12.reset();
EXPECT_TRUE(wm::IsActiveWindow(w11.get()));
w11.reset();
EXPECT_TRUE(wm::IsActiveWindow(w1.get()));
}
// Create two toplevel windows w1 and w2, and nest two modals w11 and w111 below
// w1.
// Validates:
// - activating w1 while w11/w111 is showing always activates most deeply nested
// descendant.
// - closing a window passes focus up the stack.
TEST_F(WindowModalityControllerTest, NestedModals) {
aura::test::TestWindowDelegate d;
std::unique_ptr<aura::Window> w1(
CreateTestWindowInShellWithDelegate(&d, -1, gfx::Rect()));
std::unique_ptr<aura::Window> w11(
CreateTestWindowInShellWithDelegate(&d, -11, gfx::Rect()));
std::unique_ptr<aura::Window> w111(
CreateTestWindowInShellWithDelegate(&d, -111, gfx::Rect()));
std::unique_ptr<aura::Window> w2(
CreateTestWindowInShellWithDelegate(&d, -2, gfx::Rect()));
::wm::AddTransientChild(w1.get(), w11.get());
::wm::AddTransientChild(w11.get(), w111.get());
wm::ActivateWindow(w1.get());
EXPECT_TRUE(wm::IsActiveWindow(w1.get()));
wm::ActivateWindow(w2.get());
EXPECT_TRUE(wm::IsActiveWindow(w2.get()));
// Set up modality.
w11->SetProperty(aura::client::kModalKey, ui::mojom::ModalType::kWindow);
w111->SetProperty(aura::client::kModalKey, ui::mojom::ModalType::kWindow);
wm::ActivateWindow(w1.get());
EXPECT_TRUE(wm::IsActiveWindow(w111.get()));
int check1[] = {-2, -1, -11, -111};
EXPECT_TRUE(ValidateStacking(w1->parent(), check1, std::size(check1)));
wm::ActivateWindow(w11.get());
EXPECT_TRUE(wm::IsActiveWindow(w111.get()));
EXPECT_TRUE(ValidateStacking(w1->parent(), check1, std::size(check1)));
wm::ActivateWindow(w111.get());
EXPECT_TRUE(wm::IsActiveWindow(w111.get()));
EXPECT_TRUE(ValidateStacking(w1->parent(), check1, std::size(check1)));
wm::ActivateWindow(w2.get());
EXPECT_TRUE(wm::IsActiveWindow(w2.get()));
int check2[] = {-1, -11, -111, -2};
EXPECT_TRUE(ValidateStacking(w1->parent(), check2, std::size(check2)));
w2.reset();
EXPECT_TRUE(wm::IsActiveWindow(w111.get()));
w111.reset();
EXPECT_TRUE(wm::IsActiveWindow(w11.get()));
w11.reset();
EXPECT_TRUE(wm::IsActiveWindow(w1.get()));
}
// Create two toplevel windows w1 and w2, and nest two modals w11 and w111 below
// w1.
// Validates:
// - destroying w11 while w111 is focused activates w1.
TEST_F(WindowModalityControllerTest, NestedModalsOuterClosed) {
aura::test::TestWindowDelegate d;
std::unique_ptr<aura::Window> w1(
CreateTestWindowInShellWithDelegate(&d, -1, gfx::Rect()));
std::unique_ptr<aura::Window> w11(
CreateTestWindowInShellWithDelegate(&d, -11, gfx::Rect()));
// |w111| will be owned and deleted by |w11|.
aura::Window* w111 =
CreateTestWindowInShellWithDelegate(&d, -111, gfx::Rect());
std::unique_ptr<aura::Window> w2(
CreateTestWindowInShellWithDelegate(&d, -2, gfx::Rect()));
::wm::AddTransientChild(w1.get(), w11.get());
::wm::AddTransientChild(w11.get(), w111);
wm::ActivateWindow(w1.get());
EXPECT_TRUE(wm::IsActiveWindow(w1.get()));
wm::ActivateWindow(w2.get());
EXPECT_TRUE(wm::IsActiveWindow(w2.get()));
// Set up modality.
w11->SetProperty(aura::client::kModalKey, ui::mojom::ModalType::kWindow);
w111->SetProperty(aura::client::kModalKey, ui::mojom::ModalType::kWindow);
wm::ActivateWindow(w1.get());
EXPECT_TRUE(wm::IsActiveWindow(w111));
w111->Hide();
EXPECT_TRUE(wm::IsActiveWindow(w11.get()));
// TODO(oshima): Re-showing doesn't set the focus back to
// modal window. There is no such use case right now, but it
// probably should.
w11.reset();
EXPECT_TRUE(wm::IsActiveWindow(w1.get()));
}
// Modality also prevents events from being passed to the transient parent.
TEST_F(WindowModalityControllerTest, Events) {
aura::test::TestWindowDelegate d;
std::unique_ptr<aura::Window> w1(
CreateTestWindowInShellWithDelegate(&d, -1, gfx::Rect(0, 0, 100, 100)));
std::unique_ptr<aura::Window> w11(
CreateTestWindowInShellWithDelegate(&d, -11, gfx::Rect(20, 20, 50, 50)));
std::unique_ptr<aura::Window> w111(
CreateTestWindowInShellWithDelegate(&d, -111, gfx::Rect(20, 20, 50, 50)));
::wm::AddTransientChild(w1.get(), w11.get());
// Add a non-modal child to the modal window in order to ensure modality still
// works in this case. This is a regression test for https://crbug.com/456697.
::wm::AddTransientChild(w11.get(), w111.get());
{
// Clicking a point within w1 should activate that window.
ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow(),
gfx::Point(10, 10));
generator.ClickLeftButton();
EXPECT_TRUE(wm::IsActiveWindow(w1.get()));
}
w11->SetProperty(aura::client::kModalKey, ui::mojom::ModalType::kWindow);
{
// Clicking a point within w1 should activate w11.
ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow(),
gfx::Point(10, 10));
generator.ClickLeftButton();
EXPECT_TRUE(wm::IsActiveWindow(w11.get()));
}
}
// Events on modal parent activate.
TEST_F(WindowModalityControllerTest, EventsForEclipsedWindows) {
aura::test::TestWindowDelegate d;
std::unique_ptr<aura::Window> w1(
CreateTestWindowInShellWithDelegate(&d, -1, gfx::Rect(0, 0, 100, 100)));
std::unique_ptr<aura::Window> w11(
CreateTestWindowInShellWithDelegate(&d, -11, gfx::Rect(20, 20, 50, 50)));
::wm::AddTransientChild(w1.get(), w11.get());
std::unique_ptr<aura::Window> w2(
CreateTestWindowInShellWithDelegate(&d, -2, gfx::Rect(0, 0, 50, 50)));
w11->SetProperty(aura::client::kModalKey, ui::mojom::ModalType::kWindow);
// Partially eclipse w1 with w2.
wm::ActivateWindow(w2.get());
{
// Clicking a point on w1 that is not eclipsed by w2.
ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow(),
gfx::Point(90, 90));
generator.ClickLeftButton();
EXPECT_TRUE(wm::IsActiveWindow(w11.get()));
}
}
// Creates windows w1 and non activatiable child w11. Creates transient window
// w2 and adds it as a transeint child of w1. Ensures that w2 is parented to
// the parent of w1, and that GetModalTransient(w11) returns w2.
TEST_F(WindowModalityControllerTest, GetModalTransient) {
aura::test::TestWindowDelegate d;
std::unique_ptr<aura::Window> w1(
CreateTestWindowInShellWithDelegate(&d, -1, gfx::Rect()));
std::unique_ptr<aura::Window> w11(
aura::test::CreateTestWindowWithDelegate(&d, -11, gfx::Rect(), w1.get()));
std::unique_ptr<aura::Window> w2(
CreateTestWindowInShellWithDelegate(&d, -2, gfx::Rect()));
w2->SetProperty(aura::client::kModalKey, ui::mojom::ModalType::kWindow);
aura::Window* wt;
wt = ::wm::GetModalTransient(w1.get());
ASSERT_EQ(nullptr, wt);
// Parent w2 to w1. It should get parented to the parent of w1.
::wm::AddTransientChild(w1.get(), w2.get());
ASSERT_EQ(2U, w1->parent()->children().size());
EXPECT_EQ(-2, w1->parent()->children().at(1)->GetId());
// Request the modal transient window for w1, it should be w2.
wt = ::wm::GetModalTransient(w1.get());
ASSERT_NE(nullptr, wt);
EXPECT_EQ(-2, wt->GetId());
// Request the modal transient window for w11, it should also be w2.
wt = ::wm::GetModalTransient(w11.get());
ASSERT_NE(nullptr, wt);
EXPECT_EQ(-2, wt->GetId());
}
// Verifies we generate a capture lost when showing a modal window.
TEST_F(WindowModalityControllerTest, ChangeCapture) {
views::Widget* widget = views::Widget::CreateWindowWithContext(
nullptr, Shell::GetPrimaryRootWindow(), gfx::Rect(0, 0, 200, 200));
std::unique_ptr<aura::Window> widget_window(widget->GetNativeView());
views::test::CaptureTrackingView* view = new views::test::CaptureTrackingView;
widget->client_view()->AddChildView(view);
view->SetBoundsRect(widget->client_view()->GetLocalBounds());
widget->Show();
gfx::Point center(view->width() / 2, view->height() / 2);
views::View::ConvertPointToScreen(view, ¢er);
ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow(), center);
generator.PressLeftButton();
EXPECT_TRUE(view->got_press());
views::Widget* modal_widget = views::Widget::CreateWindowWithParent(
nullptr, widget->GetNativeView(), gfx::Rect(50, 50, 200, 200));
std::unique_ptr<aura::Window> modal_window(modal_widget->GetNativeView());
modal_window->SetProperty(aura::client::kModalKey,
ui::mojom::ModalType::kWindow);
views::test::CaptureTrackingView* modal_view =
new views::test::CaptureTrackingView;
modal_widget->client_view()->AddChildView(modal_view);
modal_view->SetBoundsRect(modal_widget->client_view()->GetLocalBounds());
modal_widget->Show();
EXPECT_TRUE(view->got_capture_lost());
generator.ReleaseLeftButton();
view->reset();
EXPECT_FALSE(modal_view->got_capture_lost());
EXPECT_FALSE(modal_view->got_press());
gfx::Point modal_center(modal_view->width() / 2, modal_view->height() / 2);
views::View::ConvertPointToScreen(modal_view, &modal_center);
generator.MoveMouseTo(modal_center, 1);
generator.PressLeftButton();
EXPECT_TRUE(modal_view->got_press());
EXPECT_FALSE(modal_view->got_capture_lost());
EXPECT_FALSE(view->got_capture_lost());
EXPECT_FALSE(view->got_press());
}
// Test that when a child modal window becomes visible, we only release the
// capture window if the current capture window is in the hierarchy of the child
// modal window's modal parent window.
TEST_F(WindowModalityControllerTest, ReleaseCapture) {
// Create a window hierarchy like this:
// _______________w0______________
// | | |
// w1 <------ w3 w2
// | (modal to)
// w11
aura::test::TestWindowDelegate d;
std::unique_ptr<aura::Window> w1(
CreateTestWindowInShellWithDelegate(&d, -1, gfx::Rect()));
std::unique_ptr<aura::Window> w11(
aura::test::CreateTestWindowWithDelegate(&d, -11, gfx::Rect(), w1.get()));
std::unique_ptr<aura::Window> w2(
CreateTestWindowInShellWithDelegate(&d, -2, gfx::Rect()));
std::unique_ptr<aura::Window> w3(
CreateTestWindowInShellWithDelegate(&d, -2, gfx::Rect()));
w3->SetProperty(aura::client::kModalKey, ui::mojom::ModalType::kChild);
::wm::SetModalParent(w3.get(), w1.get());
// w1's capture should be released when w3 becomes visible.
w3->Hide();
aura::client::GetCaptureClient(Shell::GetPrimaryRootWindow())
->SetCapture(w1.get());
EXPECT_EQ(w1.get(),
aura::client::GetCaptureClient(Shell::GetPrimaryRootWindow())
->GetGlobalCaptureWindow());
w3->Show();
EXPECT_NE(w1.get(),
aura::client::GetCaptureClient(Shell::GetPrimaryRootWindow())
->GetGlobalCaptureWindow());
// w11's capture should be released when w3 becomes visible.
w3->Hide();
aura::client::GetCaptureClient(Shell::GetPrimaryRootWindow())
->SetCapture(w11.get());
EXPECT_EQ(w11.get(),
aura::client::GetCaptureClient(Shell::GetPrimaryRootWindow())
->GetGlobalCaptureWindow());
w3->Show();
EXPECT_NE(w11.get(),
aura::client::GetCaptureClient(Shell::GetPrimaryRootWindow())
->GetGlobalCaptureWindow());
// w2's capture should not be released when w3 becomes visible.
w3->Hide();
aura::client::GetCaptureClient(Shell::GetPrimaryRootWindow())
->SetCapture(w2.get());
EXPECT_EQ(w2.get(),
aura::client::GetCaptureClient(Shell::GetPrimaryRootWindow())
->GetGlobalCaptureWindow());
w3->Show();
EXPECT_EQ(w2.get(),
aura::client::GetCaptureClient(Shell::GetPrimaryRootWindow())
->GetGlobalCaptureWindow());
}
class TouchTrackerWindowDelegate : public aura::test::TestWindowDelegate {
public:
TouchTrackerWindowDelegate()
: received_touch_(false), last_event_type_(ui::EventType::kUnknown) {}
TouchTrackerWindowDelegate(const TouchTrackerWindowDelegate&) = delete;
TouchTrackerWindowDelegate& operator=(const TouchTrackerWindowDelegate&) =
delete;
~TouchTrackerWindowDelegate() override = default;
void reset() {
received_touch_ = false;
last_event_type_ = ui::EventType::kUnknown;
}
bool received_touch() const { return received_touch_; }
ui::EventType last_event_type() const { return last_event_type_; }
private:
// Overridden from aura::test::TestWindowDelegate.
void OnTouchEvent(ui::TouchEvent* event) override {
received_touch_ = true;
last_event_type_ = event->type();
aura::test::TestWindowDelegate::OnTouchEvent(event);
}
bool received_touch_;
ui::EventType last_event_type_;
};
// Modality should prevent events from being passed to transient window tree
// rooted to the top level window.
TEST_F(WindowModalityControllerTest, TouchEvent) {
TouchTrackerWindowDelegate d1;
std::unique_ptr<aura::Window> w1(
CreateTestWindowInShellWithDelegate(&d1, -1, gfx::Rect(0, 0, 100, 100)));
TouchTrackerWindowDelegate d11;
std::unique_ptr<aura::Window> w11(CreateTestWindowInShellWithDelegate(
&d11, -11, gfx::Rect(20, 20, 20, 20)));
TouchTrackerWindowDelegate d12;
std::unique_ptr<aura::Window> w12(CreateTestWindowInShellWithDelegate(
&d12, -12, gfx::Rect(40, 20, 20, 20)));
TouchTrackerWindowDelegate d2;
std::unique_ptr<aura::Window> w2(CreateTestWindowInShellWithDelegate(
&d2, -2, gfx::Rect(100, 0, 100, 100)));
// Make |w11| and |w12| non-resizable to avoid touch events inside its
// transient parent |w1| from going to them because of
// EasyResizeWindowTargeter.
w11->SetProperty(aura::client::kResizeBehaviorKey,
aura::client::kResizeBehaviorCanMaximize |
aura::client::kResizeBehaviorCanMinimize);
w12->SetProperty(aura::client::kResizeBehaviorKey,
aura::client::kResizeBehaviorCanMaximize |
aura::client::kResizeBehaviorCanMinimize);
ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow(),
gfx::Point(10, 10));
::wm::AddTransientChild(w1.get(), w11.get());
::wm::AddTransientChild(w1.get(), w12.get());
d1.reset();
d11.reset();
d12.reset();
d2.reset();
{
// Adding a modal window while a touch is down in top level transient window
// should fire a touch cancel.
generator.PressTouch();
generator.MoveTouch(gfx::Point(10, 15));
EXPECT_TRUE(d1.received_touch());
EXPECT_TRUE(wm::IsActiveWindow(w1.get()));
d1.reset();
d11.reset();
d12.reset();
d2.reset();
w11->SetProperty(aura::client::kModalKey, ui::mojom::ModalType::kWindow);
EXPECT_TRUE(d1.received_touch());
EXPECT_EQ(ui::EventType::kTouchCancelled, d1.last_event_type());
EXPECT_FALSE(d11.received_touch());
EXPECT_FALSE(d12.received_touch());
EXPECT_FALSE(d2.received_touch());
w11->SetProperty(aura::client::kModalKey, ui::mojom::ModalType::kNone);
}
{
// Adding a modal window while a touch is down in window tree rooted to top
// level transient window should fire a touch cancel.
generator.MoveTouch(gfx::Point(50, 30));
generator.PressTouch();
generator.MoveTouch(gfx::Point(50, 35));
EXPECT_TRUE(d12.received_touch());
EXPECT_TRUE(wm::IsActiveWindow(w12.get()));
d1.reset();
d11.reset();
d12.reset();
d2.reset();
w11->SetProperty(aura::client::kModalKey, ui::mojom::ModalType::kWindow);
EXPECT_FALSE(d1.received_touch());
EXPECT_FALSE(d11.received_touch());
EXPECT_TRUE(d12.received_touch());
EXPECT_EQ(ui::EventType::kTouchCancelled, d12.last_event_type());
EXPECT_FALSE(d2.received_touch());
w11->SetProperty(aura::client::kModalKey, ui::mojom::ModalType::kNone);
}
{
// Adding a modal window while a touch is down in other transient window
// tree should not fire a touch cancel.
wm::ActivateWindow(w2.get());
generator.MoveTouch(gfx::Point(110, 10));
generator.PressTouch();
generator.MoveTouch(gfx::Point(110, 15));
EXPECT_TRUE(d2.received_touch());
EXPECT_TRUE(wm::IsActiveWindow(w2.get()));
d1.reset();
d11.reset();
d12.reset();
d2.reset();
w11->SetProperty(aura::client::kModalKey, ui::mojom::ModalType::kWindow);
EXPECT_FALSE(d1.received_touch());
EXPECT_FALSE(d11.received_touch());
EXPECT_FALSE(d12.received_touch());
EXPECT_FALSE(d2.received_touch());
w11->SetProperty(aura::client::kModalKey, ui::mojom::ModalType::kNone);
}
{
// Adding a child type modal window while a touch is down in other transient
// window tree should not fire a touch cancel. (See
// https://crbug.com/900321)
wm::ActivateWindow(w2.get());
generator.MoveTouch(gfx::Point(110, 10));
generator.PressTouch();
generator.MoveTouch(gfx::Point(110, 15));
EXPECT_TRUE(d2.received_touch());
EXPECT_TRUE(wm::IsActiveWindow(w2.get()));
d1.reset();
d11.reset();
d12.reset();
d2.reset();
w11->SetProperty(aura::client::kModalKey, ui::mojom::ModalType::kChild);
EXPECT_FALSE(d1.received_touch());
EXPECT_FALSE(d11.received_touch());
EXPECT_FALSE(d12.received_touch());
EXPECT_FALSE(d2.received_touch());
w11->SetProperty(aura::client::kModalKey, ui::mojom::ModalType::kNone);
}
}
// Child-modal test.
// Creates:
// - A |top_level| window that hosts a |modal_parent| window within itself. The
// |top_level| and |modal_parent| windows are not the same window. The
// |modal_parent| window is not activatable, because it's contained within the
// |top_level| window.
// - A |modal_child| window with parent window |top_level|, but is modal to
// |modal_parent| window.
// Validates:
// - Clicking on the |modal_parent| should activate the |modal_child| window.
// - Clicking on the |top_level| window outside of the |modal_parent| bounds
// should activate the |top_level| window.
// - Clicking on the |modal_child| while |top_level| is active should activate
// the |modal_child| window.
// - Focus should follow the active window.
TEST_F(WindowModalityControllerTest, ChildModal) {
TestChildModalParent* delegate = TestChildModalParent::Show(GetContext());
aura::Window* top_level = delegate->GetWidget()->GetNativeView();
EXPECT_TRUE(wm::IsActiveWindow(top_level));
aura::Window* modal_parent = delegate->GetModalParent();
EXPECT_NE(nullptr, modal_parent);
EXPECT_NE(top_level, modal_parent);
EXPECT_FALSE(wm::IsActiveWindow(modal_parent));
aura::Window* modal_child = delegate->ShowModalChild();
EXPECT_NE(nullptr, modal_child);
EXPECT_TRUE(wm::IsActiveWindow(modal_child));
EXPECT_FALSE(wm::IsActiveWindow(modal_parent));
EXPECT_FALSE(wm::IsActiveWindow(top_level));
EXPECT_TRUE(modal_child->HasFocus());
EXPECT_FALSE(modal_parent->HasFocus());
EXPECT_FALSE(top_level->HasFocus());
wm::ActivateWindow(modal_parent);
EXPECT_TRUE(wm::IsActiveWindow(modal_child));
EXPECT_FALSE(wm::IsActiveWindow(modal_parent));
EXPECT_FALSE(wm::IsActiveWindow(top_level));
EXPECT_TRUE(modal_child->HasFocus());
EXPECT_FALSE(modal_parent->HasFocus());
EXPECT_FALSE(top_level->HasFocus());
wm::ActivateWindow(top_level);
EXPECT_FALSE(wm::IsActiveWindow(modal_child));
EXPECT_FALSE(wm::IsActiveWindow(modal_parent));
EXPECT_TRUE(wm::IsActiveWindow(top_level));
EXPECT_FALSE(modal_child->HasFocus());
EXPECT_FALSE(modal_parent->HasFocus());
EXPECT_TRUE(top_level->HasFocus());
wm::ActivateWindow(modal_child);
EXPECT_TRUE(wm::IsActiveWindow(modal_child));
EXPECT_FALSE(wm::IsActiveWindow(modal_parent));
EXPECT_FALSE(wm::IsActiveWindow(top_level));
EXPECT_TRUE(modal_child->HasFocus());
EXPECT_FALSE(modal_parent->HasFocus());
EXPECT_FALSE(top_level->HasFocus());
}
// Same as |ChildModal| test, but using |EventGenerator| rather than bypassing
// it by calling |ActivateWindow|.
TEST_F(WindowModalityControllerTest, ChildModalEventGenerator) {
TestChildModalParent* delegate = TestChildModalParent::Show(GetContext());
aura::Window* top_level = delegate->GetWidget()->GetNativeView();
EXPECT_TRUE(wm::IsActiveWindow(top_level));
aura::Window* modal_parent = delegate->GetModalParent();
EXPECT_NE(nullptr, modal_parent);
EXPECT_NE(top_level, modal_parent);
EXPECT_FALSE(wm::IsActiveWindow(modal_parent));
aura::Window* modal_child = delegate->ShowModalChild();
EXPECT_NE(nullptr, modal_child);
EXPECT_TRUE(wm::IsActiveWindow(modal_child));
EXPECT_FALSE(wm::IsActiveWindow(modal_parent));
EXPECT_FALSE(wm::IsActiveWindow(top_level));
EXPECT_TRUE(modal_child->HasFocus());
EXPECT_FALSE(modal_parent->HasFocus());
EXPECT_FALSE(top_level->HasFocus());
{
ui::test::EventGenerator generator(
Shell::GetPrimaryRootWindow(),
top_level->bounds().origin() +
gfx::Vector2d(10, top_level->bounds().height() - 10));
generator.ClickLeftButton();
generator.ClickLeftButton();
EXPECT_TRUE(wm::IsActiveWindow(modal_child));
EXPECT_FALSE(wm::IsActiveWindow(modal_parent));
EXPECT_FALSE(wm::IsActiveWindow(top_level));
EXPECT_TRUE(modal_child->HasFocus());
EXPECT_FALSE(modal_parent->HasFocus());
EXPECT_FALSE(top_level->HasFocus());
}
{
ui::test::EventGenerator generator(
Shell::GetPrimaryRootWindow(),
top_level->bounds().origin() + gfx::Vector2d(10, 10));
generator.ClickLeftButton();
EXPECT_FALSE(wm::IsActiveWindow(modal_child));
EXPECT_FALSE(wm::IsActiveWindow(modal_parent));
EXPECT_TRUE(wm::IsActiveWindow(top_level));
EXPECT_FALSE(modal_child->HasFocus());
EXPECT_FALSE(modal_parent->HasFocus());
EXPECT_TRUE(top_level->HasFocus());
}
{
ui::test::EventGenerator generator(
Shell::GetPrimaryRootWindow(),
modal_child->bounds().origin() + gfx::Vector2d(10, 10));
generator.ClickLeftButton();
EXPECT_TRUE(wm::IsActiveWindow(modal_child));
EXPECT_FALSE(wm::IsActiveWindow(modal_parent));
EXPECT_FALSE(wm::IsActiveWindow(top_level));
EXPECT_TRUE(modal_child->HasFocus());
EXPECT_FALSE(modal_parent->HasFocus());
EXPECT_FALSE(top_level->HasFocus());
}
}
// Window-modal test for the case when the originally clicked window is an
// ancestor of the modal parent.
TEST_F(WindowModalityControllerTest, WindowModalAncestor) {
aura::test::TestWindowDelegate d;
std::unique_ptr<aura::Window> w1(
CreateTestWindowInShellWithDelegate(&d, -1, gfx::Rect()));
std::unique_ptr<aura::Window> w2(
aura::test::CreateTestWindowWithDelegate(&d, -11, gfx::Rect(), w1.get()));
std::unique_ptr<aura::Window> w3(
aura::test::CreateTestWindowWithDelegate(&d, -11, gfx::Rect(), w2.get()));
std::unique_ptr<aura::Window> w4(
CreateTestWindowInShellWithDelegate(&d, -2, gfx::Rect()));
w4->SetProperty(aura::client::kModalKey, ui::mojom::ModalType::kWindow);
::wm::AddTransientChild(w1.get(), w4.get());
wm::ActivateWindow(w1.get());
EXPECT_TRUE(wm::IsActiveWindow(w4.get()));
wm::ActivateWindow(w2.get());
EXPECT_TRUE(wm::IsActiveWindow(w4.get()));
wm::ActivateWindow(w3.get());
EXPECT_TRUE(wm::IsActiveWindow(w4.get()));
wm::ActivateWindow(w4.get());
EXPECT_TRUE(wm::IsActiveWindow(w4.get()));
}
// Child-modal test for the case when the originally clicked window is an
// ancestor of the modal parent.
TEST_F(WindowModalityControllerTest, ChildModalAncestor) {
aura::test::TestWindowDelegate d;
std::unique_ptr<aura::Window> w1(
CreateTestWindowInShellWithDelegate(&d, -1, gfx::Rect()));
std::unique_ptr<aura::Window> w2(
aura::test::CreateTestWindowWithDelegate(&d, -11, gfx::Rect(), w1.get()));
std::unique_ptr<aura::Window> w3(
aura::test::CreateTestWindowWithDelegate(&d, -11, gfx::Rect(), w2.get()));
std::unique_ptr<aura::Window> w4(
CreateTestWindowInShellWithDelegate(&d, -2, gfx::Rect()));
w4->SetProperty(aura::client::kModalKey, ui::mojom::ModalType::kChild);
::wm::SetModalParent(w4.get(), w2.get());
::wm::AddTransientChild(w1.get(), w4.get());
wm::ActivateWindow(w1.get());
EXPECT_TRUE(wm::IsActiveWindow(w1.get()));
wm::ActivateWindow(w2.get());
EXPECT_TRUE(wm::IsActiveWindow(w4.get()));
wm::ActivateWindow(w3.get());
EXPECT_TRUE(wm::IsActiveWindow(w4.get()));
wm::ActivateWindow(w4.get());
EXPECT_TRUE(wm::IsActiveWindow(w4.get()));
}
} // namespace ash