1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
ash / wm / window_positioner_unittest.cc [blame]
// Copyright 2013 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ash/wm/window_positioner.h"
#include <string>
#include "ash/public/cpp/shelf_config.h"
#include "ash/shell.h"
#include "ash/test/ash_test_base.h"
#include "ash/test/toplevel_window.h"
#include "ash/test_shell_delegate.h"
#include "ash/wm/window_state.h"
#include "base/strings/string_number_conversions.h"
#include "ui/aura/client/aura_constants.h"
#include "ui/aura/client/window_types.h"
#include "ui/aura/window.h"
#include "ui/display/scoped_display_for_new_windows.h"
#include "ui/display/screen.h"
#include "ui/views/widget/widget.h"
namespace ash {
using WindowPositionerTest = AshTestBase;
TEST_F(WindowPositionerTest, OpenDefaultWindowOnSecondDisplay) {
UpdateDisplay("500x400,1400x900");
aura::Window* second_root_window = Shell::GetAllRootWindows()[1];
display::ScopedDisplayForNewWindows display_for_new_windows(
second_root_window);
shell::ToplevelWindow::CreateParams params;
params.can_resize = true;
params.can_maximize = true;
views::Widget* widget = shell::ToplevelWindow::CreateToplevelWindow(params);
gfx::Rect bounds = widget->GetWindowBoundsInScreen();
// The window should be in the 2nd display with the default size.
EXPECT_EQ("300x300", bounds.size().ToString());
EXPECT_TRUE(display::Screen::GetScreen()
->GetDisplayNearestWindow(second_root_window)
.bounds()
.Contains(bounds));
}
// Tests that second window inherits first window's maximized state as well as
// its restore bounds.
TEST_F(WindowPositionerTest, SecondMaximizedWindowHasProperRestoreSize) {
UpdateDisplay("1400x900");
const int bottom_inset = 900 - ShelfConfig::Get()->shelf_size();
shell::ToplevelWindow::CreateParams params;
params.can_resize = true;
params.can_maximize = true;
views::Widget* widget1 = shell::ToplevelWindow::CreateToplevelWindow(params);
gfx::Rect bounds = widget1->GetWindowBoundsInScreen();
// The window should have default size.
EXPECT_FALSE(widget1->IsMaximized());
EXPECT_EQ("300x300", bounds.size().ToString());
widget1->Maximize();
// The window should be maximized.
bounds = widget1->GetWindowBoundsInScreen();
EXPECT_TRUE(widget1->IsMaximized());
EXPECT_EQ(gfx::Rect(0, 0, 1400, bottom_inset).ToString(), bounds.ToString());
// Create another window
views::Widget* widget2 = shell::ToplevelWindow::CreateToplevelWindow(params);
// The second window should be maximized.
bounds = widget2->GetWindowBoundsInScreen();
EXPECT_TRUE(widget2->IsMaximized());
EXPECT_EQ(gfx::Rect(0, 0, 1400, bottom_inset).ToString(), bounds.ToString());
widget2->Restore();
// Second window's restored size should be set to default size.
bounds = widget2->GetWindowBoundsInScreen();
EXPECT_EQ("300x300", bounds.size().ToString());
}
TEST_F(WindowPositionerTest, IgnoreFullscreenInAutoRearrange) {
// Set bigger than 1366 so that the new window is opened in normal state.
UpdateDisplay("1400x800");
// 1st window mimics fullscreen browser window behavior.
shell::ToplevelWindow::CreateParams params;
params.can_resize = true;
params.can_maximize = true;
views::Widget* widget1 = shell::ToplevelWindow::CreateToplevelWindow(params);
WindowState* managed_state = WindowState::Get(widget1->GetNativeWindow());
EXPECT_TRUE(managed_state->GetWindowPositionManaged());
EXPECT_EQ("300x300", widget1->GetWindowBoundsInScreen().size().ToString());
widget1->SetFullscreen(true);
ASSERT_EQ("1400x800", widget1->GetWindowBoundsInScreen().size().ToString());
// 2nd window mimics windowed v1 app.
params.use_saved_placement = false;
views::Widget* widget2 = shell::ToplevelWindow::CreateToplevelWindow(params);
WindowState* state_2 = WindowState::Get(widget2->GetNativeWindow());
EXPECT_TRUE(state_2->GetWindowPositionManaged());
EXPECT_EQ("300x300", widget2->GetWindowBoundsInScreen().size().ToString());
// Restores to the original size.
widget1->SetFullscreen(false);
ASSERT_EQ("300x300", widget1->GetWindowBoundsInScreen().size().ToString());
// Closing 2nd widget triggers the rearrange logic but the 1st
// widget should stay in the current size.
widget2->CloseNow();
ASSERT_EQ("300x300", widget1->GetWindowBoundsInScreen().size().ToString());
}
// Tests auto managed windows do not auto-position if there are other windows
// opened.
TEST_F(WindowPositionerTest, AutoRearrangeOnHideOrRemove) {
// Create 2 browser windows.
std::unique_ptr<aura::Window> window1 = CreateAppWindow(
gfx::Rect(200, 200, 330, 230), chromeos::AppType::BROWSER);
std::unique_ptr<aura::Window> window2 = CreateAppWindow(
gfx::Rect(400, 600, 330, 230), chromeos::AppType::BROWSER);
// Create 1 app window.
std::unique_ptr<aura::Window> window3 = CreateAppWindow(
gfx::Rect(300, 200, 330, 230), chromeos::AppType::SYSTEM_APP);
WindowState::Get(window1.get())->SetWindowPositionManaged(true);
WindowState::Get(window2.get())->SetWindowPositionManaged(true);
// Closing 2nd browser window triggers the rearrange logic but the 1st
// browser window should stay in the current place.
window2.reset();
EXPECT_EQ(gfx::Rect(200, 200, 330, 230), window1->GetBoundsInScreen());
}
} // namespace ash