1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
base / command_line_unittest.cc [blame]
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifdef UNSAFE_BUFFERS_BUILD
// TODO(crbug.com/40284755): Remove this and spanify to fix the errors.
#pragma allow_unsafe_buffers
#endif
#include "base/command_line.h"
#include <array>
#include <memory>
#include <string>
#include <string_view>
#include <vector>
#include "base/debug/debugging_buildflags.h"
#include "base/files/file_path.h"
#include "base/strings/strcat.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#if BUILDFLAG(IS_WIN)
#include <windows.h>
#include <shellapi.h>
#include "base/win/scoped_localalloc.h"
#endif // BUILDFLAG(IS_WIN)
#if BUILDFLAG(ENABLE_COMMANDLINE_SEQUENCE_CHECKS)
#include "base/run_loop.h"
#include "base/task/thread_pool.h"
#include "base/test/bind.h"
#include "base/test/task_environment.h"
#endif // BUILDFLAG(ENABLE_COMMANDLINE_SEQUENCE_CHECKS)
namespace base {
#if BUILDFLAG(IS_WIN)
// To test Windows quoting behavior, we use a string that has some backslashes
// and quotes.
// Consider the command-line argument: q\"bs1\bs2\\bs3q\\\"
// Here it is with C-style escapes.
static const CommandLine::StringType kTrickyQuoted =
FILE_PATH_LITERAL("q\\\"bs1\\bs2\\\\bs3q\\\\\\\"");
#endif
// It should be parsed by Windows as: q"bs1\bs2\\bs3q\"
// Here that is with C-style escapes.
static const CommandLine::StringType kTricky =
FILE_PATH_LITERAL("q\"bs1\\bs2\\\\bs3q\\\"");
TEST(CommandLineTest, CommandLineConstructor) {
const CommandLine::CharType* argv[] = {
FILE_PATH_LITERAL("program"),
FILE_PATH_LITERAL("--foo="),
FILE_PATH_LITERAL("-bAr"),
FILE_PATH_LITERAL("-spaetzel=pierogi"),
FILE_PATH_LITERAL("-baz"),
FILE_PATH_LITERAL("flim"),
FILE_PATH_LITERAL("--other-switches=--dog=canine --cat=feline"),
FILE_PATH_LITERAL("-spaetzle=Crepe"),
FILE_PATH_LITERAL("-=loosevalue"),
FILE_PATH_LITERAL("-"),
FILE_PATH_LITERAL("FLAN"),
FILE_PATH_LITERAL("a"),
FILE_PATH_LITERAL("--input-translation=45--output-rotation"),
FILE_PATH_LITERAL("--"),
FILE_PATH_LITERAL("--"),
FILE_PATH_LITERAL("--not-a-switch"),
FILE_PATH_LITERAL("\"in the time of submarines...\""),
FILE_PATH_LITERAL("unquoted arg-with-space")};
CommandLine cl(std::size(argv), argv);
EXPECT_FALSE(cl.GetCommandLineString().empty());
EXPECT_FALSE(cl.HasSwitch("cruller"));
EXPECT_FALSE(cl.HasSwitch("flim"));
EXPECT_FALSE(cl.HasSwitch("program"));
EXPECT_FALSE(cl.HasSwitch("dog"));
EXPECT_FALSE(cl.HasSwitch("cat"));
EXPECT_FALSE(cl.HasSwitch("output-rotation"));
EXPECT_FALSE(cl.HasSwitch("not-a-switch"));
EXPECT_FALSE(cl.HasSwitch("--"));
EXPECT_EQ(FilePath(FILE_PATH_LITERAL("program")).value(),
cl.GetProgram().value());
EXPECT_TRUE(cl.HasSwitch("foo"));
#if BUILDFLAG(IS_WIN)
EXPECT_TRUE(cl.HasSwitch("bar"));
#else
EXPECT_FALSE(cl.HasSwitch("bar"));
#endif
EXPECT_TRUE(cl.HasSwitch("baz"));
EXPECT_TRUE(cl.HasSwitch("spaetzle"));
EXPECT_TRUE(cl.HasSwitch("other-switches"));
EXPECT_TRUE(cl.HasSwitch("input-translation"));
EXPECT_EQ("Crepe", cl.GetSwitchValueASCII("spaetzle"));
EXPECT_EQ("", cl.GetSwitchValueASCII("foo"));
EXPECT_EQ("", cl.GetSwitchValueASCII("bar"));
EXPECT_EQ("", cl.GetSwitchValueASCII("cruller"));
EXPECT_EQ("--dog=canine --cat=feline", cl.GetSwitchValueASCII(
"other-switches"));
EXPECT_EQ("45--output-rotation", cl.GetSwitchValueASCII("input-translation"));
const CommandLine::StringVector& args = cl.GetArgs();
ASSERT_EQ(8U, args.size());
auto iter = args.begin();
EXPECT_EQ(FILE_PATH_LITERAL("flim"), *iter);
++iter;
EXPECT_EQ(FILE_PATH_LITERAL("-"), *iter);
++iter;
EXPECT_EQ(FILE_PATH_LITERAL("FLAN"), *iter);
++iter;
EXPECT_EQ(FILE_PATH_LITERAL("a"), *iter);
++iter;
EXPECT_EQ(FILE_PATH_LITERAL("--"), *iter);
++iter;
EXPECT_EQ(FILE_PATH_LITERAL("--not-a-switch"), *iter);
++iter;
EXPECT_EQ(FILE_PATH_LITERAL("\"in the time of submarines...\""), *iter);
++iter;
EXPECT_EQ(FILE_PATH_LITERAL("unquoted arg-with-space"), *iter);
++iter;
EXPECT_TRUE(iter == args.end());
}
TEST(CommandLineTest, CommandLineFromArgvWithoutProgram) {
CommandLine::StringVector argv = {FILE_PATH_LITERAL("--switch1"),
FILE_PATH_LITERAL("--switch2=value2")};
CommandLine cl = CommandLine::FromArgvWithoutProgram(argv);
EXPECT_EQ(base::FilePath(), cl.GetProgram());
EXPECT_TRUE(cl.HasSwitch("switch1"));
EXPECT_EQ("value2", cl.GetSwitchValueASCII("switch2"));
}
TEST(CommandLineTest, CommandLineFromString) {
#if BUILDFLAG(IS_WIN)
CommandLine cl = CommandLine::FromString(
L"program --foo= -bAr /Spaetzel=pierogi /Baz flim "
L"--other-switches=\"--dog=canine --cat=feline\" "
L"-spaetzle=Crepe -=loosevalue FLAN "
L"--input-translation=\"45\"--output-rotation "
L"--quotes=" +
kTrickyQuoted +
L" -- -- --not-a-switch \"in the time of submarines...\"");
EXPECT_FALSE(cl.GetCommandLineString().empty());
EXPECT_FALSE(cl.HasSwitch("cruller"));
EXPECT_FALSE(cl.HasSwitch("flim"));
EXPECT_FALSE(cl.HasSwitch("program"));
EXPECT_FALSE(cl.HasSwitch("dog"));
EXPECT_FALSE(cl.HasSwitch("cat"));
EXPECT_FALSE(cl.HasSwitch("output-rotation"));
EXPECT_FALSE(cl.HasSwitch("not-a-switch"));
EXPECT_FALSE(cl.HasSwitch("--"));
EXPECT_EQ(FilePath(FILE_PATH_LITERAL("program")).value(),
cl.GetProgram().value());
EXPECT_TRUE(cl.HasSwitch("foo"));
EXPECT_TRUE(cl.HasSwitch("bar"));
EXPECT_TRUE(cl.HasSwitch("baz"));
EXPECT_TRUE(cl.HasSwitch("spaetzle"));
EXPECT_TRUE(cl.HasSwitch("other-switches"));
EXPECT_TRUE(cl.HasSwitch("input-translation"));
EXPECT_TRUE(cl.HasSwitch("quotes"));
EXPECT_EQ("Crepe", cl.GetSwitchValueASCII("spaetzle"));
EXPECT_EQ("", cl.GetSwitchValueASCII("foo"));
EXPECT_EQ("", cl.GetSwitchValueASCII("bar"));
EXPECT_EQ("", cl.GetSwitchValueASCII("cruller"));
EXPECT_EQ("--dog=canine --cat=feline", cl.GetSwitchValueASCII(
"other-switches"));
EXPECT_EQ("45--output-rotation", cl.GetSwitchValueASCII("input-translation"));
EXPECT_EQ(kTricky, cl.GetSwitchValueNative("quotes"));
const CommandLine::StringVector& args = cl.GetArgs();
ASSERT_EQ(5U, args.size());
std::vector<CommandLine::StringType>::const_iterator iter = args.begin();
EXPECT_EQ(FILE_PATH_LITERAL("flim"), *iter);
++iter;
EXPECT_EQ(FILE_PATH_LITERAL("FLAN"), *iter);
++iter;
EXPECT_EQ(FILE_PATH_LITERAL("--"), *iter);
++iter;
EXPECT_EQ(FILE_PATH_LITERAL("--not-a-switch"), *iter);
++iter;
EXPECT_EQ(FILE_PATH_LITERAL("in the time of submarines..."), *iter);
++iter;
EXPECT_TRUE(iter == args.end());
// Check that a generated string produces an equivalent command line.
CommandLine cl_duplicate = CommandLine::FromString(cl.GetCommandLineString());
EXPECT_EQ(cl.GetCommandLineString(), cl_duplicate.GetCommandLineString());
#endif
}
// Tests behavior with an empty input string.
TEST(CommandLineTest, EmptyString) {
#if BUILDFLAG(IS_WIN)
CommandLine cl_from_string = CommandLine::FromString(std::wstring());
EXPECT_TRUE(cl_from_string.GetCommandLineString().empty());
EXPECT_TRUE(cl_from_string.GetProgram().empty());
EXPECT_EQ(1U, cl_from_string.argv().size());
EXPECT_TRUE(cl_from_string.GetArgs().empty());
#endif
CommandLine cl_from_argv(0, nullptr);
EXPECT_TRUE(cl_from_argv.GetCommandLineString().empty());
EXPECT_TRUE(cl_from_argv.GetProgram().empty());
EXPECT_EQ(1U, cl_from_argv.argv().size());
EXPECT_TRUE(cl_from_argv.GetArgs().empty());
}
TEST(CommandLineTest, GetArgumentsString) {
static const FilePath::CharType kPath1[] =
FILE_PATH_LITERAL("C:\\Some File\\With Spaces.ggg");
static const FilePath::CharType kPath2[] =
FILE_PATH_LITERAL("C:\\no\\spaces.ggg");
static const char kFirstArgName[] = "first-arg";
static const char kSecondArgName[] = "arg2";
static const char kThirdArgName[] = "arg with space";
static const char kFourthArgName[] = "nospace";
CommandLine cl(CommandLine::NO_PROGRAM);
cl.AppendSwitchPath(kFirstArgName, FilePath(kPath1));
cl.AppendSwitchPath(kSecondArgName, FilePath(kPath2));
cl.AppendArg(kThirdArgName);
cl.AppendArg(kFourthArgName);
#if BUILDFLAG(IS_WIN)
CommandLine::StringType expected_first_arg(UTF8ToWide(kFirstArgName));
CommandLine::StringType expected_second_arg(UTF8ToWide(kSecondArgName));
CommandLine::StringType expected_third_arg(UTF8ToWide(kThirdArgName));
CommandLine::StringType expected_fourth_arg(UTF8ToWide(kFourthArgName));
#elif BUILDFLAG(IS_POSIX) || BUILDFLAG(IS_FUCHSIA)
CommandLine::StringType expected_first_arg(kFirstArgName);
CommandLine::StringType expected_second_arg(kSecondArgName);
CommandLine::StringType expected_third_arg(kThirdArgName);
CommandLine::StringType expected_fourth_arg(kFourthArgName);
#endif
#if BUILDFLAG(IS_WIN)
#define QUOTE_ON_WIN FILE_PATH_LITERAL("\"")
#else
#define QUOTE_ON_WIN FILE_PATH_LITERAL("")
#endif // BUILDFLAG(IS_WIN)
CommandLine::StringType expected_str;
expected_str.append(FILE_PATH_LITERAL("--"))
.append(expected_first_arg)
.append(FILE_PATH_LITERAL("="))
.append(QUOTE_ON_WIN)
.append(kPath1)
.append(QUOTE_ON_WIN)
.append(FILE_PATH_LITERAL(" "))
.append(FILE_PATH_LITERAL("--"))
.append(expected_second_arg)
.append(FILE_PATH_LITERAL("="))
.append(QUOTE_ON_WIN)
.append(kPath2)
.append(QUOTE_ON_WIN)
.append(FILE_PATH_LITERAL(" "))
.append(QUOTE_ON_WIN)
.append(expected_third_arg)
.append(QUOTE_ON_WIN)
.append(FILE_PATH_LITERAL(" "))
.append(expected_fourth_arg);
EXPECT_EQ(expected_str, cl.GetArgumentsString());
}
// Test methods for appending switches to a command line.
TEST(CommandLineTest, AppendSwitches) {
std::string switch1 = "switch1";
std::string switch2 = "switch2";
std::string value2 = "value";
std::string switch3 = "switch3";
std::string value3 = "a value with spaces";
std::string switch4 = "switch4";
std::string value4 = "\"a value with quotes\"";
std::string switch5 = "quotes";
CommandLine::StringType value5 = kTricky;
CommandLine cl(FilePath(FILE_PATH_LITERAL("Program")));
cl.AppendSwitch(switch1);
cl.AppendSwitchASCII(switch2, value2);
cl.AppendSwitchASCII(switch3, value3);
cl.AppendSwitchASCII(switch4, value4);
cl.AppendSwitchASCII(switch5, value4);
cl.AppendSwitchNative(switch5, value5);
EXPECT_TRUE(cl.HasSwitch(switch1));
EXPECT_TRUE(cl.HasSwitch(switch2));
EXPECT_EQ(value2, cl.GetSwitchValueASCII(switch2));
EXPECT_TRUE(cl.HasSwitch(switch3));
EXPECT_EQ(value3, cl.GetSwitchValueASCII(switch3));
EXPECT_TRUE(cl.HasSwitch(switch4));
EXPECT_EQ(value4, cl.GetSwitchValueASCII(switch4));
EXPECT_TRUE(cl.HasSwitch(switch5));
EXPECT_EQ(value5, cl.GetSwitchValueNative(switch5));
#if BUILDFLAG(IS_WIN)
EXPECT_EQ(
L"Program "
L"--switch1 "
L"--switch2=value "
L"--switch3=\"a value with spaces\" "
L"--switch4=\"\\\"a value with quotes\\\"\" "
// Even though the switches are unique, appending can add repeat
// switches to argv.
L"--quotes=\"\\\"a value with quotes\\\"\" "
L"--quotes=\"" +
kTrickyQuoted + L"\"",
cl.GetCommandLineString());
#endif
}
TEST(CommandLineTest, AppendSwitchesDashDash) {
const CommandLine::CharType* const raw_argv[] = {FILE_PATH_LITERAL("prog"),
FILE_PATH_LITERAL("--"),
FILE_PATH_LITERAL("--arg1")};
CommandLine cl(std::size(raw_argv), raw_argv);
cl.AppendSwitch("switch1");
cl.AppendSwitchASCII("switch2", "foo");
cl.AppendArg("--arg2");
EXPECT_EQ(FILE_PATH_LITERAL("prog --switch1 --switch2=foo -- --arg1 --arg2"),
cl.GetCommandLineString());
CommandLine::StringVector cl_argv = cl.argv();
EXPECT_EQ(FILE_PATH_LITERAL("prog"), cl_argv[0]);
EXPECT_EQ(FILE_PATH_LITERAL("--switch1"), cl_argv[1]);
EXPECT_EQ(FILE_PATH_LITERAL("--switch2=foo"), cl_argv[2]);
EXPECT_EQ(FILE_PATH_LITERAL("--"), cl_argv[3]);
EXPECT_EQ(FILE_PATH_LITERAL("--arg1"), cl_argv[4]);
EXPECT_EQ(FILE_PATH_LITERAL("--arg2"), cl_argv[5]);
}
#if BUILDFLAG(IS_WIN)
struct CommandLineQuoteTestCase {
const wchar_t* const input_arg;
const wchar_t* const expected_output_arg;
};
class CommandLineQuoteTest
: public ::testing::TestWithParam<CommandLineQuoteTestCase> {};
INSTANTIATE_TEST_SUITE_P(
CommandLineQuoteTestCases,
CommandLineQuoteTest,
::testing::ValuesIn(std::vector<CommandLineQuoteTestCase>{
{L"", L""},
{L"abc = xyz", LR"("abc = xyz")"},
{LR"(C:\AppData\Local\setup.exe)", LR"("C:\AppData\Local\setup.exe")"},
{LR"(C:\Program Files\setup.exe)", LR"("C:\Program Files\setup.exe")"},
{LR"("C:\Program Files\setup.exe")",
LR"("\"C:\Program Files\setup.exe\"")"},
}));
TEST_P(CommandLineQuoteTest, TestCases) {
EXPECT_EQ(CommandLine::QuoteForCommandLineToArgvW(GetParam().input_arg),
GetParam().expected_output_arg);
}
struct CommandLineQuoteAfterTestCase {
const std::vector<std::wstring> input_args;
const wchar_t* const expected_output;
};
class CommandLineQuoteAfterTest
: public ::testing::TestWithParam<CommandLineQuoteAfterTestCase> {};
INSTANTIATE_TEST_SUITE_P(
CommandLineQuoteAfterTestCases,
CommandLineQuoteAfterTest,
::testing::ValuesIn(std::vector<CommandLineQuoteAfterTestCase>{
{{L"abc=1"}, L"abc=1"},
{{L"abc=1", L"xyz=2"}, L"abc=1 xyz=2"},
{{L"abc=1", L"xyz=2", L"q"}, L"abc=1 xyz=2 q"},
{{L" abc=1 ", L" xyz=2", L"q "}, L"abc=1 xyz=2 q"},
{{LR"("abc = 1")"}, LR"("abc = 1")"},
{{LR"(abc" = "1)", L"xyz=2"}, LR"("abc = 1" xyz=2)"},
{{LR"(abc" = "1)"}, LR"("abc = 1")"},
{{LR"(\\)", LR"(\\\")"}, LR"("\\\\" "\\\"")"},
}));
TEST_P(CommandLineQuoteAfterTest, TestCases) {
std::wstring input_command_line =
base::StrCat({LR"(c:\test\process.exe )",
base::JoinString(GetParam().input_args, L" ")});
int num_args = 0;
base::win::ScopedLocalAllocTyped<wchar_t*> argv(
::CommandLineToArgvW(&input_command_line[0], &num_args));
ASSERT_EQ(num_args - 1U, GetParam().input_args.size());
std::wstring recreated_command_line;
for (int i = 1; i < num_args; ++i) {
recreated_command_line.append(
CommandLine::QuoteForCommandLineToArgvW(argv.get()[i]));
if (i + 1 < num_args) {
recreated_command_line.push_back(L' ');
}
}
EXPECT_EQ(recreated_command_line, GetParam().expected_output);
}
TEST(CommandLineTest, GetCommandLineStringForShell) {
CommandLine cl = CommandLine::FromString(
FILE_PATH_LITERAL("program --switch /switch2 --"));
EXPECT_EQ(
cl.GetCommandLineStringForShell(),
FILE_PATH_LITERAL("program --switch /switch2 -- --single-argument %1"));
}
TEST(CommandLineTest, GetCommandLineStringWithUnsafeInsertSequences) {
CommandLine cl(FilePath(FILE_PATH_LITERAL("program")));
cl.AppendSwitchASCII("switch", "%1");
cl.AppendSwitch("%2");
cl.AppendArg("%3");
EXPECT_EQ(FILE_PATH_LITERAL("program --switch=%1 --%2 %3"),
cl.GetCommandLineStringWithUnsafeInsertSequences());
}
TEST(CommandLineTest, HasSingleArgument) {
CommandLine cl(FilePath(FILE_PATH_LITERAL("Program")));
cl.AppendSwitchASCII("switch2", "foo");
EXPECT_FALSE(cl.HasSingleArgumentSwitch());
CommandLine cl_for_shell(
CommandLine::FromString(cl.GetCommandLineStringForShell()));
EXPECT_TRUE(cl_for_shell.HasSingleArgumentSwitch());
}
// Test that creating a new command line from the string version of a single
// argument command line maintains the single argument switch, and the
// argument.
TEST(CommandLineTest, MaintainSingleArgument) {
// Putting a space in the file name will force escaping of the argument.
static const CommandLine::StringType kCommandLine =
FILE_PATH_LITERAL("program --switch --single-argument foo bar.html");
CommandLine cl = CommandLine::FromString(kCommandLine);
CommandLine cl_for_shell = CommandLine::FromString(cl.GetCommandLineString());
EXPECT_TRUE(cl_for_shell.HasSingleArgumentSwitch());
// Verify that we command line survives the round trip with an escaped arg.
EXPECT_EQ(kCommandLine, cl_for_shell.GetCommandLineString());
}
#endif // BUILDFLAG(IS_WIN)
// Tests that when AppendArguments is called that the program is set correctly
// on the target CommandLine object and the switches from the source
// CommandLine are added to the target.
TEST(CommandLineTest, AppendArguments) {
CommandLine cl1(FilePath(FILE_PATH_LITERAL("Program")));
cl1.AppendSwitch("switch1");
cl1.AppendSwitchASCII("switch2", "foo");
CommandLine cl2(CommandLine::NO_PROGRAM);
cl2.AppendArguments(cl1, true);
EXPECT_EQ(cl1.GetProgram().value(), cl2.GetProgram().value());
EXPECT_EQ(cl1.GetCommandLineString(), cl2.GetCommandLineString());
CommandLine c1(FilePath(FILE_PATH_LITERAL("Program1")));
c1.AppendSwitch("switch1");
CommandLine c2(FilePath(FILE_PATH_LITERAL("Program2")));
c2.AppendSwitch("switch2");
c1.AppendArguments(c2, true);
EXPECT_EQ(c1.GetProgram().value(), c2.GetProgram().value());
EXPECT_TRUE(c1.HasSwitch("switch1"));
EXPECT_TRUE(c1.HasSwitch("switch2"));
}
#if BUILDFLAG(IS_WIN)
// Make sure that the command line string program paths are quoted as necessary.
// This only makes sense on Windows and the test is basically here to guard
// against regressions.
TEST(CommandLineTest, ProgramQuotes) {
// Check that quotes are not added for paths without spaces.
const FilePath kProgram(L"Program");
CommandLine cl_program(kProgram);
EXPECT_EQ(kProgram.value(), cl_program.GetProgram().value());
EXPECT_EQ(kProgram.value(), cl_program.GetCommandLineString());
const FilePath kProgramPath(L"Program Path");
// Check that quotes are not returned from GetProgram().
CommandLine cl_program_path(kProgramPath);
EXPECT_EQ(kProgramPath.value(), cl_program_path.GetProgram().value());
// Check that quotes are added to command line string paths containing spaces.
CommandLine::StringType cmd_string(cl_program_path.GetCommandLineString());
EXPECT_EQ(L"\"Program Path\"", cmd_string);
}
#endif
// Calling Init multiple times should not modify the previous CommandLine.
TEST(CommandLineTest, Init) {
// Call Init without checking output once so we know it's been called
// whether or not the test runner does so.
CommandLine::Init(0, nullptr);
CommandLine* initial = CommandLine::ForCurrentProcess();
EXPECT_FALSE(CommandLine::Init(0, nullptr));
CommandLine* current = CommandLine::ForCurrentProcess();
EXPECT_EQ(initial, current);
}
// Test that copies of CommandLine have a valid std::string_view map.
TEST(CommandLineTest, Copy) {
auto initial = std::make_unique<CommandLine>(CommandLine::NO_PROGRAM);
initial->AppendSwitch("a");
initial->AppendSwitch("bbbbbbbbbbbbbbb");
initial->AppendSwitch("c");
CommandLine copy_constructed(*initial);
CommandLine assigned = *initial;
CommandLine::SwitchMap switch_map = initial->GetSwitches();
initial.reset();
for (const auto& pair : switch_map)
EXPECT_TRUE(copy_constructed.HasSwitch(pair.first));
for (const auto& pair : switch_map)
EXPECT_TRUE(assigned.HasSwitch(pair.first));
}
TEST(CommandLineTest, CopySwitches) {
CommandLine source(CommandLine::NO_PROGRAM);
source.AppendSwitch("a");
source.AppendSwitch("bbbb");
source.AppendSwitch("c");
EXPECT_THAT(source.argv(), testing::ElementsAre(FILE_PATH_LITERAL(""),
FILE_PATH_LITERAL("--a"),
FILE_PATH_LITERAL("--bbbb"),
FILE_PATH_LITERAL("--c")));
CommandLine cl(CommandLine::NO_PROGRAM);
EXPECT_THAT(cl.argv(), testing::ElementsAre(FILE_PATH_LITERAL("")));
cl.CopySwitchesFrom(source, {});
EXPECT_THAT(cl.argv(), testing::ElementsAre(FILE_PATH_LITERAL("")));
static const char* const kSwitchesToCopy[] = {"a", "nosuch", "c"};
cl.CopySwitchesFrom(source, kSwitchesToCopy);
EXPECT_THAT(cl.argv(), testing::ElementsAre(FILE_PATH_LITERAL(""),
FILE_PATH_LITERAL("--a"),
FILE_PATH_LITERAL("--c")));
}
TEST(CommandLineTest, Move) {
static constexpr std::string_view kSwitches[] = {
"a",
"bbbbbbbbb",
"c",
};
constexpr static const auto kArgs =
std::to_array<CommandLine::StringViewType>({
FILE_PATH_LITERAL("beebop"),
FILE_PATH_LITERAL("alouie"),
});
CommandLine initial(CommandLine::NO_PROGRAM);
for (auto a_switch : kSwitches) {
initial.AppendSwitch(a_switch);
}
for (auto an_arg : kArgs) {
initial.AppendArgNative(an_arg);
}
// Move construct and verify.
CommandLine move_constructed(std::move(initial));
initial = CommandLine(CommandLine::NO_PROGRAM);
for (auto a_switch : kSwitches) {
EXPECT_TRUE(move_constructed.HasSwitch(a_switch));
}
EXPECT_THAT(move_constructed.GetArgs(),
::testing::ElementsAre(kArgs[0], kArgs[1]));
// Move assign and verify
initial = std::move(move_constructed);
move_constructed = CommandLine(CommandLine::NO_PROGRAM);
for (auto a_switch : kSwitches) {
EXPECT_TRUE(initial.HasSwitch(a_switch));
}
EXPECT_THAT(initial.GetArgs(), ::testing::ElementsAre(kArgs[0], kArgs[1]));
}
TEST(CommandLineTest, PrependSimpleWrapper) {
CommandLine cl(FilePath(FILE_PATH_LITERAL("Program")));
cl.AppendSwitch("a");
cl.AppendSwitch("b");
cl.PrependWrapper(FILE_PATH_LITERAL("wrapper --foo --bar"));
EXPECT_EQ(6u, cl.argv().size());
EXPECT_EQ(FILE_PATH_LITERAL("wrapper"), cl.argv()[0]);
EXPECT_EQ(FILE_PATH_LITERAL("--foo"), cl.argv()[1]);
EXPECT_EQ(FILE_PATH_LITERAL("--bar"), cl.argv()[2]);
EXPECT_EQ(FILE_PATH_LITERAL("Program"), cl.argv()[3]);
EXPECT_EQ(FILE_PATH_LITERAL("--a"), cl.argv()[4]);
EXPECT_EQ(FILE_PATH_LITERAL("--b"), cl.argv()[5]);
}
TEST(CommandLineTest, PrependComplexWrapper) {
CommandLine cl(FilePath(FILE_PATH_LITERAL("Program")));
cl.AppendSwitch("a");
cl.AppendSwitch("b");
cl.PrependWrapper(
FILE_PATH_LITERAL("wrapper --foo='hello world' --bar=\"let's go\""));
EXPECT_EQ(6u, cl.argv().size());
EXPECT_EQ(FILE_PATH_LITERAL("wrapper"), cl.argv()[0]);
EXPECT_EQ(FILE_PATH_LITERAL("--foo='hello world'"), cl.argv()[1]);
EXPECT_EQ(FILE_PATH_LITERAL("--bar=\"let's go\""), cl.argv()[2]);
EXPECT_EQ(FILE_PATH_LITERAL("Program"), cl.argv()[3]);
EXPECT_EQ(FILE_PATH_LITERAL("--a"), cl.argv()[4]);
EXPECT_EQ(FILE_PATH_LITERAL("--b"), cl.argv()[5]);
}
TEST(CommandLineTest, RemoveSwitch) {
const std::string switch1 = "switch1";
const std::string switch2 = "switch2";
const std::string value2 = "value";
CommandLine cl(FilePath(FILE_PATH_LITERAL("Program")));
cl.AppendSwitch(switch1);
cl.AppendSwitchASCII(switch2, value2);
EXPECT_TRUE(cl.HasSwitch(switch1));
EXPECT_TRUE(cl.HasSwitch(switch2));
EXPECT_EQ(value2, cl.GetSwitchValueASCII(switch2));
EXPECT_THAT(cl.argv(),
testing::ElementsAre(FILE_PATH_LITERAL("Program"),
FILE_PATH_LITERAL("--switch1"),
FILE_PATH_LITERAL("--switch2=value")));
cl.RemoveSwitch(switch1);
EXPECT_FALSE(cl.HasSwitch(switch1));
EXPECT_TRUE(cl.HasSwitch(switch2));
EXPECT_EQ(value2, cl.GetSwitchValueASCII(switch2));
EXPECT_THAT(cl.argv(),
testing::ElementsAre(FILE_PATH_LITERAL("Program"),
FILE_PATH_LITERAL("--switch2=value")));
}
TEST(CommandLineTest, RemoveSwitchWithValue) {
const std::string switch1 = "switch1";
const std::string switch2 = "switch2";
const std::string value2 = "value";
CommandLine cl(FilePath(FILE_PATH_LITERAL("Program")));
cl.AppendSwitch(switch1);
cl.AppendSwitchASCII(switch2, value2);
EXPECT_TRUE(cl.HasSwitch(switch1));
EXPECT_TRUE(cl.HasSwitch(switch2));
EXPECT_EQ(value2, cl.GetSwitchValueASCII(switch2));
EXPECT_THAT(cl.argv(),
testing::ElementsAre(FILE_PATH_LITERAL("Program"),
FILE_PATH_LITERAL("--switch1"),
FILE_PATH_LITERAL("--switch2=value")));
cl.RemoveSwitch(switch2);
EXPECT_TRUE(cl.HasSwitch(switch1));
EXPECT_FALSE(cl.HasSwitch(switch2));
EXPECT_THAT(cl.argv(), testing::ElementsAre(FILE_PATH_LITERAL("Program"),
FILE_PATH_LITERAL("--switch1")));
}
TEST(CommandLineTest, RemoveSwitchDropsMultipleSameSwitches) {
const std::string switch1 = "switch1";
const std::string value2 = "value2";
CommandLine cl(FilePath(FILE_PATH_LITERAL("Program")));
cl.AppendSwitch(switch1);
cl.AppendSwitchASCII(switch1, value2);
EXPECT_TRUE(cl.HasSwitch(switch1));
EXPECT_EQ(value2, cl.GetSwitchValueASCII(switch1));
EXPECT_THAT(cl.argv(),
testing::ElementsAre(FILE_PATH_LITERAL("Program"),
FILE_PATH_LITERAL("--switch1"),
FILE_PATH_LITERAL("--switch1=value2")));
cl.RemoveSwitch(switch1);
EXPECT_FALSE(cl.HasSwitch(switch1));
EXPECT_THAT(cl.argv(), testing::ElementsAre(FILE_PATH_LITERAL("Program")));
}
TEST(CommandLineTest, AppendAndRemoveSwitchWithDefaultPrefix) {
CommandLine cl(FilePath(FILE_PATH_LITERAL("Program")));
cl.AppendSwitch("foo");
EXPECT_THAT(cl.argv(), testing::ElementsAre(FILE_PATH_LITERAL("Program"),
FILE_PATH_LITERAL("--foo")));
EXPECT_EQ(0u, cl.GetArgs().size());
cl.RemoveSwitch("foo");
EXPECT_THAT(cl.argv(), testing::ElementsAre(FILE_PATH_LITERAL("Program")));
EXPECT_EQ(0u, cl.GetArgs().size());
}
TEST(CommandLineTest, AppendAndRemoveSwitchWithAlternativePrefix) {
CommandLine cl(FilePath(FILE_PATH_LITERAL("Program")));
cl.AppendSwitch("-foo");
EXPECT_THAT(cl.argv(), testing::ElementsAre(FILE_PATH_LITERAL("Program"),
FILE_PATH_LITERAL("-foo")));
EXPECT_EQ(0u, cl.GetArgs().size());
cl.RemoveSwitch("foo");
EXPECT_THAT(cl.argv(), testing::ElementsAre(FILE_PATH_LITERAL("Program")));
EXPECT_EQ(0u, cl.GetArgs().size());
}
TEST(CommandLineTest, AppendAndRemoveSwitchPreservesOtherSwitchesAndArgs) {
CommandLine cl(FilePath(FILE_PATH_LITERAL("Program")));
cl.AppendSwitch("foo");
cl.AppendSwitch("bar");
cl.AppendArg("arg");
EXPECT_THAT(cl.argv(), testing::ElementsAre(FILE_PATH_LITERAL("Program"),
FILE_PATH_LITERAL("--foo"),
FILE_PATH_LITERAL("--bar"),
FILE_PATH_LITERAL("arg")));
EXPECT_THAT(cl.GetArgs(), testing::ElementsAre(FILE_PATH_LITERAL("arg")));
cl.RemoveSwitch("foo");
EXPECT_THAT(cl.argv(), testing::ElementsAre(FILE_PATH_LITERAL("Program"),
FILE_PATH_LITERAL("--bar"),
FILE_PATH_LITERAL("arg")));
EXPECT_THAT(cl.GetArgs(), testing::ElementsAre(FILE_PATH_LITERAL("arg")));
}
TEST(CommandLineTest, MultipleSameSwitch) {
const CommandLine::CharType* argv[] = {
FILE_PATH_LITERAL("program"),
FILE_PATH_LITERAL("--foo=one"), // --foo first time
FILE_PATH_LITERAL("-baz"),
FILE_PATH_LITERAL("--foo=two") // --foo second time
};
CommandLine cl(std::size(argv), argv);
EXPECT_TRUE(cl.HasSwitch("foo"));
EXPECT_TRUE(cl.HasSwitch("baz"));
EXPECT_EQ("two", cl.GetSwitchValueASCII("foo"));
}
// Helper class for the next test case
class MergeDuplicateFoosSemicolon : public DuplicateSwitchHandler {
public:
~MergeDuplicateFoosSemicolon() override;
void ResolveDuplicate(std::string_view key,
CommandLine::StringViewType new_value,
CommandLine::StringType& out_value) override;
};
MergeDuplicateFoosSemicolon::~MergeDuplicateFoosSemicolon() = default;
void MergeDuplicateFoosSemicolon::ResolveDuplicate(
std::string_view key,
CommandLine::StringViewType new_value,
CommandLine::StringType& out_value) {
if (key != "mergeable-foo") {
out_value = CommandLine::StringType(new_value);
return;
}
if (!out_value.empty()) {
#if BUILDFLAG(IS_WIN)
StrAppend(&out_value, {L";"});
#else
StrAppend(&out_value, {";"});
#endif
}
StrAppend(&out_value, {new_value});
}
// This flag is an exception to the rule that the second duplicate flag wins
// Not thread safe
TEST(CommandLineTest, MultipleFilterFileSwitch) {
const CommandLine::CharType* const argv[] = {
FILE_PATH_LITERAL("program"),
FILE_PATH_LITERAL("--mergeable-foo=one"), // --first time
FILE_PATH_LITERAL("-baz"),
FILE_PATH_LITERAL("--mergeable-foo=two") // --second time
};
CommandLine::SetDuplicateSwitchHandler(
std::make_unique<MergeDuplicateFoosSemicolon>());
CommandLine cl(std::size(argv), argv);
EXPECT_TRUE(cl.HasSwitch("mergeable-foo"));
EXPECT_TRUE(cl.HasSwitch("baz"));
EXPECT_EQ("one;two", cl.GetSwitchValueASCII("mergeable-foo"));
CommandLine::SetDuplicateSwitchHandler(nullptr);
}
#if BUILDFLAG(IS_WIN)
TEST(CommandLineTest, ParseAsSingleArgument) {
CommandLine cl = CommandLine::FromString(
FILE_PATH_LITERAL("program --switch_before arg_before "
"--single-argument arg with spaces \"and quotes\" \""));
EXPECT_FALSE(cl.GetCommandLineString().empty());
EXPECT_EQ(FilePath(FILE_PATH_LITERAL("program")), cl.GetProgram());
EXPECT_TRUE(cl.HasSwitch("switch_before"));
EXPECT_EQ(cl.GetArgs(), CommandLine::StringVector({FILE_PATH_LITERAL(
"arg with spaces \"and quotes\" \"")}));
CommandLine cl_without_arg =
CommandLine::FromString(FILE_PATH_LITERAL("program --single-argument "));
EXPECT_FALSE(cl_without_arg.GetCommandLineString().empty());
EXPECT_EQ(FilePath(FILE_PATH_LITERAL("program")),
cl_without_arg.GetProgram());
EXPECT_TRUE(cl_without_arg.GetArgs().empty());
}
#endif // BUILDFLAG(IS_WIN)
#if BUILDFLAG(ENABLE_COMMANDLINE_SEQUENCE_CHECKS)
TEST(CommandLineDeathTest, ThreadChecks) {
test::TaskEnvironment task_environment;
RunLoop run_loop;
EXPECT_DEATH_IF_SUPPORTED(
{
ThreadPool::PostTask(FROM_HERE, BindLambdaForTesting([&run_loop] {
auto* command_line =
CommandLine::ForCurrentProcess();
command_line->AppendSwitch("test");
run_loop.Quit();
}));
run_loop.Run();
},
"");
}
#endif // BUILDFLAG(ENABLE_COMMANDLINE_SEQUENCE_CHECKS)
} // namespace base