1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
base / synchronization / waitable_event_watcher_unittest.cc [blame]
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/synchronization/waitable_event_watcher.h"
#include "base/functional/bind.h"
#include "base/functional/callback.h"
#include "base/memory/ptr_util.h"
#include "base/memory/raw_ptr.h"
#include "base/run_loop.h"
#include "base/synchronization/waitable_event.h"
#include "base/task/sequenced_task_runner.h"
#include "base/task/single_thread_task_runner.h"
#include "base/test/bind.h"
#include "base/test/task_environment.h"
#include "base/threading/platform_thread.h"
#include "build/build_config.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace base {
namespace {
// The main thread types on which each waitable event should be tested.
const test::TaskEnvironment::MainThreadType testing_main_threads[] = {
test::TaskEnvironment::MainThreadType::DEFAULT,
test::TaskEnvironment::MainThreadType::IO,
#if !BUILDFLAG(IS_IOS) // iOS does not allow direct running of the UI loop.
test::TaskEnvironment::MainThreadType::UI,
#endif
};
void QuitWhenSignaled(base::OnceClosure quit_closure, WaitableEvent* event) {
std::move(quit_closure).Run();
}
class DecrementCountContainer {
public:
explicit DecrementCountContainer(int* counter) : counter_(counter) {}
void OnWaitableEventSignaled(WaitableEvent* object) {
// NOTE: |object| may be already deleted.
--(*counter_);
}
private:
raw_ptr<int> counter_;
};
} // namespace
class WaitableEventWatcherTest
: public testing::TestWithParam<test::TaskEnvironment::MainThreadType> {};
TEST_P(WaitableEventWatcherTest, BasicSignalManual) {
test::TaskEnvironment task_environment(GetParam());
base::RunLoop loop;
// A manual-reset event that is not yet signaled.
WaitableEvent event(WaitableEvent::ResetPolicy::MANUAL,
WaitableEvent::InitialState::NOT_SIGNALED);
WaitableEventWatcher watcher;
watcher.StartWatching(&event,
BindOnce(&QuitWhenSignaled, loop.QuitWhenIdleClosure()),
SequencedTaskRunner::GetCurrentDefault());
event.Signal();
loop.Run();
EXPECT_TRUE(event.IsSignaled());
}
TEST_P(WaitableEventWatcherTest, BasicSignalAutomatic) {
test::TaskEnvironment task_environment(GetParam());
WaitableEvent event(WaitableEvent::ResetPolicy::AUTOMATIC,
WaitableEvent::InitialState::NOT_SIGNALED);
WaitableEventWatcher watcher;
base::RunLoop loop;
watcher.StartWatching(&event,
BindOnce(&QuitWhenSignaled, loop.QuitWhenIdleClosure()),
SequencedTaskRunner::GetCurrentDefault());
event.Signal();
loop.Run();
// The WaitableEventWatcher consumes the event signal.
EXPECT_FALSE(event.IsSignaled());
}
TEST_P(WaitableEventWatcherTest, BasicCancel) {
test::TaskEnvironment task_environment(GetParam());
// A manual-reset event that is not yet signaled.
WaitableEvent event(WaitableEvent::ResetPolicy::MANUAL,
WaitableEvent::InitialState::NOT_SIGNALED);
WaitableEventWatcher watcher;
watcher.StartWatching(&event, DoNothing(),
SequencedTaskRunner::GetCurrentDefault());
watcher.StopWatching();
}
TEST_P(WaitableEventWatcherTest, CancelAfterSet) {
test::TaskEnvironment task_environment(GetParam());
// A manual-reset event that is not yet signaled.
WaitableEvent event(WaitableEvent::ResetPolicy::MANUAL,
WaitableEvent::InitialState::NOT_SIGNALED);
WaitableEventWatcher watcher;
int counter = 1;
DecrementCountContainer delegate(&counter);
WaitableEventWatcher::EventCallback callback = BindOnce(
&DecrementCountContainer::OnWaitableEventSignaled, Unretained(&delegate));
watcher.StartWatching(&event, std::move(callback),
SequencedTaskRunner::GetCurrentDefault());
event.Signal();
// Let the background thread do its business
PlatformThread::Sleep(Milliseconds(30));
watcher.StopWatching();
RunLoop().RunUntilIdle();
// Our delegate should not have fired.
EXPECT_EQ(1, counter);
}
TEST_P(WaitableEventWatcherTest, OutlivesTaskEnvironment) {
// Simulate a task environment that dies before an WaitableEventWatcher. This
// ordinarily doesn't happen when people use the Thread class, but it can
// happen when people use the Singleton pattern or atexit.
WaitableEvent event(WaitableEvent::ResetPolicy::MANUAL,
WaitableEvent::InitialState::NOT_SIGNALED);
{
std::unique_ptr<WaitableEventWatcher> watcher;
{
test::TaskEnvironment task_environment(GetParam());
watcher = std::make_unique<WaitableEventWatcher>();
watcher->StartWatching(&event, DoNothing(),
SequencedTaskRunner::GetCurrentDefault());
}
}
}
TEST_P(WaitableEventWatcherTest, SignaledAtStartManual) {
test::TaskEnvironment task_environment(GetParam());
base::RunLoop loop;
WaitableEvent event(WaitableEvent::ResetPolicy::MANUAL,
WaitableEvent::InitialState::SIGNALED);
WaitableEventWatcher watcher;
watcher.StartWatching(&event,
BindOnce(&QuitWhenSignaled, loop.QuitWhenIdleClosure()),
SequencedTaskRunner::GetCurrentDefault());
loop.Run();
EXPECT_TRUE(event.IsSignaled());
}
TEST_P(WaitableEventWatcherTest, SignaledAtStartAutomatic) {
test::TaskEnvironment task_environment(GetParam());
base::RunLoop loop;
WaitableEvent event(WaitableEvent::ResetPolicy::AUTOMATIC,
WaitableEvent::InitialState::SIGNALED);
WaitableEventWatcher watcher;
watcher.StartWatching(&event,
BindOnce(&QuitWhenSignaled, loop.QuitWhenIdleClosure()),
SequencedTaskRunner::GetCurrentDefault());
loop.Run();
// The watcher consumes the event signal.
EXPECT_FALSE(event.IsSignaled());
}
TEST_P(WaitableEventWatcherTest, StartWatchingInCallback) {
test::TaskEnvironment task_environment(GetParam());
WaitableEvent event(WaitableEvent::ResetPolicy::MANUAL,
WaitableEvent::InitialState::NOT_SIGNALED);
WaitableEventWatcher watcher;
base::RunLoop loop;
watcher.StartWatching(&event, BindLambdaForTesting([&](WaitableEvent* event) {
// |event| is manual, so the second watcher will run
// immediately.
watcher.StartWatching(
event, BindOnce(&QuitWhenSignaled, loop.QuitWhenIdleClosure()),
SequencedTaskRunner::GetCurrentDefault());
}),
SequencedTaskRunner::GetCurrentDefault());
event.Signal();
loop.Run();
}
TEST_P(WaitableEventWatcherTest, MultipleWatchersManual) {
test::TaskEnvironment task_environment(GetParam());
WaitableEvent event(WaitableEvent::ResetPolicy::MANUAL,
WaitableEvent::InitialState::NOT_SIGNALED);
int watcher1_counter = 0;
int watcher2_counter = 0;
int total_counter = 0;
RunLoop run_loop;
auto callback = [&run_loop, &total_counter](int* watcher_counter,
WaitableEvent*) {
++(*watcher_counter);
if (++total_counter == 2) {
run_loop.Quit();
}
};
WaitableEventWatcher watcher1;
watcher1.StartWatching(
&event,
BindOnce(BindLambdaForTesting(callback), Unretained(&watcher1_counter)),
SequencedTaskRunner::GetCurrentDefault());
WaitableEventWatcher watcher2;
watcher2.StartWatching(
&event,
BindOnce(BindLambdaForTesting(callback), Unretained(&watcher2_counter)),
SequencedTaskRunner::GetCurrentDefault());
event.Signal();
run_loop.Run();
EXPECT_EQ(1, watcher1_counter);
EXPECT_EQ(1, watcher2_counter);
EXPECT_EQ(2, total_counter);
EXPECT_TRUE(event.IsSignaled());
}
// Tests that only one async waiter gets called back for an auto-reset event.
TEST_P(WaitableEventWatcherTest, MultipleWatchersAutomatic) {
test::TaskEnvironment task_environment(GetParam());
WaitableEvent event(WaitableEvent::ResetPolicy::AUTOMATIC,
WaitableEvent::InitialState::NOT_SIGNALED);
int counter1 = 0;
int counter2 = 0;
auto callback = [](RunLoop** run_loop, int* counter, WaitableEvent* event) {
++(*counter);
(*run_loop)->QuitWhenIdle();
};
// The same RunLoop instance cannot be Run more than once, and it is
// undefined which watcher will get called back first. Have the callback
// dereference this pointer to quit the loop, which will be updated on each
// Run.
RunLoop* current_run_loop;
WaitableEventWatcher watcher1;
watcher1.StartWatching(
&event,
BindOnce(callback, Unretained(¤t_run_loop), Unretained(&counter1)),
SequencedTaskRunner::GetCurrentDefault());
WaitableEventWatcher watcher2;
watcher2.StartWatching(
&event,
BindOnce(callback, Unretained(¤t_run_loop), Unretained(&counter2)),
SequencedTaskRunner::GetCurrentDefault());
event.Signal();
{
RunLoop run_loop;
current_run_loop = &run_loop;
run_loop.Run();
}
// Only one of the waiters should have been signaled.
EXPECT_TRUE((counter1 == 1) ^ (counter2 == 1));
EXPECT_FALSE(event.IsSignaled());
event.Signal();
{
RunLoop run_loop;
current_run_loop = &run_loop;
run_loop.Run();
}
EXPECT_FALSE(event.IsSignaled());
// The other watcher should have been signaled.
EXPECT_EQ(1, counter1);
EXPECT_EQ(1, counter2);
}
// To help detect errors around deleting WaitableEventWatcher, an additional
// bool parameter is used to test sleeping between watching and deletion.
class WaitableEventWatcherDeletionTest
: public testing::TestWithParam<
std::tuple<test::TaskEnvironment::MainThreadType, bool>> {};
TEST_P(WaitableEventWatcherDeletionTest, DeleteUnder) {
auto [main_thread_type, delay_after_delete] = GetParam();
// Delete the WaitableEvent out from under the Watcher. This is explictly
// allowed by the interface.
test::TaskEnvironment task_environment(main_thread_type);
{
WaitableEventWatcher watcher;
auto* event = new WaitableEvent(WaitableEvent::ResetPolicy::AUTOMATIC,
WaitableEvent::InitialState::NOT_SIGNALED);
watcher.StartWatching(event, DoNothing(),
SequencedTaskRunner::GetCurrentDefault());
if (delay_after_delete) {
// On Windows that sleep() improves the chance to catch some problems.
// It postpones the dtor |watcher| (which immediately cancel the waiting)
// and gives some time to run to a created background thread.
// Unfortunately, that thread is under OS control and we can't
// manipulate it directly.
PlatformThread::Sleep(Milliseconds(30));
}
delete event;
}
}
TEST_P(WaitableEventWatcherDeletionTest, SignalAndDelete) {
auto [main_thread_type, delay_after_delete] = GetParam();
// Signal and immediately delete the WaitableEvent out from under the Watcher.
test::TaskEnvironment task_environment(main_thread_type);
{
base::RunLoop loop;
WaitableEventWatcher watcher;
auto event = std::make_unique<WaitableEvent>(
WaitableEvent::ResetPolicy::AUTOMATIC,
WaitableEvent::InitialState::NOT_SIGNALED);
watcher.StartWatching(
event.get(), BindOnce(&QuitWhenSignaled, loop.QuitWhenIdleClosure()),
SequencedTaskRunner::GetCurrentDefault());
event->Signal();
event.reset();
if (delay_after_delete) {
// On Windows that sleep() improves the chance to catch some problems.
// It postpones the dtor |watcher| (which immediately cancel the waiting)
// and gives some time to run to a created background thread.
// Unfortunately, that thread is under OS control and we can't
// manipulate it directly.
PlatformThread::Sleep(Milliseconds(30));
}
// Wait for the watcher callback.
loop.Run();
}
}
// Tests deleting the WaitableEventWatcher between signaling the event and
// when the callback should be run.
TEST_P(WaitableEventWatcherDeletionTest, DeleteWatcherBeforeCallback) {
auto [main_thread_type, delay_after_delete] = GetParam();
test::TaskEnvironment task_environment(main_thread_type);
scoped_refptr<SingleThreadTaskRunner> task_runner =
SingleThreadTaskRunner::GetCurrentDefault();
// Flag used to esnure that the |watcher_callback| never runs.
bool did_callback = false;
WaitableEvent event(WaitableEvent::ResetPolicy::AUTOMATIC,
WaitableEvent::InitialState::NOT_SIGNALED);
auto watcher = std::make_unique<WaitableEventWatcher>();
// Queue up a series of tasks:
// 1. StartWatching the WaitableEvent
// 2. Signal the event (which will result in another task getting posted to
// the |task_runner|)
// 3. Delete the WaitableEventWatcher
// 4. WaitableEventWatcher callback should run (from #2)
WaitableEventWatcher::EventCallback watcher_callback = BindOnce(
[](bool* did_callback, WaitableEvent*) {
*did_callback = true;
},
Unretained(&did_callback));
task_runner->PostTask(
FROM_HERE, BindOnce(IgnoreResult(&WaitableEventWatcher::StartWatching),
Unretained(watcher.get()), Unretained(&event),
std::move(watcher_callback), task_runner));
task_runner->PostTask(FROM_HERE,
BindOnce(&WaitableEvent::Signal, Unretained(&event)));
task_runner->DeleteSoon(FROM_HERE, std::move(watcher));
if (delay_after_delete) {
task_runner->PostTask(FROM_HERE,
BindOnce(&PlatformThread::Sleep, Milliseconds(30)));
}
RunLoop().RunUntilIdle();
EXPECT_FALSE(did_callback);
}
INSTANTIATE_TEST_SUITE_P(All,
WaitableEventWatcherTest,
testing::ValuesIn(testing_main_threads));
INSTANTIATE_TEST_SUITE_P(
All,
WaitableEventWatcherDeletionTest,
testing::Combine(testing::ValuesIn(testing_main_threads), testing::Bool()));
} // namespace base