1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
base / task / common / operations_controller_unittest.cc [blame]
// Copyright 2018 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/task/common/operations_controller.h"
#include <atomic>
#include <cstdint>
#include <utility>
#include "base/memory/raw_ref.h"
#include "base/ranges/algorithm.h"
#include "base/threading/platform_thread.h"
#include "base/threading/simple_thread.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace base {
namespace internal {
namespace {
class ScopedShutdown {
public:
ScopedShutdown(OperationsController* controller) : controller_(*controller) {}
~ScopedShutdown() { controller_->ShutdownAndWaitForZeroOperations(); }
private:
const raw_ref<OperationsController> controller_;
};
TEST(OperationsControllerTest, CanBeDestroyedWithoutWaiting) {
OperationsController controller;
}
TEST(OperationsControllerTest, CanShutdownIfNotStarted) {
OperationsController controller;
controller.ShutdownAndWaitForZeroOperations();
}
TEST(OperationsControllerTest, FailsToBeginWhenNotStarted) {
OperationsController controller;
auto operation_token = controller.TryBeginOperation();
EXPECT_FALSE(operation_token);
}
TEST(OperationsControllerTest, CanShutdownAfterTryCallsIfNotStarted) {
OperationsController controller;
auto operation_token = controller.TryBeginOperation();
ASSERT_FALSE(operation_token);
controller.ShutdownAndWaitForZeroOperations();
}
TEST(OperationsControllerTest,
StartAcceptingOperationsReturnsFalseIfNoRejectedBeginAttempts) {
OperationsController controller;
ScopedShutdown cleanup(&controller);
EXPECT_FALSE(controller.StartAcceptingOperations());
}
TEST(OperationsControllerTest,
StartAcceptingOperationsReturnsTrueIfFailedBeginAttempts) {
OperationsController controller;
ScopedShutdown cleanup(&controller);
auto operation_token = controller.TryBeginOperation();
ASSERT_FALSE(operation_token);
EXPECT_TRUE(controller.StartAcceptingOperations());
}
TEST(OperationsControllerTest, SuccesfulBeginReturnsValidScopedObject) {
OperationsController controller;
ScopedShutdown cleanup(&controller);
controller.StartAcceptingOperations();
auto operation_token = controller.TryBeginOperation();
EXPECT_TRUE(operation_token);
}
TEST(OperationsControllerTest, BeginFailsAfterShutdown) {
OperationsController controller;
controller.StartAcceptingOperations();
controller.ShutdownAndWaitForZeroOperations();
auto operation_token = controller.TryBeginOperation();
EXPECT_FALSE(operation_token);
}
TEST(OperationsControllerTest, ScopedOperationsControllerIsMoveConstructible) {
OperationsController controller;
ScopedShutdown cleanup(&controller);
controller.StartAcceptingOperations();
auto operation_token_1 = controller.TryBeginOperation();
auto operation_token_2 = std::move(operation_token_1);
EXPECT_FALSE(operation_token_1);
EXPECT_TRUE(operation_token_2);
}
// Dummy SimpleThread implementation that periodically begins and ends
// operations until one of them fails.
class TestThread : public SimpleThread {
public:
explicit TestThread(OperationsController* ref_controller,
std::atomic<bool>* started,
std::atomic<int32_t>* thread_counter)
: SimpleThread("TestThread"),
controller_(*ref_controller),
started_(*started),
thread_counter_(*thread_counter) {}
void Run() override {
thread_counter_->fetch_add(1, std::memory_order_relaxed);
while (true) {
PlatformThread::YieldCurrentThread();
bool was_started = started_->load(std::memory_order_relaxed);
std::vector<OperationsController::OperationToken> tokens;
for (int i = 0; i < 100; ++i) {
tokens.push_back(controller_->TryBeginOperation());
}
if (!was_started)
continue;
if (ranges::any_of(tokens, [](const auto& token) { return !token; })) {
break;
}
}
}
private:
const raw_ref<OperationsController> controller_;
const raw_ref<std::atomic<bool>> started_;
const raw_ref<std::atomic<int32_t>> thread_counter_;
};
TEST(OperationsControllerTest, BeginsFromMultipleThreads) {
constexpr int32_t kNumThreads = 10;
for (int32_t i = 0; i < 10; ++i) {
OperationsController ref_controller;
std::atomic<bool> started(false);
std::atomic<int32_t> running_threads(0);
std::vector<std::unique_ptr<TestThread>> threads;
for (int j = 0; j < kNumThreads; ++j) {
threads.push_back(std::make_unique<TestThread>(&ref_controller, &started,
&running_threads));
threads.back()->Start();
}
// Make sure all threads are running.
while (running_threads.load(std::memory_order_relaxed) != kNumThreads) {
PlatformThread::YieldCurrentThread();
}
// Wait a bit before starting to try to introduce races.
constexpr TimeDelta kRaceInducingTimeout = Microseconds(50);
PlatformThread::Sleep(kRaceInducingTimeout);
ref_controller.StartAcceptingOperations();
// Signal threads to terminate on TryBeginOperation() failures
started.store(true, std::memory_order_relaxed);
// Let the test run for a while before shuting down.
PlatformThread::Sleep(Milliseconds(5));
ref_controller.ShutdownAndWaitForZeroOperations();
for (const auto& t : threads) {
t->Join();
}
}
}
} // namespace
} // namespace internal
} // namespace base