1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
base / task / thread_pool / thread_pool_impl_unittest.cc [blame]
// Copyright 2016 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifdef UNSAFE_BUFFERS_BUILD
// TODO(crbug.com/40284755): Remove this and spanify to fix the errors.
#pragma allow_unsafe_buffers
#endif
#include "base/task/thread_pool/thread_pool_impl.h"
#include <stddef.h>
#include <memory>
#include <string>
#include <tuple>
#include <utility>
#include <vector>
#include "base/base_switches.h"
#include "base/cfi_buildflags.h"
#include "base/containers/span.h"
#include "base/debug/stack_trace.h"
#include "base/functional/bind.h"
#include "base/functional/callback.h"
#include "base/functional/callback_helpers.h"
#include "base/memory/raw_ptr.h"
#include "base/message_loop/message_pump_type.h"
#include "base/metrics/field_trial.h"
#include "base/metrics/field_trial_params.h"
#include "base/system/sys_info.h"
#include "base/task/task_features.h"
#include "base/task/task_traits.h"
#include "base/task/thread_pool/environment_config.h"
#include "base/task/thread_pool/test_task_factory.h"
#include "base/task/thread_pool/test_utils.h"
#include "base/task/thread_pool/worker_thread_observer.h"
#include "base/task/updateable_sequenced_task_runner.h"
#include "base/test/bind.h"
#include "base/test/gtest_util.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/test_timeouts.h"
#include "base/test/test_waitable_event.h"
#include "base/threading/platform_thread.h"
#include "base/threading/sequence_local_storage_slot.h"
#include "base/threading/simple_thread.h"
#include "base/threading/thread.h"
#include "base/threading/thread_restrictions.h"
#include "base/time/time.h"
#include "build/build_config.h"
#include "testing/gtest/include/gtest/gtest.h"
#if BUILDFLAG(IS_POSIX)
#include <unistd.h>
#include "base/debug/leak_annotations.h"
#include "base/files/file_descriptor_watcher_posix.h"
#include "base/files/file_util.h"
#include "base/posix/eintr_wrapper.h"
#endif // BUILDFLAG(IS_POSIX)
#if BUILDFLAG(IS_WIN)
#include "base/win/com_init_util.h"
#endif // BUILDFLAG(IS_WIN)
namespace base {
namespace internal {
namespace {
constexpr size_t kMaxNumForegroundThreads = 4;
constexpr size_t kMaxNumUtilityThreads = 2;
struct TraitsExecutionModePair {
TraitsExecutionModePair(const TaskTraits& traits,
TaskSourceExecutionMode execution_mode)
: traits(traits), execution_mode(execution_mode) {}
TaskTraits traits;
TaskSourceExecutionMode execution_mode;
};
// Returns true if a task with |traits| could run at background thread priority
// on this platform. Even if this returns true, it is possible that the task
// won't run at background thread priority if a native thread group is used.
bool TraitsSupportBackgroundThreadType(const TaskTraits& traits) {
return traits.priority() == TaskPriority::BEST_EFFORT &&
traits.thread_policy() == ThreadPolicy::PREFER_BACKGROUND &&
CanUseBackgroundThreadTypeForWorkerThread();
}
// Returns true if a task with |traits| could run at utility thread
// type on this platform. Even if this returns true, it is possible that the
// task won't run at efficient thread priority if a native thread group is used
// or the utility thread group is disabled.
bool TraitsSupportUtilityThreadType(const TaskTraits& traits) {
return traits.priority() <= TaskPriority::USER_VISIBLE &&
traits.thread_policy() == ThreadPolicy::PREFER_BACKGROUND &&
CanUseUtilityThreadTypeForWorkerThread();
}
// Verify that the current thread type and I/O restrictions are appropriate to
// run a Task with |traits|.
// Note: ExecutionMode is verified inside TestTaskFactory.
void VerifyTaskEnvironment(const TaskTraits& traits,
bool use_resource_efficient_group) {
const std::string thread_name(PlatformThread::GetName());
const bool is_single_threaded =
(thread_name.find("SingleThread") != std::string::npos);
const bool expect_background_thread_type =
TraitsSupportBackgroundThreadType(traits);
const bool expect_utility_thread_type =
!TraitsSupportBackgroundThreadType(traits) &&
TraitsSupportUtilityThreadType(traits) && use_resource_efficient_group;
EXPECT_EQ(expect_background_thread_type ? ThreadType::kBackground
: expect_utility_thread_type ? ThreadType::kUtility
: ThreadType::kDefault,
PlatformThread::GetCurrentThreadType());
if (traits.may_block())
AssertBlockingAllowed();
else
AssertBlockingDisallowedForTesting();
// Verify that the thread the task is running on is named as expected.
EXPECT_THAT(thread_name, ::testing::HasSubstr("ThreadPool"));
EXPECT_THAT(thread_name, ::testing::HasSubstr(
expect_background_thread_type ? "Background"
: expect_utility_thread_type ? "Utility"
: "Foreground"));
if (is_single_threaded) {
// SingleThread workers discriminate blocking/non-blocking tasks.
if (traits.may_block()) {
EXPECT_THAT(thread_name, ::testing::HasSubstr("Blocking"));
} else {
EXPECT_THAT(thread_name,
::testing::Not(::testing::HasSubstr("Blocking")));
}
} else {
EXPECT_THAT(thread_name, ::testing::Not(::testing::HasSubstr("Blocking")));
}
}
void VerifyTaskEnvironmentAndSignalEvent(const TaskTraits& traits,
bool use_resource_efficient_group,
TestWaitableEvent* event) {
DCHECK(event);
VerifyTaskEnvironment(traits, use_resource_efficient_group);
event->Signal();
}
void VerifyTimeAndTaskEnvironmentAndSignalEvent(
const TaskTraits& traits,
bool use_resource_efficient_group,
TimeTicks expected_time,
TestWaitableEvent* event) {
DCHECK(event);
EXPECT_LE(expected_time, TimeTicks::Now());
VerifyTaskEnvironment(traits, use_resource_efficient_group);
event->Signal();
}
void VerifyOrderAndTaskEnvironmentAndSignalEvent(
const TaskTraits& traits,
bool use_resource_efficient_group,
TestWaitableEvent* expected_previous_event,
TestWaitableEvent* event) {
DCHECK(event);
if (expected_previous_event)
EXPECT_TRUE(expected_previous_event->IsSignaled());
VerifyTaskEnvironment(traits, use_resource_efficient_group);
event->Signal();
}
scoped_refptr<TaskRunner> CreateTaskRunnerAndExecutionMode(
ThreadPoolImpl* thread_pool,
const TaskTraits& traits,
TaskSourceExecutionMode execution_mode,
SingleThreadTaskRunnerThreadMode default_single_thread_task_runner_mode =
SingleThreadTaskRunnerThreadMode::SHARED) {
switch (execution_mode) {
case TaskSourceExecutionMode::kParallel:
return thread_pool->CreateTaskRunner(traits);
case TaskSourceExecutionMode::kSequenced:
return thread_pool->CreateSequencedTaskRunner(traits);
case TaskSourceExecutionMode::kSingleThread: {
return thread_pool->CreateSingleThreadTaskRunner(
traits, default_single_thread_task_runner_mode);
}
case TaskSourceExecutionMode::kJob:
break;
}
ADD_FAILURE() << "Unknown ExecutionMode";
return nullptr;
}
class ThreadPostingTasks : public SimpleThread {
public:
// Creates a thread that posts Tasks to |thread_pool| with |traits| and
// |execution_mode|.
ThreadPostingTasks(ThreadPoolImpl* thread_pool,
const TaskTraits& traits,
bool use_resource_efficient_group,
TaskSourceExecutionMode execution_mode)
: SimpleThread("ThreadPostingTasks"),
traits_(traits),
use_resource_efficient_group_(use_resource_efficient_group),
factory_(CreateTaskRunnerAndExecutionMode(thread_pool,
traits,
execution_mode),
execution_mode) {}
ThreadPostingTasks(const ThreadPostingTasks&) = delete;
ThreadPostingTasks& operator=(const ThreadPostingTasks&) = delete;
void WaitForAllTasksToRun() { factory_.WaitForAllTasksToRun(); }
private:
void Run() override {
const size_t kNumTasksPerThread = 150;
for (size_t i = 0; i < kNumTasksPerThread; ++i) {
factory_.PostTask(test::TestTaskFactory::PostNestedTask::NO,
BindOnce(&VerifyTaskEnvironment, traits_,
use_resource_efficient_group_));
}
}
const TaskTraits traits_;
bool use_resource_efficient_group_;
test::TestTaskFactory factory_;
};
// Returns a vector with a TraitsExecutionModePair for each valid combination of
// {ExecutionMode, TaskPriority, ThreadPolicy, MayBlock()}.
std::vector<TraitsExecutionModePair> GetTraitsExecutionModePairs() {
std::vector<TraitsExecutionModePair> params;
constexpr TaskSourceExecutionMode execution_modes[] = {
TaskSourceExecutionMode::kParallel, TaskSourceExecutionMode::kSequenced,
TaskSourceExecutionMode::kSingleThread};
constexpr ThreadPolicy thread_policies[] = {
ThreadPolicy::PREFER_BACKGROUND, ThreadPolicy::MUST_USE_FOREGROUND};
for (TaskSourceExecutionMode execution_mode : execution_modes) {
for (ThreadPolicy thread_policy : thread_policies) {
for (size_t priority_index = static_cast<size_t>(TaskPriority::LOWEST);
priority_index <= static_cast<size_t>(TaskPriority::HIGHEST);
++priority_index) {
const TaskPriority priority = static_cast<TaskPriority>(priority_index);
params.push_back(
TraitsExecutionModePair({priority, thread_policy}, execution_mode));
params.push_back(TraitsExecutionModePair(
{priority, thread_policy, MayBlock()}, execution_mode));
}
}
}
return params;
}
// Returns a vector with enough TraitsExecutionModePairs to cover all valid
// combinations of task destination (background/foreground ThreadGroup,
// single-thread) and whether the task is affected by a BEST_EFFORT fence.
std::vector<TraitsExecutionModePair>
GetTraitsExecutionModePairsToCoverAllSchedulingOptions() {
return {TraitsExecutionModePair({TaskPriority::BEST_EFFORT},
TaskSourceExecutionMode::kSequenced),
TraitsExecutionModePair({TaskPriority::USER_VISIBLE},
TaskSourceExecutionMode::kSequenced),
TraitsExecutionModePair({TaskPriority::USER_BLOCKING},
TaskSourceExecutionMode::kSequenced),
TraitsExecutionModePair({TaskPriority::BEST_EFFORT},
TaskSourceExecutionMode::kSingleThread),
TraitsExecutionModePair({TaskPriority::USER_VISIBLE},
TaskSourceExecutionMode::kSingleThread),
TraitsExecutionModePair({TaskPriority::USER_BLOCKING},
TaskSourceExecutionMode::kSingleThread)};
}
class ThreadPoolImplTestBase : public testing::Test {
public:
ThreadPoolImplTestBase()
: thread_pool_(std::make_unique<ThreadPoolImpl>("Test")),
service_thread_("ServiceThread") {
Thread::Options service_thread_options;
service_thread_options.message_pump_type = MessagePumpType::IO;
service_thread_.StartWithOptions(std::move(service_thread_options));
}
ThreadPoolImplTestBase(const ThreadPoolImplTestBase&) = delete;
ThreadPoolImplTestBase& operator=(const ThreadPoolImplTestBase&) = delete;
virtual bool GetUseResourceEfficientThreadGroup() const = 0;
void set_worker_thread_observer(
std::unique_ptr<WorkerThreadObserver> worker_thread_observer) {
worker_thread_observer_ = std::move(worker_thread_observer);
}
void StartThreadPool(
size_t max_num_foreground_threads = kMaxNumForegroundThreads,
size_t max_num_utility_threads = kMaxNumUtilityThreads,
TimeDelta reclaim_time = Seconds(30)) {
SetupFeatures();
ThreadPoolInstance::InitParams init_params(max_num_foreground_threads,
max_num_utility_threads);
init_params.suggested_reclaim_time = reclaim_time;
thread_pool_->Start(init_params, worker_thread_observer_.get());
}
void TearDown() override {
if (did_tear_down_)
return;
if (thread_pool_) {
thread_pool_->FlushForTesting();
thread_pool_->JoinForTesting();
thread_pool_.reset();
}
did_tear_down_ = true;
}
std::unique_ptr<ThreadPoolImpl> thread_pool_;
Thread service_thread_;
private:
void SetupFeatures() {
std::vector<base::test::FeatureRef> features;
if (GetUseResourceEfficientThreadGroup()) {
features.push_back(kUseUtilityThreadGroup);
}
if (!features.empty()) {
feature_list_.InitWithFeatures(features, {});
}
}
base::test::ScopedFeatureList feature_list_;
std::unique_ptr<WorkerThreadObserver> worker_thread_observer_;
bool did_tear_down_ = false;
};
class ThreadPoolImplTest : public ThreadPoolImplTestBase,
public testing::WithParamInterface<
bool /* use_resource_efficient_thread_group */> {
public:
bool GetUseResourceEfficientThreadGroup() const override {
return GetParam();
}
};
// Tests run for enough traits and execution mode combinations to cover all
// valid combinations of task destination (background/foreground ThreadGroup,
// single-thread) and whether the task is affected by a BEST_EFFORT fence.
class ThreadPoolImplTest_CoverAllSchedulingOptions
: public ThreadPoolImplTestBase,
public testing::WithParamInterface<
std::tuple<bool /* use_resource_efficient_thread_group */,
TraitsExecutionModePair>> {
public:
ThreadPoolImplTest_CoverAllSchedulingOptions() = default;
ThreadPoolImplTest_CoverAllSchedulingOptions(
const ThreadPoolImplTest_CoverAllSchedulingOptions&) = delete;
ThreadPoolImplTest_CoverAllSchedulingOptions& operator=(
const ThreadPoolImplTest_CoverAllSchedulingOptions&) = delete;
bool GetUseResourceEfficientThreadGroup() const override {
return std::get<0>(GetParam());
}
TaskTraits GetTraits() const { return std::get<1>(GetParam()).traits; }
TaskSourceExecutionMode GetExecutionMode() const {
return std::get<1>(GetParam()).execution_mode;
}
};
} // namespace
// Verifies that a Task posted via PostDelayedTask with parameterized TaskTraits
// and no delay runs on a thread with the expected priority and I/O
// restrictions. The ExecutionMode parameter is ignored by this test.
TEST_P(ThreadPoolImplTest_CoverAllSchedulingOptions, PostDelayedTaskNoDelay) {
StartThreadPool();
TestWaitableEvent task_ran;
thread_pool_->PostDelayedTask(
FROM_HERE, GetTraits(),
BindOnce(&VerifyTaskEnvironmentAndSignalEvent, GetTraits(),
GetUseResourceEfficientThreadGroup(), Unretained(&task_ran)),
TimeDelta());
task_ran.Wait();
}
// Verifies that a Task posted via PostDelayedTask with parameterized
// TaskTraits and a non-zero delay runs on a thread with the expected priority
// and I/O restrictions after the delay expires. The ExecutionMode parameter is
// ignored by this test.
TEST_P(ThreadPoolImplTest_CoverAllSchedulingOptions, PostDelayedTaskWithDelay) {
StartThreadPool();
TestWaitableEvent task_ran;
thread_pool_->PostDelayedTask(
FROM_HERE, GetTraits(),
BindOnce(&VerifyTimeAndTaskEnvironmentAndSignalEvent, GetTraits(),
GetUseResourceEfficientThreadGroup(),
TimeTicks::Now() + TestTimeouts::tiny_timeout(),
Unretained(&task_ran)),
TestTimeouts::tiny_timeout());
task_ran.Wait();
}
namespace {
scoped_refptr<SequencedTaskRunner> CreateSequencedTaskRunnerAndExecutionMode(
ThreadPoolImpl* thread_pool,
const TaskTraits& traits,
TaskSourceExecutionMode execution_mode,
SingleThreadTaskRunnerThreadMode default_single_thread_task_runner_mode =
SingleThreadTaskRunnerThreadMode::SHARED) {
switch (execution_mode) {
case TaskSourceExecutionMode::kSequenced:
return thread_pool->CreateSequencedTaskRunner(traits);
case TaskSourceExecutionMode::kSingleThread: {
return thread_pool->CreateSingleThreadTaskRunner(
traits, default_single_thread_task_runner_mode);
}
case TaskSourceExecutionMode::kParallel:
case TaskSourceExecutionMode::kJob:
ADD_FAILURE() << "Tests below don't cover these modes";
return nullptr;
}
ADD_FAILURE() << "Unknown ExecutionMode";
return nullptr;
}
} // namespace
TEST_P(ThreadPoolImplTest_CoverAllSchedulingOptions,
PostDelayedTaskAtViaTaskRunner) {
StartThreadPool();
TestWaitableEvent task_ran;
// Only runs for kSequenced and kSingleThread.
auto handle =
CreateSequencedTaskRunnerAndExecutionMode(thread_pool_.get(), GetTraits(),
GetExecutionMode())
->PostCancelableDelayedTaskAt(
subtle::PostDelayedTaskPassKeyForTesting(), FROM_HERE,
BindOnce(&VerifyTimeAndTaskEnvironmentAndSignalEvent, GetTraits(),
GetUseResourceEfficientThreadGroup(),
TimeTicks::Now() + TestTimeouts::tiny_timeout(),
Unretained(&task_ran)),
TimeTicks::Now() + TestTimeouts::tiny_timeout(),
subtle::DelayPolicy::kFlexibleNoSooner);
task_ran.Wait();
}
// Verifies that Tasks posted via a TaskRunner with parameterized TaskTraits and
// ExecutionMode run on a thread with the expected priority and I/O restrictions
// and respect the characteristics of their ExecutionMode.
TEST_P(ThreadPoolImplTest_CoverAllSchedulingOptions, PostTasksViaTaskRunner) {
StartThreadPool();
test::TestTaskFactory factory(
CreateTaskRunnerAndExecutionMode(thread_pool_.get(), GetTraits(),
GetExecutionMode()),
GetExecutionMode());
const size_t kNumTasksPerTest = 150;
for (size_t i = 0; i < kNumTasksPerTest; ++i) {
factory.PostTask(test::TestTaskFactory::PostNestedTask::NO,
BindOnce(&VerifyTaskEnvironment, GetTraits(),
GetUseResourceEfficientThreadGroup()));
}
factory.WaitForAllTasksToRun();
}
// Verifies that a task posted via PostDelayedTask without a delay doesn't run
// before Start() is called.
TEST_P(ThreadPoolImplTest_CoverAllSchedulingOptions,
PostDelayedTaskNoDelayBeforeStart) {
TestWaitableEvent task_running;
thread_pool_->PostDelayedTask(
FROM_HERE, GetTraits(),
BindOnce(&VerifyTaskEnvironmentAndSignalEvent, GetTraits(),
GetUseResourceEfficientThreadGroup(), Unretained(&task_running)),
TimeDelta());
// Wait a little bit to make sure that the task doesn't run before Start().
// Note: This test won't catch a case where the task runs just after the check
// and before Start(). However, we expect the test to be flaky if the tested
// code allows that to happen.
PlatformThread::Sleep(TestTimeouts::tiny_timeout());
EXPECT_FALSE(task_running.IsSignaled());
StartThreadPool();
task_running.Wait();
}
// Verifies that a task posted via PostDelayedTask with a delay doesn't run
// before Start() is called.
TEST_P(ThreadPoolImplTest_CoverAllSchedulingOptions,
PostDelayedTaskWithDelayBeforeStart) {
TestWaitableEvent task_running;
thread_pool_->PostDelayedTask(
FROM_HERE, GetTraits(),
BindOnce(&VerifyTimeAndTaskEnvironmentAndSignalEvent, GetTraits(),
GetUseResourceEfficientThreadGroup(),
TimeTicks::Now() + TestTimeouts::tiny_timeout(),
Unretained(&task_running)),
TestTimeouts::tiny_timeout());
// Wait a little bit to make sure that the task doesn't run before Start().
// Note: This test won't catch a case where the task runs just after the check
// and before Start(). However, we expect the test to be flaky if the tested
// code allows that to happen.
PlatformThread::Sleep(TestTimeouts::tiny_timeout());
EXPECT_FALSE(task_running.IsSignaled());
StartThreadPool();
task_running.Wait();
}
// Verifies that a task posted via a TaskRunner doesn't run before Start() is
// called.
TEST_P(ThreadPoolImplTest_CoverAllSchedulingOptions,
PostTaskViaTaskRunnerBeforeStart) {
bool use_resource_efficient_thread_group =
GetUseResourceEfficientThreadGroup();
// The worker_thread of SingleThreadTaskRunner is selected before
// kUseUtilityThreadGroup feature is set up at StartThreadPool().
if (GetExecutionMode() == TaskSourceExecutionMode::kSingleThread) {
use_resource_efficient_thread_group = false;
}
TestWaitableEvent task_running;
CreateTaskRunnerAndExecutionMode(thread_pool_.get(), GetTraits(),
GetExecutionMode())
->PostTask(FROM_HERE,
BindOnce(&VerifyTaskEnvironmentAndSignalEvent, GetTraits(),
use_resource_efficient_thread_group,
Unretained(&task_running)));
// Wait a little bit to make sure that the task doesn't run before Start().
// Note: This test won't catch a case where the task runs just after the check
// and before Start(). However, we expect the test to be flaky if the tested
// code allows that to happen.
PlatformThread::Sleep(TestTimeouts::tiny_timeout());
EXPECT_FALSE(task_running.IsSignaled());
StartThreadPool();
// This should not hang if the task runs after Start().
task_running.Wait();
}
// Verify that posting tasks after the thread pool was destroyed fails but
// doesn't crash.
TEST_P(ThreadPoolImplTest_CoverAllSchedulingOptions, PostTaskAfterDestroy) {
StartThreadPool();
auto task_runner = CreateTaskRunnerAndExecutionMode(
thread_pool_.get(), GetTraits(), GetExecutionMode());
EXPECT_TRUE(task_runner->PostTask(FROM_HERE, DoNothing()));
thread_pool_->JoinForTesting();
thread_pool_.reset();
EXPECT_FALSE(
task_runner->PostTask(FROM_HERE, MakeExpectedNotRunClosure(FROM_HERE)));
}
// Verifies that FlushAsyncForTesting() calls back correctly for all trait and
// execution mode pairs.
TEST_P(ThreadPoolImplTest_CoverAllSchedulingOptions,
FlushAsyncForTestingSimple) {
StartThreadPool();
TestWaitableEvent unblock_task;
CreateTaskRunnerAndExecutionMode(thread_pool_.get(), GetTraits(),
GetExecutionMode(),
SingleThreadTaskRunnerThreadMode::DEDICATED)
->PostTask(FROM_HERE,
BindOnce(&TestWaitableEvent::Wait, Unretained(&unblock_task)));
TestWaitableEvent flush_event;
thread_pool_->FlushAsyncForTesting(
BindOnce(&TestWaitableEvent::Signal, Unretained(&flush_event)));
PlatformThread::Sleep(TestTimeouts::tiny_timeout());
EXPECT_FALSE(flush_event.IsSignaled());
unblock_task.Signal();
flush_event.Wait();
}
// Verifies that BEST_EFFORT tasks don't run when the
// --disable-best-effort-tasks command-line switch is specified.
//
// Not using the same fixture as other tests because we want to append a command
// line switch before creating the pool.
TEST(ThreadPoolImplTest_Switch, DisableBestEffortTasksSwitch) {
CommandLine::ForCurrentProcess()->AppendSwitch(
switches::kDisableBestEffortTasks);
ThreadPoolImpl thread_pool("Test");
ThreadPoolInstance::InitParams init_params(kMaxNumForegroundThreads,
kMaxNumUtilityThreads);
thread_pool.Start(init_params, nullptr);
AtomicFlag best_effort_can_run;
TestWaitableEvent best_effort_did_run;
thread_pool.PostDelayedTask(
FROM_HERE,
{TaskPriority::BEST_EFFORT, TaskShutdownBehavior::BLOCK_SHUTDOWN},
BindLambdaForTesting([&] {
EXPECT_TRUE(best_effort_can_run.IsSet());
best_effort_did_run.Signal();
}),
TimeDelta());
TestWaitableEvent user_blocking_did_run;
thread_pool.PostDelayedTask(
FROM_HERE, {TaskPriority::USER_BLOCKING},
BindLambdaForTesting([&] { user_blocking_did_run.Signal(); }),
TimeDelta());
// The USER_BLOCKING task should run.
user_blocking_did_run.Wait();
PlatformThread::Sleep(TestTimeouts::tiny_timeout());
// The BEST_EFFORT task should not run when a BEST_EFFORT fence is deleted.
thread_pool.BeginBestEffortFence();
thread_pool.EndBestEffortFence();
PlatformThread::Sleep(TestTimeouts::tiny_timeout());
// The BEST_EFFORT task should only run during shutdown.
best_effort_can_run.Set();
thread_pool.Shutdown();
EXPECT_TRUE(best_effort_did_run.IsSignaled());
thread_pool.JoinForTesting();
}
// Verifies that tasks only run when allowed by fences.
TEST_P(ThreadPoolImplTest_CoverAllSchedulingOptions, Fence) {
StartThreadPool();
AtomicFlag can_run;
TestWaitableEvent did_run;
thread_pool_->BeginFence();
CreateTaskRunnerAndExecutionMode(thread_pool_.get(), GetTraits(),
GetExecutionMode())
->PostTask(FROM_HERE, BindLambdaForTesting([&] {
EXPECT_TRUE(can_run.IsSet());
did_run.Signal();
}));
PlatformThread::Sleep(TestTimeouts::tiny_timeout());
can_run.Set();
thread_pool_->EndFence();
did_run.Wait();
}
// Verifies that multiple fences can exist at the same time.
TEST_P(ThreadPoolImplTest_CoverAllSchedulingOptions, MultipleFences) {
StartThreadPool();
AtomicFlag can_run;
TestWaitableEvent did_run;
thread_pool_->BeginFence();
thread_pool_->BeginFence();
CreateTaskRunnerAndExecutionMode(thread_pool_.get(), GetTraits(),
GetExecutionMode())
->PostTask(FROM_HERE, BindLambdaForTesting([&] {
EXPECT_TRUE(can_run.IsSet());
did_run.Signal();
}));
PlatformThread::Sleep(TestTimeouts::tiny_timeout());
thread_pool_->EndFence();
PlatformThread::Sleep(TestTimeouts::tiny_timeout());
// The task can only run when both fences are removed.
can_run.Set();
thread_pool_->EndFence();
did_run.Wait();
}
// Verifies that a call to BeginFence() before Start() is honored.
TEST_P(ThreadPoolImplTest_CoverAllSchedulingOptions, FenceBeforeStart) {
thread_pool_->BeginFence();
StartThreadPool();
AtomicFlag can_run;
TestWaitableEvent did_run;
CreateTaskRunnerAndExecutionMode(thread_pool_.get(), GetTraits(),
GetExecutionMode())
->PostTask(FROM_HERE, BindLambdaForTesting([&] {
EXPECT_TRUE(can_run.IsSet());
did_run.Signal();
}));
PlatformThread::Sleep(TestTimeouts::tiny_timeout());
can_run.Set();
thread_pool_->EndFence();
did_run.Wait();
}
// Verifies that tasks only run when allowed by BEST_EFFORT fences.
TEST_P(ThreadPoolImplTest_CoverAllSchedulingOptions, BestEffortFence) {
StartThreadPool();
AtomicFlag can_run;
TestWaitableEvent did_run;
thread_pool_->BeginBestEffortFence();
CreateTaskRunnerAndExecutionMode(thread_pool_.get(), GetTraits(),
GetExecutionMode())
->PostTask(FROM_HERE, BindLambdaForTesting([&] {
if (GetTraits().priority() == TaskPriority::BEST_EFFORT)
EXPECT_TRUE(can_run.IsSet());
did_run.Signal();
}));
PlatformThread::Sleep(TestTimeouts::tiny_timeout());
can_run.Set();
thread_pool_->EndBestEffortFence();
did_run.Wait();
}
// Verifies that multiple BEST_EFFORT fences can exist at the same time.
TEST_P(ThreadPoolImplTest_CoverAllSchedulingOptions, MultipleBestEffortFences) {
StartThreadPool();
AtomicFlag can_run;
TestWaitableEvent did_run;
thread_pool_->BeginBestEffortFence();
thread_pool_->BeginBestEffortFence();
CreateTaskRunnerAndExecutionMode(thread_pool_.get(), GetTraits(),
GetExecutionMode())
->PostTask(FROM_HERE, BindLambdaForTesting([&] {
if (GetTraits().priority() == TaskPriority::BEST_EFFORT)
EXPECT_TRUE(can_run.IsSet());
did_run.Signal();
}));
PlatformThread::Sleep(TestTimeouts::tiny_timeout());
thread_pool_->EndBestEffortFence();
PlatformThread::Sleep(TestTimeouts::tiny_timeout());
// The task can only run when both fences are removed.
can_run.Set();
thread_pool_->EndBestEffortFence();
did_run.Wait();
}
// Verifies that a call to BeginBestEffortFence() before Start() is honored.
TEST_P(ThreadPoolImplTest_CoverAllSchedulingOptions,
BestEffortFenceBeforeStart) {
thread_pool_->BeginBestEffortFence();
StartThreadPool();
AtomicFlag can_run;
TestWaitableEvent did_run;
CreateTaskRunnerAndExecutionMode(thread_pool_.get(), GetTraits(),
GetExecutionMode())
->PostTask(FROM_HERE, BindLambdaForTesting([&] {
if (GetTraits().priority() == TaskPriority::BEST_EFFORT)
EXPECT_TRUE(can_run.IsSet());
did_run.Signal();
}));
PlatformThread::Sleep(TestTimeouts::tiny_timeout());
can_run.Set();
thread_pool_->EndBestEffortFence();
did_run.Wait();
}
// Spawns threads that simultaneously post Tasks to TaskRunners with various
// TaskTraits and ExecutionModes. Verifies that each Task runs on a thread with
// the expected priority and I/O restrictions and respects the characteristics
// of its ExecutionMode.
TEST_P(ThreadPoolImplTest, MultipleTraitsExecutionModePair) {
StartThreadPool();
std::vector<std::unique_ptr<ThreadPostingTasks>> threads_posting_tasks;
for (const auto& test_params : GetTraitsExecutionModePairs()) {
threads_posting_tasks.push_back(std::make_unique<ThreadPostingTasks>(
thread_pool_.get(), test_params.traits,
GetUseResourceEfficientThreadGroup(), test_params.execution_mode));
threads_posting_tasks.back()->Start();
}
for (const auto& thread : threads_posting_tasks) {
thread->WaitForAllTasksToRun();
thread->Join();
}
}
TEST_P(ThreadPoolImplTest,
GetMaxConcurrentNonBlockedTasksWithTraitsDeprecated) {
StartThreadPool();
// GetMaxConcurrentNonBlockedTasksWithTraitsDeprecated() does not support
// TaskPriority::BEST_EFFORT.
GTEST_FLAG_SET(death_test_style, "threadsafe");
EXPECT_DCHECK_DEATH({
thread_pool_->GetMaxConcurrentNonBlockedTasksWithTraitsDeprecated(
{TaskPriority::BEST_EFFORT});
});
EXPECT_DCHECK_DEATH({
thread_pool_->GetMaxConcurrentNonBlockedTasksWithTraitsDeprecated(
{MayBlock(), TaskPriority::BEST_EFFORT});
});
EXPECT_EQ(GetUseResourceEfficientThreadGroup() &&
CanUseUtilityThreadTypeForWorkerThread()
? kMaxNumUtilityThreads
: kMaxNumForegroundThreads,
thread_pool_->GetMaxConcurrentNonBlockedTasksWithTraitsDeprecated(
{TaskPriority::USER_VISIBLE}));
EXPECT_EQ(GetUseResourceEfficientThreadGroup() &&
CanUseUtilityThreadTypeForWorkerThread()
? kMaxNumUtilityThreads
: kMaxNumForegroundThreads,
thread_pool_->GetMaxConcurrentNonBlockedTasksWithTraitsDeprecated(
{MayBlock(), TaskPriority::USER_VISIBLE}));
EXPECT_EQ(kMaxNumForegroundThreads,
thread_pool_->GetMaxConcurrentNonBlockedTasksWithTraitsDeprecated(
{TaskPriority::USER_BLOCKING}));
EXPECT_EQ(kMaxNumForegroundThreads,
thread_pool_->GetMaxConcurrentNonBlockedTasksWithTraitsDeprecated(
{MayBlock(), TaskPriority::USER_BLOCKING}));
}
// Verify that the RunsTasksInCurrentSequence() method of a SequencedTaskRunner
// returns false when called from a task that isn't part of the sequence.
TEST_P(ThreadPoolImplTest, SequencedRunsTasksInCurrentSequence) {
StartThreadPool();
auto single_thread_task_runner = thread_pool_->CreateSingleThreadTaskRunner(
{}, SingleThreadTaskRunnerThreadMode::SHARED);
auto sequenced_task_runner = thread_pool_->CreateSequencedTaskRunner({});
TestWaitableEvent task_ran;
single_thread_task_runner->PostTask(
FROM_HERE,
BindOnce(
[](scoped_refptr<SequencedTaskRunner> sequenced_task_runner,
TestWaitableEvent* task_ran) {
EXPECT_FALSE(sequenced_task_runner->RunsTasksInCurrentSequence());
task_ran->Signal();
},
sequenced_task_runner, Unretained(&task_ran)));
task_ran.Wait();
}
// Verify that the RunsTasksInCurrentSequence() method of a
// SingleThreadTaskRunner returns false when called from a task that isn't part
// of the sequence.
TEST_P(ThreadPoolImplTest, SingleThreadRunsTasksInCurrentSequence) {
StartThreadPool();
auto sequenced_task_runner = thread_pool_->CreateSequencedTaskRunner({});
auto single_thread_task_runner = thread_pool_->CreateSingleThreadTaskRunner(
{}, SingleThreadTaskRunnerThreadMode::SHARED);
TestWaitableEvent task_ran;
sequenced_task_runner->PostTask(
FROM_HERE,
BindOnce(
[](scoped_refptr<SingleThreadTaskRunner> single_thread_task_runner,
TestWaitableEvent* task_ran) {
EXPECT_FALSE(
single_thread_task_runner->RunsTasksInCurrentSequence());
task_ran->Signal();
},
single_thread_task_runner, Unretained(&task_ran)));
task_ran.Wait();
}
#if BUILDFLAG(IS_WIN)
TEST_P(ThreadPoolImplTest, COMSTATaskRunnersRunWithCOMSTA) {
StartThreadPool();
auto com_sta_task_runner = thread_pool_->CreateCOMSTATaskRunner(
{}, SingleThreadTaskRunnerThreadMode::SHARED);
TestWaitableEvent task_ran;
com_sta_task_runner->PostTask(
FROM_HERE, BindOnce(
[](TestWaitableEvent* task_ran) {
win::AssertComApartmentType(win::ComApartmentType::STA);
task_ran->Signal();
},
Unretained(&task_ran)));
task_ran.Wait();
}
#endif // BUILDFLAG(IS_WIN)
TEST_P(ThreadPoolImplTest, DelayedTasksNotRunAfterShutdown) {
StartThreadPool();
// As with delayed tasks in general, this is racy. If the task does happen to
// run after Shutdown within the timeout, it will fail this test.
//
// The timeout should be set sufficiently long enough to ensure that the
// delayed task did not run. 2x is generally good enough.
//
// A non-racy way to do this would be to post two sequenced tasks:
// 1) Regular Post Task: A WaitableEvent.Wait
// 2) Delayed Task: ADD_FAILURE()
// and signalling the WaitableEvent after Shutdown() on a different thread
// since Shutdown() will block. However, the cost of managing this extra
// thread was deemed to be too great for the unlikely race.
thread_pool_->PostDelayedTask(FROM_HERE, {}, BindOnce([] { ADD_FAILURE(); }),
TestTimeouts::tiny_timeout());
thread_pool_->Shutdown();
PlatformThread::Sleep(TestTimeouts::tiny_timeout() * 2);
}
#if BUILDFLAG(IS_POSIX)
TEST_P(ThreadPoolImplTest, FileDescriptorWatcherNoOpsAfterShutdown) {
StartThreadPool();
int pipes[2];
ASSERT_EQ(0, pipe(pipes));
scoped_refptr<TaskRunner> blocking_task_runner =
thread_pool_->CreateSequencedTaskRunner(
{TaskShutdownBehavior::BLOCK_SHUTDOWN});
blocking_task_runner->PostTask(
FROM_HERE,
BindOnce(
[](int read_fd) {
std::unique_ptr<FileDescriptorWatcher::Controller> controller =
FileDescriptorWatcher::WatchReadable(
read_fd, BindRepeating([] { NOTREACHED(); }));
// This test is for components that intentionally leak their
// watchers at shutdown. We can't clean |controller| up because its
// destructor will assert that it's being called from the correct
// sequence. After the thread pool is shutdown, it is not
// possible to run tasks on this sequence.
//
// Note: Do not inline the controller.release() call into the
// ANNOTATE_LEAKING_OBJECT_PTR as the annotation is removed
// by the preprocessor in non-LEAK_SANITIZER builds,
// effectively breaking this test.
ANNOTATE_LEAKING_OBJECT_PTR(controller.get());
controller.release();
},
pipes[0]));
thread_pool_->Shutdown();
constexpr char kByte = '!';
ASSERT_TRUE(WriteFileDescriptor(pipes[1], byte_span_from_ref(kByte)));
// Give a chance for the file watcher to fire before closing the handles.
PlatformThread::Sleep(TestTimeouts::tiny_timeout());
EXPECT_EQ(0, IGNORE_EINTR(close(pipes[0])));
EXPECT_EQ(0, IGNORE_EINTR(close(pipes[1])));
}
#endif // BUILDFLAG(IS_POSIX)
#if BUILDFLAG(IS_POSIX) && !BUILDFLAG(IS_NACL)
// Verify that FileDescriptorWatcher::WatchReadable() can be called from task
// running on a task_runner with GetExecutionMode() without a crash.
TEST_P(ThreadPoolImplTest_CoverAllSchedulingOptions, FileDescriptorWatcher) {
StartThreadPool();
int fds[2];
ASSERT_EQ(0, pipe(fds));
auto task_runner = CreateTaskRunnerAndExecutionMode(
thread_pool_.get(), GetTraits(), GetExecutionMode());
EXPECT_TRUE(task_runner->PostTask(
FROM_HERE, BindOnce(IgnoreResult(&FileDescriptorWatcher::WatchReadable),
fds[0], DoNothing())));
thread_pool_->FlushForTesting();
EXPECT_EQ(0, IGNORE_EINTR(close(fds[0])));
EXPECT_EQ(0, IGNORE_EINTR(close(fds[1])));
}
#endif
// Verify that tasks posted on the same sequence access the same values on
// SequenceLocalStorage, and tasks on different sequences see different values.
TEST_P(ThreadPoolImplTest, SequenceLocalStorage) {
StartThreadPool();
SequenceLocalStorageSlot<int> slot;
auto sequenced_task_runner1 = thread_pool_->CreateSequencedTaskRunner({});
auto sequenced_task_runner2 = thread_pool_->CreateSequencedTaskRunner({});
sequenced_task_runner1->PostTask(
FROM_HERE,
BindOnce([](SequenceLocalStorageSlot<int>* slot) { slot->emplace(11); },
&slot));
sequenced_task_runner1->PostTask(
FROM_HERE, BindOnce(
[](SequenceLocalStorageSlot<int>* slot) {
EXPECT_EQ(slot->GetOrCreateValue(), 11);
},
&slot));
sequenced_task_runner2->PostTask(
FROM_HERE, BindOnce(
[](SequenceLocalStorageSlot<int>* slot) {
EXPECT_NE(slot->GetOrCreateValue(), 11);
},
&slot));
thread_pool_->FlushForTesting();
}
TEST_P(ThreadPoolImplTest, FlushAsyncNoTasks) {
StartThreadPool();
bool called_back = false;
thread_pool_->FlushAsyncForTesting(
BindOnce([](bool* called_back) { *called_back = true; },
Unretained(&called_back)));
EXPECT_TRUE(called_back);
}
namespace {
// Verifies that all strings passed as argument are found on the current stack.
// Ignores failures if this configuration doesn't have symbols.
void VerifyHasStringsOnStack(const std::string& pool_str,
const std::string& shutdown_behavior_str) {
const std::string stack = debug::StackTrace().ToString();
SCOPED_TRACE(stack);
const bool stack_has_symbols =
stack.find("WorkerThread") != std::string::npos;
if (!stack_has_symbols)
return;
EXPECT_THAT(stack, ::testing::HasSubstr(pool_str));
EXPECT_THAT(stack, ::testing::HasSubstr(shutdown_behavior_str));
}
} // namespace
#if BUILDFLAG(IS_POSIX)
// Many POSIX bots flakily crash on |debug::StackTrace().ToString()|,
// https://crbug.com/840429.
#define MAYBE_IdentifiableStacks DISABLED_IdentifiableStacks
#elif BUILDFLAG(IS_WIN) && \
(defined(ADDRESS_SANITIZER) || BUILDFLAG(CFI_CAST_CHECK))
// Hangs on WinASan and WinCFI (grabbing StackTrace() too slow?),
// https://crbug.com/845010#c7.
#define MAYBE_IdentifiableStacks DISABLED_IdentifiableStacks
#else
#define MAYBE_IdentifiableStacks IdentifiableStacks
#endif
// Integration test that verifies that workers have a frame on their stacks
// which easily identifies the type of worker and shutdown behavior (useful to
// diagnose issues from logs without memory dumps).
TEST_P(ThreadPoolImplTest, MAYBE_IdentifiableStacks) {
StartThreadPool();
// Shutdown behaviors and expected stack frames.
constexpr std::pair<TaskShutdownBehavior, const char*> shutdown_behaviors[] =
{{TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN, "RunContinueOnShutdown"},
{TaskShutdownBehavior::SKIP_ON_SHUTDOWN, "RunSkipOnShutdown"},
{TaskShutdownBehavior::BLOCK_SHUTDOWN, "RunBlockShutdown"}};
for (const auto& shutdown_behavior : shutdown_behaviors) {
const TaskTraits traits = {shutdown_behavior.first};
const TaskTraits best_effort_traits = {shutdown_behavior.first,
TaskPriority::BEST_EFFORT};
thread_pool_->CreateSequencedTaskRunner(traits)->PostTask(
FROM_HERE, BindOnce(&VerifyHasStringsOnStack, "RunPooledWorker",
shutdown_behavior.second));
thread_pool_->CreateSequencedTaskRunner(best_effort_traits)
->PostTask(FROM_HERE, BindOnce(&VerifyHasStringsOnStack,
"RunBackgroundPooledWorker",
shutdown_behavior.second));
thread_pool_
->CreateSingleThreadTaskRunner(traits,
SingleThreadTaskRunnerThreadMode::SHARED)
->PostTask(FROM_HERE,
BindOnce(&VerifyHasStringsOnStack, "RunSharedWorker",
shutdown_behavior.second));
thread_pool_
->CreateSingleThreadTaskRunner(best_effort_traits,
SingleThreadTaskRunnerThreadMode::SHARED)
->PostTask(FROM_HERE, BindOnce(&VerifyHasStringsOnStack,
"RunBackgroundSharedWorker",
shutdown_behavior.second));
thread_pool_
->CreateSingleThreadTaskRunner(
traits, SingleThreadTaskRunnerThreadMode::DEDICATED)
->PostTask(FROM_HERE,
BindOnce(&VerifyHasStringsOnStack, "RunDedicatedWorker",
shutdown_behavior.second));
thread_pool_
->CreateSingleThreadTaskRunner(
best_effort_traits, SingleThreadTaskRunnerThreadMode::DEDICATED)
->PostTask(FROM_HERE, BindOnce(&VerifyHasStringsOnStack,
"RunBackgroundDedicatedWorker",
shutdown_behavior.second));
#if BUILDFLAG(IS_WIN)
thread_pool_
->CreateCOMSTATaskRunner(traits,
SingleThreadTaskRunnerThreadMode::SHARED)
->PostTask(FROM_HERE,
BindOnce(&VerifyHasStringsOnStack, "RunSharedCOMWorker",
shutdown_behavior.second));
thread_pool_
->CreateCOMSTATaskRunner(best_effort_traits,
SingleThreadTaskRunnerThreadMode::SHARED)
->PostTask(FROM_HERE, BindOnce(&VerifyHasStringsOnStack,
"RunBackgroundSharedCOMWorker",
shutdown_behavior.second));
thread_pool_
->CreateCOMSTATaskRunner(traits,
SingleThreadTaskRunnerThreadMode::DEDICATED)
->PostTask(FROM_HERE,
BindOnce(&VerifyHasStringsOnStack, "RunDedicatedCOMWorker",
shutdown_behavior.second));
thread_pool_
->CreateCOMSTATaskRunner(best_effort_traits,
SingleThreadTaskRunnerThreadMode::DEDICATED)
->PostTask(FROM_HERE, BindOnce(&VerifyHasStringsOnStack,
"RunBackgroundDedicatedCOMWorker",
shutdown_behavior.second));
#endif // BUILDFLAG(IS_WIN)
}
thread_pool_->FlushForTesting();
}
TEST_P(ThreadPoolImplTest, WorkerThreadObserver) {
auto owned_observer =
std::make_unique<testing::StrictMock<test::MockWorkerThreadObserver>>();
auto* observer = owned_observer.get();
set_worker_thread_observer(std::move(owned_observer));
// A worker should be created for each thread group. After that, 4 threads
// should be created for each SingleThreadTaskRunnerThreadMode (8 on Windows).
const int kExpectedNumForegroundPoolWorkers = 1;
const int kExpectedNumUtilityPoolWorkers =
GetUseResourceEfficientThreadGroup() &&
CanUseUtilityThreadTypeForWorkerThread()
? 1
: 0;
const int kExpectedNumBackgroundPoolWorkers =
CanUseBackgroundThreadTypeForWorkerThread() ? 1 : 0;
const int kExpectedNumPoolWorkers = kExpectedNumForegroundPoolWorkers +
kExpectedNumUtilityPoolWorkers +
kExpectedNumBackgroundPoolWorkers;
const int kExpectedNumSharedSingleThreadedForegroundWorkers = 2;
const int kExpectedNumSharedSingleThreadedUtilityWorkers =
GetUseResourceEfficientThreadGroup() &&
CanUseUtilityThreadTypeForWorkerThread()
? 2
: 0;
const int kExpectedNumSharedSingleThreadedBackgroundWorkers =
CanUseBackgroundThreadTypeForWorkerThread() ? 2 : 0;
const int kExpectedNumSharedSingleThreadedWorkers =
kExpectedNumSharedSingleThreadedForegroundWorkers +
kExpectedNumSharedSingleThreadedUtilityWorkers +
kExpectedNumSharedSingleThreadedBackgroundWorkers;
const int kExpectedNumDedicatedSingleThreadedWorkers = 6;
const int kExpectedNumCOMSharedSingleThreadedWorkers =
#if BUILDFLAG(IS_WIN)
kExpectedNumSharedSingleThreadedWorkers;
#else
0;
#endif
const int kExpectedNumCOMDedicatedSingleThreadedWorkers =
#if BUILDFLAG(IS_WIN)
kExpectedNumDedicatedSingleThreadedWorkers;
#else
0;
#endif
EXPECT_CALL(*observer, OnWorkerThreadMainEntry())
.Times(kExpectedNumPoolWorkers + kExpectedNumSharedSingleThreadedWorkers +
kExpectedNumDedicatedSingleThreadedWorkers +
kExpectedNumCOMSharedSingleThreadedWorkers +
kExpectedNumCOMDedicatedSingleThreadedWorkers);
// Infinite detach time to prevent workers from invoking
// OnWorkerThreadMainExit() earlier than expected.
StartThreadPool(kMaxNumForegroundThreads, kMaxNumUtilityThreads,
TimeDelta::Max());
std::vector<scoped_refptr<SingleThreadTaskRunner>> task_runners;
task_runners.push_back(thread_pool_->CreateSingleThreadTaskRunner(
{TaskPriority::BEST_EFFORT}, SingleThreadTaskRunnerThreadMode::SHARED));
task_runners.push_back(thread_pool_->CreateSingleThreadTaskRunner(
{TaskPriority::BEST_EFFORT, MayBlock()},
SingleThreadTaskRunnerThreadMode::SHARED));
task_runners.push_back(thread_pool_->CreateSingleThreadTaskRunner(
{TaskPriority::USER_VISIBLE}, SingleThreadTaskRunnerThreadMode::SHARED));
task_runners.push_back(thread_pool_->CreateSingleThreadTaskRunner(
{TaskPriority::USER_VISIBLE, MayBlock()},
SingleThreadTaskRunnerThreadMode::SHARED));
task_runners.push_back(thread_pool_->CreateSingleThreadTaskRunner(
{TaskPriority::USER_BLOCKING}, SingleThreadTaskRunnerThreadMode::SHARED));
task_runners.push_back(thread_pool_->CreateSingleThreadTaskRunner(
{TaskPriority::USER_BLOCKING, MayBlock()},
SingleThreadTaskRunnerThreadMode::SHARED));
task_runners.push_back(thread_pool_->CreateSingleThreadTaskRunner(
{TaskPriority::BEST_EFFORT},
SingleThreadTaskRunnerThreadMode::DEDICATED));
task_runners.push_back(thread_pool_->CreateSingleThreadTaskRunner(
{TaskPriority::BEST_EFFORT, MayBlock()},
SingleThreadTaskRunnerThreadMode::DEDICATED));
task_runners.push_back(thread_pool_->CreateSingleThreadTaskRunner(
{TaskPriority::USER_VISIBLE},
SingleThreadTaskRunnerThreadMode::DEDICATED));
task_runners.push_back(thread_pool_->CreateSingleThreadTaskRunner(
{TaskPriority::USER_VISIBLE, MayBlock()},
SingleThreadTaskRunnerThreadMode::DEDICATED));
task_runners.push_back(thread_pool_->CreateSingleThreadTaskRunner(
{TaskPriority::USER_BLOCKING},
SingleThreadTaskRunnerThreadMode::DEDICATED));
task_runners.push_back(thread_pool_->CreateSingleThreadTaskRunner(
{TaskPriority::USER_BLOCKING, MayBlock()},
SingleThreadTaskRunnerThreadMode::DEDICATED));
#if BUILDFLAG(IS_WIN)
task_runners.push_back(thread_pool_->CreateCOMSTATaskRunner(
{TaskPriority::BEST_EFFORT}, SingleThreadTaskRunnerThreadMode::SHARED));
task_runners.push_back(thread_pool_->CreateCOMSTATaskRunner(
{TaskPriority::BEST_EFFORT, MayBlock()},
SingleThreadTaskRunnerThreadMode::SHARED));
task_runners.push_back(thread_pool_->CreateCOMSTATaskRunner(
{TaskPriority::USER_VISIBLE}, SingleThreadTaskRunnerThreadMode::SHARED));
task_runners.push_back(thread_pool_->CreateCOMSTATaskRunner(
{TaskPriority::USER_VISIBLE, MayBlock()},
SingleThreadTaskRunnerThreadMode::SHARED));
task_runners.push_back(thread_pool_->CreateCOMSTATaskRunner(
{TaskPriority::USER_BLOCKING}, SingleThreadTaskRunnerThreadMode::SHARED));
task_runners.push_back(thread_pool_->CreateCOMSTATaskRunner(
{TaskPriority::USER_BLOCKING, MayBlock()},
SingleThreadTaskRunnerThreadMode::SHARED));
task_runners.push_back(thread_pool_->CreateCOMSTATaskRunner(
{TaskPriority::BEST_EFFORT},
SingleThreadTaskRunnerThreadMode::DEDICATED));
task_runners.push_back(thread_pool_->CreateCOMSTATaskRunner(
{TaskPriority::BEST_EFFORT, MayBlock()},
SingleThreadTaskRunnerThreadMode::DEDICATED));
task_runners.push_back(thread_pool_->CreateCOMSTATaskRunner(
{TaskPriority::USER_VISIBLE},
SingleThreadTaskRunnerThreadMode::DEDICATED));
task_runners.push_back(thread_pool_->CreateCOMSTATaskRunner(
{TaskPriority::USER_VISIBLE, MayBlock()},
SingleThreadTaskRunnerThreadMode::DEDICATED));
task_runners.push_back(thread_pool_->CreateCOMSTATaskRunner(
{TaskPriority::USER_BLOCKING},
SingleThreadTaskRunnerThreadMode::DEDICATED));
task_runners.push_back(thread_pool_->CreateCOMSTATaskRunner(
{TaskPriority::USER_BLOCKING, MayBlock()},
SingleThreadTaskRunnerThreadMode::DEDICATED));
#endif
for (auto& task_runner : task_runners)
task_runner->PostTask(FROM_HERE, DoNothing());
// Release single-threaded workers. This should cause dedicated workers to
// invoke OnWorkerThreadMainExit().
observer->AllowCallsOnMainExit(kExpectedNumDedicatedSingleThreadedWorkers +
kExpectedNumCOMDedicatedSingleThreadedWorkers);
task_runners.clear();
observer->WaitCallsOnMainExit();
// Join all remaining workers. This should cause shared single-threaded
// workers and thread pool workers to invoke OnWorkerThreadMainExit().
observer->AllowCallsOnMainExit(kExpectedNumPoolWorkers +
kExpectedNumSharedSingleThreadedWorkers +
kExpectedNumCOMSharedSingleThreadedWorkers);
TearDown();
observer->WaitCallsOnMainExit();
}
// Verify a basic EnqueueJobTaskSource() runs the worker task.
TEST_P(ThreadPoolImplTest, ScheduleJobTaskSource) {
StartThreadPool();
TestWaitableEvent threads_running;
auto job_task = base::MakeRefCounted<test::MockJobTask>(
BindLambdaForTesting(
[&threads_running](JobDelegate*) { threads_running.Signal(); }),
/* num_tasks_to_run */ 1);
scoped_refptr<JobTaskSource> task_source =
job_task->GetJobTaskSource(FROM_HERE, {}, thread_pool_.get());
thread_pool_->EnqueueJobTaskSource(task_source);
threads_running.Wait();
}
// Verify that calling ShouldYield() returns true for a job task source that
// needs to change thread group because of a priority update.
TEST_P(ThreadPoolImplTest, ThreadGroupChangeShouldYield) {
StartThreadPool();
TestWaitableEvent threads_running;
TestWaitableEvent threads_continue;
auto job_task = base::MakeRefCounted<test::MockJobTask>(
BindLambdaForTesting(
[&threads_running, &threads_continue](JobDelegate* delegate) {
EXPECT_FALSE(delegate->ShouldYield());
threads_running.Signal();
threads_continue.Wait();
// The task source needs to yield if background thread groups exist.
EXPECT_EQ(delegate->ShouldYield(),
CanUseBackgroundThreadTypeForWorkerThread());
}),
/* num_tasks_to_run */ 1);
scoped_refptr<JobTaskSource> task_source = job_task->GetJobTaskSource(
FROM_HERE, {TaskPriority::USER_VISIBLE}, thread_pool_.get());
thread_pool_->EnqueueJobTaskSource(task_source);
threads_running.Wait();
thread_pool_->UpdatePriority(task_source, TaskPriority::BEST_EFFORT);
threads_continue.Signal();
// Flush the task tracker to be sure that no local variables are accessed by
// tasks after the end of the scope.
thread_pool_->FlushForTesting();
}
namespace {
class MustBeDestroyed {
public:
explicit MustBeDestroyed(bool* was_destroyed)
: was_destroyed_(was_destroyed) {}
MustBeDestroyed(const MustBeDestroyed&) = delete;
MustBeDestroyed& operator=(const MustBeDestroyed&) = delete;
~MustBeDestroyed() { *was_destroyed_ = true; }
private:
const raw_ptr<bool> was_destroyed_;
};
} // namespace
// Regression test for https://crbug.com/945087.
TEST_P(ThreadPoolImplTest_CoverAllSchedulingOptions,
NoLeakWhenPostingNestedTask) {
StartThreadPool();
SequenceLocalStorageSlot<std::unique_ptr<MustBeDestroyed>> sls;
bool was_destroyed = false;
auto must_be_destroyed = std::make_unique<MustBeDestroyed>(&was_destroyed);
auto task_runner = CreateTaskRunnerAndExecutionMode(
thread_pool_.get(), GetTraits(), GetExecutionMode());
task_runner->PostTask(FROM_HERE, BindLambdaForTesting([&] {
sls.emplace(std::move(must_be_destroyed));
task_runner->PostTask(FROM_HERE, DoNothing());
}));
TearDown();
// The TaskRunner should be deleted along with the Sequence and its
// SequenceLocalStorage when dropping this reference.
task_runner = nullptr;
EXPECT_TRUE(was_destroyed);
}
namespace {
struct TaskRunnerAndEvents {
TaskRunnerAndEvents(scoped_refptr<UpdateableSequencedTaskRunner> task_runner,
const TaskPriority updated_priority,
TestWaitableEvent* expected_previous_event)
: task_runner(std::move(task_runner)),
updated_priority(updated_priority),
expected_previous_event(expected_previous_event) {}
// The UpdateableSequencedTaskRunner.
scoped_refptr<UpdateableSequencedTaskRunner> task_runner;
// The priority to use in UpdatePriority().
const TaskPriority updated_priority;
// Signaled when a task blocking |task_runner| is scheduled.
TestWaitableEvent scheduled;
// Signaled to release the task blocking |task_runner|.
TestWaitableEvent blocked;
// Signaled in the task that runs following the priority update.
TestWaitableEvent task_ran;
// An event that should be signaled before the task following the priority
// update runs.
raw_ptr<TestWaitableEvent> expected_previous_event;
};
// Create a series of sample task runners that will post tasks at various
// initial priorities, then update priority.
std::vector<std::unique_ptr<TaskRunnerAndEvents>> CreateTaskRunnersAndEvents(
ThreadPoolImplTest* test,
ThreadPolicy thread_policy) {
ThreadPoolImpl* thread_pool = test->thread_pool_.get();
std::vector<std::unique_ptr<TaskRunnerAndEvents>> task_runners_and_events;
// -----
// Task runner that will start as USER_VISIBLE and update to USER_BLOCKING.
// Its task is expected to run first.
task_runners_and_events.push_back(std::make_unique<TaskRunnerAndEvents>(
thread_pool->CreateUpdateableSequencedTaskRunner(
TaskTraits({TaskPriority::USER_VISIBLE, thread_policy})),
TaskPriority::USER_BLOCKING, nullptr));
// -----
// Task runner that will start as BEST_EFFORT and update to USER_VISIBLE.
// Its task is expected to run after the USER_BLOCKING task runner's task,
// unless resource-efficient thread group exists, in which case they will run
// asynchronously.
TestWaitableEvent* expected_previous_event =
test->GetUseResourceEfficientThreadGroup()
? nullptr
: &task_runners_and_events.back()->task_ran;
task_runners_and_events.push_back(std::make_unique<TaskRunnerAndEvents>(
thread_pool->CreateUpdateableSequencedTaskRunner(
{TaskPriority::BEST_EFFORT, thread_policy}),
TaskPriority::USER_VISIBLE, expected_previous_event));
// -----
// Task runner that will start as USER_BLOCKING and update to BEST_EFFORT. Its
// task is expected to run asynchronously with the other two task runners'
// tasks if background thread groups exist, or after the USER_VISIBLE task
// runner's task if not.
//
// If the task following the priority update is expected to run in the
// foreground group, it should be after the task posted to the TaskRunner
// whose priority is updated to USER_VISIBLE.
expected_previous_event =
CanUseBackgroundThreadTypeForWorkerThread() ||
(test->GetUseResourceEfficientThreadGroup() &&
CanUseUtilityThreadTypeForWorkerThread())
? nullptr
: &task_runners_and_events.back()->task_ran;
task_runners_and_events.push_back(std::make_unique<TaskRunnerAndEvents>(
thread_pool->CreateUpdateableSequencedTaskRunner(
TaskTraits({TaskPriority::USER_BLOCKING, thread_policy})),
TaskPriority::BEST_EFFORT, expected_previous_event));
return task_runners_and_events;
}
// Update the priority of a sequence when it is not scheduled.
void TestUpdatePrioritySequenceNotScheduled(ThreadPoolImplTest* test,
ThreadPolicy thread_policy) {
// This test verifies that tasks run in priority order. With more than 1
// thread per pool, it is possible that tasks don't run in order even if
// threads got tasks from the PriorityQueue in order. Therefore, enforce a
// maximum of 1 thread per pool.
constexpr size_t kLocalMaxNumForegroundThreads = 1;
test->StartThreadPool(kLocalMaxNumForegroundThreads);
auto task_runners_and_events =
CreateTaskRunnersAndEvents(test, thread_policy);
// Prevent tasks from running.
test->thread_pool_->BeginFence();
// Post tasks to multiple task runners while they are at initial priority.
// They won't run immediately because of the call to BeginFence() above.
for (auto& task_runner_and_events : task_runners_and_events) {
task_runner_and_events->task_runner->PostTask(
FROM_HERE,
BindOnce(
&VerifyOrderAndTaskEnvironmentAndSignalEvent,
TaskTraits{task_runner_and_events->updated_priority, thread_policy},
test->GetUseResourceEfficientThreadGroup(),
Unretained(task_runner_and_events->expected_previous_event.get()),
Unretained(&task_runner_and_events->task_ran)));
}
// Update the priorities of the task runners that posted the tasks.
for (auto& task_runner_and_events : task_runners_and_events) {
task_runner_and_events->task_runner->UpdatePriority(
task_runner_and_events->updated_priority);
}
// Allow tasks to run.
test->thread_pool_->EndFence();
for (auto& task_runner_and_events : task_runners_and_events)
task_runner_and_events->task_ran.Wait();
}
// Update the priority of a sequence when it is scheduled, i.e. not currently
// in a priority queue.
void TestUpdatePrioritySequenceScheduled(ThreadPoolImplTest* test,
ThreadPolicy thread_policy) {
test->StartThreadPool();
auto task_runners_and_events =
CreateTaskRunnersAndEvents(test, thread_policy);
// Post blocking tasks to all task runners to prevent tasks from being
// scheduled later in the test.
for (auto& task_runner_and_events : task_runners_and_events) {
task_runner_and_events->task_runner->PostTask(
FROM_HERE, BindLambdaForTesting([&] {
task_runner_and_events->scheduled.Signal();
task_runner_and_events->blocked.Wait();
}));
task_runner_and_events->scheduled.Wait();
}
// Update the priorities of the task runners while they are scheduled and
// blocked.
for (auto& task_runner_and_events : task_runners_and_events) {
task_runner_and_events->task_runner->UpdatePriority(
task_runner_and_events->updated_priority);
}
// Post an additional task to each task runner.
for (auto& task_runner_and_events : task_runners_and_events) {
task_runner_and_events->task_runner->PostTask(
FROM_HERE,
BindOnce(
&VerifyOrderAndTaskEnvironmentAndSignalEvent,
TaskTraits{task_runner_and_events->updated_priority, thread_policy},
test->GetUseResourceEfficientThreadGroup(),
Unretained(task_runner_and_events->expected_previous_event),
Unretained(&task_runner_and_events->task_ran)));
}
// Unblock the task blocking each task runner, allowing the additional posted
// tasks to run. Each posted task will verify that it has been posted with
// updated priority when it runs.
for (auto& task_runner_and_events : task_runners_and_events) {
task_runner_and_events->blocked.Signal();
task_runner_and_events->task_ran.Wait();
}
}
} // namespace
TEST_P(ThreadPoolImplTest,
UpdatePrioritySequenceNotScheduled_PreferBackground) {
TestUpdatePrioritySequenceNotScheduled(this, ThreadPolicy::PREFER_BACKGROUND);
}
TEST_P(ThreadPoolImplTest,
UpdatePrioritySequenceNotScheduled_MustUseForeground) {
TestUpdatePrioritySequenceNotScheduled(this,
ThreadPolicy::MUST_USE_FOREGROUND);
}
TEST_P(ThreadPoolImplTest, UpdatePrioritySequenceScheduled_PreferBackground) {
TestUpdatePrioritySequenceScheduled(this, ThreadPolicy::PREFER_BACKGROUND);
}
TEST_P(ThreadPoolImplTest, UpdatePrioritySequenceScheduled_MustUseForeground) {
TestUpdatePrioritySequenceScheduled(this, ThreadPolicy::MUST_USE_FOREGROUND);
}
// Verify that a ThreadPolicy has to be specified in TaskTraits to increase
// TaskPriority from BEST_EFFORT.
TEST_P(ThreadPoolImplTest, UpdatePriorityFromBestEffortNoThreadPolicy) {
GTEST_FLAG_SET(death_test_style, "threadsafe");
StartThreadPool();
{
auto task_runner = thread_pool_->CreateUpdateableSequencedTaskRunner(
{TaskPriority::BEST_EFFORT});
EXPECT_DCHECK_DEATH(
{ task_runner->UpdatePriority(TaskPriority::USER_VISIBLE); });
}
{
auto task_runner = thread_pool_->CreateUpdateableSequencedTaskRunner(
{TaskPriority::BEST_EFFORT});
EXPECT_DCHECK_DEATH(
{ task_runner->UpdatePriority(TaskPriority::USER_BLOCKING); });
}
}
INSTANTIATE_TEST_SUITE_P(All, ThreadPoolImplTest, ::testing::Bool());
INSTANTIATE_TEST_SUITE_P(
All,
ThreadPoolImplTest_CoverAllSchedulingOptions,
::testing::Combine(
::testing::Bool(),
::testing::ValuesIn(
GetTraitsExecutionModePairsToCoverAllSchedulingOptions())));
} // namespace internal
} // namespace base