1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
cc / layers / surface_layer_impl_unittest.cc [blame]
// Copyright 2014 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "cc/layers/surface_layer_impl.h"
#include <stddef.h>
#include <utility>
#include "base/test/bind.h"
#include "base/test/scoped_feature_list.h"
#include "base/threading/thread.h"
#include "cc/base/features.h"
#include "cc/layers/append_quads_data.h"
#include "cc/test/layer_tree_impl_test_base.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
using testing::UnorderedElementsAre;
namespace cc {
namespace {
static constexpr viz::FrameSinkId kArbitraryFrameSinkId(1, 1);
TEST(SurfaceLayerImplTest, Occlusion) {
gfx::Size layer_size(1000, 1000);
gfx::Size viewport_size(1000, 1000);
const viz::LocalSurfaceId kArbitraryLocalSurfaceId(
9, base::UnguessableToken::Create());
LayerTreeImplTestBase impl;
SurfaceLayerImpl* surface_layer_impl =
impl.AddLayerInActiveTree<SurfaceLayerImpl>();
surface_layer_impl->SetBounds(layer_size);
surface_layer_impl->SetDrawsContent(true);
viz::SurfaceId surface_id(kArbitraryFrameSinkId, kArbitraryLocalSurfaceId);
surface_layer_impl->SetRange(viz::SurfaceRange(std::nullopt, surface_id),
std::nullopt);
CopyProperties(impl.root_layer(), surface_layer_impl);
impl.CalcDrawProps(viewport_size);
{
SCOPED_TRACE("No occlusion");
gfx::Rect occluded;
impl.AppendQuadsWithOcclusion(surface_layer_impl, occluded);
VerifyQuadsExactlyCoverRect(impl.quad_list(), gfx::Rect(layer_size));
EXPECT_EQ(1u, impl.quad_list().size());
EXPECT_TRUE(surface_layer_impl->WillDraw(DRAW_MODE_HARDWARE, nullptr));
}
{
SCOPED_TRACE("Full occlusion");
gfx::Rect occluded(surface_layer_impl->visible_layer_rect());
impl.AppendQuadsWithOcclusion(surface_layer_impl, occluded);
VerifyQuadsExactlyCoverRect(impl.quad_list(), gfx::Rect());
EXPECT_EQ(impl.quad_list().size(), 0u);
EXPECT_FALSE(surface_layer_impl->WillDraw(DRAW_MODE_HARDWARE, nullptr));
}
{
SCOPED_TRACE("Partial occlusion");
gfx::Rect occluded(200, 0, 800, 1000);
impl.AppendQuadsWithOcclusion(surface_layer_impl, occluded);
size_t partially_occluded_count = 0;
VerifyQuadsAreOccluded(impl.quad_list(), occluded,
&partially_occluded_count);
// The layer outputs one quad, which is partially occluded.
EXPECT_EQ(1u, impl.quad_list().size());
EXPECT_EQ(1u, partially_occluded_count);
EXPECT_TRUE(surface_layer_impl->WillDraw(DRAW_MODE_HARDWARE, nullptr));
}
}
// This test verifies that activation_dependencies and the fallback_surface_id
// are populated correctly if primary and fallback surfaces differ.
TEST(SurfaceLayerImplTest, SurfaceLayerImplWithTwoDifferentSurfaces) {
LayerTreeImplTestBase impl;
SurfaceLayerImpl* surface_layer_impl =
impl.AddLayerInActiveTree<SurfaceLayerImpl>();
// Populate the primary viz::SurfaceInfo.
const viz::LocalSurfaceId kArbitraryLocalSurfaceId1(
9, base::UnguessableToken::Create());
viz::SurfaceId surface_id1(kArbitraryFrameSinkId, kArbitraryLocalSurfaceId1);
// Populate the fallback viz::SurfaceId.
const viz::LocalSurfaceId kArbitraryLocalSurfaceId2(
7, kArbitraryLocalSurfaceId1.embed_token());
viz::SurfaceId surface_id2(kArbitraryFrameSinkId, kArbitraryLocalSurfaceId2);
gfx::Size layer_size(400, 100);
// Populate the SurfaceLayerImpl ensuring that the primary and fallback
// SurfaceInfos are different.
surface_layer_impl->SetBounds(layer_size);
surface_layer_impl->SetDrawsContent(true);
surface_layer_impl->SetRange(viz::SurfaceRange(surface_id2, surface_id1), 2u);
surface_layer_impl->SetBackgroundColor(SkColors::kBlue);
CopyProperties(impl.root_layer(), surface_layer_impl);
gfx::Size viewport_size(1000, 1000);
impl.CalcDrawProps(viewport_size);
auto render_pass = viz::CompositorRenderPass::Create();
{
AppendQuadsData data;
surface_layer_impl->AppendQuads(render_pass.get(), &data);
// The the primary viz::SurfaceInfo will be added to
// activation_dependencies.
EXPECT_THAT(data.activation_dependencies,
UnorderedElementsAre(surface_id1));
EXPECT_EQ(2u, data.deadline_in_frames);
EXPECT_FALSE(data.use_default_lower_bound_deadline);
}
// Update the fallback to an invalid viz::SurfaceInfo. The
// |activation_dependencies| should still contain the primary
// viz::SurfaceInfo.
{
AppendQuadsData data;
surface_layer_impl->SetRange(viz::SurfaceRange(std::nullopt, surface_id1),
0u);
surface_layer_impl->AppendQuads(render_pass.get(), &data);
// The primary viz::SurfaceInfo should be added to activation_dependencies.
EXPECT_THAT(data.activation_dependencies,
UnorderedElementsAre(surface_id1));
EXPECT_EQ(0u, data.deadline_in_frames);
EXPECT_FALSE(data.use_default_lower_bound_deadline);
}
// Update the primary deadline and fallback viz::SurfaceId and
// re-emit DrawQuads.
{
AppendQuadsData data;
surface_layer_impl->SetRange(viz::SurfaceRange(surface_id2, surface_id1),
4u);
surface_layer_impl->AppendQuads(render_pass.get(), &data);
// The the primary viz::SurfaceInfo will be added to
// activation_dependencies.
EXPECT_THAT(data.activation_dependencies,
UnorderedElementsAre(surface_id1));
// The primary SurfaceId hasn't changed but a new deadline was explicitly
// requested in SetRange so we'll use it in the next CompositorFrame.
EXPECT_EQ(4u, data.deadline_in_frames);
EXPECT_FALSE(data.use_default_lower_bound_deadline);
}
ASSERT_EQ(3u, render_pass->quad_list.size());
const viz::SurfaceDrawQuad* surface_draw_quad1 =
viz::SurfaceDrawQuad::MaterialCast(render_pass->quad_list.ElementAt(0));
ASSERT_TRUE(surface_draw_quad1);
const viz::SurfaceDrawQuad* surface_draw_quad2 =
viz::SurfaceDrawQuad::MaterialCast(render_pass->quad_list.ElementAt(1));
ASSERT_TRUE(surface_draw_quad2);
const viz::SurfaceDrawQuad* surface_draw_quad3 =
viz::SurfaceDrawQuad::MaterialCast(render_pass->quad_list.ElementAt(2));
ASSERT_TRUE(surface_draw_quad3);
EXPECT_EQ(surface_id1, surface_draw_quad1->surface_range.end());
EXPECT_EQ(SkColors::kBlue, surface_draw_quad1->default_background_color);
EXPECT_EQ(surface_id2, surface_draw_quad1->surface_range.start());
EXPECT_EQ(surface_id1, surface_draw_quad2->surface_range.end());
EXPECT_EQ(SkColors::kBlue, surface_draw_quad2->default_background_color);
EXPECT_EQ(std::nullopt, surface_draw_quad2->surface_range.start());
EXPECT_EQ(surface_id1, surface_draw_quad3->surface_range.end());
EXPECT_EQ(SkColors::kBlue, surface_draw_quad3->default_background_color);
EXPECT_EQ(surface_id2, surface_draw_quad3->surface_range.start());
}
// This test verifies that if one SurfaceLayerImpl has a deadline
// and the other uses the default then AppendQuadsData is populated
// correctly.
TEST(SurfaceLayerImplTest, SurfaceLayerImplsWithDeadlines) {
LayerTreeImplTestBase impl;
SurfaceLayerImpl* surface_layer_impl =
impl.AddLayerInActiveTree<SurfaceLayerImpl>();
CopyProperties(impl.root_layer(), surface_layer_impl);
SurfaceLayerImpl* surface_layer_impl2 =
impl.AddLayerInActiveTree<SurfaceLayerImpl>();
CopyProperties(impl.root_layer(), surface_layer_impl2);
const viz::LocalSurfaceId kArbitraryLocalSurfaceId1(
1, base::UnguessableToken::Create());
viz::SurfaceId surface_id1(kArbitraryFrameSinkId, kArbitraryLocalSurfaceId1);
const viz::LocalSurfaceId kArbitraryLocalSurfaceId2(
2, kArbitraryLocalSurfaceId1.embed_token());
viz::SurfaceId surface_id2(kArbitraryFrameSinkId, kArbitraryLocalSurfaceId2);
gfx::Size viewport_size(1000, 1000);
impl.CalcDrawProps(viewport_size);
gfx::Size layer_size(400, 100);
surface_layer_impl->SetBounds(layer_size);
surface_layer_impl->SetDrawsContent(true);
surface_layer_impl->SetRange(viz::SurfaceRange(surface_id1, surface_id2), 1u);
surface_layer_impl2->SetBounds(layer_size);
surface_layer_impl2->SetDrawsContent(true);
surface_layer_impl2->SetRange(viz::SurfaceRange(surface_id1, surface_id2),
std::nullopt);
auto render_pass = viz::CompositorRenderPass::Create();
AppendQuadsData data;
surface_layer_impl->AppendQuads(render_pass.get(), &data);
EXPECT_EQ(1u, data.deadline_in_frames);
EXPECT_FALSE(data.use_default_lower_bound_deadline);
surface_layer_impl2->AppendQuads(render_pass.get(), &data);
EXPECT_EQ(1u, data.deadline_in_frames);
EXPECT_TRUE(data.use_default_lower_bound_deadline);
}
// This test verifies that one viz::SurfaceDrawQuad is emitted if a
// SurfaceLayerImpl holds the same surface ID for both the primary
// and fallback viz::SurfaceInfo.
TEST(SurfaceLayerImplTest, SurfaceLayerImplWithMatchingPrimaryAndFallback) {
LayerTreeImplTestBase impl;
SurfaceLayerImpl* surface_layer_impl =
impl.AddLayerInActiveTree<SurfaceLayerImpl>();
// Populate the primary viz::SurfaceId.
const viz::LocalSurfaceId kArbitraryLocalSurfaceId1(
9, base::UnguessableToken::Create());
viz::SurfaceId surface_id1(kArbitraryFrameSinkId, kArbitraryLocalSurfaceId1);
gfx::Size layer_size(400, 100);
// Populate the SurfaceLayerImpl ensuring that the primary and fallback
// SurfaceInfos are the same.
surface_layer_impl->SetBounds(layer_size);
surface_layer_impl->SetDrawsContent(true);
surface_layer_impl->SetRange(viz::SurfaceRange(surface_id1), 1u);
surface_layer_impl->SetRange(viz::SurfaceRange(surface_id1), 2u);
surface_layer_impl->SetBackgroundColor(SkColors::kBlue);
CopyProperties(impl.root_layer(), surface_layer_impl);
gfx::Size viewport_size(1000, 1000);
impl.CalcDrawProps(viewport_size);
auto render_pass = viz::CompositorRenderPass::Create();
AppendQuadsData data;
surface_layer_impl->AppendQuads(render_pass.get(), &data);
EXPECT_THAT(data.activation_dependencies, UnorderedElementsAre(surface_id1));
EXPECT_EQ(2u, data.deadline_in_frames);
ASSERT_EQ(1u, render_pass->quad_list.size());
const viz::SurfaceDrawQuad* surface_draw_quad1 =
viz::SurfaceDrawQuad::MaterialCast(render_pass->quad_list.ElementAt(0));
ASSERT_TRUE(surface_draw_quad1);
EXPECT_EQ(surface_id1, surface_draw_quad1->surface_range.end());
EXPECT_EQ(surface_id1, surface_draw_quad1->surface_range.start());
EXPECT_EQ(SkColors::kBlue, surface_draw_quad1->default_background_color);
}
TEST(SurfaceLayerImplTest, GetEnclosingRectInTargetSpace) {
gfx::Size layer_size(902, 1000);
gfx::Size viewport_size(902, 1000);
LayerTreeImplTestBase impl;
SurfaceLayerImpl* surface_layer_impl =
impl.AddLayerInActiveTree<SurfaceLayerImpl>();
surface_layer_impl->SetBounds(layer_size);
surface_layer_impl->SetDrawsContent(true);
CopyProperties(impl.root_layer(), surface_layer_impl);
// A device scale of 1.33 and transform of 1.5 were chosen as they produce
// different results when rounding at each stage, vs applying a single
// transform.
gfx::Transform transform;
transform.Scale(1.5, 1.5);
impl.host_impl()->active_tree()->SetDeviceScaleFactor(1.33);
impl.CalcDrawProps(viewport_size);
surface_layer_impl->draw_properties().target_space_transform = transform;
// GetEnclosingRectInTargetSpace() and GetScaledEnclosingRectInTargetSpace()
// should return the same value, otherwise we may not damage the right
// pixels.
EXPECT_EQ(
surface_layer_impl->GetScaledEnclosingVisibleRectInTargetSpace(1.33),
surface_layer_impl->GetEnclosingVisibleRectInTargetSpace());
}
TEST(SurfaceLayerImplTest, WillDrawNotifiesSynchronouslyInCompositeImmediate) {
auto thread = std::make_unique<base::Thread>("VideoCompositor");
ASSERT_TRUE(thread->StartAndWaitForTesting());
scoped_refptr<base::TaskRunner> task_runner = thread->task_runner();
bool updated = false;
UpdateSubmissionStateCB callback = base::BindLambdaForTesting(
[task_runner, &updated](bool draw, base::WaitableEvent* done) {
// SurfaceLayerImpl also notifies the callback on destruction with draw
// = false. Ignore that call, since it's not really a part of the test.
if (!draw)
return;
// We're going to return control to the compositor, without signalling
// |done| for a bit.
task_runner->PostDelayedTask(
FROM_HERE,
base::BindOnce(
[](bool* updated, base::WaitableEvent* done) {
*updated = true;
if (done)
done->Signal();
},
base::Unretained(&updated), base::Unretained(done)),
base::Milliseconds(100));
});
// Note that this has to be created after the callback so that the layer is
// destroyed first (it will call the callback in the dtor).
LayerTreeImplTestBase impl;
impl.host_impl()->client()->set_is_synchronous_composite(true);
SurfaceLayerImpl* surface_layer_impl =
impl.AddLayerInActiveTree<SurfaceLayerImpl>(std::move(callback));
surface_layer_impl->SetBounds(gfx::Size(500, 500));
surface_layer_impl->SetDrawsContent(true);
CopyProperties(impl.root_layer(), surface_layer_impl);
impl.CalcDrawProps(gfx::Size(500, 500));
surface_layer_impl->WillDraw(DRAW_MODE_SOFTWARE, nullptr);
// This would not be set to true if WillDraw() completed before the task
// posted by `callback` runs and completes. That task is posted with a delay
// to ensure that the current thread really did wait.
EXPECT_TRUE(updated);
}
TEST(SurfaceLayerImplTest, WillDrawNotifiesAsynchronously) {
bool updated = false;
UpdateSubmissionStateCB callback = base::BindLambdaForTesting(
[&updated](bool draw, base::WaitableEvent* done) {
// SurfaceLayerImpl also notifies the callback on destruction with draw
// = false. Ignore that call, since it's not really a part of the test.
if (!draw)
return;
// Note that the event should always be null here, meaning we don't
// synchronize anything if posted across threads. This is because we're
// using threaded compositing in this test (see
// set_is_synchronous_composite(false) call below).
EXPECT_FALSE(done);
updated = true;
});
// Note that this has to be created after the callback so that the layer is
// destroyed first (it will call the callback in the dtor).
LayerTreeImplTestBase impl;
impl.host_impl()->client()->set_is_synchronous_composite(false);
SurfaceLayerImpl* surface_layer_impl =
impl.AddLayerInActiveTree<SurfaceLayerImpl>(std::move(callback));
surface_layer_impl->SetBounds(gfx::Size(500, 500));
surface_layer_impl->SetDrawsContent(true);
CopyProperties(impl.root_layer(), surface_layer_impl);
impl.CalcDrawProps(gfx::Size(500, 500));
surface_layer_impl->WillDraw(DRAW_MODE_SOFTWARE, nullptr);
// We should have called the callback, which would set `updated` to true.
EXPECT_TRUE(updated);
}
class SurfaceLayerImplAlignToPixelGridTest : public testing::Test {
public:
SurfaceLayerImplAlignToPixelGridTest() {
scoped_feature_list_.InitWithFeatures(
{features::kAlignSurfaceLayerImplToPixelGrid}, {});
}
private:
base::test::ScopedFeatureList scoped_feature_list_;
};
TEST_F(SurfaceLayerImplAlignToPixelGridTest, FractionalOffsetSnapsToPixelGrid) {
gfx::Size layer_size(200, 200);
gfx::Size viewport_size(1000, 1000);
LayerTreeImplTestBase impl;
SurfaceLayerImpl* surface_layer_impl =
impl.AddLayerInActiveTree<SurfaceLayerImpl>();
surface_layer_impl->SetBounds(layer_size);
surface_layer_impl->SetDrawsContent(true);
CopyProperties(impl.root_layer(), surface_layer_impl);
// Create transform with fractional translation.
gfx::Transform transform;
transform.PostTranslate(0.3, 0.7);
EXPECT_FALSE(transform.IsIdentityOrIntegerTranslation());
impl.CalcDrawProps(viewport_size);
surface_layer_impl->draw_properties().target_space_transform = transform;
// Compute RenderPass, with DrawQuads for SurfaceLayer.
auto render_pass = viz::CompositorRenderPass::Create();
AppendQuadsData data;
surface_layer_impl->AppendQuads(render_pass.get(), &data);
// Verify that the DrawQuads for the SurfaceLayer have an integral offset.
ASSERT_EQ(1U, render_pass->shared_quad_state_list.size());
viz::SharedQuadState* state =
render_pass->shared_quad_state_list.ElementAt(0);
gfx::Transform quad_to_target_transform = state->quad_to_target_transform;
EXPECT_TRUE(quad_to_target_transform.IsIdentityOrIntegerTranslation());
}
// This test verifies that paint flag overrides are propagated to the
// viz::SurfaceDrawQuad.
TEST(SurfaceLayerImplTest, OverrideChildPaintFlags) {
LayerTreeImplTestBase impl;
SurfaceLayerImpl* surface_layer_impl =
impl.AddLayerInActiveTree<SurfaceLayerImpl>();
CopyProperties(impl.root_layer(), surface_layer_impl);
gfx::Size viewport_size(1000, 1000);
impl.CalcDrawProps(viewport_size);
{
const viz::LocalSurfaceId kArbitraryLocalSurfaceId1(
1, base::UnguessableToken::Create());
viz::SurfaceId surface_id1(kArbitraryFrameSinkId,
kArbitraryLocalSurfaceId1);
gfx::Size layer_size(400, 100);
surface_layer_impl->SetBounds(layer_size);
surface_layer_impl->SetDrawsContent(true);
surface_layer_impl->SetRange(viz::SurfaceRange(surface_id1), 1u);
surface_layer_impl->SetFilterQuality(PaintFlags::FilterQuality::kNone);
}
// By default, surfaces don't override their child paint flags.
{
auto render_pass = viz::CompositorRenderPass::Create();
AppendQuadsData data;
surface_layer_impl->AppendQuads(render_pass.get(), &data);
const viz::SurfaceDrawQuad* surface_draw_quad =
viz::SurfaceDrawQuad::MaterialCast(render_pass->quad_list.ElementAt(0));
EXPECT_EQ(surface_draw_quad->override_child_filter_quality, std::nullopt);
EXPECT_EQ(surface_draw_quad->override_child_dynamic_range_limit,
std::nullopt);
}
// When specified, surfaces will propagate their paint flags (using the
// default when none has been set on the layer).
{
surface_layer_impl->SetOverrideChildPaintFlags(true);
auto render_pass = viz::CompositorRenderPass::Create();
AppendQuadsData data;
surface_layer_impl->AppendQuads(render_pass.get(), &data);
const viz::SurfaceDrawQuad* surface_draw_quad =
viz::SurfaceDrawQuad::MaterialCast(render_pass->quad_list.ElementAt(0));
EXPECT_EQ(surface_draw_quad->override_child_filter_quality,
PaintFlags::FilterQuality::kNone);
EXPECT_EQ(surface_draw_quad->override_child_dynamic_range_limit,
PaintFlags::DynamicRangeLimitMixture());
}
}
} // namespace
} // namespace cc