1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
cc / metrics / compositor_timing_history_unittest.cc [blame]
// Copyright 2015 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "cc/metrics/compositor_timing_history.h"
#include <memory>
#include "base/memory/raw_ptr.h"
#include "base/time/time.h"
#include "cc/base/features.h"
#include "cc/debug/rendering_stats_instrumentation.h"
#include "cc/metrics/dropped_frame_counter.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace cc {
namespace {
class CompositorTimingHistoryTest;
class TestCompositorTimingHistory : public CompositorTimingHistory {
public:
TestCompositorTimingHistory(CompositorTimingHistoryTest* test,
RenderingStatsInstrumentation* rendering_stats)
: CompositorTimingHistory(RENDERER_UMA, rendering_stats), test_(test) {}
TestCompositorTimingHistory(const TestCompositorTimingHistory&) = delete;
TestCompositorTimingHistory& operator=(const TestCompositorTimingHistory&) =
delete;
protected:
base::TimeTicks Now() const override;
raw_ptr<CompositorTimingHistoryTest> test_;
};
class CompositorTimingHistoryTest : public testing::Test {
public:
CompositorTimingHistoryTest()
: rendering_stats_(RenderingStatsInstrumentation::Create()),
timing_history_(this, rendering_stats_.get()) {
AdvanceNowBy(base::Milliseconds(1));
timing_history_.SetRecordingEnabled(true);
}
void AdvanceNowBy(base::TimeDelta delta) { now_ += delta; }
base::TimeTicks Now() { return now_; }
protected:
std::unique_ptr<RenderingStatsInstrumentation> rendering_stats_;
TestCompositorTimingHistory timing_history_;
base::TimeTicks now_;
uint64_t sequence_number = 0;
DroppedFrameCounter dropped_counter;
viz::BeginFrameArgs GetFakeBeginFrameArg(bool on_critical_path = true) {
viz::BeginFrameArgs args = viz::BeginFrameArgs();
const uint64_t kSourceId = 1;
args.frame_id = {kSourceId, ++sequence_number};
args.frame_time = Now();
args.on_critical_path = on_critical_path;
return args;
}
};
base::TimeTicks TestCompositorTimingHistory::Now() const {
return test_->Now();
}
TEST_F(CompositorTimingHistoryTest, AllSequential_Commit) {
base::TimeDelta one_second = base::Seconds(1);
// Critical BeginMainFrames are faster than non critical ones,
// as expected.
base::TimeDelta begin_main_frame_queue_duration = base::Milliseconds(1);
base::TimeDelta begin_main_frame_start_to_ready_to_commit_duration =
base::Milliseconds(1);
base::TimeDelta commit_to_ready_to_activate_duration = base::Milliseconds(3);
base::TimeDelta commit_duration = base::Milliseconds(1);
base::TimeDelta activate_duration = base::Milliseconds(4);
base::TimeDelta draw_duration = base::Milliseconds(5);
timing_history_.WillBeginMainFrame(GetFakeBeginFrameArg());
AdvanceNowBy(begin_main_frame_queue_duration);
timing_history_.BeginMainFrameStarted(Now());
AdvanceNowBy(begin_main_frame_start_to_ready_to_commit_duration);
timing_history_.NotifyReadyToCommit();
timing_history_.WillCommit();
AdvanceNowBy(commit_duration);
timing_history_.DidCommit();
AdvanceNowBy(commit_to_ready_to_activate_duration);
timing_history_.ReadyToActivate();
// Do not count idle time between notification and actual activation.
AdvanceNowBy(one_second);
timing_history_.WillActivate();
AdvanceNowBy(activate_duration);
timing_history_.DidActivate();
// Do not count idle time between activate and draw.
AdvanceNowBy(one_second);
timing_history_.WillDraw();
AdvanceNowBy(draw_duration);
timing_history_.DidDraw();
EXPECT_EQ(begin_main_frame_queue_duration,
timing_history_.BeginMainFrameQueueDurationCriticalEstimate());
EXPECT_EQ(begin_main_frame_queue_duration,
timing_history_.BeginMainFrameQueueDurationNotCriticalEstimate());
EXPECT_EQ(
begin_main_frame_start_to_ready_to_commit_duration,
timing_history_.BeginMainFrameStartToReadyToCommitDurationEstimate());
EXPECT_EQ(commit_duration, timing_history_.CommitDurationEstimate());
EXPECT_EQ(commit_to_ready_to_activate_duration,
timing_history_.CommitToReadyToActivateDurationEstimate());
EXPECT_EQ(activate_duration, timing_history_.ActivateDurationEstimate());
EXPECT_EQ(draw_duration, timing_history_.DrawDurationEstimate());
}
TEST_F(CompositorTimingHistoryTest, AllSequential_BeginMainFrameAborted) {
base::TimeDelta one_second = base::Seconds(1);
base::TimeDelta begin_main_frame_queue_duration = base::Milliseconds(1);
base::TimeDelta begin_main_frame_start_to_ready_to_commit_duration =
base::Milliseconds(1);
base::TimeDelta commit_to_ready_to_activate_duration = base::Milliseconds(2);
base::TimeDelta activate_duration = base::Milliseconds(4);
base::TimeDelta draw_duration = base::Milliseconds(5);
viz::BeginFrameArgs args_ = GetFakeBeginFrameArg(false);
timing_history_.WillBeginMainFrame(args_);
AdvanceNowBy(begin_main_frame_queue_duration);
timing_history_.BeginMainFrameStarted(Now());
AdvanceNowBy(begin_main_frame_start_to_ready_to_commit_duration);
// BeginMainFrameAborted counts as a commit complete.
timing_history_.BeginMainFrameAborted();
AdvanceNowBy(commit_to_ready_to_activate_duration);
// Do not count idle time between notification and actual activation.
AdvanceNowBy(one_second);
timing_history_.WillActivate();
AdvanceNowBy(activate_duration);
timing_history_.DidActivate();
// Do not count idle time between activate and draw.
AdvanceNowBy(one_second);
timing_history_.WillDraw();
AdvanceNowBy(draw_duration);
timing_history_.DidDraw();
EXPECT_EQ(base::TimeDelta(),
timing_history_.BeginMainFrameQueueDurationCriticalEstimate());
EXPECT_EQ(begin_main_frame_queue_duration,
timing_history_.BeginMainFrameQueueDurationNotCriticalEstimate());
EXPECT_EQ(activate_duration, timing_history_.ActivateDurationEstimate());
EXPECT_EQ(draw_duration, timing_history_.DrawDurationEstimate());
}
TEST_F(CompositorTimingHistoryTest, BeginMainFrame_CriticalFaster) {
// Critical BeginMainFrames are faster than non critical ones.
base::TimeDelta begin_main_frame_queue_duration_critical =
base::Milliseconds(1);
base::TimeDelta begin_main_frame_queue_duration_not_critical =
base::Milliseconds(2);
base::TimeDelta begin_main_frame_start_to_ready_to_commit_duration =
base::Milliseconds(1);
viz::BeginFrameArgs args_ = GetFakeBeginFrameArg();
timing_history_.WillBeginMainFrame(args_);
AdvanceNowBy(begin_main_frame_queue_duration_critical);
timing_history_.BeginMainFrameStarted(Now());
AdvanceNowBy(begin_main_frame_start_to_ready_to_commit_duration);
timing_history_.BeginMainFrameAborted();
args_ = GetFakeBeginFrameArg(false);
timing_history_.WillBeginMainFrame(args_);
AdvanceNowBy(begin_main_frame_queue_duration_not_critical);
timing_history_.BeginMainFrameStarted(Now());
AdvanceNowBy(begin_main_frame_start_to_ready_to_commit_duration);
timing_history_.BeginMainFrameAborted();
// Since the critical BeginMainFrames are faster than non critical ones,
// the expectations are straightforward.
EXPECT_EQ(begin_main_frame_queue_duration_critical,
timing_history_.BeginMainFrameQueueDurationCriticalEstimate());
EXPECT_EQ(begin_main_frame_queue_duration_not_critical,
timing_history_.BeginMainFrameQueueDurationNotCriticalEstimate());
}
TEST_F(CompositorTimingHistoryTest, BeginMainFrames_OldCriticalSlower) {
// Critical BeginMainFrames are slower than non critical ones,
// which is unexpected, but could occur if one type of frame
// hasn't been sent for a significant amount of time.
base::TimeDelta begin_main_frame_queue_duration_critical =
base::Milliseconds(2);
base::TimeDelta begin_main_frame_queue_duration_not_critical =
base::Milliseconds(1);
base::TimeDelta begin_main_frame_start_to_ready_to_commit_duration =
base::Milliseconds(1);
// A single critical frame that is slow.
viz::BeginFrameArgs args_ = GetFakeBeginFrameArg();
timing_history_.WillBeginMainFrame(args_);
AdvanceNowBy(begin_main_frame_queue_duration_critical);
timing_history_.BeginMainFrameStarted(Now());
AdvanceNowBy(begin_main_frame_start_to_ready_to_commit_duration);
// BeginMainFrameAborted counts as a commit complete.
timing_history_.BeginMainFrameAborted();
// A bunch of faster non critical frames that are newer.
for (int i = 0; i < 100; i++) {
args_ = GetFakeBeginFrameArg(false);
timing_history_.WillBeginMainFrame(args_);
AdvanceNowBy(begin_main_frame_queue_duration_not_critical);
timing_history_.BeginMainFrameStarted(Now());
AdvanceNowBy(begin_main_frame_start_to_ready_to_commit_duration);
// BeginMainFrameAborted counts as a commit complete.
timing_history_.BeginMainFrameAborted();
}
// Recent fast non critical BeginMainFrames should result in the
// critical estimate also being fast.
EXPECT_EQ(begin_main_frame_queue_duration_not_critical,
timing_history_.BeginMainFrameQueueDurationCriticalEstimate());
EXPECT_EQ(begin_main_frame_queue_duration_not_critical,
timing_history_.BeginMainFrameQueueDurationNotCriticalEstimate());
}
TEST_F(CompositorTimingHistoryTest, BeginMainFrames_NewCriticalSlower) {
// Critical BeginMainFrames are slower than non critical ones,
// which is unexpected, but could occur if one type of frame
// hasn't been sent for a significant amount of time.
base::TimeDelta begin_main_frame_queue_duration_critical =
base::Milliseconds(2);
base::TimeDelta begin_main_frame_queue_duration_not_critical =
base::Milliseconds(1);
base::TimeDelta begin_main_frame_start_to_ready_to_commit_duration =
base::Milliseconds(1);
// A single non critical frame that is fast.
viz::BeginFrameArgs args_ = GetFakeBeginFrameArg(false);
timing_history_.WillBeginMainFrame(args_);
AdvanceNowBy(begin_main_frame_queue_duration_not_critical);
timing_history_.BeginMainFrameStarted(Now());
AdvanceNowBy(begin_main_frame_start_to_ready_to_commit_duration);
timing_history_.BeginMainFrameAborted();
// A bunch of slower critical frames that are newer.
for (int i = 0; i < 100; i++) {
args_ = GetFakeBeginFrameArg();
timing_history_.WillBeginMainFrame(args_);
AdvanceNowBy(begin_main_frame_queue_duration_critical);
timing_history_.BeginMainFrameStarted(Now());
AdvanceNowBy(begin_main_frame_start_to_ready_to_commit_duration);
timing_history_.BeginMainFrameAborted();
}
// Recent slow critical BeginMainFrames should result in the
// not critical estimate also being slow.
EXPECT_EQ(begin_main_frame_queue_duration_critical,
timing_history_.BeginMainFrameQueueDurationCriticalEstimate());
EXPECT_EQ(begin_main_frame_queue_duration_critical,
timing_history_.BeginMainFrameQueueDurationNotCriticalEstimate());
}
} // namespace
} // namespace cc