1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
cc / trees / layer_tree_host_pixeltest_scrollbars.cc [blame]
// Copyright 2016 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <stddef.h>
#include "build/build_config.h"
#include "cc/input/scrollbar.h"
#include "cc/layers/nine_patch_thumb_scrollbar_layer.h"
#include "cc/layers/painted_scrollbar_layer.h"
#include "cc/layers/solid_color_layer.h"
#include "cc/paint/paint_canvas.h"
#include "cc/paint/paint_flags.h"
#include "cc/test/fake_scrollbar.h"
#include "cc/test/layer_tree_pixel_test.h"
#include "cc/test/pixel_comparator.h"
#include "cc/trees/layer_tree_impl.h"
#include "components/viz/test/test_in_process_context_provider.h"
#if !BUILDFLAG(IS_ANDROID)
namespace cc {
namespace {
class LayerTreeHostScrollbarsPixelTest
: public LayerTreePixelTest,
public ::testing::WithParamInterface<viz::RendererType> {
protected:
LayerTreeHostScrollbarsPixelTest() : LayerTreePixelTest(renderer_type()) {}
viz::RendererType renderer_type() const { return GetParam(); }
void SetupTree() override {
SetInitialDeviceScaleFactor(device_scale_factor_);
LayerTreePixelTest::SetupTree();
}
float device_scale_factor_ = 1.f;
};
class PaintedScrollbar : public FakeScrollbar {
public:
explicit PaintedScrollbar(const gfx::Size& size) {
set_should_paint(true);
set_has_thumb(false);
set_track_rect(gfx::Rect(size));
}
void set_paint_scale(int scale) { paint_scale_ = scale; }
private:
void Paint(PaintCanvas& canvas, const gfx::Rect& rect) override {
PaintFlags flags;
flags.setStyle(PaintFlags::kStroke_Style);
flags.setStrokeWidth(SkIntToScalar(paint_scale_));
flags.setColor(color_);
gfx::Rect inset_rect = rect;
while (!inset_rect.IsEmpty()) {
int big_rect = paint_scale_ + 2;
int small_rect = paint_scale_;
inset_rect.Inset(
gfx::Insets::TLBR(big_rect, big_rect, small_rect, small_rect));
canvas.drawRect(RectToSkRect(inset_rect), flags);
inset_rect.Inset(
gfx::Insets::TLBR(big_rect, big_rect, small_rect, small_rect));
}
}
~PaintedScrollbar() override = default;
int paint_scale_ = 4;
SkColor color_ = SK_ColorGREEN;
};
INSTANTIATE_TEST_SUITE_P(All,
LayerTreeHostScrollbarsPixelTest,
::testing::ValuesIn(viz::GetGpuRendererTypes()),
::testing::PrintToStringParamName());
// viz::GetGpuRendererTypes() can return an empty list on some platforms.
GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(LayerTreeHostScrollbarsPixelTest);
TEST_P(LayerTreeHostScrollbarsPixelTest, NoScale) {
scoped_refptr<SolidColorLayer> background =
CreateSolidColorLayer(gfx::Rect(200, 200), SK_ColorWHITE);
auto scrollbar = base::MakeRefCounted<PaintedScrollbar>(gfx::Size(200, 200));
scoped_refptr<PaintedScrollbarLayer> layer =
PaintedScrollbarLayer::Create(std::move(scrollbar));
layer->SetIsDrawable(true);
layer->SetBounds(gfx::Size(200, 200));
background->AddChild(layer);
RunPixelTest(background, base::FilePath(FILE_PATH_LITERAL("spiral.png")));
}
TEST_P(LayerTreeHostScrollbarsPixelTest, DeviceScaleFactor) {
// With a device scale of 2, the scrollbar should still be rendered
// pixel-perfect, not show scaling artifacts
device_scale_factor_ = 2.f;
scoped_refptr<SolidColorLayer> background =
CreateSolidColorLayer(gfx::Rect(100, 100), SK_ColorWHITE);
auto scrollbar = base::MakeRefCounted<PaintedScrollbar>(gfx::Size(100, 100));
scoped_refptr<PaintedScrollbarLayer> layer =
PaintedScrollbarLayer::Create(std::move(scrollbar));
layer->SetIsDrawable(true);
layer->SetBounds(gfx::Size(100, 100));
background->AddChild(layer);
RunPixelTest(background,
base::FilePath(FILE_PATH_LITERAL("spiral_double_scale.png")));
}
TEST_P(LayerTreeHostScrollbarsPixelTest, TransformScale) {
scoped_refptr<SolidColorLayer> background =
CreateSolidColorLayer(gfx::Rect(200, 200), SK_ColorWHITE);
auto scrollbar = base::MakeRefCounted<PaintedScrollbar>(gfx::Size(100, 100));
scoped_refptr<PaintedScrollbarLayer> layer =
PaintedScrollbarLayer::Create(std::move(scrollbar));
layer->SetIsDrawable(true);
layer->SetBounds(gfx::Size(100, 100));
background->AddChild(layer);
// This has a scale of 2, it should still be rendered pixel-perfect, not show
// scaling artifacts
gfx::Transform scale_transform;
scale_transform.Scale(2.0, 2.0);
layer->SetTransform(scale_transform);
RunPixelTest(background,
base::FilePath(FILE_PATH_LITERAL("spiral_double_scale.png")));
}
// Disabled on TSan due to frequent timeouts. crbug.com/848994
// TODO(crbug.com/40256786): currently do not pass on iOS.
#if defined(THREAD_SANITIZER) || BUILDFLAG(IS_IOS)
#define MAYBE_HugeTransformScale DISABLED_HugeTransformScale
#else
#define MAYBE_HugeTransformScale HugeTransformScale
#endif
TEST_P(LayerTreeHostScrollbarsPixelTest, MAYBE_HugeTransformScale) {
scoped_refptr<SolidColorLayer> background =
CreateSolidColorLayer(gfx::Rect(400, 400), SK_ColorWHITE);
auto scrollbar = base::MakeRefCounted<PaintedScrollbar>(gfx::Size(10, 400));
scrollbar->set_paint_scale(1);
scoped_refptr<PaintedScrollbarLayer> layer =
PaintedScrollbarLayer::Create(std::move(scrollbar));
layer->SetIsDrawable(true);
layer->SetBounds(gfx::Size(10, 400));
background->AddChild(layer);
// We want a scale that creates a texture taller than the max texture size. If
// there's no clamping, the texture will be invalid and we'll just get black.
double scale = 64.0;
ASSERT_GT(scale * layer->bounds().height(), max_texture_size_);
// Let's show the bottom right of the layer, so we know the texture wasn't
// just cut off.
layer->SetPosition(
gfx::PointF(-10.f * scale + 400.f, -400.f * scale + 400.f));
gfx::Transform scale_transform;
scale_transform.Scale(scale, scale);
layer->SetTransform(scale_transform);
pixel_comparator_ =
std::make_unique<AlphaDiscardingFuzzyPixelOffByOneComparator>();
base::FilePath expected_result =
base::FilePath(FILE_PATH_LITERAL("spiral_64_scale.png"));
if (use_skia_graphite()) {
expected_result = expected_result.InsertBeforeExtensionASCII("_graphite");
}
if (use_skia_vulkan()) {
expected_result = expected_result.InsertBeforeExtensionASCII("_vk");
}
RunPixelTest(background, expected_result);
}
class LayerTreeHostOverlayScrollbarsPixelTest
: public LayerTreeHostScrollbarsPixelTest {
protected:
LayerTreeHostOverlayScrollbarsPixelTest() = default;
void DidActivateTreeOnThread(LayerTreeHostImpl* host_impl) override {
LayerImpl* layer = host_impl->active_tree()->LayerById(scrollbar_layer_id_);
ToScrollbarLayer(layer)->SetThumbThicknessScaleFactor(thickness_scale_);
}
int scrollbar_layer_id_;
float thickness_scale_;
};
class NinePatchThumbScrollbar : public FakeScrollbar {
public:
NinePatchThumbScrollbar() {
set_should_paint(true);
set_has_thumb(true);
set_orientation(ScrollbarOrientation::kVertical);
set_is_overlay(true);
set_thumb_size(gfx::Size(15, 50));
set_track_rect(gfx::Rect(0, 0, 15, 400));
}
bool UsesNinePatchThumbResource() const override { return true; }
gfx::Size NinePatchThumbCanvasSize() const override {
return gfx::Size(7, 7);
}
gfx::Rect NinePatchThumbAperture() const override {
return gfx::Rect(3, 3, 1, 1);
}
private:
void Paint(PaintCanvas& canvas, const gfx::Rect& rect) override {
// The outside of the rect will be painted with a 1 pixel black, red, then
// blue border. The inside will be solid blue. This will allow the test to
// ensure that scaling the thumb doesn't scale the border at all. Note
// that the inside of the border must be the same color as the center tile
// to prevent an interpolation from being applied.
PaintFlags flags;
flags.setStyle(PaintFlags::kFill_Style);
flags.setStrokeWidth(SkIntToScalar(1));
flags.setColor(SK_ColorBLACK);
gfx::Rect inset_rect = rect;
canvas.drawRect(RectToSkRect(inset_rect), flags);
flags.setColor(SK_ColorRED);
inset_rect.Inset(1);
canvas.drawRect(RectToSkRect(inset_rect), flags);
flags.setColor(SK_ColorBLUE);
inset_rect.Inset(1);
canvas.drawRect(RectToSkRect(inset_rect), flags);
}
~NinePatchThumbScrollbar() override = default;
};
INSTANTIATE_TEST_SUITE_P(All,
LayerTreeHostOverlayScrollbarsPixelTest,
::testing::ValuesIn(viz::GetGpuRendererTypes()),
::testing::PrintToStringParamName());
// viz::GetGpuRendererTypes() can return an empty list on some platforms.
GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(
LayerTreeHostOverlayScrollbarsPixelTest);
// Simulate increasing the thickness of a NinePatchThumbScrollbar. Ensure that
// the scrollbar border remains crisp.
TEST_P(LayerTreeHostOverlayScrollbarsPixelTest, NinePatchScrollbarScaledUp) {
scoped_refptr<SolidColorLayer> background =
CreateSolidColorLayer(gfx::Rect(400, 400), SK_ColorWHITE);
auto scrollbar = base::MakeRefCounted<NinePatchThumbScrollbar>();
scoped_refptr<NinePatchThumbScrollbarLayer> layer =
NinePatchThumbScrollbarLayer::Create(std::move(scrollbar));
scrollbar_layer_id_ = layer->id();
thickness_scale_ = 5.f;
layer->SetIsDrawable(true);
layer->SetBounds(gfx::Size(10, 300));
background->AddChild(layer);
layer->SetPosition(gfx::PointF(185, 10));
RunPixelTest(
background,
base::FilePath(FILE_PATH_LITERAL("overlay_scrollbar_scaled_up.png")));
}
// Simulate decreasing the thickness of a NinePatchThumbScrollbar. Ensure that
// the scrollbar border remains crisp.
TEST_P(LayerTreeHostOverlayScrollbarsPixelTest, NinePatchScrollbarScaledDown) {
scoped_refptr<SolidColorLayer> background =
CreateSolidColorLayer(gfx::Rect(400, 400), SK_ColorWHITE);
auto scrollbar = base::MakeRefCounted<NinePatchThumbScrollbar>();
scoped_refptr<NinePatchThumbScrollbarLayer> layer =
NinePatchThumbScrollbarLayer::Create(std::move(scrollbar));
scrollbar_layer_id_ = layer->id();
thickness_scale_ = 0.4f;
layer->SetIsDrawable(true);
layer->SetBounds(gfx::Size(10, 300));
background->AddChild(layer);
layer->SetPosition(gfx::PointF(185, 10));
RunPixelTest(
background,
base::FilePath(FILE_PATH_LITERAL("overlay_scrollbar_scaled_down.png")));
}
} // namespace
} // namespace cc
#endif // BUILDFLAG(IS_ANDROID)