1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
content / browser / devtools / devtools_video_consumer_unittest.cc [blame]
// Copyright 2018 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <utility>
#include <vector>
#include "base/functional/bind.h"
#include "base/memory/read_only_shared_memory_region.h"
#include "base/test/task_environment.h"
#include "base/time/time.h"
#include "components/viz/common/surfaces/region_capture_bounds.h"
#include "content/browser/devtools/devtools_video_consumer.h"
#include "content/public/test/test_utils.h"
#include "media/base/limits.h"
#include "media/capture/mojom/video_capture_buffer.mojom.h"
#include "media/capture/mojom/video_capture_types.mojom.h"
#include "mojo/public/cpp/bindings/pending_receiver.h"
#include "mojo/public/cpp/bindings/pending_remote.h"
#include "mojo/public/cpp/bindings/receiver.h"
#include "mojo/public/cpp/bindings/remote.h"
#include "testing/gmock/include/gmock/gmock.h"
using testing::_;
namespace content {
namespace {
// Capture parameters.
constexpr gfx::Size kResolution = gfx::Size(320, 180); // Arbitrarily chosen.
constexpr media::VideoPixelFormat kFormat = media::PIXEL_FORMAT_I420;
// Video buffer parameters.
constexpr bool kNotPremapped = false;
// A non-zero FrameSinkId to prevent validation errors when
// DevToolsVideoConsumer::ChangeTarget(viz::FrameSinkId) is called
// (which eventually fails in FrameSinkVideoCapturerStubDispatch::Accept).
constexpr viz::FrameSinkId kInitialFrameSinkId = viz::FrameSinkId(1, 1);
} // namespace
// Mock for the FrameSinkVideoCapturer running in the VIZ process.
class MockFrameSinkVideoCapturer : public viz::mojom::FrameSinkVideoCapturer {
public:
MockFrameSinkVideoCapturer() {}
bool is_bound() const { return receiver_.is_bound(); }
void Bind(
mojo::PendingReceiver<viz::mojom::FrameSinkVideoCapturer> receiver) {
DCHECK(!receiver_.is_bound());
receiver_.Bind(std::move(receiver));
}
void Reset() {
receiver_.reset();
consumer_.reset();
}
// This is never called.
MOCK_METHOD1(SetFormat, void(media::VideoPixelFormat format));
void SetMinCapturePeriod(base::TimeDelta min_capture_period) final {
min_capture_period_ = min_capture_period;
MockSetMinCapturePeriod(min_capture_period_);
}
MOCK_METHOD1(MockSetMinCapturePeriod,
void(base::TimeDelta min_capture_period));
void SetMinSizeChangePeriod(base::TimeDelta min_period) final {
min_period_ = min_period;
MockSetMinSizeChangePeriod(min_period_);
}
MOCK_METHOD1(MockSetMinSizeChangePeriod, void(base::TimeDelta min_period));
void SetResolutionConstraints(const gfx::Size& min_frame_size,
const gfx::Size& max_frame_size,
bool use_fixed_aspect_ratio) final {
min_frame_size_ = min_frame_size;
max_frame_size_ = max_frame_size;
MockSetResolutionConstraints(min_frame_size_, max_frame_size_, true);
}
MOCK_METHOD3(MockSetResolutionConstraints,
void(const gfx::Size& min_frame_size,
const gfx::Size& max_frame_size,
bool use_fixed_aspect_ratio));
// This is never called.
MOCK_METHOD1(SetAutoThrottlingEnabled, void(bool));
void ChangeTarget(const std::optional<viz::VideoCaptureTarget>& target,
uint32_t sub_capture_target_version) final {
frame_sink_id_ = target ? target->frame_sink_id : viz::FrameSinkId();
MockChangeTarget(frame_sink_id_, sub_capture_target_version);
}
MOCK_METHOD2(MockChangeTarget,
void(const viz::FrameSinkId& frame_sink_id,
uint32_t sub_capture_target_version));
void Start(
mojo::PendingRemote<viz::mojom::FrameSinkVideoConsumer> consumer,
viz::mojom::BufferFormatPreference buffer_format_preference) final {
DCHECK(!consumer_);
consumer_.Bind(std::move(consumer));
MockStart(consumer_.get(), buffer_format_preference);
}
MOCK_METHOD2(
MockStart,
void(viz::mojom::FrameSinkVideoConsumer* consumer,
viz::mojom::BufferFormatPreference buffer_format_preference));
void Stop() final {
receiver_.reset();
consumer_.reset();
MockStop();
}
MOCK_METHOD0(MockStop, void());
MOCK_METHOD0(RequestRefreshFrame, void());
MOCK_METHOD2(
CreateOverlay,
void(int32_t stacking_index,
mojo::PendingReceiver<viz::mojom::FrameSinkVideoCaptureOverlay>
receiver));
// Const accessors to get the cached variables.
base::TimeDelta min_capture_period() const { return min_capture_period_; }
base::TimeDelta min_period() const { return min_period_; }
gfx::Size min_frame_size() const { return min_frame_size_; }
gfx::Size max_frame_size() const { return max_frame_size_; }
viz::FrameSinkId frame_sink_id() const { return frame_sink_id_; }
private:
// These variables are cached when they are received from
// DevToolsVideoConsumer.
base::TimeDelta min_capture_period_;
base::TimeDelta min_period_;
gfx::Size min_frame_size_;
gfx::Size max_frame_size_;
viz::FrameSinkId frame_sink_id_;
mojo::Remote<viz::mojom::FrameSinkVideoConsumer> consumer_;
mojo::Receiver<viz::mojom::FrameSinkVideoCapturer> receiver_{this};
};
// Represents the FrameSinkVideoConsumerFrameCallbacks instance in the VIZ
// process.
class MockFrameSinkVideoConsumerFrameCallbacks
: public viz::mojom::FrameSinkVideoConsumerFrameCallbacks {
public:
MockFrameSinkVideoConsumerFrameCallbacks() = default;
void Bind(
mojo::PendingReceiver<viz::mojom::FrameSinkVideoConsumerFrameCallbacks>
receiver) {
receiver_.Bind(std::move(receiver));
}
MOCK_METHOD0(Done, void());
MOCK_METHOD1(ProvideFeedback, void(const media::VideoCaptureFeedback&));
private:
mojo::Receiver<viz::mojom::FrameSinkVideoConsumerFrameCallbacks> receiver_{
this};
};
// Mock for the classes like TracingHandler that receive frames from
// DevToolsVideoConsumer via the OnFrameCapturedCallback.
class MockDevToolsVideoFrameReceiver {
public:
MOCK_METHOD1(OnFrameFromVideoConsumerMock,
void(scoped_refptr<media::VideoFrame> frame));
MockDevToolsVideoFrameReceiver() {}
scoped_refptr<media::VideoFrame> TakeFrameAt(int i) {
return std::move(frames_[i]);
}
void OnFrameFromVideoConsumer(scoped_refptr<media::VideoFrame> frame) {
OnFrameFromVideoConsumerMock(frame);
frames_.push_back(std::move(frame));
}
std::unique_ptr<DevToolsVideoConsumer> CreateDevToolsVideoConsumer() {
return std::make_unique<DevToolsVideoConsumer>(base::BindRepeating(
&MockDevToolsVideoFrameReceiver::OnFrameFromVideoConsumer,
weak_factory_.GetWeakPtr()));
}
private:
std::vector<scoped_refptr<media::VideoFrame>> frames_;
base::WeakPtrFactory<MockDevToolsVideoFrameReceiver> weak_factory_{this};
};
class DevToolsVideoConsumerTest : public testing::Test {
public:
DevToolsVideoConsumerTest() {}
void SetUp() override {
consumer_ = receiver_.CreateDevToolsVideoConsumer();
consumer_->SetFrameSinkId(kInitialFrameSinkId);
}
void SimulateFrameCapture(base::ReadOnlySharedMemoryRegion data) {
mojo::PendingRemote<viz::mojom::FrameSinkVideoConsumerFrameCallbacks>
callbacks_remote;
callbacks.Bind(callbacks_remote.InitWithNewPipeAndPassReceiver());
media::mojom::VideoFrameInfoPtr info = media::mojom::VideoFrameInfo::New(
base::TimeDelta(), media::VideoFrameMetadata(), kFormat, kResolution,
gfx::Rect(kResolution), kNotPremapped, gfx::ColorSpace::CreateREC709(),
nullptr);
consumer_->OnFrameCaptured(
media::mojom::VideoBufferHandle::NewReadOnlyShmemRegion(
std::move(data)),
std::move(info), gfx::Rect(kResolution), std::move(callbacks_remote));
}
void StartCaptureWithMockCapturer() {
consumer_->InnerStartCapture(CreateMockCapturer());
}
bool IsValidMinAndMaxFrameSize(gfx::Size min_frame_size,
gfx::Size max_frame_size) {
return consumer_->IsValidMinAndMaxFrameSize(min_frame_size, max_frame_size);
}
static gfx::Size GetVideoConsumerDefaultMinFrameSize() {
return DevToolsVideoConsumer::kDefaultMinFrameSize;
}
static gfx::Size GetVideoConsumerDefaultMaxFrameSize() {
return DevToolsVideoConsumer::kDefaultMaxFrameSize;
}
// Getters for |consumer_|'s private variables.
base::TimeDelta GetMinCapturePeriod() const {
return consumer_->min_capture_period_;
}
gfx::Size GetMinFrameSize() const { return consumer_->min_frame_size_; }
gfx::Size GetMaxFrameSize() const { return consumer_->max_frame_size_; }
viz::FrameSinkId GetFrameSinkId() const { return consumer_->frame_sink_id_; }
protected:
MockFrameSinkVideoCapturer capturer_;
MockFrameSinkVideoConsumerFrameCallbacks callbacks;
MockDevToolsVideoFrameReceiver receiver_;
std::unique_ptr<DevToolsVideoConsumer> consumer_;
private:
std::unique_ptr<viz::ClientFrameSinkVideoCapturer> CreateMockCapturer() {
return std::make_unique<viz::ClientFrameSinkVideoCapturer>(
base::BindRepeating(
[](base::WeakPtr<DevToolsVideoConsumerTest> self,
mojo::PendingReceiver<viz::mojom::FrameSinkVideoCapturer>
receiver) { self->capturer_.Bind(std::move(receiver)); },
weak_factory_.GetWeakPtr()));
}
base::test::SingleThreadTaskEnvironment task_environment_;
base::WeakPtrFactory<DevToolsVideoConsumerTest> weak_factory_{this};
};
// Tests that the OnFrameFromVideoConsumer callbacks is called when
// OnFrameCaptured is passed a valid buffer with valid mapping.
TEST_F(DevToolsVideoConsumerTest, CallbacksAreCalledWhenBufferValid) {
// On valid buffer the |receiver_| gets a frame via OnFrameFromVideoConsumer.
EXPECT_CALL(receiver_, OnFrameFromVideoConsumerMock(_)).Times(1);
auto region = base::ReadOnlySharedMemoryRegion::Create(
media::VideoFrame::AllocationSize(kFormat, kResolution))
.region;
ASSERT_TRUE(region.IsValid());
SimulateFrameCapture(std::move(region));
base::RunLoop().RunUntilIdle();
}
// Tests that the OnFrameFromVideoConsumer callback is not called when
// OnFrameCaptured is passed a buffer with less-than-expected size.
TEST_F(DevToolsVideoConsumerTest, CallbackIsNotCalledWhenBufferIsTooSmall) {
// On invalid mapping, the |receiver_| doesn't get a frame.
EXPECT_CALL(receiver_, OnFrameFromVideoConsumerMock(_)).Times(0);
constexpr size_t too_few_number_of_bytes = 4;
ASSERT_LT(too_few_number_of_bytes,
media::VideoFrame::AllocationSize(kFormat, kResolution));
auto region =
base::ReadOnlySharedMemoryRegion::Create(too_few_number_of_bytes).region;
ASSERT_TRUE(region.IsValid());
SimulateFrameCapture(std::move(region));
base::RunLoop().RunUntilIdle();
}
// Tests that starting capture calls |capturer_| functions, and capture can be
// restarted. This test is important as it ensures that when restarting capture,
// a FrameSinkVideoCapturerPtrInfo is bound to |capturer_| and it verifies that
// resources used in the previous StartCapture aren't reused.
TEST_F(DevToolsVideoConsumerTest, StartCaptureCallsSetFunctions) {
// Starting capture should call these |capturer_| functions once.
EXPECT_CALL(capturer_, MockSetMinCapturePeriod(_));
EXPECT_CALL(capturer_, MockSetMinSizeChangePeriod(_));
EXPECT_CALL(capturer_, MockSetResolutionConstraints(_, _, _));
EXPECT_CALL(capturer_, MockChangeTarget(_, _));
EXPECT_CALL(capturer_,
MockStart(_, viz::mojom::BufferFormatPreference::kDefault));
StartCaptureWithMockCapturer();
base::RunLoop().RunUntilIdle();
// Stop capturing.
consumer_->StopCapture();
// Reset the mock to allow the next consumer to connect.
capturer_.Reset();
// Start capturing again, and expect that these |capturer_| functions are
// called once. This will re-bind the |capturer_| and ensures that destroyed
// resources aren't being reused.
EXPECT_CALL(capturer_, MockSetMinCapturePeriod(_));
EXPECT_CALL(capturer_, MockSetMinSizeChangePeriod(_));
EXPECT_CALL(capturer_, MockSetResolutionConstraints(_, _, _));
EXPECT_CALL(capturer_, MockChangeTarget(_, _));
EXPECT_CALL(capturer_,
MockStart(_, viz::mojom::BufferFormatPreference::kDefault));
StartCaptureWithMockCapturer();
base::RunLoop().RunUntilIdle();
}
// Tests that calling 'Set' functions in DevToolsVideoConsumer before
// |capturer_| is initialized results in the passed values being cached.
// When capture is later started (and |capturer_| initialized), these cached
// values should be used and sent to the |capturer_|.
TEST_F(DevToolsVideoConsumerTest, CapturerIsPassedCachedValues) {
// These values are chosen so that they are valid, and different from
// the default values in DevToolsVideoConsumer.
constexpr base::TimeDelta kNewMinCapturePeriod = base::TimeDelta();
const gfx::Size kNewMinFrameSize =
gfx::Size(GetVideoConsumerDefaultMinFrameSize().width() + 1,
GetVideoConsumerDefaultMinFrameSize().height() + 1);
const gfx::Size kNewMaxFrameSize =
gfx::Size(GetVideoConsumerDefaultMaxFrameSize().width() + 1,
GetVideoConsumerDefaultMaxFrameSize().width() + 1);
constexpr viz::FrameSinkId kNewFrameSinkId = viz::FrameSinkId(2, 2);
// Right now, |capturer_| has not been created via StartCapture, so
// calling these functions should not call the |capturer_|, but the
// values that are passed in should be cached.
EXPECT_CALL(capturer_, MockSetMinCapturePeriod(_)).Times(0);
EXPECT_CALL(capturer_, MockSetMinSizeChangePeriod(_)).Times(0);
EXPECT_CALL(capturer_, MockSetResolutionConstraints(_, _, _)).Times(0);
EXPECT_CALL(capturer_, MockChangeTarget(_, _)).Times(0);
EXPECT_CALL(capturer_,
MockStart(_, viz::mojom::BufferFormatPreference::kDefault))
.Times(0);
consumer_->SetMinCapturePeriod(kNewMinCapturePeriod);
consumer_->SetMinAndMaxFrameSize(kNewMinFrameSize, kNewMaxFrameSize);
consumer_->SetFrameSinkId(kNewFrameSinkId);
base::RunLoop().RunUntilIdle();
// Verify that new values are cached.
EXPECT_EQ(GetMinCapturePeriod(), kNewMinCapturePeriod);
EXPECT_EQ(GetMinFrameSize(), kNewMinFrameSize);
EXPECT_EQ(GetMaxFrameSize(), kNewMaxFrameSize);
EXPECT_EQ(GetFrameSinkId(), kNewFrameSinkId);
// Starting capture now, will result in the cached values being sent to
// |capturer_|. So, expect that these calls are made and verify the values.
EXPECT_CALL(capturer_, MockSetMinCapturePeriod(_));
EXPECT_CALL(capturer_, MockSetMinSizeChangePeriod(_));
EXPECT_CALL(capturer_, MockSetResolutionConstraints(_, _, _));
EXPECT_CALL(capturer_, MockChangeTarget(_, _));
EXPECT_CALL(capturer_,
MockStart(_, viz::mojom::BufferFormatPreference::kDefault));
StartCaptureWithMockCapturer();
base::RunLoop().RunUntilIdle();
// Verify that the previously cached values are sent to |capturer_|.
EXPECT_EQ(capturer_.min_capture_period(), kNewMinCapturePeriod);
EXPECT_EQ(capturer_.min_frame_size(), kNewMinFrameSize);
EXPECT_EQ(capturer_.max_frame_size(), kNewMaxFrameSize);
EXPECT_EQ(capturer_.frame_sink_id(), kNewFrameSinkId);
}
// Tests that DevToolsVideoConsumer::IsValidMinAndMaxFrameSize adheres to the
// limits set by media::limits::kMaxDimension
TEST_F(DevToolsVideoConsumerTest, IsValidMinAndMaxFrameSize) {
// Choosing valid frame sizes with
// kNormalMinSize.height() > kNormalMaxSize.width() so that width
// and height are not interchanged in this test.
constexpr gfx::Size kNormalMinSize = gfx::Size(50, 150);
constexpr gfx::Size kNormalMaxSize = gfx::Size(100, 200);
// Testing success cases.
EXPECT_TRUE(IsValidMinAndMaxFrameSize(kNormalMinSize, kNormalMaxSize));
// Non-zero frames that are equal should pass.
EXPECT_TRUE(IsValidMinAndMaxFrameSize(kNormalMinSize, kNormalMaxSize));
// Swapping width and height of frames should pass.
EXPECT_TRUE(IsValidMinAndMaxFrameSize(
gfx::Size(kNormalMinSize.height(), kNormalMinSize.width()),
gfx::Size(kNormalMaxSize.height(), kNormalMaxSize.width())));
// Testing failure cases.
// |min_frame_size|.width() should be > 0
EXPECT_FALSE(IsValidMinAndMaxFrameSize(gfx::Size(0, kNormalMinSize.height()),
kNormalMaxSize));
// |min_frame_size|.height() should be > 0
EXPECT_FALSE(IsValidMinAndMaxFrameSize(gfx::Size(kNormalMinSize.width(), 0),
kNormalMaxSize));
// |min_frame_size|.width() should be <= |max_frame_size|.width()
EXPECT_FALSE(IsValidMinAndMaxFrameSize(
gfx::Size(kNormalMaxSize.width() + 1, kNormalMinSize.height()),
kNormalMaxSize));
// |max_frame_size|.height() should be <= |max_frame_size|.height()
EXPECT_FALSE(IsValidMinAndMaxFrameSize(
gfx::Size(kNormalMinSize.width(), kNormalMaxSize.height() + 1),
kNormalMaxSize));
// |max_frame_size|.height() should be <= media::limits::kMaxDimension
EXPECT_FALSE(IsValidMinAndMaxFrameSize(
kNormalMinSize,
gfx::Size(kNormalMaxSize.width(), media::limits::kMaxDimension + 1)));
// |max_frame_size|.width() should be <= media::limits::kMaxDimension
EXPECT_FALSE(IsValidMinAndMaxFrameSize(
kNormalMinSize,
gfx::Size(media::limits::kMaxDimension + 1, kNormalMaxSize.height())));
}
} // namespace content