1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
content / browser / download / download_manager_impl_unittest.cc [blame]
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "content/browser/download/download_manager_impl.h"
#include <stddef.h>
#include <stdint.h>
#include <map>
#include <memory>
#include <optional>
#include <set>
#include <string>
#include <tuple>
#include <utility>
#include "base/containers/contains.h"
#include "base/files/scoped_temp_dir.h"
#include "base/functional/bind.h"
#include "base/functional/callback_helpers.h"
#include "base/memory/raw_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/run_loop.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/gmock_callback_support.h"
#include "base/test/scoped_feature_list.h"
#include "base/uuid.h"
#include "build/build_config.h"
#include "components/download/public/common/download_create_info.h"
#include "components/download/public/common/download_features.h"
#include "components/download/public/common/download_file_factory.h"
#include "components/download/public/common/download_interrupt_reasons.h"
#include "components/download/public/common/download_item.h"
#include "components/download/public/common/download_item_factory.h"
#include "components/download/public/common/download_item_impl.h"
#include "components/download/public/common/download_item_impl_delegate.h"
#include "components/download/public/common/mock_download_file.h"
#include "components/download/public/common/mock_download_item_impl.h"
#include "components/download/public/common/mock_input_stream.h"
#include "content/browser/download/embedder_download_data.pb.h"
#include "content/public/browser/browser_context.h"
#include "content/public/browser/download_manager_delegate.h"
#include "content/public/browser/storage_partition.h"
#include "content/public/test/browser_task_environment.h"
#include "content/public/test/test_browser_context.h"
#include "content/test/storage_partition_test_helpers.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/origin.h"
using base::test::RunOnceCallback;
using ::testing::_;
using ::testing::AllOf;
using ::testing::DoAll;
using ::testing::Eq;
using ::testing::Ref;
using ::testing::Return;
using ::testing::ReturnRef;
using ::testing::ReturnRefOfCopy;
using ::testing::SetArgPointee;
using ::testing::StrictMock;
namespace content {
namespace {
const char kGuid[] = "8DF158E8-C980-4618-BB03-EBA3242EB48B";
bool URLAlwaysSafe(int render_process_id, const GURL& url) {
return true;
}
class MockDownloadManagerDelegate : public DownloadManagerDelegate {
public:
MockDownloadManagerDelegate();
~MockDownloadManagerDelegate() override;
MOCK_METHOD0(Shutdown, void());
MOCK_METHOD1(OnDownloadCanceledAtShutdown,
void(download::DownloadItem* item));
void GetNextId(DownloadIdCallback cb) override { GetNextId_(cb); }
MOCK_METHOD1(GetNextId_, void(DownloadIdCallback&));
MOCK_METHOD2(DetermineDownloadTarget,
bool(download::DownloadItem*,
download::DownloadTargetCallback*));
MOCK_METHOD1(ShouldOpenFileBasedOnExtension, bool(const base::FilePath&));
bool ShouldCompleteDownload(download::DownloadItem* item,
base::OnceClosure cb) override {
return ShouldCompleteDownload_(item, cb);
}
MOCK_METHOD2(ShouldCompleteDownload_,
bool(download::DownloadItem*, base::OnceClosure&));
bool ShouldOpenDownload(download::DownloadItem* item,
DownloadOpenDelayedCallback cb) override {
return ShouldOpenDownload_(item, cb);
}
MOCK_METHOD2(ShouldOpenDownload_,
bool(download::DownloadItem*, DownloadOpenDelayedCallback&));
MOCK_METHOD3(GetSaveDir,
void(BrowserContext*, base::FilePath*, base::FilePath*));
MOCK_METHOD5(ChooseSavePath,
void(WebContents*,
const base::FilePath&,
const base::FilePath::StringType&,
bool,
SavePackagePathPickedCallback));
MOCK_METHOD0(ApplicationClientIdForFileScanning, std::string());
MOCK_METHOD1(AttachExtraInfo, void(download::DownloadItem*));
};
MockDownloadManagerDelegate::MockDownloadManagerDelegate() {}
MockDownloadManagerDelegate::~MockDownloadManagerDelegate() {}
class MockDownloadItemFactory final : public download::DownloadItemFactory {
public:
MockDownloadItemFactory();
MockDownloadItemFactory(const MockDownloadItemFactory&) = delete;
MockDownloadItemFactory& operator=(const MockDownloadItemFactory&) = delete;
~MockDownloadItemFactory() override;
// Access to map of created items.
// TODO(rdsmith): Could add type (save page, persisted, etc.)
// functionality if it's ever needed by consumers.
// Returns NULL if no item of that id is present.
download::MockDownloadItemImpl* GetItem(int id);
// Remove and return an item made by the factory.
// Generally used during teardown.
download::MockDownloadItemImpl* PopItem();
// Should be called when the item of this id is removed so that
// we don't keep dangling pointers.
void RemoveItem(int id);
// Overridden methods from DownloadItemFactory.
download::DownloadItemImpl* CreatePersistedItem(
download::DownloadItemImplDelegate* delegate,
const std::string& guid,
uint32_t download_id,
const base::FilePath& current_path,
const base::FilePath& target_path,
const std::vector<GURL>& url_chain,
const GURL& referrer_url,
const std::string& serialized_embedder_download_data,
const GURL& tab_url,
const GURL& tab_referrer_url,
const std::optional<url::Origin>& request_initiator,
const std::string& mime_type,
const std::string& original_mime_type,
base::Time start_time,
base::Time end_time,
const std::string& etag,
const std::string& last_modified,
int64_t received_bytes,
int64_t total_bytes,
const std::string& hash,
download::DownloadItem::DownloadState state,
download::DownloadDangerType danger_type,
download::DownloadInterruptReason interrupt_reason,
bool opened,
base::Time last_access_time,
bool transient,
const std::vector<download::DownloadItem::ReceivedSlice>& received_slices)
override;
download::DownloadItemImpl* CreateActiveItem(
download::DownloadItemImplDelegate* delegate,
uint32_t download_id,
const download::DownloadCreateInfo& info) override;
download::DownloadItemImpl* CreateSavePageItem(
download::DownloadItemImplDelegate* delegate,
uint32_t download_id,
const base::FilePath& path,
const GURL& url,
const std::string& mime_type,
download::DownloadJob::CancelRequestCallback cancel_request_callback)
override;
void set_is_download_persistent(bool is_download_persistent) {
is_download_persistent_ = is_download_persistent;
}
base::WeakPtr<MockDownloadItemFactory> AsWeakPtr() {
return weak_ptr_factory_.GetWeakPtr();
}
private:
std::map<uint32_t, raw_ptr<download::MockDownloadItemImpl, CtnExperimental>>
items_;
download::DownloadItemImplDelegate item_delegate_;
bool is_download_persistent_;
base::WeakPtrFactory<MockDownloadItemFactory> weak_ptr_factory_{this};
};
MockDownloadItemFactory::MockDownloadItemFactory()
: is_download_persistent_(false) {}
MockDownloadItemFactory::~MockDownloadItemFactory() {}
download::MockDownloadItemImpl* MockDownloadItemFactory::GetItem(int id) {
if (!base::Contains(items_, id)) {
return nullptr;
}
return items_[id];
}
download::MockDownloadItemImpl* MockDownloadItemFactory::PopItem() {
if (items_.empty())
return nullptr;
auto first_item = items_.begin();
download::MockDownloadItemImpl* result = first_item->second;
items_.erase(first_item);
return result;
}
void MockDownloadItemFactory::RemoveItem(int id) {
DCHECK(base::Contains(items_, id));
items_.erase(id);
}
download::DownloadItemImpl* MockDownloadItemFactory::CreatePersistedItem(
download::DownloadItemImplDelegate* delegate,
const std::string& guid,
uint32_t download_id,
const base::FilePath& current_path,
const base::FilePath& target_path,
const std::vector<GURL>& url_chain,
const GURL& referrer_url,
const std::string& serialized_embedder_download_data,
const GURL& tab_url,
const GURL& tab_referrer_url,
const std::optional<url::Origin>& request_initiator,
const std::string& mime_type,
const std::string& original_mime_type,
base::Time start_time,
base::Time end_time,
const std::string& etag,
const std::string& last_modified,
int64_t received_bytes,
int64_t total_bytes,
const std::string& hash,
download::DownloadItem::DownloadState state,
download::DownloadDangerType danger_type,
download::DownloadInterruptReason interrupt_reason,
bool opened,
base::Time last_access_time,
bool transient,
const std::vector<download::DownloadItem::ReceivedSlice>& received_slices) {
DCHECK(!base::Contains(items_, download_id));
download::MockDownloadItemImpl* result =
new StrictMock<download::MockDownloadItemImpl>(&item_delegate_);
EXPECT_CALL(*result, GetId())
.WillRepeatedly(Return(download_id));
EXPECT_CALL(*result, GetGuid()).WillRepeatedly(ReturnRefOfCopy(guid));
EXPECT_CALL(*result, IsTransient()).WillRepeatedly(Return(transient));
items_[download_id] = result;
return result;
}
download::DownloadItemImpl* MockDownloadItemFactory::CreateActiveItem(
download::DownloadItemImplDelegate* delegate,
uint32_t download_id,
const download::DownloadCreateInfo& info) {
DCHECK(!base::Contains(items_, download_id));
download::MockDownloadItemImpl* result =
new StrictMock<download::MockDownloadItemImpl>(&item_delegate_);
EXPECT_CALL(*result, GetId())
.WillRepeatedly(Return(download_id));
EXPECT_CALL(*result, GetGuid())
.WillRepeatedly(
ReturnRefOfCopy(base::Uuid::GenerateRandomV4().AsLowercaseString()));
EXPECT_CALL(*result, GetUrlChain())
.WillRepeatedly(ReturnRefOfCopy(std::vector<GURL>()));
EXPECT_CALL(*result, GetReferrerUrl())
.WillRepeatedly(ReturnRefOfCopy(GURL()));
EXPECT_CALL(*result, GetTabUrl()).WillRepeatedly(ReturnRefOfCopy(GURL()));
EXPECT_CALL(*result, GetTabReferrerUrl())
.WillRepeatedly(ReturnRefOfCopy(GURL()));
EXPECT_CALL(*result, GetETag())
.WillRepeatedly(ReturnRefOfCopy(std::string()));
EXPECT_CALL(*result, GetLastModifiedTime())
.WillRepeatedly(ReturnRefOfCopy(std::string()));
EXPECT_CALL(*result, GetMimeType()).WillRepeatedly(Return(std::string()));
EXPECT_CALL(*result, GetOriginalMimeType())
.WillRepeatedly(Return(std::string()));
EXPECT_CALL(*result, GetTotalBytes()).WillRepeatedly(Return(0));
EXPECT_CALL(*result, GetFullPath())
.WillRepeatedly(
ReturnRefOfCopy(base::FilePath(FILE_PATH_LITERAL("foo"))));
EXPECT_CALL(*result, GetTargetFilePath())
.WillRepeatedly(
ReturnRefOfCopy(base::FilePath(FILE_PATH_LITERAL("foo"))));
EXPECT_CALL(*result, GetReceivedBytes()).WillRepeatedly(Return(0));
EXPECT_CALL(*result, GetStartTime()).WillRepeatedly(Return(base::Time()));
EXPECT_CALL(*result, GetEndTime()).WillRepeatedly(Return(base::Time()));
EXPECT_CALL(*result, GetReceivedSlices())
.WillRepeatedly(ReturnRefOfCopy(
std::vector<download::DownloadItem::ReceivedSlice>()));
EXPECT_CALL(*result, GetHash())
.WillRepeatedly(ReturnRefOfCopy(std::string()));
EXPECT_CALL(*result, GetState())
.WillRepeatedly(Return(download::DownloadItem::IN_PROGRESS));
EXPECT_CALL(*result, GetDangerType())
.WillRepeatedly(Return(download::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS));
EXPECT_CALL(*result, GetLastReason())
.WillRepeatedly(Return(download::DOWNLOAD_INTERRUPT_REASON_NONE));
EXPECT_CALL(*result, IsPaused()).WillRepeatedly(Return(false));
EXPECT_CALL(*result, IsTemporary()).WillRepeatedly(Return(false));
EXPECT_CALL(*result, IsTransient()).WillRepeatedly(Return(info.transient));
if (is_download_persistent_) {
EXPECT_CALL(*result, RemoveObserver(_));
EXPECT_CALL(*result, AddObserver(_));
}
items_[download_id] = result;
// Active items are created and then immediately are called to start
// the download.
EXPECT_CALL(*result, MockStart(_));
return result;
}
download::DownloadItemImpl* MockDownloadItemFactory::CreateSavePageItem(
download::DownloadItemImplDelegate* delegate,
uint32_t download_id,
const base::FilePath& path,
const GURL& url,
const std::string& mime_type,
download::DownloadJob::CancelRequestCallback cancel_request_callback) {
DCHECK(!base::Contains(items_, download_id));
download::MockDownloadItemImpl* result =
new StrictMock<download::MockDownloadItemImpl>(&item_delegate_);
EXPECT_CALL(*result, GetId())
.WillRepeatedly(Return(download_id));
items_[download_id] = result;
return result;
}
class MockDownloadFileFactory final : public download::DownloadFileFactory {
public:
MockDownloadFileFactory() {}
~MockDownloadFileFactory() override {}
// Overridden method from DownloadFileFactory
MOCK_METHOD2(MockCreateFile,
download::MockDownloadFile*(const download::DownloadSaveInfo&,
download::InputStream*));
download::DownloadFile* CreateFile(
std::unique_ptr<download::DownloadSaveInfo> save_info,
const base::FilePath& default_download_directory,
std::unique_ptr<download::InputStream> stream,
uint32_t download_id,
const base::FilePath& duplicate_download_file_path,
base::WeakPtr<download::DownloadDestinationObserver> observer) override {
return MockCreateFile(*save_info, stream.get());
}
base::WeakPtr<MockDownloadFileFactory> AsWeakPtr() {
return weak_ptr_factory_.GetWeakPtr();
}
private:
base::WeakPtrFactory<MockDownloadFileFactory> weak_ptr_factory_{this};
};
class MockDownloadManagerObserver : public DownloadManager::Observer {
public:
MockDownloadManagerObserver() {}
~MockDownloadManagerObserver() override {}
MOCK_METHOD2(OnDownloadCreated,
void(DownloadManager*, download::DownloadItem*));
MOCK_METHOD1(ManagerGoingDown, void(DownloadManager*));
MOCK_METHOD2(SelectFileDialogDisplayed, void(DownloadManager*, int32_t));
};
class TestInProgressManager : public download::InProgressDownloadManager {
public:
TestInProgressManager();
~TestInProgressManager() override = default;
std::vector<std::unique_ptr<download::DownloadItemImpl>>
TakeInProgressDownloads() override;
void AddDownloadItem(std::unique_ptr<download::DownloadItemImpl> item);
private:
std::vector<std::unique_ptr<download::DownloadItemImpl>> download_items_;
};
TestInProgressManager::TestInProgressManager()
: download::InProgressDownloadManager(
nullptr,
base::FilePath(),
nullptr,
download::InProgressDownloadManager::IsOriginSecureCallback(),
base::BindRepeating(&URLAlwaysSafe),
/*wake_lock_provider_binder*/ base::NullCallback()) {}
void TestInProgressManager::AddDownloadItem(
std::unique_ptr<download::DownloadItemImpl> item) {
download_items_.emplace_back(std::move(item));
}
std::vector<std::unique_ptr<download::DownloadItemImpl>>
TestInProgressManager::TakeInProgressDownloads() {
return std::move(download_items_);
}
} // namespace
class DownloadManagerTest : public testing::Test {
public:
static const char* kTestData;
static const size_t kTestDataLen;
DownloadManagerTest()
: callback_called_(false),
target_disposition_(
download::DownloadItem::TARGET_DISPOSITION_OVERWRITE),
danger_type_(download::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS),
interrupt_reason_(download::DOWNLOAD_INTERRUPT_REASON_NONE),
next_download_id_(0) {}
DownloadManagerTest(const DownloadManagerTest&) = delete;
DownloadManagerTest& operator=(const DownloadManagerTest&) = delete;
// We tear down everything in TearDown().
~DownloadManagerTest() override {}
// Create a MockDownloadItemFactory and MockDownloadManagerDelegate,
// then create a DownloadManager that points
// at all of those.
void SetUp() override {
DCHECK(!download_manager_);
mock_download_item_factory_ = (new MockDownloadItemFactory())->AsWeakPtr();
mock_download_file_factory_ = (new MockDownloadFileFactory())->AsWeakPtr();
mock_download_manager_delegate_ =
std::make_unique<StrictMock<MockDownloadManagerDelegate>>();
EXPECT_CALL(*mock_download_manager_delegate_.get(), Shutdown())
.WillOnce(Return());
browser_context_ = std::make_unique<TestBrowserContext>();
download_manager_ =
std::make_unique<DownloadManagerImpl>(browser_context_.get());
download_manager_->SetDownloadItemFactoryForTesting(
std::unique_ptr<download::DownloadItemFactory>(
mock_download_item_factory_.get()));
download_manager_->SetDownloadFileFactoryForTesting(
std::unique_ptr<download::DownloadFileFactory>(
mock_download_file_factory_.get()));
observer_ = std::make_unique<MockDownloadManagerObserver>();
download_manager_->AddObserver(observer_.get());
download_manager_->SetDelegate(mock_download_manager_delegate_.get());
download_urls_.push_back(GURL("http://www.url1.com"));
download_urls_.push_back(GURL("http://www.url2.com"));
download_urls_.push_back(GURL("http://www.url3.com"));
download_urls_.push_back(GURL("http://www.url4.com"));
}
void TearDown() override {
while (download::MockDownloadItemImpl* item =
mock_download_item_factory_->PopItem()) {
EXPECT_CALL(*item, GetState())
.WillOnce(Return(download::DownloadItem::CANCELLED));
}
EXPECT_CALL(GetMockObserver(), ManagerGoingDown(download_manager_.get()))
.WillOnce(Return());
download_manager_->Shutdown();
download_manager_.reset();
base::RunLoop().RunUntilIdle();
ASSERT_FALSE(mock_download_item_factory_);
mock_download_manager_delegate_.reset();
download_urls_.clear();
}
// Returns download id.
download::MockDownloadItemImpl& AddItemToManager() {
download::DownloadCreateInfo info;
// Args are ignored except for download id, so everything else can be
// null.
uint32_t id = next_download_id_;
++next_download_id_;
EXPECT_CALL(*mock_download_manager_delegate_, AttachExtraInfo(_));
download_manager_->CreateActiveItem(id, info);
DCHECK(mock_download_item_factory_->GetItem(id));
download::MockDownloadItemImpl& item(
*mock_download_item_factory_->GetItem(id));
// Satisfy expectation. If the item is created in StartDownload(),
// we call Start on it immediately, so we need to set that expectation
// in the factory.
item.Start(std::unique_ptr<download::DownloadFile>(), base::DoNothing(),
info, download::URLLoaderFactoryProvider::GetNullPtr());
DCHECK(id < download_urls_.size());
EXPECT_CALL(item, GetURL()).WillRepeatedly(ReturnRef(download_urls_[id]));
return item;
}
// Helper function to create a download item.
download::DownloadItem* CreateDownloadItem(
const base::Time& start_time,
const std::vector<GURL>& url_chain,
download::DownloadItem::DownloadState download_state) {
download::DownloadItem* download_item =
download_manager_->CreateDownloadItem(
kGuid, 10, base::FilePath(), base::FilePath(), url_chain,
GURL("http://example.com/a"),
StoragePartitionConfig::CreateDefault(browser_context_.get()),
GURL("http://example.com/a"), GURL("http://example.com/a"),
url::Origin::Create(GURL("http://example.com/")),
"application/octet-stream", "application/octet-stream", start_time,
base::Time::Now(), std::string(), std::string(), 10, 10,
std::string(), download_state,
download::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
download::DOWNLOAD_INTERRUPT_REASON_SERVER_FAILED, false,
base::Time::Now(), true,
std::vector<download::DownloadItem::ReceivedSlice>());
return download_item;
}
download::MockDownloadItemImpl& GetMockDownloadItem(int id) {
download::MockDownloadItemImpl* itemp =
mock_download_item_factory_->GetItem(id);
DCHECK(itemp);
return *itemp;
}
void RemoveMockDownloadItem(int id) {
// Owned by DownloadManager; should be deleted there.
mock_download_item_factory_->RemoveItem(id);
}
MockDownloadManagerDelegate& GetMockDownloadManagerDelegate() {
return *mock_download_manager_delegate_;
}
MockDownloadManagerObserver& GetMockObserver() {
return *observer_;
}
void DownloadTargetDeterminedCallback(
download::DownloadTargetInfo target_info) {
callback_called_ = true;
target_path_ = target_info.target_path;
target_disposition_ = target_info.target_disposition;
danger_type_ = target_info.danger_type;
intermediate_path_ = target_info.intermediate_path;
mime_type_ = target_info.mime_type;
interrupt_reason_ = target_info.interrupt_reason;
}
void DetermineDownloadTarget(download::DownloadItemImpl* item) {
download_manager_->DetermineDownloadTarget(
item,
base::BindOnce(&DownloadManagerTest::DownloadTargetDeterminedCallback,
base::Unretained(this)));
}
void OnInProgressDownloadManagerInitialized() {
download_manager_->OnDownloadsInitialized();
}
void OnHistoryDBInitialized() {
download_manager_->PostInitialization(
DownloadManager::DOWNLOAD_INITIALIZATION_DEPENDENCY_HISTORY_DB);
}
void SetInProgressDownloadManager(
std::unique_ptr<download::InProgressDownloadManager> manager) {
download_manager_->in_progress_manager_ = std::move(manager);
}
protected:
// Key test variable; we'll keep it available to sub-classes.
std::unique_ptr<DownloadManagerImpl> download_manager_;
base::WeakPtr<MockDownloadFileFactory> mock_download_file_factory_;
base::WeakPtr<MockDownloadItemFactory> mock_download_item_factory_;
// Target determined callback.
bool callback_called_;
base::FilePath target_path_;
download::DownloadItem::TargetDisposition target_disposition_;
download::DownloadDangerType danger_type_;
std::string mime_type_;
base::FilePath intermediate_path_;
download::DownloadInterruptReason interrupt_reason_;
std::vector<GURL> download_urls_;
private:
BrowserTaskEnvironment task_environment_;
std::unique_ptr<MockDownloadManagerDelegate> mock_download_manager_delegate_;
std::unique_ptr<MockDownloadManagerObserver> observer_;
std::unique_ptr<TestBrowserContext> browser_context_;
uint32_t next_download_id_;
};
// Confirm the appropriate invocations occur when you start a download.
TEST_F(DownloadManagerTest, StartDownload) {
std::unique_ptr<download::DownloadCreateInfo> info(
new download::DownloadCreateInfo);
// Random value, a non 0 value means history db is properly loaded, and new
// downloads should be persisted to the in-progress db.
uint32_t local_id(5);
base::FilePath download_path(FILE_PATH_LITERAL("download/path"));
OnInProgressDownloadManagerInitialized();
EXPECT_FALSE(download_manager_->GetDownload(local_id));
EXPECT_CALL(GetMockObserver(), OnDownloadCreated(download_manager_.get(), _))
.WillOnce(Return());
EXPECT_CALL(GetMockDownloadManagerDelegate(), GetNextId_(_))
.WillOnce(RunOnceCallback<0>(local_id));
EXPECT_CALL(GetMockDownloadManagerDelegate(), GetSaveDir(_, _, _));
EXPECT_CALL(GetMockDownloadManagerDelegate(),
ApplicationClientIdForFileScanning())
.WillRepeatedly(Return("client-id"));
download::MockDownloadFile* mock_file = new download::MockDownloadFile;
auto input_stream = std::make_unique<download::MockInputStream>();
EXPECT_CALL(*input_stream, IsEmpty()).WillRepeatedly(Return(false));
EXPECT_CALL(*mock_download_file_factory_.get(),
MockCreateFile(Ref(*info->save_info.get()), input_stream.get()))
.WillOnce(Return(mock_file));
mock_download_item_factory_->set_is_download_persistent(true);
EXPECT_CALL(GetMockDownloadManagerDelegate(), AttachExtraInfo(_));
download_manager_->StartDownload(
std::move(info), std::move(input_stream),
download::DownloadUrlParameters::OnStartedCallback());
EXPECT_TRUE(download_manager_->GetDownload(local_id));
}
// Test the case that a new download is started when history db failed to
// initialize.
TEST_F(DownloadManagerTest, StartDownloadWithoutHistoryDB) {
std::unique_ptr<download::DownloadCreateInfo> info(
new download::DownloadCreateInfo);
base::FilePath download_path(FILE_PATH_LITERAL("download/path"));
OnInProgressDownloadManagerInitialized();
EXPECT_FALSE(download_manager_->GetDownload(1));
EXPECT_CALL(GetMockObserver(), OnDownloadCreated(download_manager_.get(), _))
.WillOnce(Return());
// Returning kInvalidId to indicate that the history db failed.
EXPECT_CALL(GetMockDownloadManagerDelegate(), GetNextId_(_))
.WillOnce(RunOnceCallback<0>(download::DownloadItem::kInvalidId));
EXPECT_CALL(GetMockDownloadManagerDelegate(), GetSaveDir(_, _, _));
EXPECT_CALL(GetMockDownloadManagerDelegate(),
ApplicationClientIdForFileScanning())
.WillRepeatedly(Return("client-id"));
download::MockDownloadFile* mock_file = new download::MockDownloadFile;
auto input_stream = std::make_unique<download::MockInputStream>();
EXPECT_CALL(*input_stream, IsEmpty()).WillRepeatedly(Return(false));
EXPECT_CALL(*mock_download_file_factory_.get(),
MockCreateFile(Ref(*info->save_info.get()), input_stream.get()))
.WillOnce(Return(mock_file));
EXPECT_CALL(GetMockDownloadManagerDelegate(), AttachExtraInfo(_));
download_manager_->StartDownload(
std::move(info), std::move(input_stream),
download::DownloadUrlParameters::OnStartedCallback());
EXPECT_TRUE(download_manager_->GetDownload(1));
}
// Confirm that calling DetermineDownloadTarget behaves properly if the delegate
// blocks starting.
TEST_F(DownloadManagerTest, DetermineDownloadTarget_True) {
// Put a mock we have a handle to on the download manager.
download::MockDownloadItemImpl& item(AddItemToManager());
EXPECT_CALL(item, GetState())
.WillRepeatedly(Return(download::DownloadItem::IN_PROGRESS));
EXPECT_CALL(GetMockDownloadManagerDelegate(),
DetermineDownloadTarget(&item, _))
.WillOnce(Return(true));
DetermineDownloadTarget(&item);
}
// Confirm that calling DetermineDownloadTarget behaves properly if the delegate
// allows starting. This also tests OnDownloadTargetDetermined.
TEST_F(DownloadManagerTest, DetermineDownloadTarget_False) {
// Put a mock we have a handle to on the download manager.
download::MockDownloadItemImpl& item(AddItemToManager());
base::FilePath path(FILE_PATH_LITERAL("random_filepath.txt"));
EXPECT_CALL(GetMockDownloadManagerDelegate(),
DetermineDownloadTarget(&item, _))
.WillOnce(Return(false));
EXPECT_CALL(item, GetForcedFilePath())
.WillOnce(ReturnRef(path));
// Confirm that the callback was called with the right values in this case.
DetermineDownloadTarget(&item);
EXPECT_TRUE(callback_called_);
EXPECT_EQ(path, target_path_);
EXPECT_EQ(download::DownloadItem::TARGET_DISPOSITION_OVERWRITE,
target_disposition_);
EXPECT_EQ(download::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS, danger_type_);
EXPECT_EQ(path, intermediate_path_);
EXPECT_EQ(download::DOWNLOAD_INTERRUPT_REASON_NONE, interrupt_reason_);
}
TEST_F(DownloadManagerTest, GetDownloadByGuid) {
for (uint32_t i = 0; i < 4; ++i)
AddItemToManager();
download::MockDownloadItemImpl& item = GetMockDownloadItem(0);
download::DownloadItem* result =
download_manager_->GetDownloadByGuid(item.GetGuid());
ASSERT_TRUE(result);
ASSERT_EQ(static_cast<download::DownloadItem*>(&item), result);
ASSERT_FALSE(download_manager_->GetDownloadByGuid(""));
std::vector<GURL> url_chain;
url_chain.emplace_back("http://example.com/1.zip");
EXPECT_CALL(GetMockObserver(), OnDownloadCreated(download_manager_.get(), _));
EXPECT_CALL(GetMockDownloadManagerDelegate(), AttachExtraInfo(_));
download::DownloadItem* persisted_item = CreateDownloadItem(
base::Time::Now(), url_chain, download::DownloadItem::INTERRUPTED);
ASSERT_TRUE(persisted_item);
ASSERT_EQ(persisted_item, download_manager_->GetDownloadByGuid(kGuid));
}
namespace {
base::RepeatingCallback<bool(const GURL&)> GetSingleURLFilter(const GURL& url) {
return base::BindRepeating(
[](const GURL& a, const GURL& b) { return a == b; }, url);
}
} // namespace
// Confirm that only downloads with the specified URL are removed.
TEST_F(DownloadManagerTest, RemoveDownloadsByURL) {
base::Time now(base::Time::Now());
for (uint32_t i = 0; i < 2; ++i) {
download::MockDownloadItemImpl& item(AddItemToManager());
EXPECT_CALL(item, GetStartTime()).WillRepeatedly(Return(now));
EXPECT_CALL(item, GetState())
.WillRepeatedly(Return(download::DownloadItem::COMPLETE));
}
EXPECT_CALL(GetMockDownloadItem(0), Remove());
EXPECT_CALL(GetMockDownloadItem(1), Remove()).Times(0);
base::RepeatingCallback<bool(const GURL&)> url_filter =
GetSingleURLFilter(download_urls_[0]);
int remove_count = download_manager_->RemoveDownloadsByURLAndTime(
std::move(url_filter), base::Time(), base::Time::Max());
EXPECT_EQ(remove_count, 1);
}
// Confirm that in-progress downloads will be taken and managed by
// DownloadManager.
TEST_F(DownloadManagerTest, OnInProgressDownloadsLoaded) {
auto in_progress_manager = std::make_unique<TestInProgressManager>();
std::vector<GURL> url_chain;
url_chain.emplace_back("http://example.com/1.zip");
auto storage_partition_config = StoragePartitionConfig::CreateDefault(
download_manager_->GetBrowserContext());
auto in_progress_item = std::make_unique<download::DownloadItemImpl>(
in_progress_manager.get(), kGuid, 10, base::FilePath(), base::FilePath(),
url_chain, GURL("http://example.com/a"),
download_manager_->StoragePartitionConfigToSerializedEmbedderDownloadData(
storage_partition_config),
GURL("http://example.com/a"), GURL("http://example.com/a"),
url::Origin::Create(GURL("http://example.com")),
"application/octet-stream", "application/octet-stream", base::Time::Now(),
base::Time::Now(), std::string(), std::string(), 10, 10, 0, std::string(),
download::DownloadItem::INTERRUPTED,
download::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
download::DOWNLOAD_INTERRUPT_REASON_SERVER_FAILED, false, false, false,
base::Time::Now(), true,
std::vector<download::DownloadItem::ReceivedSlice>(),
download::kInvalidRange, download::kInvalidRange,
nullptr /* download_entry */);
in_progress_manager->AddDownloadItem(std::move(in_progress_item));
SetInProgressDownloadManager(std::move(in_progress_manager));
EXPECT_CALL(GetMockObserver(), OnDownloadCreated(download_manager_.get(), _))
.WillOnce(Return());
OnInProgressDownloadManagerInitialized();
ASSERT_TRUE(download_manager_->GetDownloadByGuid(kGuid));
std::vector<raw_ptr<download::DownloadItem, VectorExperimental>> vector;
download_manager_->GetAllDownloads(&vector);
ASSERT_EQ(0u, vector.size());
EXPECT_CALL(GetMockDownloadManagerDelegate(), GetNextId_(_))
.WillOnce(RunOnceCallback<0>(1));
EXPECT_CALL(GetMockDownloadManagerDelegate(), AttachExtraInfo(_));
OnHistoryDBInitialized();
ASSERT_TRUE(download_manager_->GetDownloadByGuid(kGuid));
download::DownloadItem* download =
download_manager_->GetDownloadByGuid(kGuid);
download_manager_->GetAllDownloads(&vector);
ASSERT_EQ(1u, vector.size());
download->Remove();
ASSERT_FALSE(download_manager_->GetDownloadByGuid(kGuid));
}
TEST_F(DownloadManagerTest,
StoragePartitionConfigAndEmbedderDownloadDataConversions) {
// Check that serializing then deserializing produces the same
// StoragePartitionConfig.
auto default_spc = StoragePartitionConfig::CreateDefault(
download_manager_->GetBrowserContext());
std::string serialized_default_spc =
download_manager_->StoragePartitionConfigToSerializedEmbedderDownloadData(
default_spc);
ASSERT_TRUE(!serialized_default_spc.empty());
auto deserialized_default_spc =
download_manager_->SerializedEmbedderDownloadDataToStoragePartitionConfig(
serialized_default_spc);
EXPECT_EQ(default_spc, deserialized_default_spc);
// Check that a given proto::EmbedderDownloadData produces the expected
// StoragePartitionConfig.
const char* kTestPartitionDomain = "test partition domain";
const char* kTestPartitionName = "test partition name";
const bool kTestInMemory = false;
proto::EmbedderDownloadData embedder_download_data;
proto::StoragePartitionConfig* config_proto =
embedder_download_data.mutable_storage_partition_config();
config_proto->set_partition_domain(kTestPartitionDomain);
config_proto->set_partition_name(kTestPartitionName);
config_proto->set_in_memory(kTestInMemory);
config_proto->set_fallback_mode(
proto::StoragePartitionConfig_FallbackMode_kPartitionOnDisk);
auto deserialized_embedder_download_data_spc =
download_manager_->SerializedEmbedderDownloadDataToStoragePartitionConfig(
embedder_download_data.SerializeAsString());
EXPECT_EQ(deserialized_embedder_download_data_spc.partition_domain(),
kTestPartitionDomain);
EXPECT_EQ(deserialized_embedder_download_data_spc.partition_name(),
kTestPartitionName);
EXPECT_EQ(deserialized_embedder_download_data_spc.in_memory(), kTestInMemory);
EXPECT_EQ(deserialized_embedder_download_data_spc
.fallback_to_partition_domain_for_blob_urls(),
StoragePartitionConfig::FallbackMode::kFallbackPartitionOnDisk);
// Check that the fallback modes values are properly serialized and
// deserialized.
const std::map<StoragePartitionConfig::FallbackMode,
proto::StoragePartitionConfig_FallbackMode>
fallback_mode_mapping = {
{StoragePartitionConfig::FallbackMode::kNone,
proto::StoragePartitionConfig_FallbackMode_kNone},
{StoragePartitionConfig::FallbackMode::kFallbackPartitionInMemory,
proto::StoragePartitionConfig_FallbackMode_kPartitionInMemory},
{StoragePartitionConfig::FallbackMode::kFallbackPartitionOnDisk,
proto::StoragePartitionConfig_FallbackMode_kPartitionOnDisk},
};
for (auto fallback_pair : fallback_mode_mapping) {
// Check fallback mode equality going from StoragePartitionConfig to
// proto::EmbedderDownloadData.
auto fallback_spc = CreateStoragePartitionConfigForTesting(
/*in_memory=*/false, "test domain", "test name");
fallback_spc.set_fallback_to_partition_domain_for_blob_urls(
fallback_pair.first);
std::string serialized_fallback_spc =
download_manager_
->StoragePartitionConfigToSerializedEmbedderDownloadData(
fallback_spc);
proto::EmbedderDownloadData deserialized_fallback_embedder_download_data;
ASSERT_TRUE(deserialized_fallback_embedder_download_data.ParseFromString(
serialized_fallback_spc));
ASSERT_TRUE(deserialized_fallback_embedder_download_data
.has_storage_partition_config());
EXPECT_EQ(
deserialized_fallback_embedder_download_data.storage_partition_config()
.fallback_mode(),
fallback_pair.second);
// Check fallback mode equality going from proto::EmbedderDownloadData to
// StoragePartitionConfig.
proto::EmbedderDownloadData fallback_embedder_download_data;
proto::StoragePartitionConfig* fallback_proto_spc =
fallback_embedder_download_data.mutable_storage_partition_config();
fallback_proto_spc->set_partition_domain("test domain");
fallback_proto_spc->set_partition_name("test name");
fallback_proto_spc->set_in_memory(false);
fallback_proto_spc->set_fallback_mode(fallback_pair.second);
StoragePartitionConfig deserialized_fallback_spc =
download_manager_
->SerializedEmbedderDownloadDataToStoragePartitionConfig(
fallback_embedder_download_data.SerializeAsString());
EXPECT_EQ(
deserialized_fallback_spc.fallback_to_partition_domain_for_blob_urls(),
fallback_pair.first);
}
}
TEST_F(DownloadManagerTest, BlockingShutdownCount) {
download::MockDownloadItemImpl& item(AddItemToManager());
EXPECT_CALL(item, IsInsecure()).WillRepeatedly(Return(false));
EXPECT_CALL(item, IsDangerous()).WillRepeatedly(Return(false));
EXPECT_CALL(item, GetState())
.WillRepeatedly(Return(download::DownloadItem::COMPLETE));
EXPECT_EQ(download_manager_->BlockingShutdownCount(), 0);
EXPECT_CALL(item, GetState())
.WillRepeatedly(Return(download::DownloadItem::IN_PROGRESS));
EXPECT_EQ(download_manager_->BlockingShutdownCount(), 1);
EXPECT_CALL(item, IsDangerous()).WillRepeatedly(Return(true));
EXPECT_EQ(download_manager_->BlockingShutdownCount(), 0);
EXPECT_CALL(item, IsDangerous()).WillRepeatedly(Return(false));
SCOPED_TRACE(testing::Message() << "Failed for insecure" << std::endl);
EXPECT_CALL(item, IsInsecure()).WillRepeatedly(Return(true));
EXPECT_EQ(download_manager_->BlockingShutdownCount(), 0);
}
class DownloadManagerWithExpirationTest : public DownloadManagerTest {
public:
DownloadManagerWithExpirationTest() {
std::map<std::string, std::string> params = {
{download::kExpiredDownloadDeleteTimeFinchKey,
base::NumberToString(1)}};
scoped_feature_list_.InitAndEnableFeatureWithParameters(
download::features::kDeleteExpiredDownloads, params);
}
~DownloadManagerWithExpirationTest() override = default;
private:
base::test::ScopedFeatureList scoped_feature_list_;
};
// Verifies that expired canceled or interrupted downloads are deleted
// correctly.
TEST_F(DownloadManagerWithExpirationTest, DeleteExpiredDownload) {
std::vector<GURL> url_chain;
url_chain.emplace_back("http://example.com/1.zip");
auto expired_start_time = base::Time::Now() - base::Days(10);
download::DownloadItem* download_item = CreateDownloadItem(
expired_start_time, url_chain, download::DownloadItem::INTERRUPTED);
EXPECT_FALSE(download_item)
<< "Expired interrupted download will be deleted.";
download_item = CreateDownloadItem(expired_start_time, url_chain,
download::DownloadItem::CANCELLED);
EXPECT_FALSE(download_item) << "Expired canceled download will be deleted.";
download_item = CreateDownloadItem(expired_start_time, std::vector<GURL>(),
download::DownloadItem::COMPLETE);
EXPECT_FALSE(download_item) << "Download without URL chain will be deleted.";
EXPECT_CALL(GetMockObserver(), OnDownloadCreated(download_manager_.get(), _));
EXPECT_CALL(GetMockDownloadManagerDelegate(), AttachExtraInfo(_));
download_item = CreateDownloadItem(expired_start_time, url_chain,
download::DownloadItem::COMPLETE);
EXPECT_TRUE(download_item)
<< "Expired complete download will not be deleted.";
}
class DownloadManagerShutdownTest : public DownloadManagerTest {
public:
void TearDown() override { download_manager_.reset(); }
protected:
void RunOnDownloadCanceledAtShutdownCalledTest(
download::DownloadItem::DownloadState state,
int expected_canceled_call_times) {
download::MockDownloadItemImpl& item(AddItemToManager());
EXPECT_CALL(item, GetState()).WillRepeatedly(Return(state));
EXPECT_CALL(item, Cancel(false)).Times(expected_canceled_call_times);
EXPECT_CALL(GetMockDownloadManagerDelegate(),
OnDownloadCanceledAtShutdown(&item))
.Times(expected_canceled_call_times);
EXPECT_CALL(GetMockObserver(), ManagerGoingDown(download_manager_.get()))
.WillOnce(Return());
download_manager_->Shutdown();
base::RunLoop().RunUntilIdle();
}
};
TEST_F(DownloadManagerShutdownTest,
OnDownloadCanceledAtShutdownCalledForInProgressDownload) {
RunOnDownloadCanceledAtShutdownCalledTest(download::DownloadItem::IN_PROGRESS,
/*expected_canceled_call_times=*/1);
}
TEST_F(DownloadManagerShutdownTest,
OnDownloadCanceledAtShutdownNotCalledForCompleteDownload) {
RunOnDownloadCanceledAtShutdownCalledTest(download::DownloadItem::COMPLETE,
/*expected_canceled_call_times=*/0);
}
} // namespace content