1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
content / browser / renderer_host / input / synthetic_input_browsertest.cc [blame]
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <memory>
#include <tuple>
#include "base/functional/bind.h"
#include "base/functional/callback.h"
#include "base/run_loop.h"
#include "base/task/single_thread_task_runner.h"
#include "base/test/run_until.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/test_timeouts.h"
#include "build/build_config.h"
#include "cc/base/switches.h"
#include "cc/input/scroll_utils.h"
#include "content/browser/renderer_host/render_widget_host_impl.h"
#include "content/browser/web_contents/web_contents_impl.h"
#include "content/common/input/synthetic_gesture.h"
#include "content/common/input/synthetic_gesture_params.h"
#include "content/common/input/synthetic_smooth_scroll_gesture.h"
#include "content/common/input/synthetic_smooth_scroll_gesture_params.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/render_widget_host.h"
#include "content/public/browser/render_widget_host_view.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/content_browser_test.h"
#include "content/public/test/content_browser_test_utils.h"
#include "content/public/test/hit_test_region_observer.h"
#include "content/public/test/test_utils.h"
#include "content/shell/browser/shell.h"
#include "third_party/blink/public/common/input/web_input_event.h"
#include "ui/base/ui_base_features.h"
namespace content {
class SyntheticInputTest : public ContentBrowserTest,
public testing::WithParamInterface<bool> {
public:
SyntheticInputTest() {
if (GetParam()) {
scoped_feature_list.InitAndEnableFeature(
features::kWindowsScrollingPersonality);
} else {
scoped_feature_list.InitAndDisableFeature(
features::kWindowsScrollingPersonality);
}
}
void SetUpCommandLine(base::CommandLine* command_line) override {
command_line->AppendSwitch(switches::kEnableGpuBenchmarking);
}
RenderWidgetHostImpl* GetRenderWidgetHost() const {
return RenderWidgetHostImpl::From(shell()
->web_contents()
->GetPrimaryMainFrame()
->GetRenderViewHost()
->GetWidget());
}
void LoadURL(const char* url) {
const GURL data_url(url);
EXPECT_TRUE(NavigateToURL(shell(), data_url));
RenderWidgetHostImpl* host = GetRenderWidgetHost();
HitTestRegionObserver observer(GetRenderWidgetHost()->GetFrameSinkId());
host->GetView()->SetSize(gfx::Size(400, 400));
std::u16string ready_title(u"ready");
TitleWatcher watcher(shell()->web_contents(), ready_title);
std::ignore = watcher.WaitAndGetTitle();
// Wait for the hit test data to be ready after initiating URL loading
// before returning
observer.WaitForHitTestData();
}
void OnSyntheticGestureCompleted(SyntheticGesture::Result result) {
EXPECT_EQ(SyntheticGesture::GESTURE_FINISHED, result);
runner_->Quit();
}
// Required because scrolls are animated with percent based scrolling, with
// no easy way to disable. See crbug.com/1334257
double WaitForScrollToEnd(const std::string& script) {
MainThreadFrameObserver frame_observer(
RenderWidgetHostImpl::From(shell()
->web_contents()
->GetPrimaryMainFrame()
->GetRenderViewHost()
->GetWidget()));
int frame_count = 0;
double scroll_top = -1;
while (true) {
double new_scroll_top = EvalJs(shell(), script).ExtractDouble();
if (new_scroll_top == scroll_top) {
frame_count++;
// Return when the scroll top value holds steady for 10 frames.
if (frame_count == 10)
return scroll_top;
} else {
// Scroll top value changed; reset counter.
frame_count = 0;
scroll_top = new_scroll_top;
}
frame_observer.Wait();
}
}
gfx::SizeF GetViewportSize() {
return gfx::SizeF(
EvalJs(shell(), "window.visualViewport.width").ExtractDouble(),
EvalJs(shell(), "window.visualViewport.height").ExtractDouble());
}
void InitSyntheticGestureWithDistanceAndGranularity(
SyntheticSmoothScrollGestureParams* params,
const int delta_x,
const int delta_y,
const gfx::SizeF& scroller,
const gfx::SizeF& viewport) {
if (features::IsPercentBasedScrollingEnabled()) {
params->distances.push_back(
cc::ScrollUtils::ResolvePixelScrollToPercentageForTesting(
gfx::Vector2dF(delta_x, delta_y), scroller, viewport));
params->granularity = ui::ScrollGranularity::kScrollByPercentage;
} else {
params->distances.push_back(gfx::Vector2d(delta_x, delta_y));
params->granularity = ui::ScrollGranularity::kScrollByPrecisePixel;
}
}
protected:
std::unique_ptr<base::RunLoop> runner_;
base::test::ScopedFeatureList scoped_feature_list;
};
INSTANTIATE_TEST_SUITE_P(All, SyntheticInputTest, ::testing::Bool());
class GestureScrollObserver : public RenderWidgetHost::InputEventObserver {
public:
void OnInputEvent(const blink::WebInputEvent& event) override {
if (event.GetType() == blink::WebInputEvent::Type::kGestureScrollBegin)
gesture_scroll_seen_ = true;
}
bool HasSeenGestureScrollBegin() const { return gesture_scroll_seen_; }
bool gesture_scroll_seen_ = false;
};
// This test checks that we destroying a render widget host with an ongoing
// gesture doesn't cause lifetime issues. Namely, that the gesture
// CompletionCallback isn't destroyed before being called or the Mojo pipe
// being closed.
IN_PROC_BROWSER_TEST_P(SyntheticInputTest, DestroyWidgetWithOngoingGesture) {
EXPECT_TRUE(NavigateToURL(shell(), GURL("about:blank")));
EXPECT_TRUE(WaitForLoadStop(shell()->web_contents()));
GestureScrollObserver gesture_observer;
GetRenderWidgetHost()->AddInputEventObserver(&gesture_observer);
// By starting a gesture, there's a Mojo callback that the renderer is
// waiting on the browser to resolve. If the browser is shutdown before
// ACKing the callback or closing the channel, we'll DCHECK.
ASSERT_TRUE(
ExecJs(shell()->web_contents(),
"chrome.gpuBenchmarking.smoothScrollByXY(0, 10000, ()=>{}, "
"100, 100, chrome.gpuBenchmarking.TOUCH_INPUT);"));
EXPECT_TRUE(base::test::RunUntil(
[&]() { return gesture_observer.HasSeenGestureScrollBegin(); }));
shell()->Close();
}
// This test ensures that synthetic wheel scrolling works on all platforms.
IN_PROC_BROWSER_TEST_P(SyntheticInputTest, SmoothScrollWheel) {
LoadURL(R"HTML(
data:text/html;charset=utf-8,
<!DOCTYPE html>
<meta name='viewport' content='width=device-width'>
<style>
body {
width: 10px;
height: 2000px;
}
</style>
<script>
document.title = 'ready';
</script>
)HTML");
// Note: 256 is precisely chosen since Android's minimum granularity is 64px.
// All other platforms can specify the delta per-pixel.
const int scroll_delta = 256;
SyntheticSmoothScrollGestureParams params;
params.gesture_source_type = content::mojom::GestureSourceType::kMouseInput;
params.anchor = gfx::PointF(1, 1);
InitSyntheticGestureWithDistanceAndGranularity(
¶ms, 0, -scroll_delta, gfx::SizeF(10, 2000), GetViewportSize());
// Use a speed that's fast enough that the entire scroll occurs in a single
// GSU, avoiding precision loss. SyntheticGestures can lose delta over time
// in slower scrolls on some platforms.
params.speed_in_pixels_s = 10000000.f;
runner_ = std::make_unique<base::RunLoop>();
std::unique_ptr<SyntheticSmoothScrollGesture> gesture(
new SyntheticSmoothScrollGesture(params));
GetRenderWidgetHost()->QueueSyntheticGesture(
std::move(gesture),
base::BindOnce(&SyntheticInputTest::OnSyntheticGestureCompleted,
base::Unretained(this)));
// Run until we get the OnSyntheticGestureCompleted callback
runner_->Run();
runner_.reset();
if (features::IsPercentBasedScrollingEnabled()) {
EXPECT_EQ(WaitForScrollToEnd("document.scrollingElement.scrollTop"),
scroll_delta);
} else {
EXPECT_EQ(scroll_delta, EvalJs(shell()->web_contents(),
"document.scrollingElement.scrollTop"));
}
}
// This test ensures that slow synthetic wheel scrolling does not lose precision
// over time.
// https://crbug.com/1103731. Flaky on Android bots.
// https://crbug.com/1086334. Flaky on all desktop bots, but maybe for a
// different reason.
IN_PROC_BROWSER_TEST_P(SyntheticInputTest, DISABLED_SlowSmoothScrollWheel) {
LoadURL(R"HTML(
data:text/html;charset=utf-8,
<!DOCTYPE html>
<meta name='viewport' content='width=device-width'>
<style>
body {
width: 10px;
height: 2000px;
}
</style>
<script>
document.title = 'ready';
</script>
)HTML");
// Note: 1024 is precisely chosen since Android's minimum granularity is 64px.
// All other platforms can specify the delta per-pixel.
const int scroll_delta = 1024;
SyntheticSmoothScrollGestureParams params;
params.gesture_source_type = content::mojom::GestureSourceType::kMouseInput;
params.anchor = gfx::PointF(1, 1);
InitSyntheticGestureWithDistanceAndGranularity(
¶ms, 0, -scroll_delta, gfx::SizeF(10, 2000), GetViewportSize());
// Use a speed that's slow enough that it requires the browser to require
// multiple wheel-events to be dispatched, so that precision is needed to
// scroll the correct amount.
params.speed_in_pixels_s = 1000.f;
runner_ = std::make_unique<base::RunLoop>();
auto* web_contents = shell()->web_contents();
RenderFrameSubmissionObserver scroll_offset_wait(web_contents);
std::unique_ptr<SyntheticSmoothScrollGesture> gesture(
new SyntheticSmoothScrollGesture(params));
GetRenderWidgetHost()->QueueSyntheticGesture(
std::move(gesture),
base::BindOnce(&SyntheticInputTest::OnSyntheticGestureCompleted,
base::Unretained(this)));
float device_scale_factor =
web_contents->GetRenderWidgetHostView()->GetDeviceScaleFactor();
scroll_offset_wait.WaitForScrollOffset(
gfx::PointF(0.f, ((float)scroll_delta) * device_scale_factor));
if (features::IsPercentBasedScrollingEnabled()) {
EXPECT_EQ(WaitForScrollToEnd("document.scrollingElement.scrollTop"),
scroll_delta);
} else {
EXPECT_EQ(scroll_delta, EvalJs(shell()->web_contents(),
"document.scrollingElement.scrollTop"));
}
}
} // namespace content