1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
content / browser / renderer_host / render_widget_host_view_android_unittest.cc [blame]
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "content/browser/renderer_host/render_widget_host_view_android.h"
#include <memory>
#include "base/memory/raw_ptr.h"
#include "cc/layers/deadline_policy.h"
#include "cc/slim/layer.h"
#include "components/viz/common/features.h"
#include "components/viz/common/surfaces/local_surface_id.h"
#include "content/browser/renderer_host/frame_tree.h"
#include "content/browser/renderer_host/mock_render_widget_host.h"
#include "content/browser/site_instance_group.h"
#include "content/browser/site_instance_impl.h"
#include "content/common/features.h"
#include "content/public/test/browser_task_environment.h"
#include "content/public/test/mock_render_process_host.h"
#include "content/public/test/test_browser_context.h"
#include "content/test/mock_render_widget_host_delegate.h"
#include "content/test/test_render_view_host.h"
#include "content/test/test_view_android_delegate.h"
#include "content/test/test_web_contents.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/android/view_android.h"
#include "ui/android/window_android.h"
namespace content {
namespace {
// Allows for RenderWidgetHostViewAndroidRotationTest to override the ScreenInfo
// so that different configurations can be tests. The default path fallbacks on
// an empty ScreenInfo in testing, assuming it has no effect.
class CustomScreenInfoRenderWidgetHostViewAndroid
: public RenderWidgetHostViewAndroid {
public:
CustomScreenInfoRenderWidgetHostViewAndroid(
RenderWidgetHostImpl* widget,
gfx::NativeView parent_native_view,
cc::slim::Layer* parent_layer);
~CustomScreenInfoRenderWidgetHostViewAndroid() override {}
void SetScreenInfo(display::ScreenInfo screen_info);
// RenderWidgetHostViewAndroid:
display::ScreenInfos GetScreenInfos() const override;
display::ScreenInfo GetScreenInfo() const override;
private:
CustomScreenInfoRenderWidgetHostViewAndroid(
const CustomScreenInfoRenderWidgetHostViewAndroid&) = delete;
CustomScreenInfoRenderWidgetHostViewAndroid& operator=(
const CustomScreenInfoRenderWidgetHostViewAndroid&) = delete;
display::ScreenInfo screen_info_;
};
CustomScreenInfoRenderWidgetHostViewAndroid::
CustomScreenInfoRenderWidgetHostViewAndroid(
RenderWidgetHostImpl* widget,
gfx::NativeView parent_native_view,
cc::slim::Layer* parent_layer)
: RenderWidgetHostViewAndroid(widget, parent_native_view, parent_layer) {}
void CustomScreenInfoRenderWidgetHostViewAndroid::SetScreenInfo(
display::ScreenInfo screen_info) {
screen_info_ = screen_info;
}
display::ScreenInfos
CustomScreenInfoRenderWidgetHostViewAndroid::GetScreenInfos() const {
return display::ScreenInfos(screen_info_);
}
display::ScreenInfo CustomScreenInfoRenderWidgetHostViewAndroid::GetScreenInfo()
const {
return screen_info_;
}
std::string PostTestCaseName(const ::testing::TestParamInfo<bool>& info) {
return info.param ? "FullscreenKillswitch" : "Default";
}
} // namespace
class RenderWidgetHostViewAndroidTest : public RenderViewHostImplTestHarness {
public:
RenderWidgetHostViewAndroidTest();
RenderWidgetHostViewAndroidTest(const RenderWidgetHostViewAndroidTest&) =
delete;
RenderWidgetHostViewAndroidTest& operator=(
const RenderWidgetHostViewAndroidTest&) = delete;
~RenderWidgetHostViewAndroidTest() override {}
RenderWidgetHostViewAndroid* render_widget_host_view_android() {
return render_widget_host_view_android_;
}
viz::LocalSurfaceId GetLocalSurfaceIdAndConfirmNewerThan(
viz::LocalSurfaceId other);
MockRenderWidgetHostDelegate* delegate() { return delegate_.get(); }
// Directly map to `RenderWidgetHostViewAndroid` methods.
bool SynchronizeVisualProperties(
const cc::DeadlinePolicy& deadline_policy,
const std::optional<viz::LocalSurfaceId>& child_local_surface_id);
void WasEvicted();
ui::ViewAndroid* GetNativeView();
void OnRenderFrameMetadataChangedAfterActivation(
cc::RenderFrameMetadata metadata,
base::TimeTicks activation_time);
ui::ViewAndroid* GetParentView();
cc::slim::Layer* GetParentLayer();
protected:
virtual RenderWidgetHostViewAndroid* CreateRenderWidgetHostViewAndroid(
RenderWidgetHostImpl* widget_host);
// testing::Test:
void SetUp() override;
void TearDown() override;
std::unique_ptr<TestViewAndroidDelegate> test_view_android_delegate_;
private:
std::unique_ptr<MockRenderProcessHost> process_;
scoped_refptr<SiteInstanceGroup> site_instance_group_;
std::unique_ptr<MockRenderWidgetHostDelegate> delegate_;
// TestRenderViewHost
scoped_refptr<RenderViewHostImpl> render_view_host_;
// Owned by `render_view_host_`.
raw_ptr<MockRenderWidgetHost> host_ = nullptr;
raw_ptr<RenderWidgetHostViewAndroid> render_widget_host_view_android_ =
nullptr;
// Of the parent of this RWHVA.
ui::ViewAndroid parent_view_{ui::ViewAndroid::LayoutType::NORMAL};
scoped_refptr<cc::slim::Layer> parent_layer_;
};
RenderWidgetHostViewAndroidTest::RenderWidgetHostViewAndroidTest() {
parent_layer_ = cc::slim::Layer::Create();
parent_view_.SetLayer(cc::slim::Layer::Create());
parent_view_.GetLayer()->AddChild(parent_layer_);
}
viz::LocalSurfaceId
RenderWidgetHostViewAndroidTest::GetLocalSurfaceIdAndConfirmNewerThan(
viz::LocalSurfaceId other) {
auto local_surface_id =
render_widget_host_view_android()->GetLocalSurfaceId();
EXPECT_NE(other, local_surface_id);
EXPECT_TRUE(local_surface_id.is_valid());
EXPECT_TRUE(local_surface_id.IsNewerThan(other));
return local_surface_id;
}
bool RenderWidgetHostViewAndroidTest::SynchronizeVisualProperties(
const cc::DeadlinePolicy& deadline_policy,
const std::optional<viz::LocalSurfaceId>& child_local_surface_id) {
return render_widget_host_view_android_->SynchronizeVisualProperties(
deadline_policy, child_local_surface_id);
}
void RenderWidgetHostViewAndroidTest::WasEvicted() {
render_widget_host_view_android_->WasEvicted();
}
ui::ViewAndroid* RenderWidgetHostViewAndroidTest::GetNativeView() {
return render_widget_host_view_android_->GetNativeView();
}
void RenderWidgetHostViewAndroidTest::
OnRenderFrameMetadataChangedAfterActivation(
cc::RenderFrameMetadata metadata,
base::TimeTicks activation_time) {
render_widget_host_view_android()
->host()
->render_frame_metadata_provider()
->OnRenderFrameMetadataChangedAfterActivation(metadata, activation_time);
}
ui::ViewAndroid* RenderWidgetHostViewAndroidTest::GetParentView() {
return &parent_view_;
}
cc::slim::Layer* RenderWidgetHostViewAndroidTest::GetParentLayer() {
return parent_layer_.get();
}
RenderWidgetHostViewAndroid*
RenderWidgetHostViewAndroidTest::CreateRenderWidgetHostViewAndroid(
RenderWidgetHostImpl* widget_host) {
return new RenderWidgetHostViewAndroid(widget_host, &parent_view_,
parent_layer_.get());
}
void RenderWidgetHostViewAndroidTest::SetUp() {
RenderViewHostImplTestHarness::SetUp();
delegate_ = std::make_unique<MockRenderWidgetHostDelegate>();
process_ = std::make_unique<MockRenderProcessHost>(browser_context());
site_instance_group_ = base::WrapRefCounted(
SiteInstanceGroup::CreateForTesting(browser_context(), process_.get()));
// Initialized before ownership is given to `render_view_host_`.
std::unique_ptr<MockRenderWidgetHost> mock_host =
MockRenderWidgetHost::Create(
&contents()->GetPrimaryFrameTree(), delegate_.get(),
site_instance_group_->GetSafeRef(), process_->GetNextRoutingID());
host_ = mock_host.get();
render_view_host_ = new TestRenderViewHost(
&contents()->GetPrimaryFrameTree(), site_instance_group_.get(),
contents()->GetSiteInstance()->GetStoragePartitionConfig(),
std::move(mock_host), contents(), process_->GetNextRoutingID(),
process_->GetNextRoutingID(), nullptr,
CreateRenderViewHostCase::kDefault);
render_widget_host_view_android_ = CreateRenderWidgetHostViewAndroid(host_);
test_view_android_delegate_ = std::make_unique<TestViewAndroidDelegate>();
}
void RenderWidgetHostViewAndroidTest::TearDown() {
render_widget_host_view_android_->Destroy();
render_view_host_.reset();
delegate_.reset();
process_->Cleanup();
site_instance_group_.reset();
process_ = nullptr;
RenderViewHostImplTestHarness::TearDown();
}
// Tests that when a child responds to a Surface Synchronization message, while
// we are evicted, that we do not attempt to embed an invalid
// viz::LocalSurfaceId. This test should not crash.
TEST_F(RenderWidgetHostViewAndroidTest, NoSurfaceSynchronizationWhileEvicted) {
// Android default host and views initialize as visible.
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
EXPECT_TRUE(rwhva->IsShowing());
const viz::LocalSurfaceId initial_local_surface_id =
rwhva->GetLocalSurfaceId();
EXPECT_TRUE(initial_local_surface_id.is_valid());
// Evicting while hidden should invalidate the current viz::LocalSurfaceId.
rwhva->Hide();
EXPECT_FALSE(rwhva->IsShowing());
WasEvicted();
EXPECT_FALSE(rwhva->GetLocalSurfaceId().is_valid());
// When a child acknowledges a Surface Synchronization message, and has no new
// properties to change, it responds with the original viz::LocalSurfaceId.
// If we are evicted, we should not attempt to embed our invalid id. Nor
// should we continue the synchronization process. This should not cause a
// crash in DelegatedFrameHostAndroid.
EXPECT_FALSE(SynchronizeVisualProperties(
cc::DeadlinePolicy::UseDefaultDeadline(), initial_local_surface_id));
}
// Tests insetting the Visual Viewport.
TEST_F(RenderWidgetHostViewAndroidTest, InsetVisualViewport) {
// Android default viewport should not have an inset bottom.
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
EXPECT_EQ(0, rwhva->GetNativeView()->GetViewportInsetBottom());
// Set up SurfaceId checking.
const viz::LocalSurfaceId original_local_surface_id =
rwhva->GetLocalSurfaceId();
// Set up our test delegate connected to this ViewAndroid.
test_view_android_delegate_->SetupTestDelegate(rwhva->GetNativeView());
EXPECT_EQ(0, rwhva->GetNativeView()->GetViewportInsetBottom());
JNIEnv* env = base::android::AttachCurrentThread();
// Now inset the bottom and make sure the surface changes, and the inset is
// known to our ViewAndroid.
test_view_android_delegate_->InsetViewportBottom(100);
EXPECT_EQ(100, rwhva->GetNativeView()->GetViewportInsetBottom());
rwhva->OnViewportInsetBottomChanged(env, nullptr);
viz::LocalSurfaceId inset_surface = rwhva->GetLocalSurfaceId();
EXPECT_TRUE(inset_surface.IsNewerThan(original_local_surface_id));
// Reset the bottom; should go back to the original inset and have a new
// surface.
test_view_android_delegate_->InsetViewportBottom(0);
rwhva->OnViewportInsetBottomChanged(env, nullptr);
EXPECT_EQ(0, rwhva->GetNativeView()->GetViewportInsetBottom());
EXPECT_TRUE(rwhva->GetLocalSurfaceId().IsNewerThan(inset_surface));
}
TEST_F(RenderWidgetHostViewAndroidTest, HideWindowRemoveViewAddViewShowWindow) {
std::unique_ptr<ui::WindowAndroid::ScopedWindowAndroidForTesting> window =
ui::WindowAndroid::CreateForTesting();
window->get()->AddChild(GetParentView());
EXPECT_TRUE(render_widget_host_view_android()->IsShowing());
// The layer should be visible once attached to a window.
EXPECT_FALSE(render_widget_host_view_android()
->GetNativeView()
->GetLayer()
->hide_layer_and_subtree());
// Hiding the window should and removing the view should hide the layer.
window->get()->OnVisibilityChanged(nullptr, nullptr, false);
GetParentView()->RemoveFromParent();
EXPECT_TRUE(render_widget_host_view_android()->IsShowing());
EXPECT_TRUE(render_widget_host_view_android()
->GetNativeView()
->GetLayer()
->hide_layer_and_subtree());
// Adding the view back to a window and notifying the window is visible should
// make the layer visible again.
window->get()->AddChild(GetParentView());
window->get()->OnVisibilityChanged(nullptr, nullptr, true);
EXPECT_TRUE(render_widget_host_view_android()->IsShowing());
EXPECT_FALSE(render_widget_host_view_android()
->GetNativeView()
->GetLayer()
->hide_layer_and_subtree());
}
TEST_F(RenderWidgetHostViewAndroidTest, DisplayFeature) {
// By default there is no display feature so verify we get back null.
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
RenderWidgetHostViewBase* rwhv = rwhva;
rwhva->GetNativeView()->SetLayoutForTesting(0, 0, 200, 400);
test_view_android_delegate_->SetupTestDelegate(rwhva->GetNativeView());
EXPECT_EQ(std::nullopt, rwhv->GetDisplayFeature());
// Set a vertical display feature, and verify this is reflected in the
// computed display feature.
rwhva->SetDisplayFeatureBoundsForTesting(gfx::Rect(95, 0, 10, 400));
DisplayFeature expected_display_feature = {
DisplayFeature::Orientation::kVertical,
/* offset */ 95,
/* mask_length */ 10};
EXPECT_EQ(expected_display_feature, *rwhv->GetDisplayFeature());
// Validate that a display feature in the middle of the view results in not
// being exposed as a content::DisplayFeature (we currently only consider
// display features that completely cover one of the view's dimensions).
rwhva->GetNativeView()->SetLayoutForTesting(0, 0, 400, 200);
rwhva->SetDisplayFeatureBoundsForTesting(gfx::Rect(200, 100, 100, 200));
EXPECT_EQ(std::nullopt, rwhv->GetDisplayFeature());
// Verify that horizontal display feature is correctly validated.
rwhva->SetDisplayFeatureBoundsForTesting(gfx::Rect(0, 90, 400, 20));
expected_display_feature = {DisplayFeature::Orientation::kHorizontal,
/* offset */ 90,
/* mask_length */ 20};
EXPECT_EQ(expected_display_feature, *rwhv->GetDisplayFeature());
rwhva->SetDisplayFeatureBoundsForTesting(gfx::Rect(0, 95, 600, 10));
expected_display_feature = {DisplayFeature::Orientation::kHorizontal,
/* offset */ 95,
/* mask_length */ 10};
EXPECT_EQ(expected_display_feature, *rwhv->GetDisplayFeature());
rwhva->SetDisplayFeatureBoundsForTesting(gfx::Rect(195, 0, 10, 300));
expected_display_feature = {DisplayFeature::Orientation::kVertical,
/* offset */ 195,
/* mask_length */ 10};
EXPECT_EQ(expected_display_feature, *rwhv->GetDisplayFeature());
}
// Tests that if a Renderer submits content before a navigation is completed,
// that we generate a new Surface. So that the old content cannot be used as a
// fallback.
TEST_F(RenderWidgetHostViewAndroidTest, RenderFrameSubmittedBeforeNavigation) {
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
// Creating a visible RWHVA should have a valid surface.
const viz::LocalSurfaceId initial_local_surface_id =
rwhva->GetLocalSurfaceId();
EXPECT_TRUE(initial_local_surface_id.is_valid());
EXPECT_TRUE(rwhva->IsShowing());
{
// Simulate that the Renderer submitted some content to the current Surface
// before Navigation concludes.
cc::RenderFrameMetadata metadata;
metadata.local_surface_id = initial_local_surface_id;
OnRenderFrameMetadataChangedAfterActivation(metadata,
base::TimeTicks::Now());
}
// Pre-commit information of Navigation is not told to RWHVA, these are the
// two entry points. We should have a new Surface afterwards.
rwhva->OnOldViewDidNavigatePreCommit();
rwhva->DidNavigate();
GetLocalSurfaceIdAndConfirmNewerThan(initial_local_surface_id);
}
// Tests rotation and fullscreen cases that are supported by visual properties
// analysis. Some of which fail with the fullscreen killswitch legacy path.
//
// Initializes to Portrait.
class RenderWidgetHostViewAndroidRotationTest
: public RenderWidgetHostViewAndroidTest {
public:
RenderWidgetHostViewAndroidRotationTest() = default;
~RenderWidgetHostViewAndroidRotationTest() override = default;
// If `rotation` is false this will be treated as an initialization. Same as
// the first notifications after browser launch.
void SetPortraitScreenInfo(bool rotation);
void SetLandscapeScreenInfo(bool rotation);
// From default portrait oriention to fullscreen with no rotation. Returns
// resultant viz::LocalSurfaceId.
viz::LocalSurfaceId PortraitToFullscreenPortrait();
// From default portrait orientation to fullscreen with an orientation lock to
// landscape applied. Triggering a rotation. Returns resultant
// viz::LocalSurfaceId.
viz::LocalSurfaceId PortraitToFullscreenLanscape();
// Fires the rotation throttle timeout.
void FireRotationTimeout();
// Firet the fullscreen throttle timeout.
void FireFullscreenTimeout();
// RenderWidgetHostViewAndroid:
void EnterFullscreenMode();
void ExitFullscreenMode();
void LockOrientation(device::mojom::ScreenOrientationLockType orientation);
void UnlockOrientation();
void TogglePictureInPicture(bool enabled);
void OnDidUpdateVisualPropertiesComplete(
const cc::RenderFrameMetadata& metadata);
void SetScreenInfo(display::ScreenInfo screen_info);
// ViewAndroid:
void OnPhysicalBackingSizeChanged(const gfx::Size& size);
void OnVisibleViewportSizeChanged(int width, int height);
const gfx::Size fullscreen_landscape_physical_backing = gfx::Size(800, 600);
const gfx::Size fullscreen_portrait_physical_backing = gfx::Size(600, 800);
const gfx::Size landscape_physical_backing = gfx::Size(800, 590);
const gfx::Size portrait_physical_backing = gfx::Size(600, 790);
protected:
RenderWidgetHostViewAndroid* CreateRenderWidgetHostViewAndroid(
RenderWidgetHostImpl* widget_host) override;
// testing::Test:
void SetUp() override;
};
void RenderWidgetHostViewAndroidRotationTest::SetPortraitScreenInfo(
bool rotation) {
display::ScreenInfo screen_info;
screen_info.display_id = display::kDefaultDisplayId;
screen_info.orientation_type =
display::mojom::ScreenOrientation::kPortraitPrimary;
screen_info.orientation_angle = 0;
screen_info.rect = gfx::Rect(0, 0, 300, 400);
SetScreenInfo(screen_info);
render_widget_host_view_android()->OnSynchronizedDisplayPropertiesChanged(
rotation);
}
void RenderWidgetHostViewAndroidRotationTest::SetLandscapeScreenInfo(
bool rotation) {
display::ScreenInfo screen_info;
screen_info.display_id = display::kDefaultDisplayId;
screen_info.orientation_type =
display::mojom::ScreenOrientation::kLandscapePrimary;
screen_info.orientation_angle = 90;
screen_info.rect = gfx::Rect(0, 0, 400, 300);
SetScreenInfo(screen_info);
render_widget_host_view_android()->OnSynchronizedDisplayPropertiesChanged(
rotation);
}
viz::LocalSurfaceId
RenderWidgetHostViewAndroidRotationTest::PortraitToFullscreenPortrait() {
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
const viz::LocalSurfaceId initial_local_surface_id =
rwhva->GetLocalSurfaceId();
EXPECT_TRUE(initial_local_surface_id.is_valid());
// When we enter fullscreen mode we can't sync until we get a non-rotation
// change to sizes.
EnterFullscreenMode();
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
// The non-rotation change to the `visible_viewport_size` occurs when system
// controls are hidden. We need to sync this to the Renderer. As we will not
// know if a rotation is to follow.
OnVisibleViewportSizeChanged(300, 400);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
OnPhysicalBackingSizeChanged(fullscreen_portrait_physical_backing);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
return GetLocalSurfaceIdAndConfirmNewerThan(initial_local_surface_id);
}
viz::LocalSurfaceId
RenderWidgetHostViewAndroidRotationTest::PortraitToFullscreenLanscape() {
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
const viz::LocalSurfaceId initial_local_surface_id =
rwhva->GetLocalSurfaceId();
EXPECT_TRUE(initial_local_surface_id.is_valid());
// When we enter fullscreen mode we can't sync until we get a non-rotation
// change to sizes.
EnterFullscreenMode();
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
LockOrientation(device::mojom::ScreenOrientationLockType::LANDSCAPE_PRIMARY);
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
// When we expect a rotation we will not advance the viz::LocalSurfaceId
// ourselves until rotation has completed. However we will not block it's
// advancement from other sources. As `visible_viewport_size` follows a
// non-synchronized path and blocking other sync paths can lead to incorrect
// surface size submissions.
OnVisibleViewportSizeChanged(300, 400);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
EXPECT_EQ(initial_local_surface_id, rwhva->GetLocalSurfaceId());
// We do throttle once rotation starts
SetLandscapeScreenInfo(/*rotation=*/true);
EXPECT_EQ(initial_local_surface_id, rwhva->GetLocalSurfaceId());
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
OnVisibleViewportSizeChanged(400, 300);
EXPECT_EQ(initial_local_surface_id, rwhva->GetLocalSurfaceId());
// We stop throttling once rotation ends
OnPhysicalBackingSizeChanged(fullscreen_landscape_physical_backing);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
return GetLocalSurfaceIdAndConfirmNewerThan(initial_local_surface_id);
}
void RenderWidgetHostViewAndroidRotationTest::FireRotationTimeout() {
render_widget_host_view_android()->rotation_timeout_.FireNow();
}
void RenderWidgetHostViewAndroidRotationTest::FireFullscreenTimeout() {
render_widget_host_view_android()
->screen_state_change_handler_.throttle_timeout_.FireNow();
}
void RenderWidgetHostViewAndroidRotationTest::EnterFullscreenMode() {
blink::mojom::FullscreenOptions options;
render_widget_host_view_android()->EnterFullscreenMode(options);
delegate()->set_is_fullscreen(true);
}
void RenderWidgetHostViewAndroidRotationTest::ExitFullscreenMode() {
render_widget_host_view_android()->ExitFullscreenMode();
delegate()->set_is_fullscreen(false);
}
void RenderWidgetHostViewAndroidRotationTest::LockOrientation(
device::mojom::ScreenOrientationLockType orientation) {
render_widget_host_view_android()->LockOrientation(orientation);
}
void RenderWidgetHostViewAndroidRotationTest::UnlockOrientation() {
render_widget_host_view_android()->UnlockOrientation();
}
void RenderWidgetHostViewAndroidRotationTest::TogglePictureInPicture(
bool enabled) {
render_widget_host_view_android()->SetHasPersistentVideo(enabled);
}
void RenderWidgetHostViewAndroidRotationTest::
OnDidUpdateVisualPropertiesComplete(
const cc::RenderFrameMetadata& metadata) {
render_widget_host_view_android()->OnDidUpdateVisualPropertiesComplete(
metadata);
}
void RenderWidgetHostViewAndroidRotationTest::SetScreenInfo(
display::ScreenInfo screen_info) {
static_cast<CustomScreenInfoRenderWidgetHostViewAndroid*>(
render_widget_host_view_android())
->SetScreenInfo(screen_info);
}
void RenderWidgetHostViewAndroidRotationTest::OnPhysicalBackingSizeChanged(
const gfx::Size& size) {
render_widget_host_view_android()->view_.OnPhysicalBackingSizeChanged(size);
}
void RenderWidgetHostViewAndroidRotationTest::OnVisibleViewportSizeChanged(
int width,
int height) {
// Change the size via the parent native view. `RenderWidgetHostViewAndroid`
// has `LayoutType` set to `MATCH_PARENT` so can't receive its own
// `OnSizeChanged`.
GetParentView()->OnSizeChanged(width, height);
}
RenderWidgetHostViewAndroid*
RenderWidgetHostViewAndroidRotationTest::CreateRenderWidgetHostViewAndroid(
RenderWidgetHostImpl* widget_host) {
return new CustomScreenInfoRenderWidgetHostViewAndroid(
widget_host, GetParentView(), GetParentLayer());
}
void RenderWidgetHostViewAndroidRotationTest::SetUp() {
RenderWidgetHostViewAndroidTest::SetUp();
// Set initial state to Portrait
SetPortraitScreenInfo(/*rotation=*/false);
OnPhysicalBackingSizeChanged(portrait_physical_backing);
OnVisibleViewportSizeChanged(300, 395);
}
// Tests transition from Portrait orientation to fullscreen, with no rotation.
// Along with exiting back to Portrait.
TEST_F(RenderWidgetHostViewAndroidRotationTest, PortraitOnlyFullscreen) {
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
const viz::LocalSurfaceId post_fullscreen_local_surface_id =
PortraitToFullscreenPortrait();
// When we exit fullscreen mode we don't throttle.
ExitFullscreenMode();
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
// The non-rotation change to the `visible_viewport_size` occurs when system
// controls are made visible again. We need to sync this to the Renderer. We
// do not know if a rotation is to follow.
OnVisibleViewportSizeChanged(300, 395);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
OnPhysicalBackingSizeChanged(portrait_physical_backing);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
GetLocalSurfaceIdAndConfirmNewerThan(post_fullscreen_local_surface_id);
}
// Tests the transition from Portrait to Fullscreen where a rotation lock to
// Landscape is applied. Followed by a return to the original configuration.
TEST_F(RenderWidgetHostViewAndroidRotationTest,
PortraitToLandscapeRotationLockFullscreenRotation) {
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
const viz::LocalSurfaceId post_fullscreen_local_surface_id =
PortraitToFullscreenLanscape();
// When we exit fullscreen mode we can't be sure if we are going to rotate or
// not. We don't throttle.
ExitFullscreenMode();
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
UnlockOrientation();
// When unthrottle upon the receipt of a new `visible_viewport_size`. Even if
// it is a rotation there is no guarantee that we will receive paired physical
// backing or screen info. When exiting from Landscape Fullscreen to
// Landscape, this will be the last signal.
OnVisibleViewportSizeChanged(300, 395);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
// When the other properties signal a rotation, throttle again.
OnPhysicalBackingSizeChanged(portrait_physical_backing);
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
SetPortraitScreenInfo(/*rotation=*/true);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
GetLocalSurfaceIdAndConfirmNewerThan(post_fullscreen_local_surface_id);
}
// Tests that if we receive an UnlockOrientation that we cancel any rotation
// throttle. As we may not receive a paired result, and may end up reversing the
// rotation.
TEST_F(RenderWidgetHostViewAndroidRotationTest,
UnlockOrientationCancelsRotationThrottle) {
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
const viz::LocalSurfaceId initial_local_surface_id =
rwhva->GetLocalSurfaceId();
EXPECT_TRUE(initial_local_surface_id.is_valid());
// When we enter fullscreen mode we can't sync until we get a non-rotation
// change to sizes.
EnterFullscreenMode();
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
LockOrientation(device::mojom::ScreenOrientationLockType::LANDSCAPE_PRIMARY);
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
// When we expect a rotation we will not advance the viz::LocalSurfaceId
// ourselves until rotation has completed. However we will not block it's
// advancement from other sources. As `visible_viewport_size` follows a
// non-synchronized path and blocking other sync paths can lead to incorrect
// surface size submissions.
OnVisibleViewportSizeChanged(300, 400);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
EXPECT_EQ(initial_local_surface_id, rwhva->GetLocalSurfaceId());
// We do throttle once rotation starts
SetLandscapeScreenInfo(/*rotation=*/true);
EXPECT_EQ(initial_local_surface_id, rwhva->GetLocalSurfaceId());
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
OnVisibleViewportSizeChanged(400, 300);
EXPECT_EQ(initial_local_surface_id, rwhva->GetLocalSurfaceId());
// We we unlock the rotation should be canceled, and we should sync again.
UnlockOrientation();
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
GetLocalSurfaceIdAndConfirmNewerThan(initial_local_surface_id);
}
// Previously we had an ordering expectation that ScreenInfo would update for a
// rotation before Physical Backing. This is not a guarantee, and was locking us
// in rotation throttle. Ensure we handle this ordering.
TEST_F(RenderWidgetHostViewAndroidRotationTest,
FullscreenRotationPhysicalBackingFirst) {
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
const viz::LocalSurfaceId initial_local_surface_id =
rwhva->GetLocalSurfaceId();
EXPECT_TRUE(initial_local_surface_id.is_valid());
// When we enter fullscreen mode we can't sync until we get a non-rotation
// change to sizes.
EnterFullscreenMode();
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
LockOrientation(device::mojom::ScreenOrientationLockType::LANDSCAPE_PRIMARY);
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
// When we expect a rotation we will not advance the viz::LocalSurfaceId
// ourselves until rotation has completed. However we will not block it's
// advancement from other sources. As `visible_viewport_size` follows a
// non-synchronized path and blocking other sync paths can lead to incorrect
// surface size submissions.
OnVisibleViewportSizeChanged(300, 400);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
EXPECT_EQ(initial_local_surface_id, rwhva->GetLocalSurfaceId());
// We should throttle even when receiving a rotated physical backing before
// any ScreenInfo.
OnPhysicalBackingSizeChanged(fullscreen_landscape_physical_backing);
EXPECT_EQ(initial_local_surface_id, rwhva->GetLocalSurfaceId());
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
OnVisibleViewportSizeChanged(400, 300);
EXPECT_EQ(initial_local_surface_id, rwhva->GetLocalSurfaceId());
// Receiving the rotated ScreenInfo should complete the rotation and end
// throttling.
SetLandscapeScreenInfo(/*rotation=*/true);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
GetLocalSurfaceIdAndConfirmNewerThan(initial_local_surface_id);
}
// Tests entering Picture-in-Picture from a fullscreen Portrait context, then
// returning back to the same Portrait state.
TEST_F(RenderWidgetHostViewAndroidRotationTest,
PortraitPictureInPictureToPortrait) {
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
const viz::LocalSurfaceId post_fullscreen_local_surface_id =
PortraitToFullscreenPortrait();
// Entering Picture-in-Picture should not throttle.
TogglePictureInPicture(/*enabled=*/true);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
// Each subsequent visual property change just synchronizes.
OnVisibleViewportSizeChanged(150, 200);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
const viz::LocalSurfaceId post_visual_viewport_local_surface_id =
GetLocalSurfaceIdAndConfirmNewerThan(post_fullscreen_local_surface_id);
OnPhysicalBackingSizeChanged(gfx::Size(300, 400));
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
const viz::LocalSurfaceId post_physical_backing_local_surface_id =
GetLocalSurfaceIdAndConfirmNewerThan(
post_visual_viewport_local_surface_id);
// Exiting Picture-in-Picutre should not throttle either.
TogglePictureInPicture(/*enabled=*/false);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
// Each subsequent visual property change just synchronizes.
OnVisibleViewportSizeChanged(300, 400);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
const viz::LocalSurfaceId post_exit_visual_viewport_local_surface_id =
GetLocalSurfaceIdAndConfirmNewerThan(
post_physical_backing_local_surface_id);
OnPhysicalBackingSizeChanged(fullscreen_portrait_physical_backing);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
GetLocalSurfaceIdAndConfirmNewerThan(
post_exit_visual_viewport_local_surface_id);
}
// Tests that Picture-in-Picture from a fullscreen Portrait context, then
// returning to a Landscape state does not throttle the rotation.
TEST_F(RenderWidgetHostViewAndroidRotationTest,
PortraitPictureInPictureToLandscape) {
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
const viz::LocalSurfaceId post_fullscreen_local_surface_id =
PortraitToFullscreenPortrait();
// Entering Picture-in-Picture should not throttle.
TogglePictureInPicture(/*enabled=*/true);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
// Each subsequent visual property change just synchronizes.
OnVisibleViewportSizeChanged(150, 200);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
const viz::LocalSurfaceId post_visual_viewport_local_surface_id =
GetLocalSurfaceIdAndConfirmNewerThan(post_fullscreen_local_surface_id);
OnPhysicalBackingSizeChanged(gfx::Size(300, 400));
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
const viz::LocalSurfaceId post_physical_backing_local_surface_id =
GetLocalSurfaceIdAndConfirmNewerThan(
post_visual_viewport_local_surface_id);
// We can be notified of new screen info before exiting. However being in
// Picture-in-Picture should not throttle.
SetLandscapeScreenInfo(/*rotation=*/true);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
// Exiting Picture-in-Picutre should not throttle either.
TogglePictureInPicture(/*enabled=*/false);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
// Even a rotation while exiting should not throttle.
OnVisibleViewportSizeChanged(400, 300);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
const viz::LocalSurfaceId post_exit_visual_viewport_local_surface_id =
GetLocalSurfaceIdAndConfirmNewerThan(
post_physical_backing_local_surface_id);
OnPhysicalBackingSizeChanged(fullscreen_landscape_physical_backing);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
const viz::LocalSurfaceId post_exit_physical_backing_local_surface_id =
GetLocalSurfaceIdAndConfirmNewerThan(
post_exit_visual_viewport_local_surface_id);
SetLandscapeScreenInfo(/*rotation=*/true);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
GetLocalSurfaceIdAndConfirmNewerThan(
post_exit_physical_backing_local_surface_id);
}
// When transitioning from a Landscape Fullscreen to Picture-in-Picture we end
// up in a mixed layout state. With Landscape `visual_viewport_size` and
// physical backing, and a Portrait ScreenInfo. We should not start a rotation
// throttle during this.
TEST_F(RenderWidgetHostViewAndroidRotationTest,
LandscapeFullscreenToMixedPictureInPicture) {
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
const viz::LocalSurfaceId post_fullscreen_local_surface_id =
PortraitToFullscreenLanscape();
// Entering Picture-in-Picture should not throttle.
TogglePictureInPicture(/*enabled=*/true);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
// Each subsequent visual property change just synchronizes.
OnVisibleViewportSizeChanged(200, 150);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
const viz::LocalSurfaceId post_visual_viewport_local_surface_id =
GetLocalSurfaceIdAndConfirmNewerThan(post_fullscreen_local_surface_id);
OnPhysicalBackingSizeChanged(gfx::Size(400, 300));
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
const viz::LocalSurfaceId post_physical_backing_local_surface_id =
GetLocalSurfaceIdAndConfirmNewerThan(
post_visual_viewport_local_surface_id);
// Normally the rotation of ScreenInfo would trigger throttling. However in
// Picture-in-Picture mode we can end up with mixed orientations. So we do not
// throttle.
SetPortraitScreenInfo(/*rotation=*/true);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
GetLocalSurfaceIdAndConfirmNewerThan(post_physical_backing_local_surface_id);
}
// Tests that when Picture-in-Picture mode is closed, that we do not throttle
// becoming hidden, or returning to visibility.
TEST_F(RenderWidgetHostViewAndroidRotationTest, PictureInPictureCloses) {
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
const viz::LocalSurfaceId post_fullscreen_local_surface_id =
PortraitToFullscreenLanscape();
// ScreenInfo to rotate to Portrait for Picture-in-Picture can arrive first.
// This rotation is throttled and subsequent Picture-in-Picture mode toggles.
SetPortraitScreenInfo(/*rotation=*/true);
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
// Entering Picture-in-Picture should not throttle.
TogglePictureInPicture(/*enabled=*/true);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
// Each subsequent visual property change just synchronizes.
OnVisibleViewportSizeChanged(200, 150);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
const viz::LocalSurfaceId post_visual_viewport_local_surface_id =
GetLocalSurfaceIdAndConfirmNewerThan(post_fullscreen_local_surface_id);
OnPhysicalBackingSizeChanged(gfx::Size(400, 300));
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
const viz::LocalSurfaceId post_physical_backing_local_surface_id =
GetLocalSurfaceIdAndConfirmNewerThan(
post_visual_viewport_local_surface_id);
// Closing Picture-in-Picture will first hide the view, and exit fullscreen.
// Hiding should not lead to throttle
rwhva->Hide();
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
// Exiting Fullscreen should not throttle.
ExitFullscreenMode();
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
// Exiting Picture-in-Picutre should not throttle even if rotating back to
// Portrait.
TogglePictureInPicture(/*enabled=*/false);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
OnVisibleViewportSizeChanged(300, 400);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
const viz::LocalSurfaceId hidden_local_surface_id =
GetLocalSurfaceIdAndConfirmNewerThan(
post_physical_backing_local_surface_id);
// No throttling when showing again, nor for completing the hidden rotation
rwhva->Show();
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
OnPhysicalBackingSizeChanged(portrait_physical_backing);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
GetLocalSurfaceIdAndConfirmNewerThan(hidden_local_surface_id);
}
// Tests that when we are evicted while waiting for fullscreen transition, that
// we stop throttling, and can successfully re-embed later.
TEST_F(RenderWidgetHostViewAndroidRotationTest, FullscreenEviction) {
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
auto local_surface_id = rwhva->GetLocalSurfaceId();
EnterFullscreenMode();
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
// When we are evicted while hidden, the viz::LocalSurfaceId should be
// invalidated, and we should no longer throttle syncrhonizing.
rwhva->Hide();
rwhva->WasEvicted();
auto evicted_local_surface_id = rwhva->GetLocalSurfaceId();
EXPECT_FALSE(evicted_local_surface_id.is_valid());
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
// This shouldn't crash
rwhva->ShowWithVisibility(blink::mojom::PageVisibilityState::kVisible);
// We should also have a new viz::LocalSurfaceId to become embedded again.
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
GetLocalSurfaceIdAndConfirmNewerThan(local_surface_id);
}
// Tests that when Android fakes visibility to start a rotation, before hiding
// and completing the rotation later, that the rotation timeout and subsequent
// actual visibility change correctly updates the viz::LocalSurfaceId and stops
// all throttling. (https://crbug.com/1383446)
TEST_F(RenderWidgetHostViewAndroidRotationTest, FakeVisibilityScreenRotation) {
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
auto local_surface_id = rwhva->GetLocalSurfaceId();
// Portrait orientation split screen. Same width, reduce height by half but
// keep inset for system status bar. This should not throttle, but should
// advance the viz::LocalSurfaceId
OnVisibleViewportSizeChanged(300, 195);
OnPhysicalBackingSizeChanged(gfx::Size(600, 390));
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
auto split_screen_local_surface_id =
GetLocalSurfaceIdAndConfirmNewerThan(local_surface_id);
// Rotate device to landscape orientation
SetLandscapeScreenInfo(/*rotation=*/true);
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
OnVisibleViewportSizeChanged(200, 295);
OnPhysicalBackingSizeChanged(gfx::Size(400, 590));
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
auto post_rotation_local_surface_id =
GetLocalSurfaceIdAndConfirmNewerThan(split_screen_local_surface_id);
// Hiding should not change throttle
rwhva->Hide();
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
// When turning off the screen some versions of Android lie. They set us
// visible even with the screen off, and rotate the ScreenInfo, but nothing
// else. Followed up by hiding us again.
rwhva->Show();
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
SetPortraitScreenInfo(/*rotation=*/true);
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
rwhva->Hide();
// When off the timeout can fire. It should clear the throttling and advance
// the viz::LocalSurfaceId
FireRotationTimeout();
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
auto post_timeout_local_surface_id =
GetLocalSurfaceIdAndConfirmNewerThan(post_rotation_local_surface_id);
// On some versions of Android the new post-rotation layout can be sent before
// we become visible.
OnVisibleViewportSizeChanged(300, 195);
OnPhysicalBackingSizeChanged(gfx::Size(600, 390));
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
auto post_hidden_rotation_local_surface_id =
GetLocalSurfaceIdAndConfirmNewerThan(post_timeout_local_surface_id);
// When becoming visible we should have the correct layout already and not
// need to advance the viz::LocalSurfaceId. We should also not be throttling.
rwhva->Show();
auto post_show_local_surface_id = rwhva->GetLocalSurfaceId();
EXPECT_EQ(post_show_local_surface_id, post_hidden_rotation_local_surface_id);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
}
// Tests that when toggling FullscreenMode, where no layout changes occur, that
// we unthrottle and advance the viz::LocalSurfaceId after each step.
TEST_F(RenderWidgetHostViewAndroidRotationTest, ToggleFullscreenWithoutResize) {
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
auto local_surface_id = rwhva->GetLocalSurfaceId();
EnterFullscreenMode();
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
// When there has been no resize triggered the timeout can fire. It should
// clear throttling and advance the viz::LocalSurfaceId;
FireFullscreenTimeout();
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
auto post_timeout_local_surface_id =
GetLocalSurfaceIdAndConfirmNewerThan(local_surface_id);
ExitFullscreenMode();
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
auto post_fullscreen_local_surface_id =
GetLocalSurfaceIdAndConfirmNewerThan(post_timeout_local_surface_id);
// When we re-enter fullscreen we should throttle again.
EnterFullscreenMode();
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
// The timeout should once again unthrottle and advance the
// viz::LocalSurfaceId.
FireFullscreenTimeout();
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
GetLocalSurfaceIdAndConfirmNewerThan(post_fullscreen_local_surface_id);
}
// Tests rotation and fullscreen cases that are supported by both the visual
// properties analysis, and the fullscreen killswitch legacy path.
//
// Initializes to Portrait.
class RenderWidgetHostViewAndroidRotationKillswitchTest
: public RenderWidgetHostViewAndroidRotationTest,
public testing::WithParamInterface<bool> {
public:
RenderWidgetHostViewAndroidRotationKillswitchTest() = default;
~RenderWidgetHostViewAndroidRotationKillswitchTest() override = default;
};
// Tests that when a rotation occurs, that we only advance the
// viz::LocalSurfaceId once, and that no other visual changes occurring during
// this time can separately trigger SurfaceSync. (https://crbug.com/1203804)
TEST_F(RenderWidgetHostViewAndroidRotationKillswitchTest,
RotationOnlyAdvancesSurfaceSyncOnce) {
// Android default host and views initialize as visible.
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
EXPECT_TRUE(rwhva->IsShowing());
const viz::LocalSurfaceId initial_local_surface_id =
rwhva->GetLocalSurfaceId();
EXPECT_TRUE(initial_local_surface_id.is_valid());
// When rotation has started we should not be performing Surface Sync. The
// viz::LocalSurfaceId should not have advanced.
SetLandscapeScreenInfo(/*rotation=*/true);
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
EXPECT_EQ(initial_local_surface_id, rwhva->GetLocalSurfaceId());
// When rotation has completed we should begin Surface Sync again. There
// should also be a new viz::LocalSurfaceId.
OnPhysicalBackingSizeChanged(landscape_physical_backing);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
GetLocalSurfaceIdAndConfirmNewerThan(initial_local_surface_id);
}
// Tests that when a rotation occurs while the view is hidden, that we advance
// the viz::LocalSurfaceId upon becoming visible again. Then once rotation has
// completed we update again, and unblock all other visual changes.
// (https://crbug.com/1223299)
TEST_P(RenderWidgetHostViewAndroidRotationKillswitchTest,
HiddenRotationDisplaysImmediately) {
// Android default host and views initialize as visible.
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
EXPECT_TRUE(rwhva->IsShowing());
const viz::LocalSurfaceId initial_local_surface_id =
rwhva->GetLocalSurfaceId();
EXPECT_TRUE(initial_local_surface_id.is_valid());
rwhva->Hide();
// When rotation has started we should not be performing Surface Sync. The
// viz::LocalSurfaceId should not have advanced.
SetLandscapeScreenInfo(/*rotation=*/true);
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
EXPECT_EQ(initial_local_surface_id, rwhva->GetLocalSurfaceId());
// When rotation occurs while hidden we will only have a partial state.
// However we do not want to delay showing content until Android tells us of
// the final state. So we advance the viz::LocalSurfaceId to have the newest
// possible content ready.
rwhva->Show();
GetLocalSurfaceIdAndConfirmNewerThan(initial_local_surface_id);
// We do not block synchronization, as there is no platform consistency in
// resize messages when becoming visible.
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
}
// Test that when the view is hidden, and another enters Fullscreen, that we
// complete the advancement of the viz::LocalSurfaceId upon becoming visible
// again. Since the Fullscreen flow does not trigger
// OnPhysicalBackingSizeChanged, we will continue to block further Surface Sync
// until the post rotation frame has been generated. (https://crbug.com/1223299)
TEST_P(RenderWidgetHostViewAndroidRotationKillswitchTest,
HiddenPartialRotationFromFullscreen) {
// Android default host and views initialize as visible.
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
EXPECT_TRUE(rwhva->IsShowing());
const viz::LocalSurfaceId initial_local_surface_id =
rwhva->GetLocalSurfaceId();
EXPECT_TRUE(initial_local_surface_id.is_valid());
rwhva->Hide();
// When another view enters Fullscreen, all hidden views are notified of the
// start of rotation. We should not be performing Surface Sync. The
// viz::LocalSurfaceId should not have advanced.
SetLandscapeScreenInfo(/*rotation= */ true);
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
EXPECT_EQ(initial_local_surface_id, rwhva->GetLocalSurfaceId());
// When the other view exits Fullscreen, all hidden views are notified of a
// rotation back to the original orientation. We should continue in the same
// state.
SetPortraitScreenInfo(/*rotation=*/true);
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
EXPECT_EQ(initial_local_surface_id, rwhva->GetLocalSurfaceId());
// When the cause of rotation is Fullscreen, we will NOT receive a call to
// OnPhysicalBackingSizeChanged. Due to this we advance the
// viz::LocalSurfaceId upon becoming visible, to send all visual updates to
// the Renderer.
rwhva->Show();
GetLocalSurfaceIdAndConfirmNewerThan(initial_local_surface_id);
// We do not block synchronization, as there is no platform consistency in
// resize messages when becoming visible.
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
}
// Tests that when a rotation occurs, that we accept updated viz::LocalSurfaceId
// from the Renderer, and merge them with any of our own changes.
// (https://crbug.com/1223299)
TEST_P(RenderWidgetHostViewAndroidRotationKillswitchTest,
ChildLocalSurfaceIdsAcceptedDuringRotation) {
// Android default host and views initialize as visible.
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
EXPECT_TRUE(rwhva->IsShowing());
const viz::LocalSurfaceId initial_local_surface_id =
rwhva->GetLocalSurfaceId();
EXPECT_TRUE(initial_local_surface_id.is_valid());
// When rotation has started we should not be performing Surface Sync. The
// viz::LocalSurfaceId should not have advanced.
SetLandscapeScreenInfo(/*rotation=*/true);
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
EXPECT_EQ(initial_local_surface_id, rwhva->GetLocalSurfaceId());
// If the child Renderer advances the viz::LocalSurfaceId we should accept it
// and merge it. So that we are up to date for when rotation completes.
const viz::LocalSurfaceId child_advanced_local_surface_id(
initial_local_surface_id.parent_sequence_number(),
initial_local_surface_id.child_sequence_number() + 1,
initial_local_surface_id.embed_token());
cc::RenderFrameMetadata metadata;
metadata.local_surface_id = child_advanced_local_surface_id;
OnDidUpdateVisualPropertiesComplete(metadata);
GetLocalSurfaceIdAndConfirmNewerThan(initial_local_surface_id);
// Still wait for rotation to end before resuming Surface Sync from other
// sources.
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
}
TEST_P(RenderWidgetHostViewAndroidRotationKillswitchTest, FullscreenRotation) {
// Android default host and views initialize as visible.
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
EXPECT_TRUE(rwhva->IsShowing());
const viz::LocalSurfaceId initial_local_surface_id =
rwhva->GetLocalSurfaceId();
EXPECT_TRUE(initial_local_surface_id.is_valid());
// When entering fullscreen the rotation should behave as normal.
EnterFullscreenMode();
// When rotation has started we should not be performing Surface Sync. The
// viz::LocalSurfaceId should not have advanced.
SetLandscapeScreenInfo(/*rotation= */ true);
// rwhva->OnSynchronizedDisplayPropertiesChanged(/*rotation= */ true);
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
EXPECT_EQ(initial_local_surface_id, rwhva->GetLocalSurfaceId());
// When rotation has completed we should begin Surface Sync again. There
// should also be a new viz::LocalSurfaceId.
OnPhysicalBackingSizeChanged(fullscreen_landscape_physical_backing);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
const viz::LocalSurfaceId post_rotation_local_surface_id =
GetLocalSurfaceIdAndConfirmNewerThan(initial_local_surface_id);
{
cc::RenderFrameMetadata metadata;
metadata.local_surface_id = post_rotation_local_surface_id;
OnRenderFrameMetadataChangedAfterActivation(metadata,
base::TimeTicks::Now());
}
// When exiting rotation the order of visual property updates can differ.
// Though we need to always allow Surface Sync to continue, as WebView will
// send two OnPhysicalBackingSizeChanged in a row to exit fullscreen. While
// non-WebView can alternate some combination of 1-2
// OnPhysicalBackingSizeChanged and OnSynchronizedDisplayPropertiesChanged.
ExitFullscreenMode();
OnPhysicalBackingSizeChanged(landscape_physical_backing);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
const viz::LocalSurfaceId post_fullscreen_local_surface_id =
GetLocalSurfaceIdAndConfirmNewerThan(post_rotation_local_surface_id);
// When rotation begins again it should block Surface Sync again.
SetPortraitScreenInfo(/*rotation=*/true);
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
EXPECT_EQ(post_fullscreen_local_surface_id, rwhva->GetLocalSurfaceId());
// When rotation has completed we should begin Surface Sync again.
OnPhysicalBackingSizeChanged(portrait_physical_backing);
GetLocalSurfaceIdAndConfirmNewerThan(post_fullscreen_local_surface_id);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
{
cc::RenderFrameMetadata metadata;
metadata.local_surface_id = post_fullscreen_local_surface_id;
OnRenderFrameMetadataChangedAfterActivation(metadata,
base::TimeTicks::Now());
}
}
// Tests Rotation improvements that launched with
// features::kSurfaceSyncThrottling flag, and now only exist behind the
// kSurfaceSyncFullscreenKillswitch flag. When off they should directly compare
// visual properties to make throttling determination
INSTANTIATE_TEST_SUITE_P(,
RenderWidgetHostViewAndroidRotationKillswitchTest,
::testing::Bool(),
&PostTestCaseName);
// Tests that when a device's initial orientation is Landscape, that we do not
// treat the initial UpdateScreenInfo as the start of a rotation.
// https://crbug.com/1263723
class RenderWidgetHostViewAndroidLandscapeStartupTest
: public RenderWidgetHostViewAndroidRotationKillswitchTest {
public:
RenderWidgetHostViewAndroidLandscapeStartupTest() = default;
~RenderWidgetHostViewAndroidLandscapeStartupTest() override = default;
protected:
// testing::Test:
void SetUp() override;
};
void RenderWidgetHostViewAndroidLandscapeStartupTest::SetUp() {
// The base rotation test sets up default of Landscape. Skip it.
RenderWidgetHostViewAndroidTest::SetUp();
SetLandscapeScreenInfo(/*rotation=*/false);
OnPhysicalBackingSizeChanged(landscape_physical_backing);
}
// Tests that when a device's initial orientation is Landscape, that we do not
// treat the initial UpdateScreenInfo as the start of a rotation.
// https://crbug.com/1263723
TEST_P(RenderWidgetHostViewAndroidLandscapeStartupTest, LandscapeStartup) {
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
// This method is called when initializing the ScreenInfo, not just on
// subsequent updates. Ensure that initializing to a Landscape orientation
// does not trigger rotation.
rwhva->UpdateScreenInfo();
// We should not be blocking Surface Sync.
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
}
// Tests Rotation improvements that launched with
// features::kSurfaceSyncThrottling flag, and now only exist behind the
// kSurfaceSyncFullscreenKillswitch flag. When off they should directly compare
// visual properties to make throttling determination
INSTANTIATE_TEST_SUITE_P(,
RenderWidgetHostViewAndroidLandscapeStartupTest,
::testing::Bool(),
&PostTestCaseName);
// Tests that when the ScreenInfo and PhysicalBacking are conflicting
// orientations, that entering Fullscreen and changing to a matching
// PhysicalBacking does not throttle. https://crbug.com/1418321
class RenderWidgetHostViewAndroidMixedOrientationStartupTest
: public RenderWidgetHostViewAndroidRotationKillswitchTest {
public:
RenderWidgetHostViewAndroidMixedOrientationStartupTest() = default;
~RenderWidgetHostViewAndroidMixedOrientationStartupTest() override = default;
protected:
// testing::Test:
void SetUp() override;
};
void RenderWidgetHostViewAndroidMixedOrientationStartupTest::SetUp() {
// The base rotation test sets up default of Portrait for both. Skip it.
RenderWidgetHostViewAndroidTest::SetUp();
SetPortraitScreenInfo(/*rotation=*/false);
// Small Landscape view that will expand when switching to Fullscreen.
OnPhysicalBackingSizeChanged(gfx::Size(400, 200));
}
// Tests that when we EnterFullscreenMode and the PhysicalBacking changes to
// match the Portrait ScreenInfo, that we do not block syncing.
TEST_F(RenderWidgetHostViewAndroidMixedOrientationStartupTest,
EnterFullscreenMode) {
RenderWidgetHostViewAndroid* rwhva = render_widget_host_view_android();
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
const viz::LocalSurfaceId initial_local_surface_id =
rwhva->GetLocalSurfaceId();
// When features::kSurfaceSyncFullscreenKillswitch is enabled, entering
// fullscreen mode prevents syncing until we get a non-rotation change to
// sizes.
EnterFullscreenMode();
EXPECT_FALSE(rwhva->CanSynchronizeVisualProperties());
// This is a rotation compared to the initial physical backing, however by
// matching the orientation of the ScreenInfo, we should sync and no longer
// throttle.
OnPhysicalBackingSizeChanged(fullscreen_portrait_physical_backing);
EXPECT_TRUE(rwhva->CanSynchronizeVisualProperties());
GetLocalSurfaceIdAndConfirmNewerThan(initial_local_surface_id);
}
} // namespace content