1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
content / browser / renderer_host / render_widget_host_view_mac_editcommand_helper_unittest.mm [blame]
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#import "content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper.h"
#import <Cocoa/Cocoa.h>
#include <stddef.h>
#include <stdint.h>
#include "base/apple/scoped_nsautorelease_pool.h"
#include "base/memory/raw_ptr.h"
#include "base/task/single_thread_task_runner.h"
#include "base/test/task_environment.h"
#include "content/browser/gpu/compositor_util.h"
#include "content/browser/renderer_host/frame_token_message_queue.h"
#include "content/browser/renderer_host/render_widget_host_delegate.h"
#include "content/browser/renderer_host/render_widget_host_factory.h"
#include "content/browser/renderer_host/render_widget_host_impl.h"
#include "content/browser/renderer_host/visible_time_request_trigger.h"
#include "content/browser/site_instance_group.h"
#include "content/browser/site_instance_impl.h"
#include "content/public/test/browser_task_environment.h"
#include "content/public/test/mock_render_process_host.h"
#include "content/public/test/test_browser_context.h"
#include "content/public/test/test_image_transport_factory.h"
#include "mojo/public/cpp/bindings/pending_remote.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
#include "ui/accelerated_widget_mac/window_resize_helper_mac.h"
#include "ui/base/resource/resource_scale_factor.h"
#include "ui/display/screen.h"
using content::RenderWidgetHostViewMac;
// Bare bones obj-c class for testing purposes.
@interface RenderWidgetHostViewMacEditCommandHelperTestClass : NSObject
@end
@implementation RenderWidgetHostViewMacEditCommandHelperTestClass
@end
// Class that owns a RenderWidgetHostViewMac.
@interface RenderWidgetHostNSViewHostOwner
: NSObject <RenderWidgetHostNSViewHostOwner> {
raw_ptr<RenderWidgetHostViewMac> _rwhvm;
}
- (id)initWithRenderWidgetHostViewMac:(RenderWidgetHostViewMac*)rwhvm;
@end
@implementation RenderWidgetHostNSViewHostOwner
- (id)initWithRenderWidgetHostViewMac:(RenderWidgetHostViewMac*)rwhvm {
if ((self = [super init])) {
_rwhvm = rwhvm;
}
return self;
}
- (remote_cocoa::mojom::RenderWidgetHostNSViewHost*)renderWidgetHostNSViewHost {
return _rwhvm;
}
@end
namespace content {
namespace {
// Returns true if all the edit command names in the array are present in
// test_obj. edit_commands is a list of NSStrings, selector names are formed
// by appending a trailing ':' to the string.
bool CheckObjectRespondsToEditCommands(NSArray* edit_commands, id test_obj) {
for (NSString* edit_command_name in edit_commands) {
NSString* sel_str = [edit_command_name stringByAppendingString:@":"];
if (![test_obj respondsToSelector:NSSelectorFromString(sel_str)]) {
return false;
}
}
return true;
}
class RenderWidgetHostDelegateEditCommandCounter
: public RenderWidgetHostDelegate {
public:
RenderWidgetHostDelegateEditCommandCounter() = default;
~RenderWidgetHostDelegateEditCommandCounter() override = default;
unsigned int edit_command_message_count_ = 0;
private:
void ExecuteEditCommand(const std::string& command,
const std::optional<std::u16string>& value) override {
edit_command_message_count_++;
}
void Undo() override {}
void Redo() override {}
void Cut() override {}
void Copy() override {}
void Paste() override {}
void PasteAndMatchStyle() override {}
void SelectAll() override {}
VisibleTimeRequestTrigger& GetVisibleTimeRequestTrigger() override {
return visible_time_request_trigger_;
}
VisibleTimeRequestTrigger visible_time_request_trigger_;
};
class RenderWidgetHostViewMacEditCommandHelperTest : public PlatformTest {
protected:
void SetUp() override {
ImageTransportFactory::SetFactory(
std::make_unique<TestImageTransportFactory>());
}
void TearDown() override { ImageTransportFactory::Terminate(); }
private:
base::test::SingleThreadTaskEnvironment task_environment_;
};
class RenderWidgetHostViewMacEditCommandHelperWithTaskEnvTest
: public PlatformTest {
protected:
void SetUp() override {
ImageTransportFactory::SetFactory(
std::make_unique<TestImageTransportFactory>());
}
void TearDown() override { ImageTransportFactory::Terminate(); }
private:
display::ScopedNativeScreen screen_;
// This has a MessageLoop for ImageTransportFactory and enables
// BrowserThread::UI for RecyclableCompositorMac used by
// RenderWidgetHostViewMac.
content::BrowserTaskEnvironment task_environment_;
};
} // namespace
// Tests that editing commands make it through the pipeline all the way to
// RenderWidgetHost.
TEST_F(RenderWidgetHostViewMacEditCommandHelperWithTaskEnvTest,
TestEditingCommandDelivery) {
RenderWidgetHostDelegateEditCommandCounter delegate;
TestBrowserContext browser_context;
MockRenderProcessHostFactory process_host_factory;
RenderProcessHost* process_host =
process_host_factory.CreateRenderProcessHost(&browser_context, nullptr);
scoped_refptr<SiteInstanceGroup> site_instance_group = base::WrapRefCounted(
SiteInstanceGroup::CreateForTesting(&browser_context, process_host));
ui::test::ScopedSetSupportedResourceScaleFactors scoped_supported(
{ui::k100Percent});
@autoreleasepool {
int32_t routing_id = process_host->GetNextRoutingID();
std::unique_ptr<RenderWidgetHostImpl> render_widget =
RenderWidgetHostFactory::Create(
/*frame_tree=*/nullptr, &delegate,
RenderWidgetHostImpl::DefaultFrameSinkId(*site_instance_group,
routing_id),
site_instance_group->GetSafeRef(), routing_id,
/*hidden=*/false, /*renderer_initiated_creation=*/false);
ui::WindowResizeHelperMac::Get()->Init(
base::SingleThreadTaskRunner::GetCurrentDefault());
// Owned by its |GetInProcessNSView()|, i.e. |rwhv_cocoa|.
RenderWidgetHostViewMac* rwhv_mac =
new RenderWidgetHostViewMac(render_widget.get());
// ARC conversion note: the previous version of this code held this view
// strongly throughout with a scoped_nsobject. The precise lifetime
// attribute replicates that but it's not clear if it's necessary.
[[maybe_unused]] NS_VALID_UNTIL_END_OF_SCOPE RenderWidgetHostViewCocoa*
rwhv_cocoa = rwhv_mac->GetInProcessNSView();
NSArray* edit_command_strings = RenderWidgetHostViewMacEditCommandHelper::
GetEditSelectorNamesForTesting();
RenderWidgetHostNSViewHostOwner* rwhwvm_owner =
[[RenderWidgetHostNSViewHostOwner alloc]
initWithRenderWidgetHostViewMac:rwhv_mac];
RenderWidgetHostViewMacEditCommandHelper::AddEditingSelectorsToClass(
[rwhwvm_owner class]);
for (NSString* edit_command_name in edit_command_strings) {
NSString* sel_str = [edit_command_name stringByAppendingString:@":"];
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Warc-performSelector-leaks"
[rwhwvm_owner performSelector:NSSelectorFromString(sel_str)
withObject:nil];
#pragma clang diagnostic pop
}
size_t num_edit_commands = edit_command_strings.count;
EXPECT_EQ(delegate.edit_command_message_count_, num_edit_commands);
rwhv_cocoa = nil;
}
process_host->Cleanup();
ui::WindowResizeHelperMac::Get()->ShutdownForTests();
}
// Test RenderWidgetHostViewMacEditCommandHelper::AddEditingSelectorsToClass
TEST_F(RenderWidgetHostViewMacEditCommandHelperTest,
TestAddEditingSelectorsToClass) {
RenderWidgetHostViewMacEditCommandHelper helper;
NSArray* edit_command_strings = RenderWidgetHostViewMacEditCommandHelper::
GetEditSelectorNamesForTesting();
ASSERT_GT(edit_command_strings.count, 0U);
// Create a class instance and add methods to the class.
RenderWidgetHostViewMacEditCommandHelperTestClass* test_obj =
[[RenderWidgetHostViewMacEditCommandHelperTestClass alloc] init];
// Check that edit commands aren't already attached to the object.
ASSERT_FALSE(CheckObjectRespondsToEditCommands(edit_command_strings,
test_obj));
RenderWidgetHostViewMacEditCommandHelper::AddEditingSelectorsToClass(
[test_obj class]);
// Check that all edit commands where added.
ASSERT_TRUE(CheckObjectRespondsToEditCommands(edit_command_strings,
test_obj));
// AddEditingSelectorsToClass() should be idempotent.
RenderWidgetHostViewMacEditCommandHelper::AddEditingSelectorsToClass(
[test_obj class]);
// Check that all edit commands are still there.
ASSERT_TRUE(CheckObjectRespondsToEditCommands(edit_command_strings,
test_obj));
}
// Test RenderWidgetHostViewMacEditCommandHelper::IsMenuItemEnabled.
TEST_F(RenderWidgetHostViewMacEditCommandHelperTest, TestMenuItemEnabling) {
RenderWidgetHostViewMacEditCommandHelper helper;
RenderWidgetHostNSViewHostOwner* rwhvm_owner =
[[RenderWidgetHostNSViewHostOwner alloc] init];
// The select all menu should always be enabled.
SEL select_all = NSSelectorFromString(@"selectAll:");
ASSERT_TRUE(helper.IsMenuItemEnabled(select_all, rwhvm_owner));
// Random selectors should be enabled by the function.
SEL garbage_selector = NSSelectorFromString(@"randomGarbageSelector:");
ASSERT_FALSE(helper.IsMenuItemEnabled(garbage_selector, rwhvm_owner));
// TODO(jeremy): Currently IsMenuItemEnabled just returns true for all edit
// selectors. Once we go past that we should do more extensive testing here.
}
} // namespace content