1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
content / browser / web_package / signed_exchange_envelope_unittest.cc [blame]
// Copyright 2018 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifdef UNSAFE_BUFFERS_BUILD
// TODO(crbug.com/342213636): Remove this and spanify to fix the errors.
#pragma allow_unsafe_buffers
#endif
#include "content/browser/web_package/signed_exchange_envelope.h"
#include <string_view>
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/functional/callback.h"
#include "base/path_service.h"
#include "components/cbor/values.h"
#include "components/cbor/writer.h"
#include "content/browser/web_package/signed_exchange_consts.h"
#include "content/browser/web_package/signed_exchange_prologue.h"
#include "content/public/common/content_paths.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace content {
namespace {
const char kSignatureString[] =
"sig1;"
" sig=*MEUCIQDXlI2gN3RNBlgFiuRNFpZXcDIaUpX6HIEwcZEc0cZYLAIga9DsVOMM+"
"g5YpwEBdGW3sS+bvnmAJJiSMwhuBdqp5UY=*;"
" integrity=\"mi-draft2\";"
" validity-url=\"https://test.example.org/resource.validity.1511128380\";"
" cert-url=\"https://example.com/oldcerts\";"
" cert-sha256=*W7uB969dFW3Mb5ZefPS9Tq5ZbH5iSmOILpjv2qEArmI=*;"
" date=1511128380; expires=1511733180";
cbor::Value CBORByteString(const char* str) {
return cbor::Value(str, cbor::Value::Type::BYTE_STRING);
}
std::optional<SignedExchangeEnvelope> GenerateHeaderAndParse(
SignedExchangeVersion version,
std::string_view fallback_url,
std::string_view signature,
const std::map<const char*, const char*>& response_map) {
cbor::Value::MapValue response_cbor_map;
for (auto& pair : response_map)
response_cbor_map[CBORByteString(pair.first)] = CBORByteString(pair.second);
DCHECK_EQ(version, SignedExchangeVersion::kB3);
auto serialized =
cbor::Writer::Write(cbor::Value(std::move(response_cbor_map)));
return SignedExchangeEnvelope::Parse(
version, signed_exchange_utils::URLWithRawString(fallback_url), signature,
base::make_span(serialized->data(), serialized->size()),
nullptr /* devtools_proxy */);
}
} // namespace
class SignedExchangeEnvelopeTest
: public ::testing::TestWithParam<SignedExchangeVersion> {};
TEST_P(SignedExchangeEnvelopeTest, ParseGoldenFile) {
base::FilePath test_sxg_path;
base::PathService::Get(content::DIR_TEST_DATA, &test_sxg_path);
test_sxg_path =
test_sxg_path.AppendASCII("sxg").AppendASCII("test.example.org_test.sxg");
std::string contents;
ASSERT_TRUE(base::ReadFileToString(test_sxg_path, &contents));
auto* contents_bytes = reinterpret_cast<const uint8_t*>(contents.data());
ASSERT_GT(contents.size(),
signed_exchange_prologue::BeforeFallbackUrl::kEncodedSizeInBytes);
signed_exchange_prologue::BeforeFallbackUrl prologue_a =
signed_exchange_prologue::BeforeFallbackUrl::Parse(
base::make_span(
contents_bytes,
signed_exchange_prologue::BeforeFallbackUrl::kEncodedSizeInBytes),
nullptr /* devtools_proxy */);
ASSERT_GT(contents.size(),
signed_exchange_prologue::BeforeFallbackUrl::kEncodedSizeInBytes +
prologue_a.ComputeFallbackUrlAndAfterLength());
signed_exchange_prologue::FallbackUrlAndAfter prologue_b =
signed_exchange_prologue::FallbackUrlAndAfter::Parse(
base::make_span(contents_bytes +
signed_exchange_prologue::BeforeFallbackUrl::
kEncodedSizeInBytes,
prologue_a.ComputeFallbackUrlAndAfterLength()),
prologue_a, nullptr /* devtools_proxy */);
size_t signature_header_field_offset =
signed_exchange_prologue::BeforeFallbackUrl::kEncodedSizeInBytes +
prologue_a.ComputeFallbackUrlAndAfterLength();
std::string_view signature_header_field(
contents.data() + signature_header_field_offset,
prologue_b.signature_header_field_length());
const auto cbor_bytes =
base::make_span(contents_bytes + signature_header_field_offset +
prologue_b.signature_header_field_length(),
prologue_b.cbor_header_length());
const std::optional<SignedExchangeEnvelope> envelope =
SignedExchangeEnvelope::Parse(
SignedExchangeVersion::kB3, prologue_b.fallback_url(),
signature_header_field, cbor_bytes, nullptr /* devtools_proxy */);
ASSERT_TRUE(envelope.has_value());
EXPECT_EQ(envelope->request_url().url,
GURL("https://test.example.org/test/"));
EXPECT_EQ(envelope->response_code(), static_cast<net::HttpStatusCode>(200u));
EXPECT_EQ(envelope->response_headers().size(), 4u);
EXPECT_EQ(envelope->response_headers().find("content-encoding")->second,
"mi-sha256-03");
}
TEST_P(SignedExchangeEnvelopeTest, ValidHeader) {
auto header = GenerateHeaderAndParse(
GetParam(), "https://test.example.org/test/", kSignatureString,
{{kStatusKey, "200"}, {"content-type", "text/html"}, {"digest", "foo"}});
ASSERT_TRUE(header.has_value());
EXPECT_EQ(header->request_url().url, GURL("https://test.example.org/test/"));
EXPECT_EQ(header->response_code(), static_cast<net::HttpStatusCode>(200u));
EXPECT_EQ(header->response_headers().size(), 3u);
EXPECT_EQ(header->response_headers().find("content-type")->second,
"text/html");
EXPECT_EQ(header->response_headers().find("digest")->second, "foo");
EXPECT_EQ(header->response_headers().find("x-content-type-options")->second,
"nosniff"); // Injected by SignedExchangeEnvelope.
}
TEST_P(SignedExchangeEnvelopeTest, InformationalResponseCode) {
auto header = GenerateHeaderAndParse(
GetParam(), "https://test.example.org/test/", kSignatureString,
{
{kStatusKey, "100"},
{"content-type", "text/html"},
});
ASSERT_FALSE(header.has_value());
}
TEST_P(SignedExchangeEnvelopeTest, RelativeURL) {
auto header = GenerateHeaderAndParse(GetParam(), "test/", kSignatureString,
{
{kStatusKey, "200"},
{"content-type", "text/html"},
});
ASSERT_FALSE(header.has_value());
}
TEST_P(SignedExchangeEnvelopeTest, HttpURLShouldFail) {
auto header = GenerateHeaderAndParse(
GetParam(), "http://test.example.org/test/", kSignatureString,
{
{kStatusKey, "200"},
{"content-type", "text/html"},
});
ASSERT_FALSE(header.has_value());
}
TEST_P(SignedExchangeEnvelopeTest, RedirectStatusShouldFail) {
auto header =
GenerateHeaderAndParse(GetParam(), "https://test.example.org/test/",
kSignatureString, {{kStatusKey, "302"}});
ASSERT_FALSE(header.has_value());
}
TEST_P(SignedExchangeEnvelopeTest, Status300ShouldFail) {
auto header = GenerateHeaderAndParse(
GetParam(), "https://test.example.org/test/", kSignatureString,
{{kStatusKey, "300"}, // 300 is not a redirect status.
{"content-type", "text/html"}});
ASSERT_FALSE(header.has_value());
}
TEST_P(SignedExchangeEnvelopeTest, StatefulResponseHeader) {
auto header = GenerateHeaderAndParse(
GetParam(), "https://test.example.org/test/", kSignatureString,
{
{kStatusKey, "200"},
{"content-type", "text/html"},
{"set-cookie", "foo=bar"},
});
ASSERT_FALSE(header.has_value());
}
TEST_P(SignedExchangeEnvelopeTest, UppercaseResponseMap) {
auto header = GenerateHeaderAndParse(
GetParam(), "https://test.example.org/test/", kSignatureString,
{{kStatusKey, "200"},
{"content-type", "text/html"},
{"Content-Length", "123"}});
ASSERT_FALSE(header.has_value());
}
TEST_P(SignedExchangeEnvelopeTest, InvalidValidityURLHeader) {
auto header = GenerateHeaderAndParse(
GetParam(), "https://test2.example.org/test/", kSignatureString,
{{kStatusKey, "200"}, {"content-type", "text/html"}});
ASSERT_FALSE(header.has_value());
}
TEST_P(SignedExchangeEnvelopeTest, NoContentType) {
auto header =
GenerateHeaderAndParse(GetParam(), "https://test.example.org/test/",
kSignatureString, {{kStatusKey, "200"}});
ASSERT_FALSE(header.has_value());
}
TEST_P(SignedExchangeEnvelopeTest, XContentTypeOptionsShouldBeOverwritten) {
auto header = GenerateHeaderAndParse(
GetParam(), "https://test.example.org/test/", kSignatureString,
{{kStatusKey, "200"},
{"content-type", "text/html"},
{"x-content-type-options", "foo"}});
ASSERT_TRUE(header.has_value());
EXPECT_EQ(header->response_headers().find("x-content-type-options")->second,
"nosniff");
}
TEST_P(SignedExchangeEnvelopeTest, InnerResponseIsSXG) {
auto header = GenerateHeaderAndParse(
GetParam(), "https://test.example.org/test/", kSignatureString,
{{kStatusKey, "200"},
{"content-type", "application/signed-exchange;v=b3"}});
ASSERT_FALSE(header.has_value());
}
TEST_P(SignedExchangeEnvelopeTest, CacheControlNoStore) {
auto header = GenerateHeaderAndParse(
GetParam(), "https://test.example.org/test/", kSignatureString,
{
{kStatusKey, "200"},
{"content-type", "text/html"},
{"cache-control", "no-store"},
});
ASSERT_FALSE(header.has_value());
}
TEST_P(SignedExchangeEnvelopeTest, CacheControlSecondValueIsNoStore) {
auto header = GenerateHeaderAndParse(
GetParam(), "https://test.example.org/test/", kSignatureString,
{
{kStatusKey, "200"},
{"content-type", "text/html"},
{"cache-control", "max-age=300, no-store"},
});
ASSERT_FALSE(header.has_value());
}
TEST_P(SignedExchangeEnvelopeTest, CacheControlPrivateWithValue) {
auto header = GenerateHeaderAndParse(
GetParam(), "https://test.example.org/test/", kSignatureString,
{
{kStatusKey, "200"},
{"content-type", "text/html"},
{"cache-control", "private=foo"},
});
ASSERT_FALSE(header.has_value());
}
TEST_P(SignedExchangeEnvelopeTest, CacheControlNoStoreInQuotedString) {
auto header = GenerateHeaderAndParse(
GetParam(), "https://test.example.org/test/", kSignatureString,
{
{kStatusKey, "200"},
{"content-type", "text/html"},
{"cache-control", "foo=\"300, no-store\""},
{"digest", "foo"},
});
ASSERT_TRUE(header.has_value());
}
TEST_P(SignedExchangeEnvelopeTest, CacheControlParseError) {
auto header = GenerateHeaderAndParse(
GetParam(), "https://test.example.org/test/", kSignatureString,
{
{kStatusKey, "200"},
{"content-type", "text/html"},
{"cache-control", "max-age=\"abc"},
});
ASSERT_FALSE(header.has_value());
}
INSTANTIATE_TEST_SUITE_P(SignedExchangeEnvelopeTests,
SignedExchangeEnvelopeTest,
::testing::Values(SignedExchangeVersion::kB3));
} // namespace content