1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
gpu / command_buffer / service / service_font_manager.cc [blame]
// Copyright 2018 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "gpu/command_buffer/service/service_font_manager.h"
#include <inttypes.h>
#include <bit>
#include <type_traits>
#include "base/bits.h"
#include "base/debug/dump_without_crashing.h"
#include "base/logging.h"
#include "base/memory/raw_ptr.h"
#include "base/metrics/histogram_macros.h"
#include "base/numerics/checked_math.h"
#include "base/rand_util.h"
#include "base/strings/stringprintf.h"
#include "components/crash/core/common/crash_key.h"
#include "gpu/command_buffer/common/buffer.h"
#include "gpu/command_buffer/common/discardable_handle.h"
namespace gpu {
namespace {
class Deserializer {
public:
Deserializer(const volatile uint8_t* memory, uint32_t memory_size)
: memory_(memory), memory_size_(memory_size) {}
~Deserializer() = default;
template <typename T>
bool Read(T* val) {
static_assert(std::is_trivially_copyable_v<T>);
if (!AlignMemory(sizeof(T), alignof(T)))
return false;
memcpy(val, const_cast<const uint8_t*>(memory_.get()), sizeof(T));
memory_ += sizeof(T);
bytes_read_ += sizeof(T);
return true;
}
bool ReadStrikeData(SkStrikeClient* strike_client, uint32_t size) {
if (size == 0u)
return true;
if (!AlignMemory(size, 16))
return false;
if (size > memory_size_ - bytes_read_)
return false;
if (!strike_client->readStrikeData(memory_, size))
return false;
bytes_read_ += size;
memory_ += size;
return true;
}
private:
bool AlignMemory(uint32_t size, size_t alignment) {
// Due to the math below, alignment must be a power of two.
DCHECK(std::has_single_bit(alignment));
size_t padding = base::bits::AlignUp(memory_.get(), alignment) - memory_;
base::CheckedNumeric<uint32_t> checked_padded_size = bytes_read_;
checked_padded_size += padding;
checked_padded_size += size;
uint32_t padded_size = 0;
if (!checked_padded_size.AssignIfValid(&padded_size) ||
padded_size > memory_size_) {
return false;
}
memory_ += padding;
bytes_read_ += padding;
return true;
}
raw_ptr<const volatile uint8_t, AllowPtrArithmetic> memory_;
uint32_t memory_size_;
uint32_t bytes_read_ = 0u;
};
} // namespace
class ServiceFontManager::SkiaDiscardableManager
: public SkStrikeClient::DiscardableHandleManager {
public:
explicit SkiaDiscardableManager(
scoped_refptr<ServiceFontManager> font_manager)
: font_manager_(std::move(font_manager)) {}
~SkiaDiscardableManager() override = default;
static constexpr int kMaxDumps = 5;
bool deleteHandle(SkDiscardableHandleId handle_id) override {
if (!font_manager_)
return true;
return font_manager_->DeleteHandle(handle_id);
}
void notifyCacheMiss(SkStrikeClient::CacheMissType type,
int fontSize) override {
UMA_HISTOGRAM_ENUMERATION("GPU.OopRaster.GlyphCacheMiss", type,
SkStrikeClient::CacheMissType::kLast + 1);
// In general, Skia analysis of glyphs should find all cases.
// If this is not happening, please file a bug with a repro so
// it can be fixed.
static crash_reporter::CrashKeyString<64> crash_key("oop_cache_miss");
static constexpr char kFormatString[] = "type: %" PRIu32 ", fontSize: %d";
#if DCHECK_IS_ON()
crash_reporter::ScopedCrashKeyString auto_clear(
&crash_key, base::StringPrintf(kFormatString, type, fontSize));
NOTREACHED();
#else
if (dump_count_ < kMaxDumps && base::RandInt(1, 100) == 1 &&
!font_manager_->disable_oopr_debug_crash_dump()) {
crash_reporter::ScopedCrashKeyString auto_clear(
&crash_key, base::StringPrintf(kFormatString, type, fontSize));
base::debug::DumpWithoutCrashing();
++dump_count_;
}
#endif
}
void notifyReadFailure(
const DiscardableHandleManager::ReadFailureData& data) override {
if (dump_count_ >= kMaxDumps)
return;
std::string str = base::StringPrintf(
"ms: %zd, br: %zd, ts: %" PRIu64 ", sc: %" PRIu64 ", gic: %" PRIu64
", gpc: %" PRIu64,
data.memorySize, data.bytesRead, data.typefaceSize, data.strikeCount,
data.glyphImagesCount, data.glyphPathsCount);
static crash_reporter::CrashKeyString<128> crash_key("oop_read_failure");
crash_reporter::ScopedCrashKeyString auto_clear(&crash_key, str);
++dump_count_;
base::debug::DumpWithoutCrashing();
}
private:
int dump_count_ = 0;
scoped_refptr<ServiceFontManager> font_manager_;
};
ServiceFontManager::ServiceFontManager(Client* client,
bool disable_oopr_debug_crash_dump)
: client_(client),
client_thread_id_(base::PlatformThread::CurrentId()),
strike_client_(std::make_unique<SkStrikeClient>(
sk_make_sp<SkiaDiscardableManager>(this))),
disable_oopr_debug_crash_dump_(disable_oopr_debug_crash_dump) {}
ServiceFontManager::~ServiceFontManager() {
DCHECK(destroyed_);
DLOG_IF(ERROR, !discardable_handle_map_.empty())
<< "discardable_handle_map_ is not empty.";
}
void ServiceFontManager::Destroy() {
base::AutoLock hold(lock_);
client_ = nullptr;
strike_client_.reset();
destroyed_ = true;
}
bool ServiceFontManager::Deserialize(
const volatile uint8_t* memory,
uint32_t memory_size,
std::vector<SkDiscardableHandleId>* locked_handles) {
base::ReleasableAutoLock hold(&lock_);
DCHECK_EQ(client_thread_id_, base::PlatformThread::CurrentId());
DCHECK(locked_handles->empty());
DCHECK(!destroyed_);
// All new handles.
Deserializer deserializer(memory, memory_size);
uint32_t new_handles_created;
if (!deserializer.Read<uint32_t>(&new_handles_created))
return false;
for (uint32_t i = 0; i < new_handles_created; ++i) {
SerializableSkiaHandle handle;
if (!deserializer.Read<SerializableSkiaHandle>(&handle))
return false;
scoped_refptr<gpu::Buffer> buffer = client_->GetShmBuffer(handle.shm_id);
if (!DiscardableHandleBase::ValidateParameters(buffer.get(),
handle.byte_offset)) {
return false;
}
if (!AddHandle(handle.handle_id,
ServiceDiscardableHandle(
std::move(buffer), handle.byte_offset, handle.shm_id))) {
return false;
}
}
// All locked handles
uint32_t num_locked_handles;
if (!deserializer.Read<uint32_t>(&num_locked_handles))
return false;
// Loosely avoid extremely large (but fake) numbers of locked handles.
if (memory_size / sizeof(SkDiscardableHandleId) < num_locked_handles)
return false;
locked_handles->resize(num_locked_handles);
for (auto& locked_handle : *locked_handles) {
if (!deserializer.Read<SkDiscardableHandleId>(&locked_handle))
return false;
auto it = discardable_handle_map_.find(locked_handle);
if (it == discardable_handle_map_.end()) {
DLOG(ERROR) << "Got an invalid SkDiscardableHandleId:" << locked_handle;
continue;
}
it->second.Lock();
}
// Skia font data.
uint32_t skia_data_size = 0u;
if (!deserializer.Read<uint32_t>(&skia_data_size))
return false;
hold.Release();
if (!deserializer.ReadStrikeData(strike_client_.get(), skia_data_size))
return false;
return true;
}
bool ServiceFontManager::AddHandle(SkDiscardableHandleId handle_id,
ServiceDiscardableHandle handle) {
bool inserted;
std::tie(std::ignore, inserted) =
discardable_handle_map_.try_emplace(handle_id, std::move(handle));
return inserted;
}
bool ServiceFontManager::Unlock(
const std::vector<SkDiscardableHandleId>& handles) {
base::AutoLock hold(lock_);
for (auto handle_id : handles) {
auto it = discardable_handle_map_.find(handle_id);
if (it == discardable_handle_map_.end())
return false;
it->second.Unlock();
}
return true;
}
bool ServiceFontManager::DeleteHandle(SkDiscardableHandleId handle_id) {
base::AutoLock hold(lock_);
// If this method returns true, the strike associated with the handle will be
// deleted which deletes the memory for all glyphs cached by the strike. On
// mac this is resulting in hangs during strike deserialization when a bunch
// of strikes may be deleted in bulk. Try to avoid that by pinging the
// progress reporter before deleting each strike.
// Note that this method should generally only run on the Gpu main thread,
// where skia is used, except for single process webview where the renderer
// and GPU run in the same process.
const bool report_progress =
base::PlatformThread::CurrentId() == client_thread_id_ && !destroyed_;
auto it = discardable_handle_map_.find(handle_id);
if (it == discardable_handle_map_.end()) {
LOG(ERROR) << "Tried to delete invalid SkDiscardableHandleId: "
<< handle_id;
if (report_progress) {
DCHECK(client_);
client_->ReportProgress();
}
return true;
}
// If the renderer is destroyed, we just need check if the local ref count is
// 0.
bool deleted = destroyed_ ? it->second.ref_count() == 0 : it->second.Delete();
if (!deleted)
return false;
DCHECK_EQ(it->second.ref_count(), 0);
discardable_handle_map_.erase(it);
if (report_progress) {
DCHECK(client_);
client_->ReportProgress();
}
return true;
}
} // namespace gpu