1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
infra / config / migration / values.py [blame]
# Copyright 2024 The Chromium Authors
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
"""Utilities for creating starlark values.
The convert_direct function converts python values when the starlark
value is the direct translation. The convert_swarming function converts
the swarming dict present in pyl files to a targets.swarming call.
3 classes are provided that enable building compound values for starlark
output: CallValueBuilder, DictValueBuilder and ListValueBuilder for
building function call, dict literal and list literal values,
respectively. Objects of each class can be initialized with elements
and/or updated using the [] operator for CallValueBuilder and
DictValueBuilder or the append method for ListValueBuilder.
The text form of the value can be obtained from all 3 classes by calling
the output method.
The parameter values of a call, item values of a dict or elements of a
list can be either strings or value builders. Value builders can contain
0 or more entries (arguments in a function call, dict items, list
elements). Unless the value builder is constructed with
output_empty=True, if the value builder has no entries, it will not
produce any output. In that case, any entry using that value will be
ignored when producing output for the containing object.
This makes it simple to combine ValueBuilders in specified orders
without having to worry about conditonalizing their creation while
matching on dict keys in a loop.
e.g.
must_be_first_if_present_builder = CallBuilder('foo')
list_builder = ListBuilder([must_be_first_if_present_builder])
for k, v in d.items():
match k:
case 'foo':
must_be_first_if_present_builder['arg'] = value
case _:
list_builder.append(v)
Given
d = {'bar': 'x', 'baz': 'y', 'foo': 'z'}
list_builder.output will be
[
foo(
arg = z,
),
'x',
'y',
]
Given
d = {'bar', 'x', 'baz', 'y'}
list_builder.output will be
[
'x',
'y',
]
"""
import abc
import typing
# A value that can be contained by another value. A string value will be output
# as-is. A ValueBuilder may or may not produce output.
Value: typing.TypeAlias = 'str | ValueBuilder'
def to_output(value: Value) -> str | None:
"""Get the output for a starlark value."""
if isinstance(value, ValueBuilder):
return value.output()
return value
_MAGIC_ARG_MAPPING = {
'$$MAGIC_SUBSTITUTION_ChromeOSTelemetryRemote': 'CROS_TELEMETRY_REMOTE',
'$$MAGIC_SUBSTITUTION_ChromeOSGtestFilterFile': 'CROS_GTEST_FILTER_FILE',
'$$MAGIC_SUBSTITUTION_GPUExpectedVendorId': 'GPU_EXPECTED_VENDOR_ID',
'$$MAGIC_SUBSTITUTION_GPUExpectedDeviceId': 'GPU_EXPECTED_DEVICE_ID',
'$$MAGIC_SUBSTITUTION_GPUParallelJobs': 'GPU_PARALLEL_JOBS',
'$$MAGIC_SUBSTITUTION_GPUTelemetryNoRootForUnrootedDevices':
'GPU_TELEMETRY_NO_ROOT_FOR_UNROOTED_DEVICES',
'$$MAGIC_SUBSTITUTION_GPUWebGLRuntimeFile': 'GPU_WEBGL_RUNTIME_FILE',
}
def convert_arg(arg: str) -> Value:
"""Convert a test argument to a starlark value.
In //testing/buildbot, there are magic strings that trigger special
replacement behavior. In starlark, these are replaced with struct
values. This function takes care of converting the argument to a
string or a magic struct as appropriate.
"""
if arg.startswith('$$MAGIC_SUBSTITUTION_'):
return f'targets.magic_args.{_MAGIC_ARG_MAPPING[arg]}'
return convert_direct(arg)
def convert_args(args: list[str]) -> Value:
"""Convert a list of test arguments to a starlark value.
In //testing/buildbot, there are magic strings that trigger special
replacement behavior. In starlark, these are replaced with struct
values. This function takes care of converting the indiviual arguments
to a string or a magic struct as appropriate.
"""
return ListValueBuilder([convert_arg(arg) for arg in args])
def convert_direct(value: typing.Any) -> Value:
"""Convert a python value to a starlark value.
This converts python values where the starlark representation is the
same.
"""
if value is None or isinstance(value, (int, bool)):
return str(value)
if isinstance(value, str):
return f'"{value}"'
if isinstance(value, list):
return ListValueBuilder([convert_direct(e) for e in value])
if isinstance(value, dict):
return DictValueBuilder({
convert_direct(k): convert_direct(v)
for k, v in value.items()
})
raise Exception(f'unhandled python value: {value!r}')
def convert_resultdb(resultdb: dict[str, typing.Any]) -> Value:
"""Convert a resultdb dict to a targets.resultdb call."""
value_builder = CallValueBuilder('targets.resultdb')
for key, value in resultdb.items():
match key:
case 'enable':
value_builder[key] = convert_direct(value)
case _:
raise Exception(f'unhandled key in resultdb: "{key}"')
return value_builder
def convert_swarming(swarming: dict[str, typing.Any]) -> Value:
"""Convert a swarming dict to a targets.swarming call."""
value_builder = CallValueBuilder('targets.swarming')
for key, value in swarming.items():
match key:
case 'dimensions' | 'idempotent' | 'service_account' | 'shards':
value_builder[key] = convert_direct(value)
case 'expiration':
value_builder['expiration_sec'] = convert_direct(value)
case 'hard_timeout':
value_builder['hard_timeout_sec'] = convert_direct(value)
case 'io_timeout':
value_builder['io_timeout_sec'] = convert_direct(value)
case _:
raise Exception(f'unhandled key in swarming: "{key}"')
return value_builder
class ValueBuilder(abc.ABC):
"""An object that potentially builds a value for starlark output.
A ValueBuilder can contain 0 or more entries (arguments in a function
call, dictionary items, list elements). If the ValueBuilder contains
no entries, it will not produce output and it will not appear in the
output of a ValueBuilder that contains it, unless the ValueBuilder was
created with output_empty=True.
"""
_INDENT = ' '
@typing.final
def output(self) -> str | None:
"""Get the final output of the value.
Returns:
A string if the there is output associated with the value,
otherwise None.
"""
output_stream = self._output_stream('')
if output_stream is None:
return None
return ''.join(output_stream)
@abc.abstractmethod
def _output_stream(self, indent: str) -> typing.Iterable[str] | None:
raise NotImplementedError()
class _CompoundValueBuilder(ValueBuilder):
"""A class for building compound values.
A _CompoundValueBuilder can contain 0 or more entries which themselves
can contain ValueBuilder instances. If a contained ValueBuilder
doesn't produce output, then the containing entry will be ignored. If
none of the contained ValueBuilder instances produce output, then the
_CompoundValueBuilder will also not produce any output, unless it was
created with output_empty=True.
"""
def __init__(self, *, output_empty: bool = False):
"""Initialize the _CompoundValueBuilder.
Args:
output_empty: Output the value even if it contains no entries.
"""
self._output_empty = output_empty
@property
@abc.abstractmethod
def _prefix(self) -> str:
"""The text of the opening of the compound value."""
raise NotImplementedError()
@property
@abc.abstractmethod
def _suffix(self) -> str:
"""The text of the closing of the compound value."""
raise NotImplementedError()
@abc.abstractmethod
def _entries(self, indent: str) -> typing.Iterable[str] | None:
"""The text of the compound value's entries.
Args:
indent: The level of indentation that the entries are at.
Returns:
An iterable of strings containing the text of the entries if there
are entries that produce text, otherwise None. The elements of the
iterable will be concatenated in the final string.
"""
raise NotImplementedError()
def _output_stream(self, indent: str) -> typing.Iterable[str] | None:
"""The text of the compound value.
Args:
indent: The level of indentation that the value is at.
Returns:
An iterable of strings containing the text of the value if there
are entries that produce text, otherwise None. The elements of the
iterable will be concatenated in the final string.
"""
entries = self._entries(indent + self._INDENT)
# We only have to indent before the suffix:
# * The indentation preceding the value is handled by any containing value,
# this might not be the first thing on the line
# * Indentation for each entry is handled by the _entries method
# We only have to add a newline after the prefix:
# * Newlines for each entry are handled by the _entries method
# * The containing value may or may not need to add a command and newline
# after the value, so leave it be
if entries is not None:
return [self._prefix, '\n', *entries, indent, self._suffix]
if self._output_empty:
return [self._prefix, self._suffix]
return None
@staticmethod
def _get_output_stream_for_contained_value(
contained_value: Value,
indent: str,
) -> typing.Iterable[str] | None:
"""Get the text of a value.
Args:
value: The value to get the output for.
indent: The level of indentation that the value is at.
Returns:
An iterable of strings containing the text of the value if there
are entries that produce text, otherwise None. The elements of the
iterable will be concatenated in the final string.
"""
if isinstance(contained_value, ValueBuilder):
return contained_value._output_stream(indent)
return [contained_value]
class CallValueBuilder(_CompoundValueBuilder):
"""A builder of function call expression values.
Only function calls using keyword arguments are supported.
The entries of a function call are the parameters to the function. The
parameters will appear in the output in the order they were added.
"""
def __init__(self,
function: str,
params: dict[str, Value] | None = None,
*,
elide_param: str | None = None,
**kwargs):
"""Initialize the CallValueBuilder.
Args:
function: The expression giving the function to call.
params: Initial parameters to include. The parameters will appear
in the output in the same order they are present in the dict and
before any parameters added after initialization.
"""
super().__init__(**kwargs)
self._function: str = function
self._params = params or {}
self._elide_param = elide_param
def __setitem__(self, param_name: str, param_value: Value) -> None:
"""Add an additional parameter to the call."""
self._params[param_name] = param_value
@property
def _prefix(self) -> str:
return f'{self._function}('
@property
def _suffix(self) -> str:
return ')'
def _output_stream(self, indent: str) -> typing.Iterable[str] | None:
param_output_streams = {}
for param_name, param_value in self._params.items():
output_stream = self._get_output_stream_for_contained_value(
param_value, indent)
if output_stream is not None:
param_output_streams[param_name] = output_stream
if (self._elide_param is not None
and self._elide_param in param_output_streams
and len(param_output_streams) == 1):
return param_output_streams[self._elide_param]
return super()._output_stream(indent)
def _entries(self, indent: str) -> typing.Iterable[str] | None:
param_output_streams = {}
for param_name, param_value in self._params.items():
output_stream = self._get_output_stream_for_contained_value(
param_value, indent)
if output_stream is not None:
param_output_streams[param_name] = output_stream
if not param_output_streams:
return None
def gen():
for key, output_stream in param_output_streams.items():
yield f'{indent}{key} = '
yield from output_stream
yield ',\n'
return gen()
class DictValueBuilder(_CompoundValueBuilder):
"""A builder of dict literal values.
The entries of a dict are the items in the dict. The items will appear
in the order they were added.
"""
def __init__(self, items: dict[str, Value] | None = None, **kwargs):
"""Initialize the CallValueBuilder.
Args:
items: Initial items to include. The items will appear in the
output in the same order they are present in the dict and before
any items added after initialization.
"""
super().__init__(**kwargs)
self._items = items or {}
def __setitem__(self, key: str, value: Value) -> None:
"""Add an additional item to the dict."""
self._items[key] = value
@property
def _prefix(self) -> str:
return '{'
@property
def _suffix(self) -> str:
return '}'
def _entries(self, indent: str) -> typing.Iterable[str] | None:
item_output_streams = {}
for key, value in self._items.items():
output_stream = self._get_output_stream_for_contained_value(value, indent)
if output_stream is not None:
item_output_streams[key] = output_stream
if not item_output_streams:
return None
def gen():
for key, output_stream in item_output_streams.items():
yield f'{indent}{key}: '
yield from output_stream
yield ',\n'
return gen()
class ListValueBuilder(_CompoundValueBuilder):
"""A builder of list literal values.
The entries of a list are the elements in the dict. The elements will
appear in the order they were added.
"""
def __init__(self, elements: list[Value] | None = None, **kwargs):
"""Initialize the ListValueBuilder.
Args:
elements: Initial elements to include. The elements will appear in
the output in the same order they are present in the dict and
before any elements added after initialization.
"""
super().__init__(**kwargs)
self._elements = elements or []
def append(self, value: Value) -> None:
"""Add an additional element to the list."""
self._elements.append(value)
@property
def _prefix(self) -> str:
return '['
@property
def _suffix(self) -> str:
return ']'
def _entries(self, indent: str = '') -> typing.Iterable[str] | None:
element_output_streams = []
for element in self._elements:
output_stream = self._get_output_stream_for_contained_value(
element, indent)
if output_stream is not None:
element_output_streams.append(output_stream)
if not element_output_streams:
return None
def gen():
for output_element in element_output_streams:
yield indent
yield from output_element
yield ',\n'
return gen()