1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
media / base / android / media_codec_loop_unittest.cc [blame]
// Copyright 2016 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "media/base/android/media_codec_loop.h"
#include <memory>
#include "base/android/build_info.h"
#include "base/task/single_thread_task_runner.h"
#include "base/test/test_mock_time_task_runner.h"
#include "media/base/android/media_codec_bridge.h"
#include "media/base/android/mock_media_codec_bridge.h"
#include "media/base/waiting.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
using ::testing::_;
using ::testing::AtLeast;
using ::testing::DoAll;
using ::testing::Eq;
using ::testing::Field;
using ::testing::InSequence;
using ::testing::Mock;
using ::testing::Return;
using ::testing::SetArgPointee;
using ::testing::StrictMock;
namespace media {
// The client is a strict mock, since we don't want random calls into it. We
// want to be sure about the call sequence.
class MockMediaCodecLoopClient : public StrictMock<MediaCodecLoop::Client> {
public:
MOCK_CONST_METHOD0(IsAnyInputPending, bool());
MOCK_METHOD0(ProvideInputData, scoped_refptr<DecoderBuffer>());
MOCK_METHOD1(OnInputDataQueued, void(bool));
MOCK_METHOD1(OnDecodedEos, bool(const MediaCodecLoop::OutputBuffer&));
MOCK_METHOD1(OnDecodedFrame, bool(const MediaCodecLoop::OutputBuffer&));
MOCK_METHOD1(OnWaiting, void(WaitingReason reason));
MOCK_METHOD0(OnOutputFormatChanged, bool());
MOCK_METHOD0(OnCodecLoopError, void());
};
class MediaCodecLoopTest : public testing::Test {
public:
MediaCodecLoopTest()
: task_runner_current_default_handle_(mock_task_runner_),
client_(std::make_unique<MockMediaCodecLoopClient>()) {}
MediaCodecLoopTest(const MediaCodecLoopTest&) = delete;
MediaCodecLoopTest& operator=(const MediaCodecLoopTest&) = delete;
~MediaCodecLoopTest() override {}
protected:
enum IdleExpectation {
ShouldBeIdle,
ShouldNotBeIdle,
};
// Wait until |codec_loop_| is idle.
// Do not call this in a sequence.
void WaitUntilIdle(IdleExpectation idleExpectation = ShouldBeIdle) {
switch (idleExpectation) {
case ShouldBeIdle:
EXPECT_CALL(*client_, IsAnyInputPending()).Times(0);
EXPECT_CALL(Codec(), DequeueOutputBuffer(_, _, _, _, _, _, _)).Times(0);
break;
case ShouldNotBeIdle:
// Expect at least one call to see if more work is ready. We will
// return 'no'.
EXPECT_CALL(*client_, IsAnyInputPending())
.Times(AtLeast(1))
.WillRepeatedly(Return(false));
EXPECT_CALL(Codec(), DequeueOutputBuffer(_, _, _, _, _, _, _))
.Times(AtLeast(1))
.WillRepeatedly(Return(MediaCodecResult::Codes::kTryAgainLater));
break;
}
// Either way, we expect that MCL should not attempt to dequeue input
// buffers, either because it's idle or because we said that no input
// is pending.
EXPECT_CALL(Codec(), DequeueInputBuffer(_, _)).Times(0);
// TODO(liberato): assume that MCL doesn't retry for 30 seconds. Note
// that this doesn't actually wall-clock wait.
mock_task_runner_->FastForwardBy(base::Seconds(30));
}
void ConstructCodecLoop() {
int sdk_int = base::android::SDK_VERSION_NOUGAT;
auto codec = std::make_unique<MockMediaCodecBridge>();
// Since we're providing a codec, we do not expect an error.
EXPECT_CALL(*client_, OnCodecLoopError()).Times(0);
codec_loop_ = std::make_unique<MediaCodecLoop>(
sdk_int, client_.get(), std::move(codec), mock_task_runner_);
codec_loop_->SetTestTickClock(mock_task_runner_->GetMockTickClock());
Mock::VerifyAndClearExpectations(client_.get());
}
// Set an expectation that MCL will try to get another input / output buffer,
// and not get one in ExpectWork.
void ExpectEmptyIOLoop() {
ExpectIsAnyInputPending(false);
EXPECT_CALL(Codec(), DequeueOutputBuffer(_, _, _, _, _, _, _))
.Times(1)
.WillOnce(Return(MediaCodecResult::Codes::kTryAgainLater));
}
void ExpectIsAnyInputPending(bool pending) {
EXPECT_CALL(*client_, IsAnyInputPending()).WillOnce(Return(pending));
}
void ExpectDequeueInputBuffer(int input_buffer_index,
MediaCodecResult status = OkStatus()) {
EXPECT_CALL(Codec(), DequeueInputBuffer(_, _))
.WillOnce(DoAll(SetArgPointee<1>(input_buffer_index), Return(status)));
}
void ExpectInputDataQueued(bool success) {
EXPECT_CALL(*client_, OnInputDataQueued(success)).Times(1);
}
// Expect a call to queue |data| into MC buffer |input_buffer_index|.
void ExpectQueueInputBuffer(int input_buffer_index,
scoped_refptr<DecoderBuffer> data,
MediaCodecResult status = OkStatus()) {
EXPECT_CALL(Codec(), QueueInputBuffer(input_buffer_index, data->AsSpan(),
data->timestamp()))
.Times(1)
.WillOnce(Return(status));
}
void ExpectProvideInputData(scoped_refptr<DecoderBuffer> data) {
EXPECT_CALL(*client_, ProvideInputData()).WillOnce(Return(std::move(data)));
}
scoped_refptr<DecoderBuffer> BigBuckBunny() {
auto data = DecoderBuffer::CopyFrom(base::as_byte_span("big buck bunny"));
data->set_timestamp(base::Seconds(1));
return data;
}
struct OutputBuffer {
int index = 1;
size_t offset = 0;
size_t size = 1024;
base::TimeDelta pts = base::Seconds(1);
bool eos = false;
bool key_frame = true;
};
struct EosOutputBuffer : public OutputBuffer {
EosOutputBuffer() { eos = true; }
};
void ExpectDequeueOutputBuffer(MediaCodecResult status) {
EXPECT_CALL(Codec(), DequeueOutputBuffer(_, _, _, _, _, _, _))
.WillOnce(Return(status));
}
void ExpectDequeueOutputBuffer(const OutputBuffer& buffer) {
EXPECT_CALL(Codec(), DequeueOutputBuffer(_, _, _, _, _, _, _))
.WillOnce(DoAll(
SetArgPointee<1>(buffer.index), SetArgPointee<2>(buffer.offset),
SetArgPointee<3>(buffer.size), SetArgPointee<4>(buffer.pts),
SetArgPointee<5>(buffer.eos), SetArgPointee<6>(buffer.key_frame),
Return(OkStatus())));
}
void ExpectOnDecodedFrame(const OutputBuffer& buf) {
EXPECT_CALL(*client_,
OnDecodedFrame(
Field(&MediaCodecLoop::OutputBuffer::index, Eq(buf.index))))
.Times(1)
.WillOnce(Return(true));
}
MockMediaCodecBridge& Codec() {
return *static_cast<MockMediaCodecBridge*>(codec_loop_->GetCodec());
}
public:
// Mocks the current thread's task runner which will also be used as the
// MediaCodecLoop's task runner.
scoped_refptr<base::TestMockTimeTaskRunner> mock_task_runner_ =
new base::TestMockTimeTaskRunner;
base::SingleThreadTaskRunner::CurrentDefaultHandle
task_runner_current_default_handle_;
std::unique_ptr<MediaCodecLoop> codec_loop_;
std::unique_ptr<MockMediaCodecLoopClient> client_;
};
TEST_F(MediaCodecLoopTest, TestConstructionWithNullCodec) {
std::unique_ptr<MediaCodecBridge> codec;
EXPECT_CALL(*client_, OnCodecLoopError()).Times(1);
const int sdk_int = base::android::SDK_VERSION_NOUGAT;
codec_loop_ = std::make_unique<MediaCodecLoop>(
sdk_int, client_.get(), std::move(codec),
scoped_refptr<base::SingleThreadTaskRunner>());
// Do not WaitUntilIdle() here, since that assumes that we have a codec.
ASSERT_FALSE(codec_loop_->GetCodec());
}
TEST_F(MediaCodecLoopTest, TestConstructionWithCodec) {
ConstructCodecLoop();
ASSERT_EQ(codec_loop_->GetCodec(), &Codec());
WaitUntilIdle(ShouldBeIdle);
}
TEST_F(MediaCodecLoopTest, TestPendingWorkWithoutInput) {
ConstructCodecLoop();
// MCL should try ask if there is pending input, and try to dequeue output.
ExpectIsAnyInputPending(false);
EXPECT_CALL(Codec(), DequeueOutputBuffer(_, _, _, _, _, _, _))
.Times(1)
.WillOnce(Return(MediaCodecResult::Codes::kTryAgainLater));
codec_loop_->ExpectWork();
WaitUntilIdle(ShouldNotBeIdle);
}
TEST_F(MediaCodecLoopTest, TestPendingWorkWithInput) {
ConstructCodecLoop();
// MCL should try ask if there is pending input, and try to dequeue both an
// output and input buffer.
ExpectIsAnyInputPending(true);
EXPECT_CALL(Codec(), DequeueOutputBuffer(_, _, _, _, _, _, _)).Times(1);
EXPECT_CALL(Codec(), DequeueInputBuffer(_, _)).Times(1);
codec_loop_->ExpectWork();
WaitUntilIdle(ShouldNotBeIdle);
}
TEST_F(MediaCodecLoopTest, TestPendingWorkWithOutputBuffer) {
ConstructCodecLoop();
{
InSequence _s;
// MCL will first request input, then try to dequeue output.
ExpectIsAnyInputPending(false);
OutputBuffer buf;
ExpectDequeueOutputBuffer(buf);
ExpectOnDecodedFrame(buf);
// MCL will try again for another set of buffers before ExpectWork()
// returns. This is why we don't just leave them for WaitUntilIdle().
ExpectEmptyIOLoop();
}
codec_loop_->ExpectWork();
WaitUntilIdle(ShouldNotBeIdle);
}
TEST_F(MediaCodecLoopTest, TestQueueEos) {
// Test sending an EOS to MCL => MCB =dequeue EOS=> MCL .
ConstructCodecLoop();
{
InSequence _s;
ExpectIsAnyInputPending(true);
int input_buffer_index = 123;
ExpectDequeueInputBuffer(input_buffer_index);
auto data = DecoderBuffer::CreateEOSBuffer();
ExpectProvideInputData(data);
EXPECT_CALL(Codec(), QueueEOS(input_buffer_index));
ExpectInputDataQueued(true);
// Now send the EOS back on the output queue.
EosOutputBuffer eos;
ExpectDequeueOutputBuffer(eos);
EXPECT_CALL(Codec(), ReleaseOutputBuffer(eos.index, false));
EXPECT_CALL(*client_, OnDecodedEos(_)).Times(1).WillOnce(Return(true));
// See TestUnqueuedEos.
EXPECT_CALL(Codec(), DequeueOutputBuffer(_, _, _, _, _, _, _))
.Times(1)
.WillOnce(Return(MediaCodecResult::Codes::kTryAgainLater));
}
codec_loop_->ExpectWork();
// Don't WaitUntilIdle() here. See TestUnqueuedEos.
}
TEST_F(MediaCodecLoopTest, TestQueueEosFailure) {
// Test sending an EOS to MCL => MCB =dequeue EOS fails=> MCL error.
ConstructCodecLoop();
{
InSequence _s;
ExpectIsAnyInputPending(true);
int input_buffer_index = 123;
ExpectDequeueInputBuffer(input_buffer_index);
auto data = DecoderBuffer::CreateEOSBuffer();
ExpectProvideInputData(data);
EXPECT_CALL(Codec(), QueueEOS(input_buffer_index));
ExpectInputDataQueued(true);
// Now send the EOS back on the output queue.
EosOutputBuffer eos;
ExpectDequeueOutputBuffer(eos);
EXPECT_CALL(Codec(), ReleaseOutputBuffer(eos.index, false));
EXPECT_CALL(*client_, OnDecodedEos(_)).Times(1).WillOnce(Return(false));
EXPECT_CALL(*client_, OnCodecLoopError()).Times(1);
}
codec_loop_->ExpectWork();
// Don't WaitUntilIdle() here.
}
TEST_F(MediaCodecLoopTest, TestQueueInputData) {
// Send a buffer full of data into MCL and make sure that it gets queued with
// MediaCodecBridge correctly.
ConstructCodecLoop();
{
InSequence _s;
ExpectIsAnyInputPending(true);
int input_buffer_index = 123;
ExpectDequeueInputBuffer(input_buffer_index);
auto data = BigBuckBunny();
ExpectProvideInputData(data);
// MCL should send the buffer into MediaCodec and notify the client.
ExpectQueueInputBuffer(input_buffer_index, data);
ExpectInputDataQueued(true);
// MCL will try to dequeue an output buffer too.
EXPECT_CALL(Codec(), DequeueOutputBuffer(_, _, _, _, _, _, _))
.Times(1)
.WillOnce(Return(MediaCodecResult::Codes::kTryAgainLater));
// ExpectWork will try again.
ExpectEmptyIOLoop();
}
codec_loop_->ExpectWork();
WaitUntilIdle(ShouldNotBeIdle);
}
TEST_F(MediaCodecLoopTest, TestQueueInputDataFails) {
// Send a buffer full of data into MCL, but MediaCodecBridge fails to queue
// it successfully.
ConstructCodecLoop();
{
InSequence _s;
ExpectIsAnyInputPending(true);
int input_buffer_index = 123;
ExpectDequeueInputBuffer(input_buffer_index);
auto data = BigBuckBunny();
ExpectProvideInputData(data);
// MCL should send the buffer into MediaCodec and notify the client.
ExpectQueueInputBuffer(input_buffer_index, data,
MediaCodecResult::Codes::kError);
ExpectInputDataQueued(false);
EXPECT_CALL(*client_, OnCodecLoopError()).Times(1);
}
codec_loop_->ExpectWork();
// MCL is now in the error state.
}
TEST_F(MediaCodecLoopTest, TestQueueInputDataTryAgain) {
// Signal that there is input pending, but don't provide an input buffer.
ConstructCodecLoop();
{
InSequence _s;
ExpectIsAnyInputPending(true);
ExpectDequeueInputBuffer(-1, MediaCodecResult::Codes::kTryAgainLater);
// MCL will try for output too.
ExpectDequeueOutputBuffer(MediaCodecResult::Codes::kTryAgainLater);
}
codec_loop_->ExpectWork();
// Note that the client might not be allowed to change from "input pending"
// to "no input pending" without actually being asked for input. For now,
// MCL doesn't assume this.
WaitUntilIdle(ShouldNotBeIdle);
}
TEST_F(MediaCodecLoopTest, TestSeveralPendingIOBuffers) {
// Provide several input and output buffers to MCL.
ConstructCodecLoop();
int input_buffer_index = 123;
const int num_loops = 4;
InSequence _s;
for (int i = 0; i < num_loops; i++, input_buffer_index++) {
ExpectIsAnyInputPending(true);
ExpectDequeueInputBuffer(input_buffer_index);
auto data = BigBuckBunny();
ExpectProvideInputData(data);
ExpectQueueInputBuffer(input_buffer_index, data);
ExpectInputDataQueued(true);
OutputBuffer buffer;
buffer.index = i;
buffer.size += i;
buffer.pts = base::Seconds(i + 1);
ExpectDequeueOutputBuffer(buffer);
ExpectOnDecodedFrame(buffer);
}
ExpectEmptyIOLoop();
codec_loop_->ExpectWork();
}
TEST_F(MediaCodecLoopTest, TestOnKeyAdded) {
ConstructCodecLoop();
int input_buffer_index = 123;
auto data = BigBuckBunny();
// First provide input, but have MediaCodecBridge require a key.
{
InSequence _s;
// First ExpectWork()
ExpectIsAnyInputPending(true);
ExpectDequeueInputBuffer(input_buffer_index);
ExpectProvideInputData(data);
// Notify MCL that it's missing the key.
ExpectQueueInputBuffer(input_buffer_index, data,
MediaCodecResult::Codes::kNoKey);
EXPECT_CALL(*client_, OnWaiting(WaitingReason::kNoDecryptionKey)).Times(1);
// MCL should now try for output buffers.
ExpectDequeueOutputBuffer(MediaCodecResult::Codes::kTryAgainLater);
// MCL will try again, since trying to queue the input buffer is considered
// doing work, for some reason. It would be nice to make this optional.
// Note that it should not ask us for more input, since it has not yet sent
// the buffer we just provided.
ExpectDequeueOutputBuffer(MediaCodecResult::Codes::kTryAgainLater);
}
codec_loop_->ExpectWork();
// Try again, to be sure that MCL doesn't request more input. Note that this
// is also done in the above loop, but that one could be made optional. This
// forces MCL to try again as part of an entirely new ExpectWork cycle.
{
InSequence _s;
// MCL should only try for output buffers, since it's still waiting for a
// key to be added.
ExpectDequeueOutputBuffer(MediaCodecResult::Codes::kTryAgainLater);
}
codec_loop_->ExpectWork();
// When we add the key, MCL will DoPending work again. This time, it should
// succeed since the key has been added.
{
InSequence _s;
ExpectQueueInputBuffer(input_buffer_index, data);
ExpectInputDataQueued(true);
ExpectDequeueOutputBuffer(MediaCodecResult::Codes::kTryAgainLater);
// MCL did work, so it will try again.
ExpectEmptyIOLoop();
}
codec_loop_->OnKeyAdded();
WaitUntilIdle(ShouldNotBeIdle);
}
} // namespace media