1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
media / filters / vpx_video_decoder_unittest.cc [blame]
// Copyright 2017 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "media/filters/vpx_video_decoder.h"
#include <memory>
#include <string>
#include <vector>
#include "base/functional/bind.h"
#include "base/functional/callback_helpers.h"
#include "base/run_loop.h"
#include "base/test/task_environment.h"
#include "build/build_config.h"
#include "media/base/decoder_buffer.h"
#include "media/base/limits.h"
#include "media/base/test_data_util.h"
#include "media/base/test_helpers.h"
#include "media/base/video_frame.h"
#include "media/ffmpeg/ffmpeg_common.h"
#include "media/ffmpeg/scoped_av_packet.h"
#include "media/filters/in_memory_url_protocol.h"
#include "testing/gmock/include/gmock/gmock.h"
using ::testing::_;
namespace media {
class VpxVideoDecoderTest : public testing::Test {
public:
VpxVideoDecoderTest()
: decoder_(std::make_unique<VpxVideoDecoder>()),
i_frame_buffer_(ReadTestDataFile("vp9-I-frame-320x240")) {}
VpxVideoDecoderTest(const VpxVideoDecoderTest&) = delete;
VpxVideoDecoderTest& operator=(const VpxVideoDecoderTest&) = delete;
~VpxVideoDecoderTest() override { Destroy(); }
void Initialize() {
InitializeWithConfig(TestVideoConfig::Normal(VideoCodec::kVP9));
}
void InitializeWithConfigWithResult(const VideoDecoderConfig& config,
bool success) {
decoder_->Initialize(config, false, nullptr,
base::BindOnce(
[](bool success, DecoderStatus status) {
EXPECT_EQ(status.is_ok(), success);
},
success),
base::BindRepeating(&VpxVideoDecoderTest::FrameReady,
base::Unretained(this)),
base::NullCallback());
base::RunLoop().RunUntilIdle();
}
void InitializeWithConfig(const VideoDecoderConfig& config) {
InitializeWithConfigWithResult(config, true);
}
void Reinitialize() {
InitializeWithConfig(TestVideoConfig::Large(VideoCodec::kVP9));
}
void Reset() {
decoder_->Reset(NewExpectedClosure());
base::RunLoop().RunUntilIdle();
}
void Destroy() {
decoder_.reset();
base::RunLoop().RunUntilIdle();
}
// Sets up expectations and actions to put VpxVideoDecoder in an active
// decoding state.
void ExpectDecodingState() {
EXPECT_TRUE(DecodeSingleFrame(i_frame_buffer_).is_ok());
ASSERT_EQ(1U, output_frames_.size());
}
// Sets up expectations and actions to put VpxVideoDecoder in an end
// of stream state.
void ExpectEndOfStreamState() {
EXPECT_TRUE(DecodeSingleFrame(DecoderBuffer::CreateEOSBuffer()).is_ok());
ASSERT_FALSE(output_frames_.empty());
}
using InputBuffers = std::vector<scoped_refptr<DecoderBuffer>>;
using OutputFrames = std::vector<scoped_refptr<VideoFrame>>;
// Decodes all buffers in |input_buffers| and push all successfully decoded
// output frames into |output_frames|.
// Returns the last decode status returned by the decoder.
DecoderStatus DecodeMultipleFrames(const InputBuffers& input_buffers) {
for (auto iter = input_buffers.begin(); iter != input_buffers.end();
++iter) {
DecoderStatus status = Decode(*iter);
switch (status.code()) {
case DecoderStatus::Codes::kOk:
break;
case DecoderStatus::Codes::kAborted:
NOTREACHED();
default:
DCHECK(output_frames_.empty());
return status;
}
}
return DecoderStatus::Codes::kOk;
}
// Decodes the single compressed frame in |buffer| and writes the
// uncompressed output to |video_frame|. This method works with single
// and multithreaded decoders. End of stream buffers are used to trigger
// the frame to be returned in the multithreaded decoder case.
DecoderStatus DecodeSingleFrame(scoped_refptr<DecoderBuffer> buffer) {
InputBuffers input_buffers;
input_buffers.push_back(std::move(buffer));
input_buffers.push_back(DecoderBuffer::CreateEOSBuffer());
return DecodeMultipleFrames(input_buffers);
}
// Decodes |i_frame_buffer_| and then decodes the data contained in
// the file named |test_file_name|. This function expects both buffers
// to decode to frames that are the same size.
void DecodeIFrameThenTestFile(const std::string& test_file_name,
const gfx::Size& expected_size) {
Initialize();
scoped_refptr<DecoderBuffer> buffer = ReadTestDataFile(test_file_name);
InputBuffers input_buffers;
input_buffers.push_back(i_frame_buffer_);
input_buffers.push_back(buffer);
input_buffers.push_back(DecoderBuffer::CreateEOSBuffer());
DecoderStatus status = DecodeMultipleFrames(input_buffers);
EXPECT_TRUE(status.is_ok());
ASSERT_EQ(2U, output_frames_.size());
gfx::Size original_size = TestVideoConfig::NormalCodedSize();
EXPECT_EQ(original_size.width(),
output_frames_[0]->visible_rect().size().width());
EXPECT_EQ(original_size.height(),
output_frames_[0]->visible_rect().size().height());
EXPECT_EQ(expected_size.width(),
output_frames_[1]->visible_rect().size().width());
EXPECT_EQ(expected_size.height(),
output_frames_[1]->visible_rect().size().height());
}
DecoderStatus Decode(scoped_refptr<DecoderBuffer> buffer) {
DecoderStatus status;
EXPECT_CALL(*this, DecodeDone(_)).WillOnce(testing::SaveArg<0>(&status));
decoder_->Decode(std::move(buffer),
base::BindOnce(&VpxVideoDecoderTest::DecodeDone,
base::Unretained(this)));
base::RunLoop().RunUntilIdle();
return status;
}
void FrameReady(scoped_refptr<VideoFrame> frame) {
DCHECK(!frame->metadata().end_of_stream);
output_frames_.push_back(std::move(frame));
}
MOCK_METHOD1(DecodeDone, void(DecoderStatus));
base::test::TaskEnvironment task_env_;
std::unique_ptr<VideoDecoder> decoder_;
scoped_refptr<DecoderBuffer> i_frame_buffer_;
OutputFrames output_frames_;
};
TEST_F(VpxVideoDecoderTest, Initialize_Normal) {
Initialize();
}
TEST_F(VpxVideoDecoderTest, Reinitialize_AfterReset) {
Initialize();
ExpectDecodingState();
Reset();
Reinitialize();
}
TEST_F(VpxVideoDecoderTest, DecodeFrame_Normal) {
Initialize();
// Simulate decoding a single frame.
EXPECT_TRUE(DecodeSingleFrame(i_frame_buffer_).is_ok());
ASSERT_EQ(1U, output_frames_.size());
}
TEST_F(VpxVideoDecoderTest, DecodeFrame_OOM) {
Initialize();
static_cast<VpxVideoDecoder*>(decoder_.get())
->force_allocation_error_for_testing();
EXPECT_FALSE(DecodeSingleFrame(i_frame_buffer_).is_ok());
EXPECT_TRUE(output_frames_.empty());
}
// Decode |i_frame_buffer_| and then a frame with a larger width and verify
// the output size was adjusted.
TEST_F(VpxVideoDecoderTest, DecodeFrame_LargerWidth) {
DecodeIFrameThenTestFile("vp9-I-frame-1280x720", gfx::Size(1280, 720));
}
// Decode |i_frame_buffer_| and then a frame with a larger width and verify
// the output size was adjusted.
TEST_F(VpxVideoDecoderTest, Offloaded_DecodeFrame_LargerWidth) {
decoder_ = std::make_unique<OffloadingVpxVideoDecoder>();
DecodeIFrameThenTestFile("vp9-I-frame-1280x720", gfx::Size(1280, 720));
}
// Test resetting when decoder has initialized but not decoded.
TEST_F(VpxVideoDecoderTest, Reset_Initialized) {
Initialize();
Reset();
}
// Test resetting when decoder has decoded single frame.
TEST_F(VpxVideoDecoderTest, Reset_Decoding) {
Initialize();
ExpectDecodingState();
Reset();
}
// Test resetting when decoder has hit end of stream.
TEST_F(VpxVideoDecoderTest, Reset_EndOfStream) {
Initialize();
ExpectDecodingState();
ExpectEndOfStreamState();
Reset();
}
// Test destruction when decoder has initialized but not decoded.
TEST_F(VpxVideoDecoderTest, Destroy_Initialized) {
Initialize();
Destroy();
}
// Test destruction when decoder has decoded single frame.
TEST_F(VpxVideoDecoderTest, Destroy_Decoding) {
Initialize();
ExpectDecodingState();
Destroy();
}
// Test destruction when decoder has hit end of stream.
TEST_F(VpxVideoDecoderTest, Destroy_EndOfStream) {
Initialize();
ExpectDecodingState();
ExpectEndOfStreamState();
Destroy();
}
TEST_F(VpxVideoDecoderTest, SimpleFrameReuse) {
Initialize();
Decode(i_frame_buffer_);
ASSERT_EQ(1u, output_frames_.size());
scoped_refptr<VideoFrame> frame = std::move(output_frames_.front());
const uint8_t* old_y_data = frame->data(VideoFrame::Plane::kY);
output_frames_.pop_back();
// Clear frame reference to return the frame to the pool.
frame = nullptr;
// Since we're decoding I-frames which are marked as having dependent frames,
// libvpx will still have a ref on the previous buffer. So verify we see an
// increase to two frames.
Decode(i_frame_buffer_);
EXPECT_NE(old_y_data, output_frames_.front()->data(VideoFrame::Plane::kY));
// Issuing another decode should reuse the first buffer now that the refs have
// been dropped by the previous decode.
Decode(i_frame_buffer_);
ASSERT_EQ(2u, output_frames_.size());
EXPECT_EQ(old_y_data, output_frames_.back()->data(VideoFrame::Plane::kY));
}
TEST_F(VpxVideoDecoderTest, SimpleFormatChange) {
scoped_refptr<DecoderBuffer> large_frame =
ReadTestDataFile("vp9-I-frame-1280x720");
Initialize();
Decode(i_frame_buffer_);
Decode(i_frame_buffer_);
output_frames_.clear();
base::RunLoop().RunUntilIdle();
Decode(large_frame);
}
TEST_F(VpxVideoDecoderTest, FrameValidAfterPoolDestruction) {
Initialize();
Decode(i_frame_buffer_);
Destroy();
// Write to the Y plane. The memory tools should detect a
// use-after-free if the storage was actually removed by pool destruction.
memset(output_frames_.front()->writable_data(VideoFrame::Plane::kY), 0xff,
output_frames_.front()->rows(VideoFrame::Plane::kY) *
output_frames_.front()->stride(VideoFrame::Plane::kY));
}
// The test stream uses profile 2, which needs high bit depth support in libvpx.
// On ARM we fail to decode the final, duplicate frame, so there is no point in
// running this test (https://crbug.com/864458).
#if !defined(LIBVPX_NO_HIGH_BIT_DEPTH) && !defined(ARCH_CPU_ARM_FAMILY)
TEST_F(VpxVideoDecoderTest, MemoryPoolAllowsMultipleDisplay) {
// Initialize with dummy data, we could read it from the test clip, but it's
// not necessary for this test.
Initialize();
scoped_refptr<DecoderBuffer> data =
ReadTestDataFile("vp9-duplicate-frame.webm");
InMemoryUrlProtocol protocol(data->data(), data->size(), false);
FFmpegGlue glue(&protocol);
ASSERT_TRUE(glue.OpenContext());
auto packet = ScopedAVPacket::Allocate();
while (av_read_frame(glue.format_context(), packet.get()) >= 0) {
DecoderStatus decode_status =
Decode(DecoderBuffer::CopyFrom(AVPacketData(*packet)));
av_packet_unref(packet.get());
if (!decode_status.is_ok())
break;
}
ASSERT_EQ(output_frames_.size(), 26u);
// The final frame is a duplicate of the third-from-final one.
scoped_refptr<VideoFrame> last_frame = output_frames_[25];
scoped_refptr<VideoFrame> dupe_frame = output_frames_[23];
EXPECT_EQ(last_frame->data(VideoFrame::Plane::kY),
dupe_frame->data(VideoFrame::Plane::kY));
EXPECT_EQ(last_frame->data(VideoFrame::Plane::kU),
dupe_frame->data(VideoFrame::Plane::kU));
EXPECT_EQ(last_frame->data(VideoFrame::Plane::kV),
dupe_frame->data(VideoFrame::Plane::kV));
// This will release all frames held by the memory pool, but should not
// release |last_frame| since we still have a ref despite sharing the same
// memory as |dupe_frame|.
output_frames_.clear();
dupe_frame = nullptr;
Destroy();
// ASAN will be very unhappy with this line if the above is incorrect.
memset(last_frame->writable_data(VideoFrame::Plane::kY), 0,
last_frame->row_bytes(VideoFrame::Plane::kY));
}
#endif // !defined(LIBVPX_NO_HIGH_BIT_DEPTH) && !defined(ARCH_CPU_ARM_FAMILY)
} // namespace media