1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
media / gpu / android / codec_image_group.cc [blame]
// Copyright 2017 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "media/gpu/android/codec_image_group.h"
#include "base/functional/bind.h"
#include "base/task/sequenced_task_runner.h"
#include "media/gpu/android/codec_surface_bundle.h"
namespace media {
CodecImageGroup::CodecImageGroup(
scoped_refptr<base::SequencedTaskRunner> task_runner,
scoped_refptr<CodecSurfaceBundle> surface_bundle,
scoped_refptr<gpu::RefCountedLock> drdc_lock)
: gpu::RefCountedLockHelperDrDc(std::move(drdc_lock)),
surface_bundle_(std::move(surface_bundle)),
task_runner_(std::move(task_runner)) {
// If the surface bundle has an overlay, then register for destruction
// callbacks. We thread-hop to the right thread, which means that we might
// find out about destruction asynchronously. Remember that the wp will be
// cleared on |task_runner|.
if (surface_bundle_->overlay()) {
surface_bundle_->overlay()->AddSurfaceDestroyedCallback(base::BindOnce(
[](scoped_refptr<base::SequencedTaskRunner> task_runner,
base::OnceCallback<void(AndroidOverlay*)> cb,
AndroidOverlay* overlay) -> void {
task_runner->PostTask(FROM_HERE,
base::BindOnce(std::move(cb), overlay));
},
task_runner_,
base::BindOnce(&CodecImageGroup::OnSurfaceDestroyed,
weak_this_factory_.GetWeakPtr())));
}
// TODO(liberato): if there's no overlay, should we clear |surface_bundle_|?
// be sure not to call SurfaceDestroyed if !surface_bundle_ in that case when
// adding a new image.
}
CodecImageGroup::~CodecImageGroup() {
// Since every CodecImage should hold a strong ref to us until it becomes
// unused, we shouldn't be destroyed with any outstanding images.
DCHECK(images_.empty());
CHECK(task_runner_->RunsTasksInCurrentSequence());
}
void CodecImageGroup::AddCodecImage(CodecImage* image) {
// Temporary: crbug.com/986783 .
CHECK(task_runner_->RunsTasksInCurrentSequence());
// If somebody adds an image after the surface has been destroyed, fail the
// image immediately. This can happen due to thread hopping.
if (!surface_bundle_) {
base::AutoLockMaybe auto_lock(GetDrDcLockPtr());
image->ReleaseCodecBuffer();
return;
}
images_.insert(image);
// Bind a strong ref to |this| so that the callback will prevent us from being
// destroyed until the CodecImage is no longer in use for drawing. In that
// case, it doesn't need |surface_bundle_|, nor does it need to be notified
// if the overlay is destroyed.
image->AddUnusedCB(
base::BindOnce(&CodecImageGroup::OnCodecImageUnused, this));
}
void CodecImageGroup::OnCodecImageUnused(CodecImage* image) {
// Temporary: crbug.com/986783 .
CHECK(task_runner_->RunsTasksInCurrentSequence());
images_.erase(image);
}
void CodecImageGroup::OnSurfaceDestroyed(AndroidOverlay* overlay) {
// Temporary: crbug.com/986783 .
CHECK(task_runner_->RunsTasksInCurrentSequence());
// Release any codec buffer, so that the image doesn't try to render to the
// overlay. If it already did, that's fine.
for (CodecImage* image : images_) {
base::AutoLockMaybe auto_lock(GetDrDcLockPtr());
image->ReleaseCodecBuffer();
}
// While this might cause |surface_bundle_| to be deleted, it's okay because
// it's a RefCountedDeleteOnSequence.
surface_bundle_ = nullptr;
}
} // namespace media