1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
media / gpu / windows / d3d12_video_decoder_wrapper.cc [blame]
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifdef UNSAFE_BUFFERS_BUILD
// TODO(crbug.com/40285824): Remove this and convert code to safer constructs.
#pragma allow_unsafe_buffers
#endif
#include "media/gpu/windows/d3d12_video_decoder_wrapper.h"
#include <Windows.h>
#include "base/check_op.h"
#include "base/memory/scoped_refptr.h"
#include "base/notreached.h"
#include "base/win/scoped_handle.h"
#include "media/gpu/windows/d3d11_picture_buffer.h"
#include "media/gpu/windows/d3d12_fence.h"
#include "media/gpu/windows/d3d12_helpers.h"
#include "media/gpu/windows/scoped_d3d_buffers.h"
#include "media/gpu/windows/supported_profile_helpers.h"
#define RETURN_IF_FAILED(message, status_code, hr) \
do { \
if (FAILED(hr)) { \
media_log_->NotifyError<D3D11StatusTraits>({status_code, message, hr}); \
return false; \
} \
} while (0)
#define STATIC_RETURN_IF_FAILED(hr, message) \
do { \
if (FAILED(hr)) { \
MEDIA_PLOG(ERROR, hr, media_log) << message; \
return nullptr; \
} \
} while (0)
namespace media {
namespace {
class ScopedD3D12MemoryBuffer;
class ScopedD3D12ResourceBuffer;
class D3D12VideoDecoderWrapperImpl : public D3D12VideoDecoderWrapper {
public:
D3D12VideoDecoderWrapperImpl(MediaLog* media_log,
ComD3D12Device device,
ComD3D12CommandQueue command_queue,
ComD3D12CommandAllocator command_allocator,
ComD3D12VideoDevice video_device,
ComD3D12VideoDecoder video_decoder,
ComD3D12VideoDecoderHeap video_decoder_heap,
ComD3D12VideoDecodeCommandList command_list,
scoped_refptr<D3D12Fence> fence)
: D3D12VideoDecoderWrapper(media_log),
device_(std::move(device)),
video_device_(std::move(video_device)),
command_queue_(std::move(command_queue)),
command_allocator_(std::move(command_allocator)),
command_list_(std::move(command_list)),
video_decoder_(std::move(video_decoder)),
video_decoder_heap_(std::move(video_decoder_heap)),
reference_frame_list_(std::move(video_decoder_heap)),
fence_(std::move(fence)) {
input_stream_arguments_.pHeap = video_decoder_heap_.Get();
}
~D3D12VideoDecoderWrapperImpl() override = default;
std::optional<bool> UseSingleTexture() const override { return true; }
void Reset() override {
picture_parameters_buffer_.clear();
inverse_quantization_matrix_buffer_.clear();
slice_control_buffer_.clear();
input_stream_arguments_.NumFrameArguments = 0;
compressed_bitstream_.Reset();
bitstream_buffer_.reset();
}
bool WaitForFrameBegins(D3D11PictureBuffer* output_picture) override {
Reset();
HRESULT hr = command_allocator_->Reset();
RETURN_IF_FAILED("Failed to reset command allocator",
D3D11Status::Codes::kDecoderBeginFrameFailed, hr);
hr = command_list_->Reset(command_allocator_.Get());
RETURN_IF_FAILED("Failed to reset command list",
D3D11Status::Codes::kDecoderBeginFrameFailed, hr);
// Previous output texture will be read as a reference frame now.
if (output_stream_arguments_.pOutputTexture2D) {
auto barriers = CreateD3D12TransitionBarriersForAllPlanes(
output_stream_arguments_.pOutputTexture2D,
output_stream_arguments_.OutputSubresource,
D3D12_RESOURCE_STATE_COMMON, D3D12_RESOURCE_STATE_VIDEO_DECODE_READ);
command_list_->ResourceBarrier(barriers.size(), barriers.data());
}
ComD3D11Texture2D d3d11_texture2d = output_picture->Texture();
D3D11_TEXTURE2D_DESC desc;
d3d11_texture2d->GetDesc(&desc);
CHECK(desc.MiscFlags & D3D11_RESOURCE_MISC_SHARED_NTHANDLE)
<< "Cannot create shared handle for d3d11 texture2d without "
"D3D11_RESOURCE_MISC_SHARED_NTHANDLE flag.";
auto d3d12_resource_or_error =
output_picture->ToD3D12Resource(device_.Get());
if (!d3d12_resource_or_error.has_value()) {
return false;
}
ComD3D12Resource d3d12_resource =
std::move(d3d12_resource_or_error).value();
output_stream_arguments_ = {
.pOutputTexture2D = d3d12_resource.Get(),
.OutputSubresource = output_picture->array_slice()};
reference_frame_list_.emplace(output_picture->picture_index(),
d3d12_resource.Get(),
output_picture->array_slice());
return true;
}
bool HasPendingBuffer(BufferType type) override {
switch (type) {
case BufferType::kPictureParameters:
return !picture_parameters_buffer_.empty();
case BufferType::kInverseQuantizationMatrix:
return !inverse_quantization_matrix_buffer_.empty();
case BufferType::kSliceControl:
return !slice_control_buffer_.empty();
case BufferType::kBitstream:
return bitstream_buffer_.has_value();
}
NOTREACHED();
}
bool SubmitSlice() override {
if (!slice_info_bytes_.empty()) {
// In D3D12 we need to submit the frame at once, so SubmitSlice() is
// expected to be called only once per frame.
CHECK(slice_control_buffer_.empty());
slice_info_bytes_.swap(slice_control_buffer_);
slice_info_bytes_.clear();
CHECK_LT(input_stream_arguments_.NumFrameArguments,
std::size(input_stream_arguments_.FrameArguments));
input_stream_arguments_
.FrameArguments[input_stream_arguments_.NumFrameArguments++] = {
.Type = D3D12_VIDEO_DECODE_ARGUMENT_TYPE_SLICE_CONTROL,
.Size = static_cast<UINT>(slice_control_buffer_.size()),
.pData = slice_control_buffer_.data(),
};
}
CHECK_LE(input_stream_arguments_.NumFrameArguments, 3u);
reference_frame_list_.WriteTo(&input_stream_arguments_.ReferenceFrames);
CHECK(bitstream_buffer_);
bitstream_buffer_.reset();
CHECK(compressed_bitstream_);
input_stream_arguments_.CompressedBitstream = {
.pBuffer = compressed_bitstream_.Get(),
// The size of a buffer resource is its width.
.Size = compressed_bitstream_->GetDesc().Width,
};
return true;
}
bool SubmitDecode() override {
auto barriers = CreateD3D12TransitionBarriersForAllPlanes(
output_stream_arguments_.pOutputTexture2D,
output_stream_arguments_.OutputSubresource, D3D12_RESOURCE_STATE_COMMON,
D3D12_RESOURCE_STATE_VIDEO_DECODE_WRITE);
command_list_->ResourceBarrier(barriers.size(), barriers.data());
command_list_->DecodeFrame(video_decoder_.Get(), &output_stream_arguments_,
&input_stream_arguments_);
for (D3D12_RESOURCE_BARRIER& barrier : barriers) {
std::swap(barrier.Transition.StateBefore, barrier.Transition.StateAfter);
}
command_list_->ResourceBarrier(barriers.size(), barriers.data());
HRESULT hr = command_list_->Close();
RETURN_IF_FAILED("Failed to close command list",
D3D11Status::Codes::kSubmitDecoderBuffersFailed, hr);
ID3D12CommandList* command_lists[] = {command_list_.Get()};
command_queue_->ExecuteCommandLists(std::size(command_lists),
command_lists);
auto fence_value_or_error = fence_->Signal(*command_queue_.Get());
if (!fence_value_or_error.has_value()) {
media_log_->NotifyError<D3D11StatusTraits>(
std::move(fence_value_or_error).error());
return false;
}
// Just wait here like D3D11's behavior before render side supports D3D12
// TODO(crbug.com/40233230): Let ID3D11DeviceContext4::Wait() for a
// ID3D11Fence instead.
D3D11Status status = fence_->Wait(std::move(fence_value_or_error).value());
if (!status.is_ok()) {
media_log_->NotifyError<D3D11StatusTraits>(status);
return false;
}
return true;
}
private:
friend class ScopedD3D12MemoryBuffer;
friend class ScopedD3D12ResourceBuffer;
std::unique_ptr<ScopedD3DBuffer> GetBuffer(BufferType type,
uint32_t desired_size) override;
ComD3D12Device device_;
ComD3D12VideoDevice video_device_;
ComD3D12CommandQueue command_queue_;
ComD3D12CommandAllocator command_allocator_;
ComD3D12VideoDecodeCommandList command_list_;
ComD3D12VideoDecoder video_decoder_;
ComD3D12VideoDecoderHeap video_decoder_heap_;
D3D12_VIDEO_DECODE_INPUT_STREAM_ARGUMENTS input_stream_arguments_{};
D3D12_VIDEO_DECODE_OUTPUT_STREAM_ARGUMENTS output_stream_arguments_{};
std::vector<uint8_t> picture_parameters_buffer_;
std::vector<uint8_t> inverse_quantization_matrix_buffer_;
std::vector<uint8_t> slice_control_buffer_;
ComD3D12Resource compressed_bitstream_;
D3D12ReferenceFrameList reference_frame_list_;
scoped_refptr<D3D12Fence> fence_{};
};
class ScopedD3D12MemoryBuffer : public ScopedD3DBuffer {
public:
ScopedD3D12MemoryBuffer(D3D12VideoDecoderWrapperImpl* decoder,
D3D12_VIDEO_DECODE_ARGUMENT_TYPE type,
base::span<uint8_t> data)
: ScopedD3DBuffer(data), decoder_(*decoder), type_(type) {}
~ScopedD3D12MemoryBuffer() override { ScopedD3D12MemoryBuffer::Commit(); }
ScopedD3D12MemoryBuffer(ScopedD3D12MemoryBuffer&) = delete;
ScopedD3D12MemoryBuffer& operator=(ScopedD3D12MemoryBuffer&) = delete;
bool Commit() override { return Commit(data_.size()); }
bool Commit(uint32_t written_size) override {
if (data_.empty()) {
return false;
}
CHECK_LE(written_size, data_.size());
CHECK_LT(decoder_->input_stream_arguments_.NumFrameArguments,
std::size(decoder_->input_stream_arguments_.FrameArguments));
decoder_->input_stream_arguments_
.FrameArguments[decoder_->input_stream_arguments_.NumFrameArguments++] =
{
.Type = type_,
.Size = written_size,
.pData = data_.data(),
};
data_ = base::span<uint8_t>();
return true;
}
private:
const raw_ref<D3D12VideoDecoderWrapperImpl> decoder_;
const D3D12_VIDEO_DECODE_ARGUMENT_TYPE type_;
};
class ScopedD3D12ResourceBuffer : public ScopedD3DBuffer {
public:
ScopedD3D12ResourceBuffer(D3D12VideoDecoderWrapperImpl* decoder,
ID3D12Resource* resource,
MediaLog* media_log)
: resource_(resource), media_log_(media_log->Clone()) {
void* mapped_data;
HRESULT hr = resource_->Map(0, nullptr, &mapped_data);
if (FAILED(hr)) {
MEDIA_PLOG(ERROR, hr, media_log_)
<< "Failed to map data of ID3D12Resource";
return;
}
data_ = base::span(reinterpret_cast<uint8_t*>(mapped_data),
static_cast<size_t>(resource_->GetDesc().Width));
}
~ScopedD3D12ResourceBuffer() override { ScopedD3D12ResourceBuffer::Commit(); }
ScopedD3D12ResourceBuffer(ScopedD3D12ResourceBuffer&) = delete;
ScopedD3D12ResourceBuffer& operator=(ScopedD3D12ResourceBuffer&) = delete;
bool Commit() override { return Commit(resource_->GetDesc().Width); }
bool Commit(uint32_t written_size) override {
if (data_.empty()) {
return false;
}
CHECK_LE(written_size, data_.size());
D3D12_RANGE range{0, written_size};
resource_->Unmap(0, &range);
data_ = base::span<uint8_t>();
return true;
}
protected:
raw_ptr<ID3D12Resource> resource_;
const std::unique_ptr<MediaLog> media_log_;
};
std::unique_ptr<ScopedD3DBuffer> D3D12VideoDecoderWrapperImpl::GetBuffer(
BufferType type,
uint32_t desired_size) {
switch (type) {
case BufferType::kPictureParameters:
picture_parameters_buffer_.resize(desired_size);
return std::make_unique<ScopedD3D12MemoryBuffer>(
this, D3D12_VIDEO_DECODE_ARGUMENT_TYPE_PICTURE_PARAMETERS,
picture_parameters_buffer_);
case BufferType::kInverseQuantizationMatrix:
inverse_quantization_matrix_buffer_.resize(desired_size);
return std::make_unique<ScopedD3D12MemoryBuffer>(
this, D3D12_VIDEO_DECODE_ARGUMENT_TYPE_INVERSE_QUANTIZATION_MATRIX,
inverse_quantization_matrix_buffer_);
case BufferType::kSliceControl:
slice_control_buffer_.resize(desired_size);
return std::make_unique<ScopedD3D12MemoryBuffer>(
this, D3D12_VIDEO_DECODE_ARGUMENT_TYPE_SLICE_CONTROL,
slice_control_buffer_);
case BufferType::kBitstream:
// Make sure we don't create more than one resource for a frame.
CHECK(!compressed_bitstream_);
// Create a general buffer resource for uploading
D3D12_HEAP_PROPERTIES heap_properties{.Type = D3D12_HEAP_TYPE_UPLOAD};
D3D12_RESOURCE_DESC desc{.Dimension = D3D12_RESOURCE_DIMENSION_BUFFER,
.Width = desired_size,
.Height = 1,
.DepthOrArraySize = 1,
.MipLevels = 1,
.SampleDesc = {1},
.Layout = D3D12_TEXTURE_LAYOUT_ROW_MAJOR};
HRESULT hr = device_->CreateCommittedResource(
&heap_properties, {}, &desc, D3D12_RESOURCE_STATE_GENERIC_READ,
nullptr, IID_PPV_ARGS(&compressed_bitstream_));
if (FAILED(hr)) {
MEDIA_PLOG(ERROR, hr, media_log_)
<< "Failed to CreateCommittedResource";
return std::make_unique<ScopedD3D12MemoryBuffer>(
this, D3D12_VIDEO_DECODE_ARGUMENT_TYPE{}, base::span<uint8_t>{});
}
return std::make_unique<ScopedD3D12ResourceBuffer>(
this, compressed_bitstream_.Get(), media_log_);
}
NOTREACHED();
}
} // namespace
// static
std::unique_ptr<D3D12VideoDecoderWrapper> D3D12VideoDecoderWrapper::Create(
MediaLog* media_log,
ComD3D12VideoDevice video_device,
VideoDecoderConfig config,
uint8_t bit_depth,
VideoChromaSampling chroma_sampling) {
GUID guid =
GetD3D12VideoDecodeGUID(config.profile(), bit_depth, chroma_sampling);
DXGI_FORMAT decode_format = GetOutputDXGIFormat(bit_depth, chroma_sampling);
#if BUILDFLAG(ENABLE_HEVC_PARSER_AND_HW_DECODER)
// For D3D11/D3D12, 8b/10b-422 HEVC will share 10b-422 GUID no matter
// it is defined by Intel or DXVA spec(as part of Windows SDK).
if (guid == DXVA_ModeHEVC_VLD_Main422_10_Intel) {
decode_format = DXGI_FORMAT_Y210;
}
#endif // BUILDFLAG(ENABLE_HEVC_PARSER_AND_HW_DECODER)
D3D12_FEATURE_DATA_VIDEO_DECODE_SUPPORT feature{
.Configuration = {guid},
.Width = static_cast<UINT>(config.coded_size().width()),
.Height = static_cast<UINT>(config.coded_size().height()),
.DecodeFormat = decode_format,
};
HRESULT hr = video_device->CheckFeatureSupport(
D3D12_FEATURE_VIDEO_DECODE_SUPPORT, &feature, sizeof(feature));
STATIC_RETURN_IF_FAILED(hr, "D3D12VideoDevice CheckFeatureSupport failed");
if (feature.SupportFlags != D3D12_VIDEO_DECODE_SUPPORT_FLAG_SUPPORTED) {
MEDIA_LOG(ERROR, media_log)
<< "D3D12VideoDecoder does not support profile "
<< GetProfileName(config.profile()) << " with bit depth "
<< base::strict_cast<int>(bit_depth) << ", chroma subsampling format "
<< VideoChromaSamplingToString(chroma_sampling) << ", coded size "
<< config.coded_size().ToString() << ", and output dxgi format "
<< decode_format;
return nullptr;
}
ComD3D12VideoDecoder video_decoder;
D3D12_VIDEO_DECODER_DESC desc{.Configuration = {guid}};
hr = video_device->CreateVideoDecoder(&desc, IID_PPV_ARGS(&video_decoder));
STATIC_RETURN_IF_FAILED(hr, "D3D12VideoDevice CreateVideoDecoder failed");
D3D12_VIDEO_DECODER_HEAP_DESC heap_desc{
.Configuration = {guid},
.DecodeWidth = static_cast<UINT>(config.coded_size().width()),
.DecodeHeight = static_cast<UINT>(config.coded_size().height()),
.Format = decode_format,
};
ComD3D12VideoDecoderHeap video_decoder_heap;
hr = video_device->CreateVideoDecoderHeap(&heap_desc,
IID_PPV_ARGS(&video_decoder_heap));
STATIC_RETURN_IF_FAILED(hr, "D3D12VideoDevice CreateVideoDecoderHeap failed");
ComD3D12Device device;
hr = video_decoder->GetDevice(IID_PPV_ARGS(&device));
CHECK_EQ(hr, S_OK);
// TODO(crbug.com/40233230): Share the command queue across video decoders.
ComD3D12CommandQueue command_queue;
D3D12_COMMAND_QUEUE_DESC command_queue_desc{
D3D12_COMMAND_LIST_TYPE_VIDEO_DECODE};
hr = device->CreateCommandQueue(&command_queue_desc,
IID_PPV_ARGS(&command_queue));
STATIC_RETURN_IF_FAILED(hr, "D3D12Device CreateCommandQueue failed");
ComD3D12CommandAllocator command_allocator;
hr = device->CreateCommandAllocator(D3D12_COMMAND_LIST_TYPE_VIDEO_DECODE,
IID_PPV_ARGS(&command_allocator));
STATIC_RETURN_IF_FAILED(hr, "D3D12Device CreateCommandAllocator failed");
ComD3D12VideoDecodeCommandList command_list;
hr = device->CreateCommandList(0, D3D12_COMMAND_LIST_TYPE_VIDEO_DECODE,
command_allocator.Get(), nullptr,
IID_PPV_ARGS(&command_list));
STATIC_RETURN_IF_FAILED(hr, "D3D12Device CreateCommandList failed");
CHECK_EQ(command_list->Close(), S_OK);
scoped_refptr<D3D12Fence> fence = D3D12Fence::Create(device.Get());
if (!fence) {
return nullptr;
}
return std::make_unique<D3D12VideoDecoderWrapperImpl>(
media_log, std::move(device), std::move(command_queue),
std::move(command_allocator), std::move(video_device),
std::move(video_decoder), std::move(video_decoder_heap),
std::move(command_list), std::move(fence));
}
D3D12VideoDecoderWrapper::D3D12VideoDecoderWrapper(MediaLog* media_log)
: D3DVideoDecoderWrapper(media_log) {}
} // namespace media