1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
media / webrtc / audio_processor_test.cc [blame]
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifdef UNSAFE_BUFFERS_BUILD
// TODO(crbug.com/40285824): Remove this and convert code to safer constructs.
#pragma allow_unsafe_buffers
#endif
#include "media/webrtc/audio_processor.h"
#include <stddef.h>
#include <stdint.h>
#include <optional>
#include <string>
#include <string_view>
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/logging.h"
#include "base/memory/aligned_memory.h"
#include "base/path_service.h"
#include "base/strings/stringprintf.h"
#include "base/test/mock_callback.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/task_environment.h"
#include "base/test/test_file_util.h"
#include "base/time/time.h"
#include "build/build_config.h"
#include "build/chromecast_buildflags.h"
#include "media/base/audio_bus.h"
#include "media/base/audio_parameters.h"
#include "media/base/audio_processing.h"
#include "media/webrtc/constants.h"
#include "media/webrtc/webrtc_features.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/webrtc/api/make_ref_counted.h"
#include "third_party/webrtc/modules/audio_processing/include/mock_audio_processing.h"
using ::testing::_;
using ::testing::AnyNumber;
using ::testing::AtLeast;
using ::testing::Return;
namespace media {
namespace {
// Test all sample rates observed in UMA metric WebRTC.AudioInputSampleRate.
static const int kSupportedSampleRates[] = {8000, 11025, 16000, 22050, 24000,
32000, 44100, 48000, 96000, 192000};
using MockProcessedCaptureCallback =
base::MockRepeatingCallback<void(const media::AudioBus& audio_bus,
base::TimeTicks audio_capture_time,
std::optional<double> new_volume)>;
AudioProcessor::LogCallback LogCallbackForTesting() {
return base::BindRepeating(
[](std::string_view message) { VLOG(1) << (message); });
}
// The number of packets used for testing.
const int kNumberOfPacketsForTest = 100;
void ReadDataFromSpeechFile(char* data, int length) {
base::FilePath file;
CHECK(base::PathService::Get(base::DIR_SRC_TEST_DATA_ROOT, &file));
file = file.Append(FILE_PATH_LITERAL("media"))
.Append(FILE_PATH_LITERAL("test"))
.Append(FILE_PATH_LITERAL("data"))
.Append(FILE_PATH_LITERAL("speech_16b_stereo_48kHz.raw"));
DCHECK(base::PathExists(file));
std::optional<int64_t> data_file_size64 = base::GetFileSize(file);
DCHECK(data_file_size64.has_value());
EXPECT_EQ(length, base::ReadFile(file, data, length));
DCHECK(data_file_size64.value() > length);
}
void DisableDefaultSettings(AudioProcessingSettings& settings) {
settings.echo_cancellation = false;
settings.noise_suppression = false;
settings.automatic_gain_control = false;
settings.multi_channel_capture_processing = false;
}
} // namespace
class AudioProcessorTest : public ::testing::Test {
public:
AudioProcessorTest()
: params_(media::AudioParameters::AUDIO_PCM_LOW_LATENCY,
ChannelLayoutConfig::Stereo(),
48000,
480) {}
protected:
// Helper method to save duplicated code.
static void ProcessDataAndVerifyFormat(
AudioProcessor& audio_processor,
MockProcessedCaptureCallback& mock_capture_callback) {
// Read the audio data from a file.
const media::AudioParameters& input_params = audio_processor.input_format();
const media::AudioParameters& output_params =
audio_processor.output_format();
const int packet_size =
input_params.frames_per_buffer() * 2 * input_params.channels();
const size_t length = packet_size * kNumberOfPacketsForTest;
auto capture_data = std::make_unique<char[]>(length);
ReadDataFromSpeechFile(capture_data.get(), static_cast<int>(length));
const int16_t* data_ptr =
reinterpret_cast<const int16_t*>(capture_data.get());
std::unique_ptr<media::AudioBus> data_bus = media::AudioBus::Create(
input_params.channels(), input_params.frames_per_buffer());
const base::TimeTicks input_capture_time = base::TimeTicks::Now();
int num_preferred_channels = -1;
for (int i = 0; i < kNumberOfPacketsForTest; ++i) {
data_bus->FromInterleaved<media::SignedInt16SampleTypeTraits>(
data_ptr, data_bus->frames());
// 1. Provide playout audio, if echo cancellation is enabled.
const bool is_aec_enabled =
audio_processor.has_webrtc_audio_processing() &&
(*audio_processor.GetAudioProcessingModuleConfigForTesting())
.echo_canceller.enabled;
if (is_aec_enabled) {
audio_processor.OnPlayoutData(*data_bus, input_params.sample_rate(),
base::Milliseconds(10));
}
// 2. Set up expectations and process captured audio.
EXPECT_CALL(mock_capture_callback, Run(_, _, _))
.WillRepeatedly([&](const media::AudioBus& processed_audio,
base::TimeTicks audio_capture_time,
std::optional<double> new_volume) {
EXPECT_EQ(processed_audio.channels(), output_params.channels());
EXPECT_EQ(processed_audio.frames(),
output_params.frames_per_buffer());
EXPECT_EQ(audio_capture_time, input_capture_time);
});
audio_processor.ProcessCapturedAudio(*data_bus, input_capture_time,
num_preferred_channels, 1.0);
data_ptr += input_params.frames_per_buffer() * input_params.channels();
// Test different values of num_preferred_channels.
if (++num_preferred_channels > 5) {
num_preferred_channels = 0;
}
}
}
// TODO(bugs.webrtc.org/7494): Remove/reduce duplication with
// `CreateWebRtcAudioProcessingModuleTest.CheckDefaultAudioProcessingConfig`.
void VerifyDefaultComponents(AudioProcessor& audio_processor) {
ASSERT_TRUE(audio_processor.has_webrtc_audio_processing());
const webrtc::AudioProcessing::Config config =
*audio_processor.GetAudioProcessingModuleConfigForTesting();
EXPECT_FALSE(config.pre_amplifier.enabled);
EXPECT_TRUE(config.echo_canceller.enabled);
#if BUILDFLAG(IS_WIN) || BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX)
EXPECT_FALSE(config.gain_controller1.enabled);
EXPECT_TRUE(config.gain_controller2.enabled);
#elif BUILDFLAG(IS_CHROMEOS) || BUILDFLAG(IS_FUCHSIA)
EXPECT_FALSE(config.gain_controller1.enabled);
EXPECT_TRUE(config.gain_controller2.enabled);
#elif BUILDFLAG(IS_CASTOS) || BUILDFLAG(IS_CAST_ANDROID)
EXPECT_TRUE(config.gain_controller1.enabled);
EXPECT_FALSE(config.gain_controller2.enabled);
#elif BUILDFLAG(IS_ANDROID) || BUILDFLAG(IS_IOS)
EXPECT_FALSE(config.gain_controller1.enabled);
EXPECT_TRUE(config.gain_controller2.enabled);
#else
GTEST_FAIL() << "Undefined expectation.";
#endif
EXPECT_TRUE(config.noise_suppression.enabled);
EXPECT_EQ(config.noise_suppression.level,
webrtc::AudioProcessing::Config::NoiseSuppression::kHigh);
}
media::AudioParameters params_;
MockProcessedCaptureCallback mock_capture_callback_;
// Necessary for working with WebRTC task queues.
base::test::TaskEnvironment task_environment_;
};
struct AudioProcessorTestMultichannelAndFormat
: public AudioProcessorTest,
public ::testing::WithParamInterface<std::tuple<bool, bool>> {
AudioParameters GetProcessorOutputParams(
const AudioParameters& params,
const AudioProcessingSettings& settings) {
const bool use_input_format_for_output = std::get<1>(GetParam());
return use_input_format_for_output
? params
: AudioProcessor::GetDefaultOutputFormat(params, settings);
}
static std::string PrintTestName(
const testing::TestParamInfo<ParamType>& info) {
auto [multichannel, input_format_for_output] = info.param;
return base::StringPrintf("MultichannelApm%sSameInputOutputFormat%s",
multichannel ? "True" : "False",
input_format_for_output ? "True" : "False");
}
};
INSTANTIATE_TEST_SUITE_P(
/*no prefix*/,
AudioProcessorTestMultichannelAndFormat,
::testing::Combine(::testing::Bool(), ::testing::Bool()),
&AudioProcessorTestMultichannelAndFormat::PrintTestName);
// Test crashing with ASAN on Android. crbug.com/468762
#if BUILDFLAG(IS_ANDROID) && defined(ADDRESS_SANITIZER)
#define MAYBE_WithAudioProcessing DISABLED_WithAudioProcessing
#else
#define MAYBE_WithAudioProcessing WithAudioProcessing
#endif
TEST_P(AudioProcessorTestMultichannelAndFormat, MAYBE_WithAudioProcessing) {
AudioProcessingSettings settings{.multi_channel_capture_processing =
std::get<0>(GetParam())};
std::unique_ptr<AudioProcessor> audio_processor = AudioProcessor::Create(
mock_capture_callback_.Get(), LogCallbackForTesting(), settings, params_,
GetProcessorOutputParams(params_, settings));
EXPECT_TRUE(audio_processor->has_webrtc_audio_processing());
VerifyDefaultComponents(*audio_processor);
ProcessDataAndVerifyFormat(*audio_processor, mock_capture_callback_);
}
TEST_F(AudioProcessorTest, TurnOffDefaultConstraints) {
AudioProcessingSettings settings;
// Turn off the default settings and pass it to AudioProcessor.
DisableDefaultSettings(settings);
std::unique_ptr<AudioProcessor> audio_processor = AudioProcessor::Create(
mock_capture_callback_.Get(), LogCallbackForTesting(), settings, params_,
AudioProcessor::GetDefaultOutputFormat(params_, settings));
EXPECT_FALSE(audio_processor->has_webrtc_audio_processing());
EXPECT_EQ(audio_processor->output_format().sample_rate(),
params_.sample_rate());
EXPECT_EQ(audio_processor->output_format().channels(), params_.channels());
EXPECT_EQ(audio_processor->output_format().frames_per_buffer(),
params_.sample_rate() / 100);
ProcessDataAndVerifyFormat(*audio_processor, mock_capture_callback_);
}
// Test crashing with ASAN on Android. crbug.com/468762
#if BUILDFLAG(IS_ANDROID) && defined(ADDRESS_SANITIZER)
#define MAYBE_TestAllSampleRates DISABLED_TestAllSampleRates
#else
#define MAYBE_TestAllSampleRates TestAllSampleRates
#endif
TEST_P(AudioProcessorTestMultichannelAndFormat, MAYBE_TestAllSampleRates) {
AudioProcessingSettings settings{.multi_channel_capture_processing =
std::get<0>(GetParam())};
for (int sample_rate : kSupportedSampleRates) {
SCOPED_TRACE(testing::Message() << "sample_rate=" << sample_rate);
int buffer_size = sample_rate / 100;
media::AudioParameters params(media::AudioParameters::AUDIO_PCM_LOW_LATENCY,
ChannelLayoutConfig::Stereo(), sample_rate,
buffer_size);
std::unique_ptr<AudioProcessor> audio_processor = AudioProcessor::Create(
mock_capture_callback_.Get(), LogCallbackForTesting(), settings, params,
GetProcessorOutputParams(params, settings));
EXPECT_TRUE(audio_processor->has_webrtc_audio_processing());
VerifyDefaultComponents(*audio_processor);
ProcessDataAndVerifyFormat(*audio_processor, mock_capture_callback_);
}
}
TEST_F(AudioProcessorTest, StartStopAecDump) {
auto dir = base::CreateUniqueTempDirectoryScopedToTest();
base::FilePath temp_file_path;
ASSERT_TRUE(base::CreateTemporaryFileInDir(dir, &temp_file_path));
{
AudioProcessingSettings settings;
std::unique_ptr<AudioProcessor> audio_processor = AudioProcessor::Create(
mock_capture_callback_.Get(), LogCallbackForTesting(), settings,
params_, AudioProcessor::GetDefaultOutputFormat(params_, settings));
// Start and stop recording.
audio_processor->OnStartDump(base::File(
temp_file_path, base::File::FLAG_WRITE | base::File::FLAG_OPEN));
audio_processor->OnStopDump();
// Start and stop a second recording.
audio_processor->OnStartDump(base::File(
temp_file_path, base::File::FLAG_WRITE | base::File::FLAG_OPEN));
audio_processor->OnStopDump();
}
// Check that dump file is non-empty after audio processor has been
// destroyed. Note that this test fails when compiling WebRTC
// without protobuf support, rtc_enable_protobuf=false.
std::string output;
ASSERT_TRUE(base::ReadFileToString(temp_file_path, &output));
EXPECT_FALSE(output.empty());
// The temporary file is deleted when temp_directory exits scope.
}
TEST_F(AudioProcessorTest, StartAecDumpDuringOngoingAecDump) {
auto temp_dir = base::CreateUniqueTempDirectoryScopedToTest();
base::FilePath temp_file_path_a;
ASSERT_TRUE(base::CreateTemporaryFileInDir(temp_dir, &temp_file_path_a));
base::FilePath temp_file_path_b;
ASSERT_TRUE(base::CreateTemporaryFileInDir(temp_dir, &temp_file_path_b));
{
AudioProcessingSettings settings;
std::unique_ptr<AudioProcessor> audio_processor = AudioProcessor::Create(
mock_capture_callback_.Get(), LogCallbackForTesting(), settings,
params_, AudioProcessor::GetDefaultOutputFormat(params_, settings));
// Start a recording.
audio_processor->OnStartDump(base::File(
temp_file_path_a, base::File::FLAG_WRITE | base::File::FLAG_OPEN));
// Start another recording without stopping the previous one.
audio_processor->OnStartDump(base::File(
temp_file_path_b, base::File::FLAG_WRITE | base::File::FLAG_OPEN));
audio_processor->OnStopDump();
}
// Check that dump files are non-empty after audio processor has been
// destroyed. Note that this test fails when compiling WebRTC
// without protobuf support, rtc_enable_protobuf=false.
std::string output;
ASSERT_TRUE(base::ReadFileToString(temp_file_path_a, &output));
EXPECT_FALSE(output.empty());
ASSERT_TRUE(base::ReadFileToString(temp_file_path_b, &output));
EXPECT_FALSE(output.empty());
// The temporary files are deleted when temp_directory exits scope.
}
TEST_P(AudioProcessorTestMultichannelAndFormat, TestStereoAudio) {
const bool use_multichannel_processing = std::get<0>(GetParam());
// Construct a stereo audio bus and fill the left channel with content.
std::unique_ptr<media::AudioBus> data_bus =
media::AudioBus::Create(params_.channels(), params_.frames_per_buffer());
data_bus->Zero();
for (int i = 0; i < data_bus->frames(); ++i) {
data_bus->channel(0)[i] = (i % 11) * 0.1f - 0.5f;
}
// Test without and with audio processing enabled.
constexpr bool kUseApmValues[] =
#if BUILDFLAG(IS_IOS)
// TODO(crbug.com/40257333): `false` fails on ios-blink platform
// due to a special case for iOS in settings.NeedWebrtcAudioProcessing()
{true};
#else
{false, true};
#endif
for (bool use_apm : kUseApmValues) {
// No need to test stereo with APM if disabled.
if (use_apm && !use_multichannel_processing) {
continue;
}
SCOPED_TRACE(testing::Message() << "use_apm=" << use_apm);
AudioProcessingSettings settings{.multi_channel_capture_processing =
use_multichannel_processing};
if (!use_apm) {
// Turn off the audio processing.
DisableDefaultSettings(settings);
}
std::unique_ptr<AudioProcessor> audio_processor = AudioProcessor::Create(
mock_capture_callback_.Get(), LogCallbackForTesting(), settings,
params_, GetProcessorOutputParams(params_, settings));
EXPECT_EQ(audio_processor->has_webrtc_audio_processing(), use_apm);
// There's no sense in continuing if this fails.
ASSERT_EQ(2, audio_processor->output_format().channels());
// Run the test consecutively to make sure the stereo channels are not
// flipped back and forth.
const base::TimeTicks pushed_capture_time = base::TimeTicks::Now();
for (int num_preferred_channels = 0; num_preferred_channels <= 5;
++num_preferred_channels) {
SCOPED_TRACE(testing::Message()
<< "num_preferred_channels=" << num_preferred_channels);
for (int i = 0; i < kNumberOfPacketsForTest; ++i) {
SCOPED_TRACE(testing::Message() << "packet index i=" << i);
EXPECT_CALL(mock_capture_callback_, Run(_, _, _)).Times(1);
// Pass audio for processing.
audio_processor->ProcessCapturedAudio(*data_bus, pushed_capture_time,
num_preferred_channels, 0.0);
}
// At this point, the audio processing algorithms have gotten past any
// initial buffer silence generated from resamplers, FFTs, and whatnot.
// Set up expectations via the mock callback:
EXPECT_CALL(mock_capture_callback_, Run(_, _, _))
.WillRepeatedly([&](const media::AudioBus& processed_audio,
base::TimeTicks audio_capture_time,
std::optional<double> new_volume) {
EXPECT_EQ(audio_capture_time, pushed_capture_time);
if (!use_apm) {
EXPECT_FALSE(new_volume.has_value());
}
float left_channel_energy = 0.0f;
float right_channel_energy = 0.0f;
for (int i = 0; i < processed_audio.frames(); ++i) {
left_channel_energy +=
processed_audio.channel(0)[i] * processed_audio.channel(0)[i];
right_channel_energy +=
processed_audio.channel(1)[i] * processed_audio.channel(1)[i];
}
if (use_apm && num_preferred_channels <= 1) {
// Mono output. Output channels are averaged.
EXPECT_NE(left_channel_energy, 0);
EXPECT_NE(right_channel_energy, 0);
} else {
// Stereo output. Output channels are independent.
EXPECT_NE(left_channel_energy, 0);
EXPECT_EQ(right_channel_energy, 0);
}
});
// Process one more frame of audio.
audio_processor->ProcessCapturedAudio(*data_bus, pushed_capture_time,
num_preferred_channels, 0.0);
}
}
}
struct AudioProcessorDefaultOutputFormatTest
: public ::testing::Test,
public ::testing::WithParamInterface<std::tuple<bool, int>> {
static std::string PrintTestName(
const testing::TestParamInfo<ParamType>& info) {
auto [multichannel, sample_rate] = info.param;
return base::StringPrintf("MultichannelApm%sSampleRate%d",
multichannel ? "True" : "False", sample_rate);
}
};
INSTANTIATE_TEST_SUITE_P(
/*no prefix*/,
AudioProcessorDefaultOutputFormatTest,
::testing::Combine(::testing::Bool(),
::testing::ValuesIn(kSupportedSampleRates)),
&AudioProcessorDefaultOutputFormatTest::PrintTestName);
TEST_P(AudioProcessorDefaultOutputFormatTest, GetDefaultOutputFormat) {
AudioProcessingSettings settings{.multi_channel_capture_processing =
std::get<0>(GetParam())};
const int sample_rate = std::get<1>(GetParam());
media::AudioParameters input_params(
media::AudioParameters::AUDIO_PCM_LOW_LATENCY,
ChannelLayoutConfig::Stereo(), sample_rate, sample_rate / 100);
AudioParameters output_params =
AudioProcessor::GetDefaultOutputFormat(input_params, settings);
// TODO(crbug.com/1336055): Investigate why chromecast devices need special
// logic here. See https://crrev.com/c/1572807 and
// https://crrev.com/c/3621456/comments/2e73cc96_0e9773cd for details.
const int expected_sample_rate =
#if BUILDFLAG(IS_CASTOS) || BUILDFLAG(IS_CAST_ANDROID)
std::min(sample_rate, media::WebRtcAudioProcessingSampleRateHz());
#else
media::WebRtcAudioProcessingSampleRateHz();
#endif
const int expected_output_channels =
settings.multi_channel_capture_processing ? input_params.channels() : 1;
EXPECT_EQ(output_params.sample_rate(), expected_sample_rate);
EXPECT_EQ(output_params.channels(), expected_output_channels);
EXPECT_EQ(output_params.frames_per_buffer(), expected_sample_rate / 100);
}
// Ensure that discrete channel layouts do not crash with audio processing
// enabled.
TEST_F(AudioProcessorTest, DiscreteChannelLayout) {
AudioProcessingSettings settings;
// Test both 1 and 2 discrete channels.
for (int channels = 1; channels <= 2; ++channels) {
media::AudioParameters params(media::AudioParameters::AUDIO_PCM_LOW_LATENCY,
{media::CHANNEL_LAYOUT_DISCRETE, channels},
48000, 480);
std::unique_ptr<AudioProcessor> audio_processor = AudioProcessor::Create(
mock_capture_callback_.Get(), LogCallbackForTesting(), settings, params,
AudioProcessor::GetDefaultOutputFormat(params, settings));
EXPECT_TRUE(audio_processor->has_webrtc_audio_processing());
}
}
class AudioProcessorPlayoutTest : public AudioProcessorTest {
protected:
AudioProcessorPlayoutTest()
: mock_webrtc_apm_(
rtc::make_ref_counted<webrtc::test::MockAudioProcessing>()),
audio_processor_(mock_capture_callback_.Get(),
LogCallbackForTesting(),
params_,
params_,
mock_webrtc_apm_,
/*needs_playout_reference=*/true) {}
rtc::scoped_refptr<webrtc::test::MockAudioProcessing> mock_webrtc_apm_;
AudioProcessor audio_processor_;
};
TEST_F(AudioProcessorPlayoutTest, OnPlayoutData_ForwardsDataToWebrtcApm) {
std::unique_ptr<media::AudioBus> data_bus =
media::AudioBus::Create(/*channels=*/2, /*frames=*/480);
data_bus->Zero();
EXPECT_CALL(*mock_webrtc_apm_, AnalyzeReverseStream(_, _)).Times(1);
audio_processor_.OnPlayoutData(*data_bus, 48000, base::Milliseconds(10));
}
TEST_F(AudioProcessorPlayoutTest, OnPlayoutData_BuffersPlayout) {
std::unique_ptr<media::AudioBus> data_bus =
media::AudioBus::Create(/*channels=*/2, /*frames=*/48000 * 4 / 1000);
data_bus->Zero();
// 5 buffers of 4 ms yields two 10 ms calls to APM.
EXPECT_CALL(*mock_webrtc_apm_, AnalyzeReverseStream(_, _)).Times(2);
audio_processor_.OnPlayoutData(*data_bus, 48000, base::Milliseconds(10));
audio_processor_.OnPlayoutData(*data_bus, 48000, base::Milliseconds(10));
audio_processor_.OnPlayoutData(*data_bus, 48000, base::Milliseconds(10));
audio_processor_.OnPlayoutData(*data_bus, 48000, base::Milliseconds(10));
audio_processor_.OnPlayoutData(*data_bus, 48000, base::Milliseconds(10));
}
TEST_F(AudioProcessorPlayoutTest, OnPlayoutData_HandlesVariableInputSize) {
std::unique_ptr<media::AudioBus> long_data_bus =
media::AudioBus::Create(/*channels=*/2, /*frames=*/48000 * 25 / 1000);
long_data_bus->Zero();
std::unique_ptr<media::AudioBus> short_data_bus =
media::AudioBus::Create(/*channels=*/2, /*frames=*/48000 * 5 / 1000);
short_data_bus->Zero();
// 25 ms + 5 ms yields three 10 ms calls to APM.
EXPECT_CALL(*mock_webrtc_apm_, AnalyzeReverseStream(_, _)).Times(3);
audio_processor_.OnPlayoutData(*long_data_bus, 48000, base::Milliseconds(10));
audio_processor_.OnPlayoutData(*short_data_bus, 48000,
base::Milliseconds(10));
}
TEST_F(AudioProcessorPlayoutTest, OnPlayoutData_HandlesSampleRateChange) {
std::unique_ptr<media::AudioBus> high_rate_data_bus =
media::AudioBus::Create(/*channels=*/2, /*frames=*/48000 * 12 / 1000);
high_rate_data_bus->Zero();
std::unique_ptr<media::AudioBus> low_rate_data_bus =
media::AudioBus::Create(/*channels=*/2, /*frames=*/32000 * 18 / 1000);
low_rate_data_bus->Zero();
// 12 ms yields one 10 ms call to APM and leaves 2 ms in the buffer.
EXPECT_CALL(*mock_webrtc_apm_, AnalyzeReverseStream(_, _)).Times(1);
audio_processor_.OnPlayoutData(*high_rate_data_bus, 48000,
base::Milliseconds(10));
// 18 ms yields one 10 ms call to APM. Any previous buffer content should have
// been discarded, otherwise there would be more than one call to APM.
EXPECT_CALL(*mock_webrtc_apm_, AnalyzeReverseStream(_, _)).Times(1);
audio_processor_.OnPlayoutData(*low_rate_data_bus, 32000,
base::Milliseconds(10));
}
// When audio processing is performed, processed audio should be delivered as
// soon as 10 ms of audio has been received.
TEST(AudioProcessorCallbackTest,
ProcessedAudioIsDeliveredAsSoonAsPossibleWithShortBuffers) {
MockProcessedCaptureCallback mock_capture_callback;
AudioProcessingSettings settings;
// Set buffer size to 4 ms.
media::AudioParameters params(media::AudioParameters::AUDIO_PCM_LOW_LATENCY,
ChannelLayoutConfig::Stereo(), 48000,
48000 * 4 / 1000);
std::unique_ptr<AudioProcessor> audio_processor = AudioProcessor::Create(
mock_capture_callback.Get(), LogCallbackForTesting(), settings, params,
AudioProcessor::GetDefaultOutputFormat(params, settings));
ASSERT_TRUE(audio_processor->has_webrtc_audio_processing());
int output_sample_rate = audio_processor->output_format().sample_rate();
std::unique_ptr<media::AudioBus> data_bus =
media::AudioBus::Create(params.channels(), params.frames_per_buffer());
data_bus->Zero();
auto check_audio_length = [&](const media::AudioBus& processed_audio,
base::TimeTicks, std::optional<double>) {
EXPECT_EQ(processed_audio.frames(), output_sample_rate * 10 / 1000);
};
// 4 ms of data: Not enough to process.
EXPECT_CALL(mock_capture_callback, Run(_, _, _)).Times(0);
audio_processor->ProcessCapturedAudio(*data_bus, base::TimeTicks::Now(), -1,
1.0);
// 8 ms of data: Not enough to process.
EXPECT_CALL(mock_capture_callback, Run(_, _, _)).Times(0);
audio_processor->ProcessCapturedAudio(*data_bus, base::TimeTicks::Now(), -1,
1.0);
// 12 ms of data: Should trigger callback, with 2 ms left in the processor.
EXPECT_CALL(mock_capture_callback, Run(_, _, _))
.Times(1)
.WillOnce(check_audio_length);
audio_processor->ProcessCapturedAudio(*data_bus, base::TimeTicks::Now(), -1,
1.0);
// 2 + 4 ms of data: Not enough to process.
EXPECT_CALL(mock_capture_callback, Run(_, _, _)).Times(0);
audio_processor->ProcessCapturedAudio(*data_bus, base::TimeTicks::Now(), -1,
1.0);
// 10 ms of data: Should trigger callback.
EXPECT_CALL(mock_capture_callback, Run(_, _, _))
.Times(1)
.WillOnce(check_audio_length);
audio_processor->ProcessCapturedAudio(*data_bus, base::TimeTicks::Now(), -1,
1.0);
}
// When audio processing is performed, input containing 10 ms several times over
// should trigger a comparable number of processing callbacks.
TEST(AudioProcessorCallbackTest,
ProcessedAudioIsDeliveredAsSoonAsPossibleWithLongBuffers) {
MockProcessedCaptureCallback mock_capture_callback;
AudioProcessingSettings settings;
// Set buffer size to 35 ms.
media::AudioParameters params(media::AudioParameters::AUDIO_PCM_LOW_LATENCY,
ChannelLayoutConfig::Stereo(), 48000,
48000 * 35 / 1000);
std::unique_ptr<AudioProcessor> audio_processor = AudioProcessor::Create(
mock_capture_callback.Get(), LogCallbackForTesting(), settings, params,
AudioProcessor::GetDefaultOutputFormat(params, settings));
ASSERT_TRUE(audio_processor->has_webrtc_audio_processing());
int output_sample_rate = audio_processor->output_format().sample_rate();
std::unique_ptr<media::AudioBus> data_bus =
media::AudioBus::Create(params.channels(), params.frames_per_buffer());
data_bus->Zero();
auto check_audio_length = [&](const media::AudioBus& processed_audio,
base::TimeTicks, std::optional<double>) {
EXPECT_EQ(processed_audio.frames(), output_sample_rate * 10 / 1000);
};
// 35 ms of audio --> 3 chunks of 10 ms, and 5 ms left in the processor.
EXPECT_CALL(mock_capture_callback, Run(_, _, _))
.Times(3)
.WillRepeatedly(check_audio_length);
audio_processor->ProcessCapturedAudio(*data_bus, base::TimeTicks::Now(), -1,
1.0);
// 5 + 35 ms of audio --> 4 chunks of 10 ms.
EXPECT_CALL(mock_capture_callback, Run(_, _, _))
.Times(4)
.WillRepeatedly(check_audio_length);
audio_processor->ProcessCapturedAudio(*data_bus, base::TimeTicks::Now(), -1,
1.0);
}
// When no audio processing is performed, audio is delivered immediately. Note
// that unlike the other cases, unprocessed audio input of less than 10 ms is
// forwarded directly instead of collecting chunks of 10 ms.
TEST(AudioProcessorCallbackTest,
UnprocessedAudioIsDeliveredImmediatelyWithShortBuffers) {
MockProcessedCaptureCallback mock_capture_callback;
AudioProcessingSettings settings;
DisableDefaultSettings(settings);
// Set buffer size to 4 ms.
media::AudioParameters params(media::AudioParameters::AUDIO_PCM_LOW_LATENCY,
ChannelLayoutConfig::Stereo(), 48000,
48000 * 4 / 1000);
std::unique_ptr<AudioProcessor> audio_processor = AudioProcessor::Create(
mock_capture_callback.Get(), LogCallbackForTesting(), settings, params,
AudioProcessor::GetDefaultOutputFormat(params, settings));
ASSERT_FALSE(audio_processor->has_webrtc_audio_processing());
int output_sample_rate = audio_processor->output_format().sample_rate();
std::unique_ptr<media::AudioBus> data_bus =
media::AudioBus::Create(params.channels(), params.frames_per_buffer());
data_bus->Zero();
auto check_audio_length = [&](const media::AudioBus& processed_audio,
base::TimeTicks, std::optional<double>) {
EXPECT_EQ(processed_audio.frames(), output_sample_rate * 4 / 1000);
};
EXPECT_CALL(mock_capture_callback, Run(_, _, _))
.Times(1)
.WillOnce(check_audio_length);
audio_processor->ProcessCapturedAudio(*data_bus, base::TimeTicks::Now(), -1,
1.0);
EXPECT_CALL(mock_capture_callback, Run(_, _, _))
.Times(1)
.WillOnce(check_audio_length);
audio_processor->ProcessCapturedAudio(*data_bus, base::TimeTicks::Now(), -1,
1.0);
}
// When no audio processing is performed, audio is delivered immediately. Chunks
// greater than 10 ms are delivered in chunks of 10 ms.
TEST(AudioProcessorCallbackTest,
UnprocessedAudioIsDeliveredImmediatelyWithLongBuffers) {
MockProcessedCaptureCallback mock_capture_callback;
AudioProcessingSettings settings;
DisableDefaultSettings(settings);
// Set buffer size to 35 ms.
media::AudioParameters params(media::AudioParameters::AUDIO_PCM_LOW_LATENCY,
ChannelLayoutConfig::Stereo(), 48000,
48000 * 35 / 1000);
std::unique_ptr<AudioProcessor> audio_processor = AudioProcessor::Create(
mock_capture_callback.Get(), LogCallbackForTesting(), settings, params,
AudioProcessor::GetDefaultOutputFormat(params, settings));
ASSERT_FALSE(audio_processor->has_webrtc_audio_processing());
int output_sample_rate = audio_processor->output_format().sample_rate();
std::unique_ptr<media::AudioBus> data_bus =
media::AudioBus::Create(params.channels(), params.frames_per_buffer());
data_bus->Zero();
auto check_audio_length = [&](const media::AudioBus& processed_audio,
base::TimeTicks, std::optional<double>) {
EXPECT_EQ(processed_audio.frames(), output_sample_rate * 10 / 1000);
};
// 35 ms of audio --> 3 chunks of 10 ms, and 5 ms left in the processor.
EXPECT_CALL(mock_capture_callback, Run(_, _, _))
.Times(3)
.WillRepeatedly(check_audio_length);
audio_processor->ProcessCapturedAudio(*data_bus, base::TimeTicks::Now(), -1,
1.0);
// 5 + 35 ms of audio --> 4 chunks of 10 ms.
EXPECT_CALL(mock_capture_callback, Run(_, _, _))
.Times(4)
.WillRepeatedly(check_audio_length);
audio_processor->ProcessCapturedAudio(*data_bus, base::TimeTicks::Now(), -1,
1.0);
}
class ApmTellsIfPlayoutReferenceIsNeededParametrizedTest
: public ::testing::TestWithParam<bool> {
public:
ApmTellsIfPlayoutReferenceIsNeededParametrizedTest() {
if (GetParam()) {
feature_list_.InitAndEnableFeature(
features::kWebRtcApmTellsIfPlayoutReferenceIsNeeded);
} else {
feature_list_.InitAndDisableFeature(
features::kWebRtcApmTellsIfPlayoutReferenceIsNeeded);
}
}
private:
::base::test::ScopedFeatureList feature_list_;
};
// Checks that, when all the audio processing settings are disabled, APM does
// not need the playout reference.
TEST_P(ApmTellsIfPlayoutReferenceIsNeededParametrizedTest,
DoesNotNeedPlayoutReference) {
AudioProcessingSettings settings;
DisableDefaultSettings(settings);
MockProcessedCaptureCallback mock_capture_callback;
media::AudioParameters params(media::AudioParameters::AUDIO_PCM_LOW_LATENCY,
ChannelLayoutConfig::Stereo(), 48000, 480);
std::unique_ptr<AudioProcessor> audio_processor = AudioProcessor::Create(
mock_capture_callback.Get(), LogCallbackForTesting(), settings, params,
AudioProcessor::GetDefaultOutputFormat(params, settings));
EXPECT_FALSE(audio_processor->needs_playout_reference());
}
// Checks that, with echo cancellation, APM always needs the playout reference.
#if BUILDFLAG(IS_IOS)
#define MAYBE_NeedsPlayoutReference DISABLED_NeedsPlayoutReference
#else
#define MAYBE_NeedsPlayoutReference NeedsPlayoutReference
#endif
// TODO: This test is disabled for ios-blink platform as per the discussion on
// bug https://crbug.com/1417474
TEST_P(ApmTellsIfPlayoutReferenceIsNeededParametrizedTest,
MAYBE_NeedsPlayoutReference) {
AudioProcessingSettings settings;
DisableDefaultSettings(settings);
settings.echo_cancellation = true;
MockProcessedCaptureCallback mock_capture_callback;
media::AudioParameters params(media::AudioParameters::AUDIO_PCM_LOW_LATENCY,
ChannelLayoutConfig::Stereo(), 48000, 480);
std::unique_ptr<AudioProcessor> audio_processor = AudioProcessor::Create(
mock_capture_callback.Get(), LogCallbackForTesting(), settings, params,
AudioProcessor::GetDefaultOutputFormat(params, settings));
EXPECT_TRUE(audio_processor->needs_playout_reference());
}
INSTANTIATE_TEST_SUITE_P(AudioProcessor,
ApmTellsIfPlayoutReferenceIsNeededParametrizedTest,
::testing::Bool());
} // namespace media